Skip to content
Snippets Groups Projects
  1. Jun 07, 2016
  2. Jun 06, 2016
  3. Jun 05, 2016
  4. Jun 03, 2016
  5. Jun 02, 2016
    • Olivier Dony's avatar
      [FIX] res.partner: performance of name_get() · af1a8758
      Olivier Dony authored
      Rev. 93e9a4dc tried to speed up
      the 9.0 name_get() of res.partner by only calling fields_get()
      once for the whole name_get, instead of calling it lazily.
      
      This may have worked for name_get calls on multiple unnamed
      addresses (name is NULL), but this is a rare occurrence
      in practice - while now every single name_get() call would
      incur the full cost of the fields_get() call.
      
      That fields_get() call is O(n) in the number of fields,
      and there can be quite a few for res.partner.
      Calling it only for the specific 'type' field can easily be
      about 40x faster than without it.
      
      And since name_get() is called for each Many2One field
      of each record being read (due to convert_to_read()), reading
      a batch of records with partner fields had become quite
      a bit slower!
      
      Avoiding this cost entirely with lazy fields_get() calls
      saves quite a lot of time for the common cases. And now
      that fields_get() specifies a single field, it is cheap
      enough to be called within the loop.
      
      Non-scientific benchmark: account.invoice.search_read() in
      the list view of invoices took 500ms for 25 invoices
      _before_ this fix, and 90ms after!
      af1a8758
    • Xudong Yang's avatar
      [FIX] base_import: t-if does not work with t-jquery · f558c049
      Xudong Yang authored
      Not evaluated, move the condition to the button
      Closes #12230
      f558c049
    • Jairo Llopis's avatar
      [FIX] doc: declaration of computed fields · f94f570b
      Jairo Llopis authored
      Cannot link a method before declaring it.
      
      Closes #12057
      f94f570b
    • Laurent Bélorgey's avatar
      [CLA] signature for lbelorgey · 149b8fe2
      Laurent Bélorgey authored
      Closes #11226
      149b8fe2
    • Adrien Peiffer (ACSONE)'s avatar
    • Martin Trigaux's avatar
      [FIX] website_forum: convert content of posted comment to plaintext · 30f06fd3
      Martin Trigaux authored
      HTML content should be escaped before being sanitized. Any content (link, image,
      code,...) that is acceptable in usual mail.message but should not be interprated
      when posted on a comment of the forum.
      
      Fixes #3737
      30f06fd3
    • Denis Ledoux's avatar
      [FIX] website_sale: `State` select readonly in shipping info · c751c129
      Denis Ledoux authored
      If we take the below facts:
       - The country select is set as disabled
         when Shipping is set to "Ship to the same address"
       - The disable property of select inputs is
         removed when shipping is set to
         `create a new address`:
         In `website_sale.js`:
         ```
         $selects.attr("disabled", value <= 0 ? null : "disabled" ).prop("disabled", value <= 0 ? null : "disabled" );
         ```
      
      We can safely assume that the select input "State / Province" was supposed
      to be set as `disabled` in the first place, not as `readonly`
      
      Before this revision, State / Provice was greyed when choosing
      "Create a new address" for shipping, and selecting the United States
      (but the select input was still usable, though, it was just greyed)
      
      opw-675739
      c751c129
Loading