closes odoo/odoo#108076

X-original-commit: 6957808a
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this commit, it was possible to resize a column so that it
overflows the right border of the row.

Steps to reproduce the bug:
  1. In website edit mode, drop a `media list` snippet in the page.
  2. Select a column.
  3. Resize the column by dragging its left side to the right to make it
  smaller.
  4. Drag its right side to make it bigger and go until the edge of the
  editor => The column overflows and ends outside of the content zone.

This commit prevents the column from overflowing when it has an offset.

task-2837361

closes odoo/odoo#108022

X-original-commit: 2d825e02
Signed-off-by: Bojabza Soukéina (sobo) <sobo@odoo.com>

The `payWithGiftCard` JS method in the `pos_gift_card.GiftCardPopup` module,
was missing the extra option `price_manually_set` set to true.

That option makes to whenever the `set_pricelist` method on the order is
executed, those lines prices are not going to be re-computed.

closes odoo/odoo#107912

Signed-off-by: Heinz Robin (rhe) <rhe@odoo.com>

Steps to reproduce:

1- install any payment acquirer (e.g. stripe)
2- configure the payment acquirer and link it to a journal
3- try to delete the journal
4- the journal can be deleted which will create an internal server
error when this payment acquirer is used

Bug:

There is no restriction on deleting `account.journal` linked to
payment acquirers

Fix:

add a restriction that forces the user to remove the journal from the
payment acquirers first

OPW-3089006

closes odoo/odoo#107882

X-original-commit: 60366ba8
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Small CSS change to make sure that when the customer name is too long,
the rest of the PoS ui is not displaced

opw-3087852

closes odoo/odoo#107417

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

closes odoo/odoo#108075

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

The motivation of this commit is to get a correct pathname on an
ir_logging when a test fail .

The main issue comes from subtest since an exception inside a subtest
will have only a partial traceback, not containing the line triggering
the error in the test method.

This can also affect debugging since a part of the stack is missing.

See pull request for more informations

Part-of: odoo/odoo#108075

Steps to reproduce the bug:
- Enable “subcontracting” in the mrp settings
- Create a storable product “P1”:
    - Add a vendor:
        - supplier: “Azure interior”
        - currency: euro
        - price: 20
     - Add a BoM:
        - Type: subcontracting
        - add any product as component
        - Save

- Check that the currency of the company is in dollars
- Click on BoM overview

Problem:
The seller's price is displayed with the dollar symbol, but it is not
converted into dollars

opw-3085392

closes odoo/odoo#107888

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

When checking if a line in traceability report is unfoldable,
`_get_move_lines` is a costly operation and should be executed last when
all other conditions are satisfied.

closes odoo/odoo#107843

X-original-commit: b40e0ea6
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

To Reproduce
============
- on a db with sales, website and Stripe payment aquirer activated
- on the portal of a user add two payment methods, an expired card
and a valid one
- create a SO and generate its payment link
- try to pay with the invalid card first -> and error (card was declined)
- try to pay with the valid card -> error (same idempotency key)

Problem
=======
the generation of the idempotency key is based only on dbuuid, transaction's
reference and the scope. So in this use case it will generate the same key.

Solution
========
The idempotency key prevents issues where the customer is charged twice for
the same thing. In this case, we don't want to prevent anything since the
customer is on the page. It's suggested to use idempotency keys only for offline
payment when the customer is not in front of the payment page (e.g. when the cron
charges the customer for his subscription)

opw-3091354

closes odoo/odoo#107723

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Prevent the editor to inserting html during pasting or dropping
in editable zone that will not support the html content received.

task-2990147

closes odoo/odoo#107640

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

PURPOSE

Simply improve the design of the link popover

SPECIFICATION

- "ellipsis" the link preview instead of wrapping it
- only keep a 0.5rem gap between each of the right icons

Task-2916270

closes odoo/odoo#104964

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

- Select the "Sidebar" header template
- Position it to the left (it's left by default)
- Select a website layout != 'full', like 'framed'

In edit mode, the menu will be floating in the middle of the screen.

Probably a bad adaption in commit [1] which refactored the code to move
the edition panel from left to right.
The rule was initially working fine for the left panel since [2].

Note that one might think that the rule should have been kept and
adapted to add the same behavior when the menu is positioned right but
this case was actually handled with [3].

[1]: https://github.com/odoo/odoo/commit/2abe8517063b2696cc89e9a453dcc3921fb3b8c7
[2]: https://github.com/odoo/odoo/commit/b30e47d81c1f71a66b1b6aa6846b52e080c25643
[3]: https://github.com/odoo/odoo/commit/f693c71b8c1b03367e00ec8f0f7854a239a9f097



closes odoo/odoo#107972

X-original-commit: d8674bf6
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

Before this commit, the span within monetary field could wrongly be
removed. Python code that parse the value (see `from_html` of
`ir.qweb.field.monetary`) expect to have that span available.

This commit make that span being unremovable.

opw-3090775

closes odoo/odoo#107421

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Before this commit, changing the font size of an element with one
ancestor having the same font size could trigger a traceback. For fixing
that issue some code has to be refactored to handle the setFontSize case
in formatSelection. As a side effect of this refactoring, nested
font-size is now properly handled (see added tests).

task-3086301

closes odoo/odoo#107381

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

This is a rare case where method _read() raises a MissingError instead
of just ignoring it.

The issue is triggered by several conditions on a model M:
 - at least one ir.rule on M with a domain using a column field on M;
 - one deleted record Y which is in the prefetch set of a record X;
 - one reads a non-column field on record X.

Fix method _read() to manage that case.  It adds an extra call to
exists() in that case, but adds no overhead in the general case.

closes odoo/odoo#107965

X-original-commit: 65a012c2
Signed-off-by: Rémy Voet <ryv@odoo.com>
Signed-off-by: Raphael Collet <rco@odoo.com>

Steps to reproduce:
- edit some text on the website
- select a part of the text then press (alt+s)

Bug:
the selected text is deleted before the save

Fix:
if "alt" key is pressed don't execute the editor listener
(except for Mac OS)

opw-2996264

closes odoo/odoo#106412

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Before this commit:

command prompt is not displayed when html field has placeholder.

After this commit:

placeholder is replaced with command prompt when focused.

Task-2881079

closes odoo/odoo#106305

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Commit [1] introduced the shape system. This system was able to chain
shapes depending on the shape of the previous sibling element.

Unfortunately, if the shape selected on the sibling was the last shape
available, clicking on the toggle shape button would result in nothing
happening.

This commit fixes that by defaulting to the first shape if no possible
shapes are given by the sibling.

[1]: https://github.com/odoo/odoo/commit/b84e0af742c51b88b4c108ebec2d0c7fff4b7483



opw-3082292

closes odoo/odoo#108000

X-original-commit: 9bdd8fae
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>

The currency field shows as a badly aligned "in USD".
This PR adds a proper handling of the combinations
of accounting and multi_currency groups.

Original PR in v15: https://github.com/odoo/odoo/pull/104013



closes odoo/odoo#107963

X-original-commit: 1ee8d10b
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>

An option to disable the automatic wrapping of inline nodes into p at
editable root is needed by Studio's report editor.

task #2995601

closes odoo/odoo#105585

Related: odoo/enterprise#33886
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Current behavior:
When a global discount is applied, it is considered as a regular
orderline when computing the order discounts. Because of this if you
applied a coupon and a global discount, the pos would add a discount of
infinity value.

Steps to reproduce:
- Create a promotion with a discount of 10%
- Create a product with no taxes
- Enable the global discount feature, and make sure the Discount product
  has a tax set on it.
- Create a new order, add the product, apply the promotion, and apply
  the global discount.
- The order will have a discount of infinity value.

opw-3094784

closes odoo/odoo#107833

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

row

When it comes to closing POS sessions, both the frontend and the backend
currently have some way to prevent the same operations from executing
simultaneously because of repeated clicks. `closeSession` in the
frontend has a `closeSessionClicked` boolean that prevents the operation
 from triggering multiple times at once. `close_session_from_ui`
in the backend checks if the session state isn't already `closed`.

A flaw in the current logic is that
`update_closing_control_state_session`, which is called by the frontend
before `close_session_from_ui`, doesn't check the session state before
writing it to be `closing_control`. This means that if you time things
in such a way that the `closeSession` logic in the frontend triggers
again right after it finishes, it will call
`update_closing_control_state_session` and `close_session_from_ui`
again, which will happily close the session again, duplicating stock
moves and account moves resulting from it.

This fix has `update_closing_control_state_session` check if the session
is already closed and raises a UserError if so. This prevents the
duplicate closings and records from happening.

There were two variants in the UI I observed when the issue occurred:
the first is when the repeated execution of
`update_closing_control_state_session` and `close_session_from_ui`
successfully finished. In that case the session would be closed with
duplicate stock moves and journal entries.

In the second variant, from the repeated calls only
`update_closing_control_state_session` executed but not
`close_session_from_ui`. This could happen if the timing of the
frontend was such that it redirected to the POS dashboard before it was
able to call `close_session_from_ui`. In that case, the session would
be in the `closing_control` state, which is visible in the POS dashboard
. If the user then closed the session, it would be closed twice and the
duplicate records would again be created.

opw-2988701

closes odoo/odoo#107873

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Currently _compute_bulk_weight and _compute_weight are
going through each picking in self and each stock_move_line
in picking.move_line_ids to compute the pickings' weight.

This can be slow when there are lots of move_lines by pickings
as the field cache will be filled by the move_lines records
and uom._compute_quantity will be called once by move_line.

This is especially true for pickings with SN-tracked products.
For SN tracked products there will be one move_line by product_qty
(so a picking with 1 SN tracked product with a qty of 100 will have
 100 move_lines). In this case doing a read_group yields the highest
speedup.

Following the same reasoning a search_count is done in _compute_packages
before retrieving package.move_line_ids.
When package.move_line_ids.result_package_id is empty doing a count
is much faster as it avoids calling _in_cache_without for the package
move_line_ids. The search_count overhead is negligeable in the other
case so adding it leads to an overall speedup on average.

opw-3017013

closes odoo/odoo#107868

X-original-commit: ccac6fce
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

No view is available for the mobile form of change.password.wizard. The
default behavior of the framework is to generate one using the backend
model. This result on showing some hidden fields to the user, some of
them (like in this case `Wizard Id`) is impossible to fill in.

opw-3027797

closes odoo/odoo#107857

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

The linked overtime record was not deleted when deleting a time off.
Meaning that those hours were lost.

task-3097259

closes odoo/odoo#107713

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Steps to reproduce
- Install Accounting
- Create user and employee, "user_acc", with Accounting-Accounting and no Expense rights
- Take the expense in "To Submit" state for the employee different than user_acc and create report
- Save the report.

Bug - expense lines disappear.

task - 3099142

closes odoo/odoo#107845

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Computing the recurrences of a task repeating every X months until a
certain date generates too much dates

Steps to reproduce:
1. Install Project
2. Go to Settings > Project > Tasks Management and enable Recurring
   Tasks
3. Open any project in the Project app and create a new task then edit
   it
4. Enable the Recurrent field of the task
5. In the Recurrence tab, edit:
   - Repeat Every: 6 Months
   - Until: End Date: one year from now
6. The recurrence message says there are 11 tasks but there should only
   be 2

Solution:
Generate the recurrences until the `repeat_until` date is reached if the
`repeat_type` is 'until', otherwise generate as much recurrences as the
count
Also relax the constraint on the `repeat_day` and `repeat_until` to not
raise an error if `repeat_until` is the last day of the month

Problem:
The recurrence of a task with `repeat_unit` month and `repeat_interval`
different than 1 with a `repeat_type` until creates too much tasks,
exceeding the `repeat_until`

opw-3076593

closes odoo/odoo#107817

X-original-commit: f94dbfe0
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>

This PR (https://github.com/odoo/odoo/pull/105748

) introduced a bug
by having an extra `OR` operator in the domain.

This commit fixes the error.

opw-3099849

closes odoo/odoo#107819

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

currently the provided documentation link is of 14.0, updating it to correct version

closes odoo/odoo#107447

Related: odoo/enterprise#34769
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Steps to reproduce the issue:

- Accounting > Configuration > Journals
- Click on Journal
- View metadata of Journal

Bug:

Even if no modification has been made to the journal, it marked current time
in Latest Modification By/Date

opw:3089551

closes odoo/odoo#107816

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Without this change, upgrades would generate the `pos_config_main`
record even in dbs with otherwise-well-organized structure.

Also, it might cause issues[^1] hard to solve otherwise.

[^1]: https://upgrade.odoo.com/web#active_id=421039&cids=1&id=421039&menu_id=107&model=upgrade.request&view_type=form



closes odoo/odoo#107716

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

closes odoo/odoo#107711

Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>

In the QUnit type definitions, there is a QUnit namespace and a QUnit
interface. When using a jetbrains IDE, it is confused between the two
and thinks the global QUnit is the namespace.
This means that it can't resolve QUnit.test, QUnit.module, etc

This fixes this issue by disambiguating between the two.

Part-of: odoo/odoo#107711

update the module name of l10n_ma. Morocco is the real country name and currently upon searching with country name, app is not listed.

closes odoo/odoo#107612

X-original-commit: d332f38f
Signed-off-by: John Laterre (jol) <jol@odoo.com>

*: website

The fields of a form that are mandatory because of the model they need
to be used in cannot be removed. When such a field is selected, the
remove button displays a tooltip giving this information.
Disabling the overlay button is done by removing the specific class -
which makes the event selector not linked to the button, but also
impacts the applied CSS rules.

In stable, this commit only updates the CSS to keep the look-and-feel of
the remove button when it is disabled.

In master, this commit will add an `o_disabled` CSS class upon disabling
buttons and adapt the event selectors accordingly - making it possible
to not impact any `oe_snippet_*`-specific CSS rule.

Steps to reproduce:
- Drop a "Form" block.
- Select the "Phone Number" field.
- The overlay's delete icon has a reddish background.
- Select the "Your Email" field.
=> The overlay's delete icon had a dark gray background instead of a
reddish one.

task-2950433

closes odoo/odoo#107574

X-original-commit: 166dca8a
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>

Steps to reproduce:
-install l10n_sa_invoice module
-switch to a company in Saudi Arabia (SA company)
-create and print an invoice with a product that has arabic translation

Bug:
When adding a product and the Arabic translation.
If we add an internal reference it is added to the template,
Odoo directly concatenates this with the product name.
The result is the product name being duplicated.

Fix:
display line name and add the translation if it's different

opw-2829934

closes odoo/odoo#107792

X-original-commit: ad585bc4
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>

Field `has_partner_email` depends on `partners_domain` field, which uses domain
widget. The domain widget may generate broken value.
This commit fixes it by checking that value in the onchange method.

STEPS:

1) go to coupon programs
2) click generate coupon
3) select <Number of Selected Customers>
4) click on domain field, and click the arrow back (nothing is in the domain)
5) if you click on the scrollbar, error appears (the same for any other click
that triggers onchange)

Alternative solution could be fixing the domain widget. But this looks as an
overkill for v14 for few reasons. First, the js client was heavily updated in v15+.
Second, the problem is quite specific for this module and v16 has not such usage
examples in standard modules.

opw-3062969

closes odoo/odoo#107764

X-original-commit: 1f6d84e3
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

The journal id from a purchase order was not
taken into account when creating the bill

Override _prepare_invoice method and add
the journal_id to the vals.

opw-3080805

closes odoo/odoo#107790

X-original-commit: ce2b0f8d
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Guillaume Vanleynseele (guva) <guva@odoo.com>

Follow-up reports were previously not handled by the commit fixing
invoices. This commit aims to fix that.

closes odoo/odoo#107770

X-original-commit: 768cfbe0
Signed-off-by: Florian Daloze (fda) <fda@odoo.com>
Signed-off-by: Solan Delvenne (sode) <sode@odoo.com>