Skip to content
Snippets Groups Projects
  1. Aug 05, 2019
  2. Aug 02, 2019
  3. Jul 30, 2019
  4. Aug 03, 2019
    • Robot Odoo's avatar
      [IMP] *: correctly read/write website_published · 9885ccfd
      Robot Odoo authored
      
      The `website_published` field from the website's mixins is basically a readonly
      from `is_published` field.
      On read, this field will simply read `is_published` and check if the record's
      website_id is accessible (only for the multi mixin).
      On write, it will always write on `is_published`.
      
      Whenever possible, any access (read/search) on published state should be done on `website_published`.
      Any write should be done on `is_published`.
      
      This PR improves a few things:
      - A lot of code was writting on website_published which was just then writting
      on is_published. Writting directly on is_published makes more sense.
      - Some backend fields would still reference `website_published` instead of
      `is_published` which would just go through the related for no reason.
      Plus, using `is_published` will make the field tooltip more accurate as we
      are not in a website context ('Visible on current website' to 'Is Published')
      - Filter and search on tree view were still using the `website_published`
      related field, which is just a readonly when we are not in a frontend
      context.
      - Some create and write function would have security check on
      `website_published` value but that was wrong as the user could bypass that by
      simply writting on `is_published`. For the write method, check `is_published`
      is more accurate as it will cover both case since `website_published` will
      then call the write method on `is_published`
      - Some models would create their own `website_published` field rather than using the
      `website.published.mixin` mixin which should be used instead.
      That was done to be able to override the default value of the boolean.
      This commit simply adds the possibility to override the default value of the
      mixin field.
      - Fix wrong publish security check that were only checking `website_published` in vals.
      
      closes odoo/odoo#35189
      
      Signed-off-by: default avatarJérémy Kersten (jke) <jke@openerp.com>
      Unverified
      9885ccfd
    • Romain Derie's avatar
      [FIX] website: correctly check security of publish mixin · 4086f344
      Romain Derie authored
      Commit 91696805 introduced a mechanism to check rights when writing or
      creating on `website_published` field.
      Problem is, `website_published` is just kind of a related to `is_published`
      which really stores the value.
      
      Thus, the checks would not work when writing/creating on `is_published`.
      That would leave a loophole to bypass the expected behavior.
      4086f344
    • Romain Derie's avatar
      [IMP] website*: use published mixin rather than own field · 7a90dedd
      Romain Derie authored
      *website_crm_partner_assign, website_customer
      
      Before this commit, some models would create their own `website_published`
      field rather than using the `website.published.mixin` mixin which should be
      used instead.
      
      That was done to be able to override the default value of the boolean.
      
      This commit simply adds the possibility to override the default value of the
      mixin field.
      
      Also, help and string could simply be added on xml views rather than overriding
      the field.
      7a90dedd
    • Romain Derie's avatar
      [IMP] *: correctly read/write website_published · cc1d78a8
      Romain Derie authored
      The `website_published` field from the website's mixins is basically a readonly
      from `is_published` field.
      On read, this field will simply read `is_published` and check if the record's
      website_id is accessible (only for the multi mixin).
      On write, it will always write on `is_published`.
      
      This commit improves a few things:
      - A lot of code was writting on website_published which was just then writting
        on is_published. Writting directly on is_published makes more sense.
      - Some backend fields would still reference `website_published` instead of
        `is_published` which would just go through the related for no reason.
        Plus, using `is_published` will make the field tooltip more accurate as we
        are not in a website context ('Visible on current website' to 'Is Published')
      - Filter and search on tree view were still using the `website_published`
        related field, which is just a readonly when we are not in a frontend
        context.
      - Some create and write function would have security check on
        `website_published` value but that was wrong as the user could bypass that by
        simply writting on `is_published`. For the write method, check `is_published`
        is more accurate as it will cover both case since `website_published` will
        then call the write method on `is_published`
      cc1d78a8
  5. Aug 02, 2019
  6. Jul 24, 2019
  7. Aug 02, 2019
    • Robot Odoo's avatar
      [MERGE] *: rename image fields and use image.mixin · 6df11fc4
      Robot Odoo authored
      
      Merge commit for PR #34925
      Related enterprise PR odoo/enterprise/pull/4865
      
      The goal is to:
      - Use `image.mixin` on the models currently storing multiple image sizes.
      - Create Image field and use it on models where mixin is overkill.
      - Rename the image fields to contain the pixel number in the name.
      - Add 512 size.
      - Clean up `image.mixin`, zoom field, variant fields.
      
      Note: models that currently store only a single size image will not be changed
      in this PR.
      
      Signed-off-by: default avatarJérémy Kersten (jke) <jke@openerp.com>
      Unverified
      6df11fc4
    • Sébastien Theys's avatar
      [IMP] tools, base: removed unused image helpers · 45e3be94
      Sébastien Theys authored
      PR: #34925
      45e3be94
    • Sébastien Theys's avatar
      [IMP] *: use image.mixin when appropriate · 1e977288
      Sébastien Theys authored
      The following models are already using big images, or they might need big images
      in the future:
      
      - partner
      - hr employee
      - shop category
      - lunch product
      - gamification badge and karma rank
      
      PR: #34925
      1e977288
    • Sébastien Theys's avatar
      [IMP] *: remove unnecessary image sizes · f0ffbea1
      Sébastien Theys authored
      The big images are probably never going to be used for the following models:
      
      - pos category
      - fleet brand
      - livechat channel
      - mail channel
      - payment acquirer
      
      And if big images are needed some day the model should use image.mixin instead.
      
      PR: #34925
      f0ffbea1
    • Sébastien Theys's avatar
      [IMP] base, product, website_sale: move image zoom out of mixin · 1b85ab93
      Sébastien Theys authored
      This field is not necessary on most models so move it to the few places where it
      is needed to avoid computing it and storing it everywhere.
      
      PR: #34925
      1b85ab93
    • Sébastien Theys's avatar
      [IMP] *: rename image fields · 58a2ffa2
      Sébastien Theys authored
      image_original => image_1920 (now resized to 1920)
      image_big => image_1024
      image_large => image_256
      image_medium => image_128
      image_small  => image_64
      image replaced by image_1920 (when writing) or by image_1024 (when displaying
      	what was previously the big size)
      
      + add new intermediate format:
      image_512
      
      PR: #34925
      58a2ffa2
    • Sébastien Theys's avatar
      [IMP] fields: add image field · 8206b5b4
      Sébastien Theys authored
      PR: #34925
      8206b5b4
    • Hardik Prajapati's avatar
      [FIX] account: traceback while creating Bank statement · ec32fd54
      Hardik Prajapati authored
      
      Validate a bank statement from reconciliation widget and then open the statements view from the widget and try creating a new statement. An error happens when trying to select a partner because the default journal is not set in the action
      
      closes odoo/odoo#35418
      
      Signed-off-by: default avatarCedric Snauwaert (csn) <csn@openerp.com>
      ec32fd54
    • mreficent's avatar
      [IMP] base: add external id in error message · aafc5f78
      mreficent authored
      
      The view name is often not very informative, add the external id for a better
      error
      
      closes odoo/odoo#29473
      
      Signed-off-by: default avatarMartin Trigaux (mat) <mat@odoo.com>
      aafc5f78
    • Robot Odoo's avatar
      [MERGE][REF] utm, mass_mailing: improve and use utm.campaign · de4a9453
      Robot Odoo authored
      
      This merge removes the mass_mailing.campaign model. Instead of having a
      fully fledged model, we will simply inherit utm.campaign.
      
      This change implies that mass_mailing.tag and mass_mailing.stage move to
      the utm model along their associated views/data.
      
      These changes were made so that campaigns could be used in the future by
      social, mass_mailing and mass_sms and available in the same view
      
      This commit also removes the source_id and the medium_id fields on the
      campaign. Indeed those depends on the flow, not the campaign (mass mailing
      is a source, email is a medium for example).
      
      In this merge we also add statistics from crm and sales to the campaign
      model like what has been done for mass mailing previously.
      
      Task ID: 2002029&
      PR: #34015
      
      closes odoo/odoo#34452
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      Unverified
      de4a9453
    • qmo-odoo's avatar
      [REF] mass_mailing: Renaming 'mass_mailing_' fields to mailing · 01ec59b2
      qmo-odoo authored
      This commit renames the mass_mailing_ids and the mass_mailing_clicks_ratio
      to mailing_ids and mailing_clicks_ratio. Indeed it is shorted and more
      inlined with the new model names.
      
      Task ID: 2002029
      PR: #34015
      01ec59b2
    • qmo-odoo's avatar
      [REF] website_links: set is_website to True on the campaign · d716b538
      qmo-odoo authored
      PURPOSE
      
      This commit removes the mass_mailing.campaign model. Instead of having a fully
      fledged model, we will simply inherit utm.campaign. We will also add relevant
      statistics on utm campaign model in order to use it in various applications.
      
      SPECIFICATIONS
      
      This commit changes website_links.js so that, when creating a campaign,
      the field is_website is set to true.
      
      This will allow us to filter irrelevant campaigns in mass_mailing and social
      
      Task ID: 2002029
      PR: #34015
      d716b538
    • qmo-odoo's avatar
      [FIX] mass_mailing_sale: fix domain for invoiced · 4f924301
      qmo-odoo authored
      PURPOSE
      
      This commit removes the mass_mailing.campaign model. Instead of having a fully
      fledged model, we will simply inherit utm.campaign. We will also add relevant
      statistics on utm campaign model in order to use it in various applications.
      
      SPECIFICATIONS
      
      This commit fixes the domain used to get the invoiced amount generated
      by the mailing.mailing.
      
      The new domain will be the same as the one used in the invoice report
      
      Task ID: 2002029
      PR: #34015
      4f924301
    • qmo-odoo's avatar
      [IMP] sale, utm: add sale statistics to utm campaign · 682b62f8
      qmo-odoo authored
      PURPOSE
      
      This commit removes the mass_mailing.campaign model. Instead of having a fully
      fledged model, we will simply inherit utm.campaign. We will also add relevant
      statistics on utm campaign model in order to use it in various applications.
      
      SPECIFICATIONS
      
      This commit adds revenue and quotations statistics on the
      kanban and the form view of the utm.campaign
      
      Kanban and form views will now display the invoiced_amount
      and the number of quotations generated by the campaign.
      
      TaskID: 2002029
      PR: #34452
      682b62f8
    • qmo-odoo's avatar
      [IMP] utm, crm: add lead/opportunity stats on campaign · f49d83f0
      qmo-odoo authored
      PURPOSE
      
      This commit removes the mass_mailing.campaign model. Instead of having a fully
      fledged model, we will simply inherit utm.campaign. We will also add relevant
      statistics on utm campaign model in order to use it in various applications.
      
      SPECIFICATIONS
      
      This commit adds leads/generated statistics in the kanban and
      the form view of the utm campaign.
      
      Kanban and form views will now display the number of leads and
      opportunities generated with the campaign
      
      TaskID: 2002029
      PR: #34452
      f49d83f0
    • qmo-odoo's avatar
      [REF] utm,mass_mailing: replace mass mailing campaign by utm campaign · a661b000
      qmo-odoo authored
      PURPOSE
      
      This commit removes the mass_mailing.campaign model. Instead of having a fully
      fledged model, we will simply inherit utm.campaign. We will also add relevant
      statistics on utm campaign model in order to use it in various applications.
      
      SPECIFICATIONS
      
      This commit removes the mass_mailing.campaign model. Instead of having a fully
      fledged model, we will simply inherit utm.campaign. This change implies that
      mass_mailing.tag and mass_mailing.stage have to move to the utm model along
      their associated views/data.
      
      These changes were made so that campaigns could be used in the future
      by social, mass_mailing and mass_sms and available in the same view
      
      This commit also removes the source_id and the medium_id
      fields on the campaign.
      
      This commit also moves the unique_ab_testing field from the mass_mailing_campaign
      to the mass_mailing model
      
      Task ID: 2002029
      PR: #34015
      a661b000
  8. Jul 31, 2019
    • wan's avatar
      [IMP] account: credit note usability · 2d086f5d
      wan authored
      Task 2038326
      
      * Tick the credit note sequence by default on the customer invoices and vendor bills journals
      * Write Customer Invoice/Vendor Bill/Credit Note/Customer refund at the top of the document
      * The reference field should be printed on the credit note pdf (interesting because it gives source and reason)
      * If the document is a credit note, there shouldn't be any payment information on the pdf (the customer doesn't have to pay you) (currently you see the "payment communication" the customer is supposed to use)
      * Rename Credit Note to Refund on dashboard
      * Add tooltip on payment widget
      
      closes odoo/odoo#35231
      
      Signed-off-by: default avatarCedric Snauwaert (csn) <csn@openerp.com>
      2d086f5d
  9. May 15, 2019
  10. Aug 02, 2019
Loading