Skip to content
Snippets Groups Projects
  1. Jan 18, 2019
  2. Jan 17, 2019
    • Christophe Simonis's avatar
      4aa153e6
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
      17adccd9
    • Julien (juc) Castiaux's avatar
      [FIX] web_editor: save less file · 71c4c139
      Julien (juc) Castiaux authored
      Modifying less files and saving them using the web editor can raise
      and error. The error is due to the way odoo save the modified file.
      
      It extends the view containing the URL of the file by filtering views
      related to the xml bundle id and keeping those that have the said URL
      in their content.
      
      This lookup fails to give just one result in case there are multiple
      file containing the said URL. This fix change the filter from a
      bare `if url in view.arch` to a correct xpath lookup.
      
      The "/web/static/src/variables.less" less file was one of the
      problematic files.
      
      opw-1889794
      
      closes odoo/odoo#30186
      71c4c139
    • Nans Lefebvre's avatar
      [FIX] base: disable prefetching during module uninstall #2 · ba41c3c1
      Nans Lefebvre authored
      Create any module that inherit 'res.lang'.
      Define any new field that is added with that inheritance.
      Install that module. Then try to uninstall it. Traceback ensues.
      
      When trying to write 'state': 'uninstalled' on the module,
      the prefetching tries to read a column that has been deleted
      by the _module_data_uninstall.
      
      opw 1917369
      
      closes odoo/odoo#30176
      ba41c3c1
    • Jorge Pinna Puissant's avatar
      [FIX] payment: Acquired deployed in production · e6b5a0e2
      Jorge Pinna Puissant authored
      Before this commit, in the config bar (Sales or Invoicing) when you configure a payment
      acquirer,  it was deployed in test mode, and not in production mode. Note that, the config
      bar wizard asks for the production credentials.
      
      Now, when you configure a payment acquirer, from the config bar, the acquirer is deployed
      directly in production mode.
      
      opw-1918412
      
      closes odoo/odoo#30319
      e6b5a0e2
    • Denis Ledoux's avatar
      [FIX] res_partner: a partner is portal if he has no employee users · 8865d631
      Denis Ledoux authored
      Currently, a partner is considered a portal
      if he has no users
      or
      if at least one of his users is portal.
      
      This causes problems if an employee has two users,
      one portal, one employee
      and gets notified in a thread (e.g. @ Marc demo):
      The email sent won't contain the action buttons (e.g. view opportunity)
      because the employee is considered as portal.
      
      A partner of an employee can have multiple users
      linked if at some point two partners were merged,
      and the partners had each a user, one a portal
      and the other an employee.
      
      This revision changes this behavior,
      to consider a user as not portal (employee)
      if one of its users is not a portal (an employee).
      
      This is uniform with to the behavior of the
      `share` field of `res.users`,
      which is `True` when the user is part of the group employee.
      ```
      user.share = not user.has_group('base.group_user')
      ```
      
      opw-1914103
      
      closes odoo/odoo#30314
      8865d631
    • Nicolas Martinelli's avatar
      [FIX] stock_account: ctx after group by · 4da16124
      Nicolas Martinelli authored
      - Set valuation to FIFO
      - Make a PO for a product
      - Validate the picking
      - Execute the Inventory Valuation report
      - Apply group by Category
      - Click on the 'Valuation' info button
      
      A traceback occurs because of the usual `group_by` context key which is
      kept.
      
      opw-1918915
      
      closes odoo/odoo#30313
      4da16124
    • Lucas Perais (lpe)'s avatar
      [FIX] crm: test lead from email needs second company · 0dd38282
      Lucas Perais (lpe) authored
      Because of a742813c36fc8cdf4e41c72e00944b6901be6017.
      Apparently when crm is installed alone, there is only one company
      
      closes odoo/odoo#30312
      0dd38282
    • wan's avatar
      [FIX] account: journal dashboard graph wrong value · 50bae1c0
      wan authored
      OPW 1918926
      
      Current behavior:
        The sql query groups by date,id in a intermediary table instead of the result. This allows to get data in the wrong order if the statements were not produced sequentially. The fill values are computed in the wrong order and may override correct values.
      
      Desired behavior:
        There is no override of the values correctly computed.
      
      closes odoo/odoo#29936
      50bae1c0
    • Lucas Perais (lpe)'s avatar
      [FIX] web: pivot correct context after reload · 187c32c2
      Lucas Perais (lpe) authored
      Open a pivot view with default filters automatically activating
      Disable those filters
      
      Change the groupBys on the rows and cols of the pivot
      
      Save your result as a favorite filter
      
      Before this commit, the filter did not contain the context information for columns groupby
      Also, the search view did not exploit the context of the new filter as it should be
      
      After this commit, the flow works as expected
      
      OPW 1913732
      
      closes odoo/odoo#29415
      187c32c2
    • Jorge Pinna Puissant's avatar
      [FIX] hr_timesheet: task view in mobile · 91fb1551
      Jorge Pinna Puissant authored
      Before this commit, there were not specific view for the mobile devices.
      The analytic account views were used.
      
      Now, there are specifics views for the timesheet in the tasks.
      
      opw-1913371
      
      closes odoo/odoo#30309
      91fb1551
    • Hardik Prajapati's avatar
      [FIX] mrp: Barcode on Manufacturing Order Report · 81c09075
      Hardik Prajapati authored
      opw-1925956
      
      closes odoo/odoo#30304
      81c09075
    • Nans Lefebvre's avatar
      [FIX] web: remove the report_layout from studio selectable widgets · 01cd8779
      Nans Lefebvre authored
      Open studio to modify the widget displaying a relational field.
      The report_layout widget can be selected, say, to display payment terms.
      Obviously it doesn't make sense.
      
      We remove its supported field, as the field is not generic
      (indeed there is only one use for it in the codebase).
      
      opw 1919369
      
      closes odoo/odoo#30303
      01cd8779
    • Lucas Perais (lpe)'s avatar
      [FIX] base: merge contacts linked to by an o2m field with caps · 15cd94b7
      Lucas Perais (lpe) authored
      Define a field on a model as:
      - o2m to res.partner
      - the field's column, hence its name, has capital letters in it
      (studio does that)
      
      create two objects of that class, each one linked to a different partner with the new o2m
      
      merge the partners
      
      Before this commit, the object linked to the second partner, was deleted
      This was because merge partner sql requests did not quote the column name
      
      After this commit, the second object still exists
      
      OPW 1925060
      
      closes odoo/odoo#30300
      15cd94b7
    • qsm-odoo's avatar
      [FIX] web_tour: ensure Tip template is loaded · 606bae9e
      qsm-odoo authored
      The 500 page has `session.is_frontend === undefined` as it has its own
      whole HTML template.
      In that case, the ajax.loadXML is not done, making the tour crash when
      visiting a 500 error page.
      
      This is needed for #29957 that has a test tour on 500 error page.
      
      closes odoo/odoo#30240
      606bae9e
    • Lucas Perais (lpe)'s avatar
      [FIX] base: merge contacts linked to by an o2m field with caps · ba39efdf
      Lucas Perais (lpe) authored
      Define a field on a model as:
      - o2m to res.partner
      - the field's column, hence its name, has capital letters in it
      (studio does that)
      
      create two objects of that class, each one linked to a different partner with the new o2m
      
      merge the partners
      
      Before this commit, the object linked to the second partner, was deleted
      This was because merge partner sql requests did not quote the column name
      
      After this commit, the second object still exists
      
      This commit is tested in v12.0 with PR #30300 only. In v10.0 it is not testable as
      the model concerned is in CRM, and that no new fields in business modules can be added in stable
      
      OPW 1925060
      
      closes odoo/odoo#30301
      ba39efdf
  3. Jan 16, 2019
  4. Jan 15, 2019
  5. Jan 16, 2019
    • Nicolas Martinelli's avatar
      [FIX] product: unwanted attribute values in name · 180ace7b
      Nicolas Martinelli authored
      - Create the following attributes with values:
        Size: S, M, L, XL
        Color: Black, White
      - Create a product template with the following attribute values:
        Size: S, M, L, XL
        Color: Black
      
      The `name_get` of `product.product` returns `Name (SIZE, Black)` while
      it should only return `Name (SIZE)`.
      
      When using `attribute_id.value_ids`, the list of values contains all
      possible values of the attribute, not only the values which apply to the
      given product. In this case, it contains 'Black' and 'White', therefore
      the condition `> 1` is verified and the attribute is kept for display.
      
      We go back to the original filtering, and add `attribute_line_ids` in
      the list fields read in order to avoid prefetching.
      
      opw-1922140
      opw-1922447
      
      closes odoo/odoo#30273
      180ace7b
    • Joren Van Onder's avatar
      [FIX] point_of_sale: allow refunds on non-cash journals · 302d8a52
      Joren Van Onder authored
      Cherry pick of 5b769650 in version 11.0
      
      A customer can pay an order with a non-cash journal (e.g. a credit
      card through a stand-alone terminal).
      
      When this order has to be refunded later it should be possible to do
      so on that same journal.
      
      Some code prevented this from happening, notably a check in
      order_is_valid which explicitly prevented this for an unknown
      reason. There is no explanation in the
      commit (4647f896) introducing that.
      
      This commit allows the following:
      
      1. input what you want to refund with a negative qty
      2. click 'Payment'
      3. click the Credit Card (type Bank) journal
      4. (amount is auto-populated)
      5. click 'Validate'
      
      opw-805302
      opw-1913731
      
      closes odoo/odoo#30218
      302d8a52
    • Nicolas Martinelli's avatar
      [FIX] account: bank statement with many AML · 614babd1
      Nicolas Martinelli authored
      - Create a bank statement with more than 80 lines (therefore more than
        80 AML)
      - Reconcile the lines
      - Go back to the bank statement, and try to add a new line
      
      An error arise:
      "You cannot do this modification on a posted journal entry, you can just
      change some non legal fields"
      
      The error arise on the `move_line_ids` field on which the web client
      tries to write.
      
      Actually, this field is hidden since it is only used in the domain of a
      stat button. We can make it read-only.
      
      opw-1921138
      
      closes odoo/odoo#30266
      614babd1
    • Iryna Vyshnevska's avatar
      [CLA] signature for ivyshnevska · 92e4c4c3
      Iryna Vyshnevska authored
      Backport to 10.0 of 3b14a7da
      
      closes odoo/odoo#30090
      92e4c4c3
    • Manuel Vázquez Acosta's avatar
      [FIX] survey: don't disclose the survey via print · 6ac32c65
      Manuel Vázquez Acosta authored
      To avoid bigger changes, only verify if the login is required.
      A proper refactoring has been implemented in master at 9771fdfe
      
      Closes odoo/odoo#30166
      6ac32c65
  6. Jan 14, 2019
Loading