The pdf viewer sometimes displays the sidebar when we open the pdf

Solution:
Add `pagemode=none` to the url when opening a pdf in attachments

opw-3193516

closes odoo/odoo#120347

X-original-commit: da9b89ad
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>

"ValueError: External ID not found in the system: payment.payment_acquirer_
stripe" is generated because the user deleted the Stripe payment acquirer
record and its corresponding model tried to access the record of it.

Steps to produce the error:
1. Install e-commerce
2. Install install 'Stripe Payment Acquirer ' module
2. delete the Stripe payment from payment acquirer
3. Go to the e-commerce dashoboard
4. Click Set Payment
5. select Credit card (via Stripe)
6. enter any secret and Publishable key
7. click apply

This commit solves the above issue by preventing the deletion
of the payment acquirer if it has a external reference.

sentry-4041178833

closes odoo/odoo#120391

X-original-commit: https://github.com/odoo/odoo/commit/c54a398513666508161796a498e8f8c3c7401b9f


Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Purpose:
The purpose of this commit is to change the current behavior of days to close
graph generating from customizable desk demo data.

Specification:
For the opportunities, the day_close field is a compute field depending upon the
date_closed field. For the customizable desk demo data, the date_closed field
pre-existed, due to that customizable desk opportunity was not won or lost but
the graph report was generated.
so, this commit fixes the current behavior for customizable desk opportunity.

Task-3278039

closes odoo/odoo#120384

X-original-commit: e368725b
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The edi attachment (for every format in `account_edi_ubl_cii`) contains
a tag indicating whether the invoice is fully/partially paid.

Before this fix, when this tag was filled, a down payment section was
created on the invoice. For a fully paid invoice, the resulting amount
was then 0, so the invoice was marked as "Paid".

This was wrong. The correct amounts need to be kept on the invoices.
This fix no longer creates a down payment, instead a message is logged
in the chatter.

task-3264843
opw-3248200

closes odoo/odoo#120340

X-original-commit: 47905d21
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Julien Van Roy <juvr@odoo.com>

Current behaviour:
If a project has more than 80 tasks, there is pagination activated
in the project portal view. But when clicking on the second page, we
are requested to login, even when we come from a shared link.

Expected behaviour:
You should be able to scroll through the pages of tasks related to
the shared project without being requested to login.

Steps to reproduce:
- Install Project
- Create 100+ tasks in 1 project
- Copy the share link of that project.
- Log out, open the shared link.
- Go to page 2 of the tasks -> login request.

Reason for the problem:
Missing `access_token` in the pager urls to browse through the tasks.

Fix:
Add the `access_token` as url argument in the links when creating
the pager for the portal view. Backport PR #119941

Affected versions:
- 15.0
- saas-15.2

opw-3220659

closes odoo/odoo#120382

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Before this commit, on a blog page with the "regular cover" and "read
next article" options enabled, the image in the "read next article"
block would shrink when the text was too long.

Steps to reproduce the bug:

- Go to a blog page (e.g. "Sierra Tarahumara").
- Enable the "regular cover" and "read next article" options.
- Enter edit mode.
- Scroll down the page.
- Enter a lot of text as the title of the "read next article" block.
- Bug: As the text increases, the width of the image decreases.

opw-3267842

closes odoo/odoo#119945

X-original-commit: 06a6e78b
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

On small viewports, and with the "Same as desktop" option enabled on
header, The "autohide menu" adaptation is disabled and overflowing
menu items are visible.

The goal of this commit is to fix this behaviour by keeping the
"autohide" feature enabled on expanded navbar.

task-3261909

closes odoo/odoo#119553

Signed-off-by: loco-odoo <loco@odoo.com>

Before this commit:
Files that should be ignored in the manifest but aren't (js library for example)
it can happen that files have huge lines, the regex to substract the
comments will overuse memory.
For example, a file of 13M with a line of more that 8M characters, the
memory consumptions peak at 1.7G

The results might be different, but it's an acceptable compromise

closes odoo/odoo#120139

X-original-commit: 0e56e4a7
Signed-off-by: Thibault Francois <tfr@odoo.com>

Deleting a kit BoM will lead to an error if the kit is in the middle
of a sale process

To reproduce the issue:
1. In Settings, enable UoM
2. Create a product category PC:
   - AVCO
   - Auto
3. Create three storable products P_kit, P_01, P_02
   - UoM of P_01: `m`
   - UoM of P_02: `kg`
4. Create a BoM:
   - Product: P_kit
   - Type: kit
   - Components:
     - 1 x P_01
     - 1 x P_02
5. Create and confirm a SO with 1 x P_kit
6. Force the delivery
7. Delete the BoM
8. Create and confirm the SO's invoice

Error: a traceback appears "ValueError: Expected singleton: uom.uom..."

Because of the configuration, when posting the invoice, we compute
the COGS. During that process, we need the average price of P_kit
https://github.com/odoo/odoo/blob/640907ec1852c4e477957c865549a87d3ae840dd/addons/sale_stock/models/account_move.py#L133
We give to that method the components' SMs. In
`_compute_average_price`, since we don't find a BoM, we will bypass
the mrp override
https://github.com/odoo/odoo/blob/419e42132d9526e9d98c2126158d4f88716d17c4/addons/mrp_account/models/product.py#L48-L50
As a result, it leads to
https://github.com/odoo/odoo/blob/640907ec1852c4e477957c865549a87d3ae840dd/addons/stock_account/models/product.py#L680-L684
Where we will have the candidates of all components (i.e., several
different products). But that method is not designed for such a
situation. This is the reason why, when calling `_consume_all`, it
will fail:
https://github.com/odoo/odoo/blob/858d24a611c4c8af0dcae82a6eb4077e391398ed/addons/stock_account/models/stock_valuation_layer.py#L85


We try to get the rounding of the product, but there are actually
two of them (the two components) -> singleton error

OPW-3218141

closes odoo/odoo#120009

X-original-commit: a816c632
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

Steps to reproduce:
- create an expense product, re-invoice: "at cost"
- create a sale order with the product and set an analytic account
- create a purchase order with the expense product and the same analytic account
- create the bill
-> a new line on the SO is created with the same "Quantity Delivered" as the "Quantity Invoiced" for the purchase order
- for the bill, create a Credit Note of x unit
-> the purchase order has the Quantity Invoiced diminished of x

Issue:
- the Sale Order has not taken into account the new quantity after refund
- Since the line is an "analytic" one, the quantity delivered cannot be changed even if we wreate a credit note for the invoice

Solution:
During the processus of creation of new analytic lines, instead of creating new so lines we adapt the analytic line

closes odoo/odoo#115907

Signed-off-by: William André (wan) <wan@odoo.com>

QR codes had different translations than the official ones.
That prevented the QR-bill to be submitted through Snailmail.

Reference of translations (p.58): https://www.six-group.com/dam/download/banking-services/standardization/qr-bill/ig-qr-bill-v2.2-en.pdf



closes odoo/odoo#120026

Opw: 3223714
Signed-off-by: William André (wan) <wan@odoo.com>

Before this commit: it was possible to create an event for another user as
its organizer. But even if that user has a synchronized Google calendar, it
will be sent by the current user token, and it causes several issues.

The solution is to use the event's organizer token if it exists.

opw-3076595

closes odoo/odoo#113910

X-original-commit: 83f0f180
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
Signed-off-by: Arnaud Joset <arj@odoo.com>

closes odoo/odoo#120225

X-original-commit: 44458824
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps to reproduce:

- Go to a website page > Add a 'Form' block > Add a new 'Selection'
field.
- Go to the page (in 'edit_translations' mode) > The selection field
options are not translatable.

The goal of this commit is to make the select options translatable
by adding an intermediate `.o_translation_select` element.

This element will handle option's text translations from the linked
`<select/>`. The final values are copied to the original element
right before save.

opw-3233360

closes odoo/odoo#120028

X-original-commit: 57d7e75b
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

  Fixes a situation where users who are part of the Attendances Officer (or Manager) group but
  without access to private employee data would see the following error when trying to book time
  off.

  `ValueError: Invalid field 'last_check_in' on model 'hr.employee.public'`

  Other instances of the same ValueError were observed by managers trying to approve employee leave
  and employee expenses.

  As per hr/models/hr_employee.py:22-26 fields not available on hr.employee.public should have
  groups='hr.group_hr_user' and this was not the case in hr_attendance.

closes odoo/odoo#119109

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Steps to reproduce:

- Install `mass_mailing` module
- Create a new mailing
- Set a subject and a mailing list
- Select for the mail body the template "Thank you for joining us!'
- Add a dynamic placeholder (e.g. ${object.email})
- Click on "Send"
- Open the email received and click on "View Online"

Issue:

  The dynamic placeholder is not replaced.

Cause:

  The controller does not re-render the body based on the res_id.

Solution:

  Use `mailing` variable (that inherit from `mail.render.mixin`) to
  re-render the body based on the res_id if available (same as when
  sending the mail).
  https://github.com/odoo/odoo/blob/d3a6a20788c78ddaaff0919ea627e7b10c7ab81c/addons/mail/wizard/mail_compose_message.py#L476



opw-3133975

closes odoo/odoo#118996

X-original-commit: 6a0850b5
Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Current behavior:
When settling a pos order containing 2 different product, the qty of the
2 products would be modified even if you only deliver one of them
through the pos order.

Steps to reproduce:
- Create 2 product A and B
- Create a sale order with 1 product A and 1 product B
- Open a PoS session, and settle the order you just created
- Deliver only 1 product A
- Close the PoS session
- Go the the sale order delivery, you will see that the qty are not
  correct

opw-3227053

closes odoo/odoo#117402

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

When installing l10n_eu_oss without a localization installed, a line fails
in the get_oss_tags function of res_company, thus halting the installation
and returning an error.

This fail is due to the function relying on the company in self having its
'chart_template_id' set, when this is not always the case.

Adding a failsafe to that function allows the installation of the module to
proceed in the event that the chart_template_id is not set.

opw-3291118
opw-3289913

closes odoo/odoo#120104

X-original-commit: 4b140806
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Huylenbroeck Florent (flhu) <flhu@odoo.com>

On Debian based systems, the `tzdata` package is maintained to reflect changes
in timezones and there is no need to upgrade the `python3-tz` package.
On the other hand, for those who are using `pip` and thus our `requirements.txt`,
the package needs to be up to date. By unpinning it in the requirements.txt:

- new installations based on pip will be up to date
- older installations based on pip can easily upgrade
- debian based installations have to maintain the tzdata package
- mixed installs like on runbot will rely on Debian tzdata

closes odoo/odoo#117527

closes odoo/odoo#120084

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

closes odoo/odoo#119895

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

Before this PR from version 15 to 16.1, the approval date was not populated so
when you were in studio and add this field manually. The field stayed empty
which wasn't the behaviour we wanted.

When clicking the approve button, the approval date is now populated with the
complete date.

closes odoo/odoo#117126

Task-id: 3254147
Signed-off-by: Quentin De Paoli <qdp@odoo.com>

Since this commit [1], the option to set the background color for
snippets in the footer has been removed. However, this should not affect
the snippets in the "All pages" popup, which is also located in the
footer.

This commit fixes that by showing the background color option for popup
snippets in the footer.

Steps to reproduce the bug:

- Drop a popup.
- Set the "Show On" option to "All pages".
- Drop a text block in the popup.
=> The text color is white over a white BG (because it is in the footer
and the footer text is white).

[1]: https://github.com/odoo/odoo/commit/00f70f7936d37ec1c7c26065b2126045337e2825



task-3102275

closes odoo/odoo#120083

Signed-off-by: Benoit Socias (bso) <bso@odoo.com>

What are the steps to reproduce your issue?
- Create a product with more than one attribute.
- Let say color White, black and purple
- Create a 'draft' invoice for the purple product variant
- Remove the 'purple' attribute value from the product
- It will archive that variant (because the account.move linked to it)
- Try to delete the attribute value from menu Sales > Cofinfiguration > Attribute

What is the current behavior that you observe?
- technical error message

What would be your expected behavior in this case?
- non-technical message for end-users

Solution :
- Change both message to tell user he cannot delete the value if the value has been referenced somewhere else.
opw-2623583

missing forward-port of db1e52f0

closes odoo/odoo#119989

Signed-off-by: Morgane Demesmaeker <edm@odoo.com>

In this commit, when user has created a transporter from the invoice view and if it's forget to enter GSTIN
Then we throws error to set GSTIN in transporter

transporter always have GSTIN, without having GSTIN any one is not allowed to transport goods in India.

task - 3262215

closes odoo/odoo#117658

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

Starting with Firefox 109, a widget element prototype that is put
inside an iframe will not be instanceof its original constructor.
See: https://github.com/webcompat/web-bugs/issues/118350

This is because a node that is adopted by an iframe will have its
prototype changed to match the constructor from within the iframe
instead of its original one. This has been the case for a long time.
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1470017

It largely went unnoticed because of another quirk of Firefox related
to the use of instanceof which was fixed in version 109.
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1360715



Since this bug was fixed it became apparent, in the form of a
traceback, that the wrong instance of ClipboardJS was being used
in the case of Firefox, due to the forced prototype change.

This commit could be reverted once Firefox is fixed.

Steps to reproduce the issue in Firefox > 109:
- Create a new mass mailing.
- Choose the third template with "Thank you for joining us!".
- Click on the "LOGIN" button link inside the email.
- Get a traceback about a paremeter not being the right type.

Task-3186513
OPW-3172914

closes odoo/odoo#120003

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Co-authored-by: Jinjiu Liu <jili@odoo.com>
Co-authored-by: David Monjoie <dmo@odoo.com>

Before this commit:

When the toolbar was located at the bottom of the screen, the dropdown menus
would open outside of the viewport.

After this commit:

When the toolbar is in the bottom of the screen the dropdown will always open
upwards ensuring they remain visible within the viewport.

Task - 3149341

closes odoo/odoo#118759

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Steps to reproduce:

- Install crm
- Go to settings and activate leads in crm.
- Go to leads list and select any lead, now mark it as lost.

Issue:

It will ask for lost reason. But if we do it from the Leads form view,
we don't get to set any reason. I discussed with the PO and we don't
want to add the lost reason in the leads.

Solution:

Modified action of lost so it takes leads into account.

opw-3119748

closes odoo/odoo#119546

X-original-commit: 1d68b5c7
Signed-off-by: Maruan Aguerdouh Mohtar (magm) <magm@odoo.com>

Current behaviour:
If a project has more than 80 tasks, there is pagination activated
in the project portal view. But when clicking on the second page, we
are greeted with a 404.

Expected behaviour:
You should be able to scroll through the pages of tasks related to
the shared project without hitting a 404.

Steps to reproduce:
- Install Project
- Create 100+ tasks in 1 project
- Copy the share link of that project.
- Log out, open the shared link.
- Go to page 2 of the tasks -> 404.

Reason for the problem:
Missing route `/my/project/<int:project_id>/page/<int:page>`.

Fix:
Add the missing route.
Essentially a backport of 336befc0

Affected versions:
- 15.0
- saas-15.2
- 16.0       <-- issue is different for this version and newers
- saas-16.1
- saas-16.2
- master

opw-3220659

closes odoo/odoo#119905

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

closes odoo/odoo#119075

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

before this commit, on duplicating a contact tag
will duplicate the assigned partners also.

suppose if we have a partner A with tag B assigned,
and then we duplicate tag B and create new tag C,
the newly created tag is automatically getting
assigned to partner A.

after this commit, the copy is set to False for
partner_ids field in tag and then the partners
wont be copied on duplicating a tag

closes odoo/odoo#116791

X-original-commit: 1ffc0471
Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

Since commit [1], when we are in the `/shop/cart` page and if a language
selector is in the header, a cart popover also appears when hovering the
languages. This happens because the `websiteSaleCartLink` widget
selector also targets the cart links inside the language buttons.

This commit solves this issue by excluding the language selectors from
this widget selector.

[1]: https://github.com/odoo/odoo/commit/ecefa679b224ce0e4a5a7e91ce28936321132d9c



opw-3288727

closes odoo/odoo#119833

X-original-commit: bdfceb8e
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

A previous commit[^1] added the shipping address in case the `sale`
module is installed. But it didn't manage the case where that module
is not installed.

opw-3199710

[^1]: bd5071ac

closes odoo/odoo#119853

X-original-commit: f75e1c68
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

For each node that the `insert` command inserts, the previous node is evaluated
and tested to be a `shrunk` block. If it is, it is considered "invisible" and
removed.

Prior to this commit, an element containing sub-elements with a fontawesome icon
was considered to be `isEmptyBlock==='true'` even though it is supposedly
visible as it contains that icon.

Therefore in cases where multiple nodes are inserted at once, if one of them has
only fa-icon nodes as children, that node would not have been inserted.

Task-3284580

closes odoo/odoo#119792

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

In the case of transaction linked to sales orders it is
more appropiated to use the invoice partner related to the
sale order than its main partner.
After this fix the invoice partner of sale orders will be
used for transactions linked to it.

opw - 3212748

closes odoo/odoo#118506

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Current behaviour before PR:
  1.Go to Company Partner
  2.Create a shipping address
  3.Set this shipping address in the warehouse
  4.Create a sale order with that warehouse
  5.Create an Invoice
  Then that invoice can't be send because the address name is empty.

Current behaviour after PR:
  If anyone creates a contact under the company as the shipping address and if
  the name is empty then in this case it assigns the company name

Task:3259223

closes odoo/odoo#117660

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Current behaviour:
On a brand new task with no assignees, when we add an user to follow
the task with an email, there is a link "I take it" that is supposed
to assign the newly following user as the assignee of the task. This
link is dead, returning a 404.

Expected behaviour:
Either correct the link, or remove it from the email header.

Steps to reproduce:
- Install Project
- Create a task, with no assignees
- Add a new follower to the task with Send Email checked.
- Check the outgoing email, and click on the link "I take it".
- 404 response

Reason for the problem:
The route which we were using for this `/mail/assign` doesn't exist
anymore since version 15. This was an intended design change, to
remove noice. The user can click on "See task" and assign himself on
there.

Fix:
Remove the "I take it" link from the email header.

Affected versions:
- 15.0
- saas-15.2
- 16.0
- saas-16.1
- saas-16.2
- master

opw-3276036

closes odoo/odoo#119821

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Chart template tests install demo_data that are not required and
can cause an access right error in some builds:
https://runbot.odoo.com/runbot/build/27709490



closes odoo/odoo#119784

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

The tax 21% ISP actually behaves like a normal 21% tax
(it gets reported in the same lines, ...)

But the reason for its existence is that in case of the
fiscal position Revendedor ISP...  it gets mapped to the
0% ISP tax (which needs to be 0)

Before, if you would however send a 21% ISP tax to the SII,
it would be set as ISP and you would get an error telling
that the tax rate should be 0 in case of ISP.  (but now, it
will be reported as S1 and not trigger the error)

See also discussion in
https://github.com/odoo/odoo/pull/119339#issuecomment-1519720558



closes odoo/odoo#119645

X-original-commit: ab03b50c
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Josse Colpaert <jco@odoo.com>

Scenario:

- set a quotation template on a quotation that adds lines ordered with
  a sequence (eg. 3 lines with sequences 10, 11, 12)
- add lines in this quotation
- save

Issue:

The added lines have sequence 10 and the seen order changes.

This is caused by 6f11060d that tries to
mitigate a more rare issue when there is more than one page of lines.

Solution:

Reverting the previous fix, and setting the sequence of the first line
to -99:

- when resequencing the first page, the sequence will be -99 to -60 =>
  records from the second page will not get in the first page

- new lines will be added at the end

Issues still present:

- when resequencing the second page, item from 3 pages get into it (it
  was already the case before 6f11060d)

- when adding a new line (without resequencing), it is added at the end
  and not at the beginning of the next page

But those are just behavior in any list view (as is the original issue
of 6f11060d, but since it was partially
fixed for a year, this patch try to give an in-between solution instead
of just reverting it).

opw-2833913

closes odoo/odoo#119231

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>