closes odoo/odoo#42050

Signed-off-by: Josse Colpaert <jco@openerp.com>

If a component is used in a production with another unit of measure
than it's one, the created stock move line could not convert the quantity
correctly.
If there is enough quantity in stock, the created move line takes the
quant uom but the quantity in the production ones.
ex: consume 1 dozen, the quantity on the stock move line is 1 unit

This commit always uses the wo line's UoM and quantity to create the
stock move line.

This commit is a backport of d813873f (in 13.1)
opw 2154288

closes odoo/odoo#41954

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

If a visitor has access to a task through access_token, he should have
access to the task attachments. He already see the list of attachment
and their name, but since the task access_token is not propagated to the
attachment he doesn't have the rights to see them.

In this PR, we generate the attachments access_token and provide them to
the user that is viewing a task with an access_token.

opw-2125252
closes #41881

closes odoo/odoo#42115

X-original-commit: e7984c49
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Accountant who change the lock date is not always a pos user, and then 
cannot read pos sessions.

closes odoo/odoo#41994

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Company used to get defaults was user.company_id and not current company
in the environment.

Fixes #41679

closes odoo/odoo#41791

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Co-authored-by: Raphael Collet <rco@odoo.com>

Issue

    - Download the customer db: stargue-inc
    - Go on the website in mobile mode

    Traceback & the second item in the carousel is not displayed.

Cause

    Traceback: we use `this.$iframe` without checking if it's defined
    Second item not displayed: the first video promise is overriden
    by the second video promise.

Solution

    Check if this.$iframe is defined and resolve the old promise
    instead of overriding it.

OPW-2152690

closes odoo/odoo#42098

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

If getLangDateFormat is called right in loading the js file, it returns
default format. We now call it when translations are ready.

closes odoo/odoo#42119

X-original-commit: e7a58430a382ca1161131e562d53bef3ea0e6ce0
Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

If a long-running transaction holds a write-lock on any row in
ir.attachment, the GC job can wait an indefinite amount of time to
acquire its table-wise SHARE LOCK.

While sitting in the queue for this lock, it will conflict with any
future transaction that tries to acquire a write-lock on any row [1].
So the GC transaction, which would normally execute very fast and
immediately release its lock, will start to block other transactions and
cause severe delays in response time. It basically depends on how long
the tx holding the lock takes to complete... which is unknown.

As a workaround, we force an arbitrary (but short) lock_timeout in the
GC tx before attempting the lock. If it fails to acquire it, it will
fail and raise, causing the whole operation to abort. The cron job will
be rescheduled quickly because it failed to complete, giving the GC
another chance to complete.

10 seconds seems a reasonable compromise, as it gives the blocking
transaction(s) some time to complete before bailing out, yet should
not be long enough to bring the system to a halt due to other
transactions blocked by the GC one. I have no hard data to back this
claim, though.

[1] See the LOCK conflict table in the documentation:
      https://www.postgresql.org/docs/10/explicit-locking.html



closes odoo/odoo#41816

Signed-off-by: Christophe Simonis <chs@odoo.com>

When running multiple odoo on the same machine (in order to test
multiple things concurrently, etc...) it's easily enough to start them
on 8069, 8070, 8071, ... and that *seems* to work, but then they start
walking on one another and *losing* chromes entirely, so you end up
with hundreds of chrome processes: right now with 2 Odoo running tests
my machine is at 365 Chrome processes, 550 process and 3180 threads
total (should be ~160 and ~700 with 2 chrome processes at most).

Instead, ask the OS to ask for a devtools port, then close the socket
and pass that to the child process. There's a race of sort for the
instant between closing the socket and Chrome reopening it, but:

* the window is very short
* we got a random port from the ephemeral range, it's possible
  somebody else gets it inbetween but unlikely (the 50% on a birthday
  attack is 200 for Linux's ephemeral range, it's a somewhat lower 150
  for the IANA range used by BSDs and Windows)

Sadly chrome doesn't stop if it can't bind to the port it's given.

closes odoo/odoo#42096

X-original-commit: 897ded1c
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

* web_editor

Previously, increasing the number of columns on the tabs snippet would
cause the newly created tabs to toggle the original tabs instead of its
own, this was caused by an oversight where the columns were clone
directly using jQuery, and the snippets' the onClone method was not
called on the newly created columns (here, tabs). This commit move the
responsibility to clone onto the SnippetsMenu so that it can create the
appropriate snippetEditor if needed and call its onClone method.

task-2070643

closes odoo/odoo#41909

X-original-commit: 5876e01c
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

opw-2157568

closes odoo/odoo#42086

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, the log displayed "set as done"
before actually trying to put the transaction in done.
If an error then occurred in the'_set_transaction_done'
function and the transaction could not be processed,
this could lead to a misinterpretation of these logs.

This log is therefore moved after the transaction is
processed and is only displayed if it is actually successful.

This is valid for'done','pending' and'cancel'.

closes odoo/odoo#42078

X-original-commit: dd7552b1
Signed-off-by: jev <jev-odoo@users.noreply.github.com>

We are looking for the "Bom Count" stat-button, which can be hidden
behind the "More" dropdown, depending on the number of installed modules
and views inheritance order loading.

closes odoo/odoo#42073

X-original-commit: dc4a40cc130175a60aa77a0660613b23c4bb916f
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

closes odoo/odoo#42068

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

opw-2157386

closes odoo/odoo#42044

X-original-commit: e8f080b0
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Without this commit the multi-company dropdown breaks the page on mobile

closes odoo/odoo#38146

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

Was added at 958f9106 but lost during design change

closes odoo/odoo#42058

X-original-commit: 560dba53
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#41997

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Steps to reproduce:
-install website, website_partner, contacts and studio
-go to contacts and open any partner
-click the studio icon (top-right corner of the screen)
-add the 'website_description' field to the partner

Previous behavior:
the description field is not translatable and attempting to
change the "translatable" option in technical > fields spawns
an error

Current behavior:
the description field is translatable

opw-2155115

closes odoo/odoo#42034

X-original-commit: 186b5992
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

SPECIFICATIONS

Fixes following issue: when a lead is marked as lost, the probability is
correctly set to 0 but not the automatic one. If one clicks on the "Set to
automatic", the probability is updated, which un-archives it without really
restoring it, meaning we get in a very strange state outside the expected flow
(no Won/Lost buttons, ...).

With this commit the automated probability is set to 0 when setting as lost.
Moreover restoring a lead recomputes its probabilities.

LINKS

Task ID 2092799
Manual backport of PR odoo/odoo#42015 done in master
PR odoo/odoo#42045

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to produce:

1. Go to 'Contacts'
2. Select a contact
3. Click on "More" stat button

To fix this, we need to force the padding to avoid touch_device rules.

closes odoo/odoo#42008

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

closes odoo/odoo#42005

X-original-commit: 026224ce
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Task 2080222

Some localizations need to have a higher precision on percentage values
in the reconciliation models.

closes odoo/odoo#41843

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

A new currency has been introduced in Mauritania in 2018:
https://en.wikipedia.org/wiki/Mauritanian_ouguiya



opw-2156411

closes odoo/odoo#41992

X-original-commit: 321fc5b3
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue

    - Install website
    - Add another language
    - Edit > Click on a menu item > Edit menu
    - Add mega menu & save
    - Change language
    - Click on the translate button
    - Try to translate a mega menu's item

    You can't, it always closes.

Cause

    This is the default bootstrap behavior.

Solution

    Override the default bootstrap behavior.

OPW-2151710

closes odoo/odoo#41911

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When expending a many2x record, a field named 'name' was used to
represent the exported record.
If there was no field 'name' on the record, expanding the many2x field
raised a KeyError in the export screen with "import-compatible export"
enabled.

Use the _rec_name instead as fallback

closes odoo/odoo#40768

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Purpose of this commit is to better support custom styling used notably
for mass mailing and outgoing emails. Indeed styling is whitelisted when
storing html. Finding it in html requires some parsing. This commit improves
the regex used to find it when semicolons are involved. It allows more use
cases to be correctly supported.

Task ID #2125856
PR #40433

closes odoo/odoo#41966

X-original-commit: 5235a49a
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Since commit 91560fae, we are using sudo to write
calendar_last_notif_ack, but we need to update the real partner stored
in the context.

opw-2133566

closes odoo/odoo#41976

X-original-commit: 4d6416db
Signed-off-by: Alex Tuyls <alt-odoo@users.noreply.github.com>

Before this fix, when a refresh of the google token was triggered
and error 400 where returned, if the user did not have write rights
on res_users, an access rights was raised

Now, the write is done and the real error is raised for the client.

Part of OPW-2123045 (needed to further investigations)

closes odoo/odoo#41765

X-original-commit: b4f794c5
Signed-off-by: Richard Mathot (rim) <rim@openerp.com>

closes odoo/odoo#41604

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Be in multi-company with companies C1, C2.
Let user U1 in company C1 create a vendor bill V.
Then U1 change to company C2.
Another user U2, in company C1, tries to print the vendor bill.
Traceback: Access error trying to access U1 to render the template

opw 2145738

closes odoo/odoo#41644

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

If an operator executes the /lead commands, the visitor was not linked to the
lead. This commit fixed that. The visitor is now linked to the lead but the
visitor does not take the lead's name.
(As '/lead leadName' creates a lead with 'leadName' as name but not as contact
name and the visitor needs the contact name of the lead)

Task ID: 2081534
PR #38706

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Only the livechat users can see the livechat sessions linked to the lead.

Task ID: 2081534
PR #38706

The security file was not loaded in the manifest.
also, the tracking model name has changed to website_track.

Task ID: 2081534
PR #38706

closes odoo/odoo#41716

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The slide.slide and slide.channel "_compute_slides_statistics" methods do not
always assign a default value for the "total_slides" field.

This can cause some CacheMiss and seem related to nondeterministic errors on
the runbot.

Task#2123711
Runbot build error ID 247

closes odoo/odoo#41797

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The filename can be obtained in 3 ways when downloading a file, in order:
- by the filename argument
- by the filename_field argument
- a default one is computed as backup.

In the last case, there is by construction no file extension.
The filename is made from the record's model name, id and field.
However the model name almost certainly contains a ".",
which is the standard extension separator for filenames.
As a result <model_name_end-id-field> is considered to be the existing
extension, so we don't try to guess it from the mimetype.

To keep the existing default filename convention, we always add the
guessed extension in this case.

opw 2149612

closes odoo/odoo#41917

X-original-commit: f62a49a2f83bcce66eb9c3b08687ee5a37def503
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

- Create a product A, FIFO & Automated
- Create a SO, deliver and invoice
- Post the invoice
- Reset it to draft
- Post the invoice again

The COGS lines are duplicated.

Unlike the other lines, the COGS lines are only added at posting. This
is done in case several invoices are generated in draft, but validated
in an arbitrary order.

We clean up the COGS lines when resetting to draft.

opw-2153695
opw-2152465

closes odoo/odoo#41915

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue

    - Install e-commerce
    - Add stripe as payment acquirer
    - Go in website > shop
    - Add something in your cart and process checkout
    - In developer tools > network set online to slow 3g
    - Spam the pay now button
    - Go in Website > Configuration > Ecommerce > Payment Transactions

    Multiple transactions have been created for your order.

Cause

    The pay now button doesn't stay disabled during the payment process.

Solution

    Disable the button and enable it only when the process is done.

OPW-2148899

closes odoo/odoo#41860

X-original-commit: 2d63d8165b96fc5cb3118fdc16aadbafd8ee9963
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>