Before this commit, when we export a list with a groupby on
boolean, the groupby title 'False' is replaced by 'Undefined'
in xls document.

After this commit, with an export and groupby on a boolean, we
will have correct title: True and False.

With a Right to Left lang.
Go to an employee form view.
Click on the small pill with the number of subordinates (in the org chart).
The popover opens but on the right side of the window instead of next to the
pill.

Fixes #38722

closes odoo/odoo#38776

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Before this commit:
Private email and phone are related of partner 'address' fields.
But the phone was read-only and the email is editable.

After this commit:
As phone and mail are related, they are read-only. We must edit
them on the partner of Address field.

close #38518

closes odoo/odoo#38713

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Before this commit:
When there few elements in kanban and a search panel, all kanban
cards try to take a maximum of height and become deformed.

After this commit:
The behaviour of dimensions of kanban cards must be the same with
or without searchpanel.

closes #38556

closes odoo/odoo#38703

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

When a reconciliation proposition's amount is computed from a regex, we
cannnot be sure the regex captured something. If it didn't we don't want
to display a badly formatted line so we set the amount to 0.

closes odoo/odoo#37578

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>

closes odoo/odoo#38834

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Once we add an address in Peru we need it to be displayed in the next
way for the reports:

Name of the partner
Street name, number
Apartment(optional)
District
City

The level State and Country are added to complement the street address.

closes odoo/odoo#38764

Signed-off-by: Josse Colpaert <jco@openerp.com>

- base_vat: Correct management of the check of peruvian VAT without prefix.
- l10n_pe: Correct income account the last one is not correct.
- l10n_pe: Forced Round globally for peruvian companies once l10n_pe is
installed, and with the onchange.
- l10n_pe: For peruvian companies it does not make sense a sequence per
year and the year in the prefix is incorrect, we must force XXX- as
a sequence prefix.

This option, if set to True, prevents the user from modifying the
color of the tags.

Part of task 2070454

closes odoo/odoo#38785

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

closes odoo/odoo#38824

X-original-commit: 62d7eaf8
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Since we are not using document only in invoice by now we remove the
option to incoude receipts.

closes odoo/odoo#38439

Signed-off-by: Josse Colpaert <jco@openerp.com>

The im_support module was broken in 12.0 after bus refactorings between
11.0 and 12.0.

closes odoo/odoo#38831

X-original-commit: db37e0ce
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
Co-authored-by: @alexkuhn

Have a reconciliation model that applies to some particular journals
And that will match some of those journals' lines
The field journal should be filled too
(this field is only the default journal that a proposition will be filled with)

Open the reconciliation widget on a given journal, within the list of
possible journal (from the account dashboard)

Before this commit there was a crashed. This was caused by the fact that
one of the lines that should be displayed had a reconcile model that was not fetched beforehand

After this commit, there is no crash as all relevant reconcile
models are fetched

Note that, on reconcile models, the field journal_id is just there to prefill
the propositions it will create

corrects commit e5c80714

OPW 2084942

closes odoo/odoo#38817

X-original-commit: 2f4344cce6672e5dbe319047c5c7db293a05ba54
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

Before this commit, trying to print a registration without a name
specified (not required), was failing

Fixes odoo/odoo#38564

Replace and closes odoo/odoo#38582
Courtesy of Swapnesh Shah

closes odoo/odoo#38811

X-original-commit: a21a81e9
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

companies.

We revert the change we apply in order to let the user to define their
own fiscal positions, now the fiscal position will be set depending on
the afip responsability.

With this change we fix the error that the fiscal position is properly
setted for the customers that are of type "Responsable Inscription" and
"Consumidor Final".

Before this change the "Compras / Ventas en el Exterior" fiscal position
was wrongly seted, now the fiscal position is leave empty so the related
invoice taxes are properly matched

closes odoo/odoo#38431

Signed-off-by: Josse Colpaert <jco@openerp.com>

In 12.0 it was 3.5 but for 13.0, it is acceptable 3.6.
Debian Buster has 3.7 and Ubuntu 18.04 LTS has 3.6
This will avoid undeterminist errors with OrderedDict

CentOS 7 still does not ship python3 by default but it is possible to
install it and CentOS 8 with python 3.6 was released in septembre 2019

closes odoo/odoo#38364

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#38770

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

- Let a model M define a Many2oneReference field F1.
- Let a model N define a One2many field F2 whose inverse is M->F1
- Define a computed field N->F3 that depends on N->F2

If, for whatever reason, a recordset of M contains records that have
been unlinked already and we try to unlink them again, the system will
crash with a MissingException error.

This happened because, while most _modified_trigger cases cover the case
of a MissingException (i.e. record not in cache), the case for a
Many2oneReference didn't.

This is fixed by simply ignoring these "stale" records in the
_modified_triggers section for Many2oneReference fields.

closes odoo/odoo#38697

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Co-authored-by: mreficent <miquel.raich@eficent.com>

Instead of showing a traceback, show a user-friendly error message
to the user to avoid recursive pos.category.

closes odoo/odoo#38769

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Install Accounting, create a journal entry, post it, reverse it with
a date in the future.

The reverse entry will be posted, instead it should stay a draft (with
the appropriate 'auto_post' set to True)

opw-2083121

closes odoo/odoo#38470

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Install Accounting, create a journal entry, save. Go to "Other Info"
tab.

"Reverse entry" button is visible, but it should be names "Reversal of"
and it should be hidden if there is no linked reversed entry.

opw-2083121

The snippet was using the posts of all websites and blog post creation
was suggesting all blogs. Now:

- On blog post creation only suggest the blogs of the current website
- In latest posts option, only suggest blogs of the current website
- In any case, latest posts only displays posts of the current website

Part of https://github.com/odoo/odoo/pull/38510
Related to task-2083198

closes odoo/odoo#38727

X-original-commit: https://github.com/odoo/odoo/commit/acd010fdc928acebf20552ae32f2667d72fdca56


Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Indeed, a theme can declare its own latest posts template so it would
crash with ref instead of viewref.

Part of https://github.com/odoo/odoo/pull/38510
Related to task-2083198

X-original-commit: https://github.com/odoo/odoo/commit/c20b3826099619eaa0bc084cd54ebb43c092c416

Since the ir.sequence records linked to pos.config records are on
delete restrict, it is necessary to delete the pos.config records first
before deleting the ir.sequence's linked to them.

closes odoo/odoo#38760

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

closes odoo/odoo#38211

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Translate 'hours' and 'days' in leave allocation
Modify e1c2bbe1 in 13.0 for a better structure

closes odoo/odoo#38721

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

From Accounting Dashboard, under the kanban card "Customer Invoices"
click on "Upload Invoice" and submit an e-fff invoice (xml) which is
actually an invoice (e-fff type 380, should be uploaded under
"Vendor Bills" card). The server will reply "Cannot create an invoice of
type in_invoice with a journal having purchase as type." because it will
fetch the type not from the destination journal but from the guessed
journal.

opw-2083545

closes odoo/odoo#38755

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Create a sales order for a company with a contact name.
- Click the Preview button.
- The company and contact names appear on the same line, only separated by a
comma.

Before this commit:

it's not possible to easily override this behavior.

After this commit:

it's possible to override `Partner._get_contact_name` to change the format of
contact name.

Beware that this method is used in `_get_name` which is called from various
places. A check on the context may be necessary.

closes odoo/odoo#38701

Opw: 2077294
X-original-commit: 0b8f3f93a2cb05cc9c940964fe80acd23b86b8a0
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Revision on https://github.com/odoo/odoo/commit/9a66619db33fca5f0cb81d9f6bfeb0fb0290cf68



Commit above improves the web client startup by not having to wait
for discuss widgets to fully load beforehand.

However, it introduced an issue with chatter when the 1st rendering
happens before messaging becomes ready: it displays
"Creating a record..." instead of the whole history of messages.
This happens because when messaging is ready, it updates data from
the chatter but it does not trigger a re-render.

This commit fixes the issue by triggering a re-render on messaging
ready. When messaging is not ready, thread field now displays
"Loading..." instead of the message "Creating a record...".

Task-Id 2078193

closes odoo/odoo#38749

X-original-commit: 93bdd7c91095025f4d6e7a058e0ab1c4e1a0ad60
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Ease module upgrade.

closes odoo/odoo#38741

Signed-off-by: Christophe Simonis <chs@odoo.com>

As the python3-xlrd package is available in Debian stretch and Ubuntu
bionic, there is no reason to not include it in Odoo debian package.

However, it cannot be used in Odoo 11.0 package as it does not exists in
Ubuntu Xenial.

ubuntu package:
https://packages.ubuntu.com/bionic/python3-xlrd

debian package:
https://packages.debian.org/stretch/python3-xlrd



closes odoo/docker#276

closes odoo/odoo#38742

X-original-commit: acf413df
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Follow up of commit a3845ae3

Issue
=====

Since the above commit there is a confirmation dialog when clicking on a button,
for which the only options are to Discard or Cancel.

The problem is that when discarding it will revert the selected website back to
the default value. Therefore before the current commit it is impossible to
install a theme on a website other than the first.

Solution
========

The solution is to avoid showing this dialog when clicking on buttons for which
the result depends on the currently selected website. This leads to the same
behavior as what existed before the mentioned commit: the settings are
implicitly discarded because they are not saved, but at the time of the click
the transient model still holds the non-discarded value that the user selected.

This restores the "select a theme" feature, but also restores the unfortunate
side effect that the user might unknowingly loose all of his pending changes
when clicking on the button, but only for those two specific buttons.

Other considerations
====================

Saving instead of Discarding was considered but it is impossible to do because
saving might do a lot of changes that might even lead to the installation of
modules, so the settings page has to be reloaded to apply them, and then the
website field will be reset to its default value again.

Instead of changing website specific settings from the main settings, it was
considered to update them through a form view, but it is apparently too
complicated for on-boarding.

The last consideration was that the settings view should actually mark the
corresponding fields as unchanged when changing the website, but it is too
complex to implement for a case that is not supported in the first place,
especially for a fix in a stable version.

task-2083198

closes odoo/odoo#38716

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Before this commit, the editable quant list was editable by top, which
is not really pratical when the user creates (with the keyboard)
multiple quants tracked by SN because the focus always go back on the
top of the list. Now, this list is editable by bottom.

closes odoo/odoo#38704

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

When you are adding a line on your sale order that is a delivery line,
the carrier is not always set on the sale order which means that when
the carrier is not explicitly set on the sale order, the carrier won't
be set on picking created from the sale order.

When you are using the wizard on sale order, it works, but when the
carrier is selected on the e-commerce, it is not set on the sale order.

To avoid such difference in behavior, we are writing the carrier_id of
sale order in the function 'set_delivery_line' insread of the wizard and
e-commerce.

closes odoo/odoo#35855

closes odoo/odoo#38730

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

The product copy was fixed in https://github.com/odoo/odoo/pull/38303

 
but the result is still not intuitive.

You could duplicate one of the multiple variants of a template and see 
another variant form opened than the one you just duplicated.

closes odoo/odoo#38725

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Before this commit, when clicking on "Unstar All" from Discuss
'Starred' mailbox, it crashes with following error:

```
TypeError: unstar_all() takes 1 positional argument but 2 were given
```

This commit fixes this issue

closes #37994

closes odoo/odoo#38226

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Revision on https://github.com/odoo/odoo/commit/e7aff236b8073b952a0e554d9897a8f88d5c4c91

Commit above remove cross icon on attachments from messages that are
not in the chatter, since this only makes sense in the chatter.

However, it also removed by mistake the possibility to delete
attachments from the attachment box in the chatter.

This happens because the template of attachments uses a newly
introduced contextual boolean `isDeletable`, and this is false by
default due to undefined being falsy.

This commit fixes the issue by explicitly enabling deletion of
attachments from the attachment box.

Task-Id 2081987

closes #38003

When you try to create two users with the same login, the shown error message is
the Postgresql integrity error instead of a nice (translated) validation error.
This happens since bf88f3e3 which changed the way error messages are translated.

The reason is the manually created unique index `res_users_login_key_unique_website_index`.
The error handling and translation mechanisms don't know it exists.
The index was created for performance reasons in commit b5a12b4a where the
original python constraint was replaced with this custom SQL index.

In this commit, the python constraint is re-introduced to remove the index hack,
but the implementation now uses a single SQL query, which should be quite fast.

closes odoo/odoo#37901

Signed-off-by: Christophe Simonis <chs@odoo.com>

When selecting the "Continue shopping" option after adding a
configurable product from the products page with "Add to Cart" enabled
the top navbar was not updated.

Part of https://github.com/odoo/odoo/pull/37132

task-2070507

closes odoo/odoo#38538

X-original-commit: https://github.com/odoo/odoo/commit/9e58f0659e21d0f7e63b127d7a84b505e6aa1fb5


Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

The animation was not waiting for the target to be displayed.

Part of https://github.com/odoo/odoo/pull/37132

task-2070507

X-original-commit: https://github.com/odoo/odoo/commit/b7f2dd4d56537fb06682419fa75fb7c671160243