It was discussed previously from:
 - https://github.com/odoo/odoo/commit/b79d05fff0cacb4d99ebc1b60f44d8dab757b806



I quote Olivier Dony commit message:

"""
Having it in INFO should be sufficient for its purpose, and will avoid
impacting all CI builds done on a system that does not have the lib
installed.

For the record, this is not a hard requirement because the lib was not
available in Debian stable packages at the time of release. It is only
enabled on demand for those who want the feature and can install it
manually.

Fixes #22426
Closes #22459
"""

closes odoo/odoo#40781

X-original-commit: 0394f5e9
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

steps to reproduce:
-change decimal accuracy for "Product Price"
-create a price list with fixed price
-the fixed price field does not takes the decimal accuracy into account

this was working in V11 and V12
fixed_price was a float field like other price fields

previous behavior:
fixed_price is a monetary field
when setting up a fixed price for a pricelist, it takes into account
the precision from the current currency

current behavior:
fixed_price is a float field
when setting up a fixed price for a pricelist, it takes into account
the proper decimal accuracy setting ("Product Price")

opw-2121964

closes odoo/odoo#40777

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

Added Chart of Accounts, taxes and other related data

closes odoo/odoo#40776

Task: 42243
Courtesy: www.vitraining.com
Signed-off-by: Josse Colpaert <jco@openerp.com>

closes odoo/odoo#40512

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

This is a performance fix.  It avoids the cost of XML/HTML translations
for fields that may not be necessary when prefetching fields on records.
This patch marks such fields as non-prefetchable by default.

The code that changes the attribute `translate` on HTML fields (from
`translate=True` to `translate=html_translate`) has been adapted to
allow the setup of textual fields to mark the field as non-prefetchable.

Jairo Llopis made a comparative benchmark: evaluating `name_get` on
`event.event` records.  The method needs the field `name` and without
the patch, the prefetching mechanism reads the translated HTML field
`description` as well.  This patch speeds up the benchmark from 5800ms
to 800ms (see https://github.com/odoo/odoo/pull/37967#issuecomment-538364011

).

closes odoo/odoo#40706

X-original-commit: 4d501480
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Co-authored-by: Pedro Baeza <pedro.baeza@tecnativa.com>
Co-authored-by: Jairo Llopis <jairo.llopis@tecnativa.com>

The `session_info` dictionnary is used to bootstrap some JS code client
side (usually in the backend). It includes relevant information, such
as some parameters key for the OdooBot onboarding, the Enterprise
subscription expiration alert, etc. to avoid triggering a lot of RPC
calls upon webclient start.

`session_info` is also called by the remote authentication mechanism
located at `/web/session/authenticate`, which can be used by external
mechanism to obtain a valid session remotely.

Revision odoo/odoo@8a28cc2 introduced the concept of cache keys for
some oft-requested data (such as menus, translations and dynamic qweb
templates) to avoid requesting them on each webclient start, since they
tend not to change often. Unfortunately, it introduced a read on the
ir.ui.menu model that raised an `AccessError` if the authenticating user
was not a member of the `base.group_user` group ('Internal' user type).

While fixing that issue, it became apparent that `session_info`
returns a whole lot of information through this remote connection route
which is entirely unnecessary if not used in the context of a webclient
start, such a currencies, the state of the enterprise subscription, etc.

This commit fixes the access right issue by removing this non-relevant
information from the returned dict (including cache keys) if the user
is not an internal one.

closes odoo/odoo#40213

Related: odoo/enterprise#6688
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

closes odoo/odoo#40589

X-original-commit: d8bc17d5
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

We are initializing over the limit to make sure we will compute it at least once.
If the target goal is set to 0, we are facing a division by zero error when
displaying the gamification goal just after initialization.

closes odoo/odoo#40729

X-original-commit: 24546e7c4cac61efea8d3f9e558518a55ef9acd2
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Do not update the date_planned of section/note purchase lines when 
writing on the order date_planned.  Otherwise the SQL constraint 
ensuring display lines have no other data blocks the changes.

Fixes #40741

closes odoo/odoo#40743

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

If the user put more than 200 emojis, we didn't replace emoji with
image. But due to a typo in the code, this mechanism broke the
discuss application.

closes odoo/odoo#40725

X-original-commit: 0877cb6c
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

'Send' button meant to send Italian e-invoices are shown
for invoices belonging to non-Italian companies as well.

Since the invoices' are being sent on validating the
invoice itself, Send button means less business here.

Hence removed it.

opw-1945836
closes #31470

closes odoo/odoo#40717

Signed-off-by: Josse Colpaert <jco@openerp.com>

Install Accounting, go to Configuration > Follow-up Levels. Create a new
Follow-Up Action with low due days just to make testing easier and "Join
open invoices" enabled. Go to Customers>"Follow-up Reports", select a
follow up report with action "test", click on "Send Email"

The email will be sent, without attachments. There should be a number of
attachments equal to the number of due invoices, but for security reason
the attachments are filtered in the message post processing phase.

Changing security check to avoid filtering legitimate material.

opw-2116803

closes odoo/odoo#40181

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

An UBL invoice can contain several `AdditionalDocumentReference`, some
of them without `Attachment`. For example:

```
  <cac:AdditionalDocumentReference>
    <cbc:ID>UBL.BE</cbc:ID>
    <cbc:DocumentDescription>BOB50  6.07.0</cbc:DocumentDescription>
  </cac:AdditionalDocumentReference>
  <cac:AdditionalDocumentReference>
    <cbc:ID>Facture N°19090118 - 30-09-2019.pdf</cbc:ID>
    <cbc:DocumentDescription>CommercialInvoice</cbc:DocumentDescription>
    <cac:Attachment>
      <cbc:EmbeddedDocumentBinaryObject filename="Facture.pdf" mimeCode="application/pdf">JVBERi0xLjMK...
...
```

In this case, a crash occurs since:

```
element.xpath('cac:Attachment//cbc:EmbeddedDocumentBinaryObject', namespaces=namespaces)
```

is an empty list.

To avoid this, we loop on all elements and generate all PDFs.

opw-2128083

closes odoo/odoo#40698

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, the field `next_serial_count` in stock.move, used to
know how many SN the user wants to generate, wasn't correctly set and
was always equals to 0.

closes odoo/odoo#40559

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Before this commit, when user creates a receipt for a product tracked by
serial number, using immediate transfer, the fields to generate and
assign SN was hidden.
The reason was the move is confirmed in this case, and those fields was
displayed only for partially available and assigned moves.

task-2123761

Before this commit, with a time range activated in a pivot view,
click on a non empty cell would not always give the right list of
records because of a bad action domain.

The reason is that the headers domain or comparisonDomain were
not always set when appropriate:
    - for the headers 'Total', the corresponding group obtained
      by read_group does not contain the key __domain. For that
      reason both the key domain and comparisonDomain were left
      undefined.
    - for headers that correspond to groups not present in the two
      periods compared, one of the key was left undefined.

With the present commit, we correctly set the domain and
comparisonDomain keys everytime they are useful.

closes odoo/odoo#40509

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Reproduce the issue

    - Install Projects
    - Create a project
    - Create a task with a deadline

    The deadline format is correct in the form view but not in the
    kanban view.

Cause

    In the kanban view, there is some code applied on the `date_deadline`
    field to add a class when the deadline is near.

    As it uses a `span` with a `t-esc`, the only way to get the date
    is to do `record.date_deadline.raw_value` which return the raw
    value of the datetime object (a big string with all the infos).

This commit creates a char field for the formatted date and uses it
only for the display.

OPW-2122928

closes odoo/odoo#40599

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, calling gengo_authentication (executed from the
cron _send_translation_terms) returns an error when the python library
gengo is not found on the system.
If tried to request a synchronisation, got an error "NameError: name
'Gengo' is not defined"
Gengo variable was undefined as no imported.

closes odoo/odoo#40674

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

No justification, commit message not linked to the diff.
If there is an issue in the line_number extraction it must be
investigated.
I suspect an outdated polib version.

closes odoo/odoo#40672

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#40639

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

In case the Stripe API call fails, an Internal Server Error page is
displayed to the user, which is not user friendly.

opw-2126196

closes odoo/odoo#40670

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

When a calendar event is created with a duration of for example 20
minutes, the end time appears as the start time + 19 minutes.

Because of the rounding of the duration (20 minutes = 0.333... hours),
the end time is incorrectly set (xx:19:59.998...) then displayed. Since
the duration can only be set by the minute, we round it before computing
the end time.

opw-2122853

closes odoo/odoo#40652

X-original-commit: f6ae9f0a
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

A deadlock can occur between threads when concurrent requests
acquire the registry lock and conflicting database-level locks
in different orders. The database won't be able to detect and
break the deadlock because it involves an external, Python-level
lock. This situation is more likely to occur during module
installations [1].

If the server is started with the `limit_time_real` option,
it should be able to abort the deadlocked requests after the
timeout, and restart. However that could not work because
the recovery initiated by `reload()` is blocked at the end
of the `stop()` method, as it cannot acquire the registry
lock either, necessary for `Registry.delete_all()`.

Since that deletion step is in fact not necessary, it can
be skipped, avoiding the deadlock entirely.

Indeed there's no real reason anymore to delete the DB's
registry upon shutdown. This was introduced for 7.0 by
b5daffc1, in order to perform
other cleanups (including cron agent threads). These other
cleanups are not necessary anymore, and when the stop()
method of the ThreadedServer completes, the next step is
either a restart of the whole process (via execve() through
_reexec()), or a full process exit. Keeping the registry in
memory for a few cycles until this happens makes no difference.

When such a deadlock occurs, it's always possible to manually
kill the server with 2 `kill` commands, or 1 `kill -9`.

~~~~~~~~~~~~~~~~~~~~~~
[1] Reproduction info:

The following deadlock was observed in Odoo threaded server mode:

1. incoming request spawns a new thread A
   A starts a transaction and does a "SELECT ... FROM res_users ..."
   getting an ACCESS SHARE lock on the table
2. incoming request spawns a new thread B
   B is a request that calls `button_immediate_install`, that will
   install new modules and alter the res_users table.
3. B takes and holds the registry lock and executes "ALTER TABLE
   res_users ...", that waits to get the ACCESS EXCLUSIVE lock on the
   table until A's transaction releases the ACCESS SHARE lock.
4. A continues code execution and reaches a .sudo() call, it tries to
   create a new environment. The creation of the new environment
   requires to wait for the registry's lock to be release but it's held
   by B.

-> A waits for B's registry lock to be released
-> B waits for A's ACCESS SHARE lock to be released
-> Deadlock that can't be broken except by force-killing the server

closes odoo/odoo#40663

X-original-commit: 9e675254
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

Since Odoo V13, ES6 is supported and we therefore do not support IE 11
anymore.

closes odoo/odoo#40602

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

 - Add blank lines at end of python files (pep8)
 - Easier uncomment (entire blocks, and no remaining whitespaces in empty lines)
 - Add `_description` to model to avoid the warning telling it's missing
 - Correct compute field, `self.value` raised an `ensure_one` issue
 - Change access so the user can add/edit/delete records in the web interface
   by default
 - Correct the server action, `self` is not in the server action context.

closes odoo/odoo#38520

Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

Steps to reproduce the bug:

- Let's consider customer P
- Create two customer invoices C1 and C2 for P
- Cancel C1
- Go to bank reconciliation
- Create a statement with a line for P
- Click on 'Reconcile'

Bug:

C1 was suggested to be reconciled

opw:2120756

closes odoo/odoo#40601

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Install Helpdesk, setup an email alias. Send to that alias an email
where the name of the from field contains unicode characters. The name
shown in the interface is base64 encoded, RFC compliant email name.

Python 2 `email.utils.formataddr` does not generate RFC compliant
header fields. It just formats the header as `name <email>`, quoting
the name when necessary. Only ASCII names/emails are supported but it is
convenient to show correctly formatted emails on forms.

Python 3 `email.utils.formataddr` generates RFC compliant header
fields, it encodes the name in base64 or quoted-printable when it
contains non-ascii characters. The entire unicode charset is supported
but the function shouldn't be used when showing email addresses on
forms.

The problem has been fixed by backporting our own `formataddr` (c024d89,
a66e16e and 81003c1). Our function supports both use cases : pretty
format and RFC compliant format.

opw-2115767

closes odoo/odoo#40298

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Activate Google Synchronization, create on OE a recurrent event (no allday)
synchronize the calendar, then delete an event of the recursion on OE,
sync again on OE.

An error will popup in the console. There is a typo in the variable
sent to the google API.
https://developers.google.com/calendar/v3/reference/events



closes odoo/odoo#40614

X-original-commit: 299bb8a9
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce:

1. Go to the Accounting / Invoicing apps
2. Open Taxes (Configuration -> Accounting / Invoicing -> Taxes)
3. Try to create a new tax and the client crash.

It occurs because the `_processX2ManyCommands()` method doesn't handle
correctly a missing `fieldInfo` on some X2Many tags.

On mobile, when calling `load_views` the kanban view is used by default.
But if the kanban isn't defined, a default kanban view with only the id
of the model is used.

In the case of the taxes form, the `default_get` retrieved for this
form refers to a Many2Many (`tag_ids`) inside a One2Many. But this field
isn't present inside the loaded kanban view, so when we process the
command defined by the `default_get`, the `field_view` item doesn't
exist (because the default kanban loaded only contains the id of the
field).

Now instead of using an undefined `fieldInfo`, we fall back to an empty
object on the missing field to avoid the crash.

closes odoo/odoo#40612

X-original-commit: 47a306a31ac6d3c9e68e83b77a80426d5c6ceb05
Signed-off-by: res-odoo <res-odoo@users.noreply.github.com>

Reproduce the issue

    - Install Time Off
    - Select all the lines
    - Action > Export

    The file has only columns but no data

Cause

    In `hr_leave_type.py` the `_search` method's limit is `False` when
    we select all the lines.

    In 04e85efb, we return the leaves ids with `[:limit]` so `[:False]`
    that always returns an empty array instead of `[:None]` that returns
    the full list.

This commit replaces the `[:limit]` by `[:limit or None]`

OPW-2126109

closes odoo/odoo#40539

Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>

closes odoo/odoo#40576

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Missing / wrong indented code during rewrite of binary controller:
https://github.com/odoo/odoo/commit/7d85ab1#diff-1407a8ce197a04eefaefa26c127a4418L343-L348



In case you have:

    <record id="s_cover_default_image" model="theme.ir.attachment">
        <field name="key">website.s_cover_default_image</field>
        <field name="url">/web/image/theme_treehouse.bg_img_15</field>
    </record>

theme_treehouse.bg_img_15 will be not found in /web addons.
So we need a 301 redirect too.

opw-live

How to reproduce:
odoo.com/trial > Website > Install theme Clean
Drop first snippet > background is 404

closes odoo/odoo#40483

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

closes odoo/odoo#39432

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Reproduce the issue

    - Install Sales & Events
    - Create an event with tickets (remember the category you choose)
    - Configuration > Event categories
    - Check "Ticketing" and add your tickets types
    - Create a quotation with "EVENT_REG" product
    - Select your event and your ticket
    - Confirm the quotation

    A wizard open with no lines in registration.

Cause

    The backend response is different from the V12 due to some dark
    and deep changes. The old response was converting the
    `registration_event_ids` into a create action but it does'nt do
    that anymore.

This commit specifies the action for the `registration_event_ids`.

closes odoo/odoo#40566

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

— In a SO, create a section or a note;
— Add an invisible modifier (with studio for example).

Before this commit, the table-cells of the section/note were not aligned
any more, and the delete button (trash-can icon) wasn't available.

In a list, the invisible modifier uses a display: table-cell to keep
table cells aligned. But in this specific case, the display is already
none, because they are hidden cells. Therefore, the invisible modifier
it removes the display: none in the hidden cells, this has as outcome
that the table cells are not aligned any more.

Now, the hidden cells cannot have an invisible modifier.

opw-2117714

closes odoo/odoo#40580

X-original-commit: d040f02dd0140d9b7128e806e4a974fe1e8aa0d3
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

The method _get_tax_grouping_key_from_tax_line could give twice the same
key if we removed the analytic tags or tax ids: when 2 lines were
slightly different but are merged, a key conflict could happen.

If this is the case, drop the subsequent lines with the same key.

closes odoo/odoo#38279

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Task 2075249

The commit dd627b96 added a default_get to retrieve the default analytic
values. However, it was depending on self, which cannot be done in a
api.model

In this commit, we use an editable compute in order to update the
analytic values in all the cases, and to reduce the duplication of the
code.

Process a workorder in the community version. Change the quantity to
produce. The quantity to consume is adapted for each component. Save the
workorder and the quantities to consume are rollbacked to the previous values

Those quantities are readonly so not saved to the server.

Task : 2127443

closes odoo/odoo#40557

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>