This commit adapts some existing steps or add new ones to execute
the same tour on mobile.

This tour has many steps and give a good idea to know if new tasks
broke mobile or not.
The goal is that even if the design isn't perfect, users aren't blocked
and are able to perform their usual tasks.

Task ID: 2149402

This commit moves some step utils in a dedicated file and add new ones.
These steps will be very useful for the Main Flow Tour to avoid
duplicated code.

To do this, we also had to transform it into functions to allow
utils to call each other. Existing one are converted for
standardization purpose.

Note that 'WEBSITE_NEW_PAGE' wasn't considered as an util.
This is a very simple step only used twice.

In this commit, we are still running the main flow tour on desktop
but we also run it a second time on mobile.

It's only available in enterprise, otherwise the test will be skipped.

'375x667' correspond to the Bootstrap XS size.
This value is already used for the mobile tests suite.

Task ID: 2149402

We are not able to precise in which case a step should be executed.
We already have 'edition' and now we introduce 'mobile'.

undefined: Desktop + Mobile*
true:      Mobile* only
false:     Desktop only

*: Responsive (<= SM), see isMobile

Note that tours shouldn't be language dependent.
By using XMLID's we are able to find a menu even if the tour
is running in another language.

The tip has been moved slightly but it's not a big deal,
others selectors menu already used XMLID's.

Before this commit, the tip for a many2X field was consumed with a
input event.

But on mobile we doesn't have the same behaviour; a kanban modal is
opened when we click on the many2X field input instead of writing in it
(auto-complete) like on desktop.

After this commit, the tip is consumed with a click event for many2X on mobile.

Since commit: odoo/enterprise@e662ef36296afb2787eb694a33b4c6616a5e1326
a 'div' wrapper was added around the notebook header.

The tip was not visible due to it's location in the wrapper with
'overflow: hidden'.

After this commit, the tip is appended to the ancestor of the wrapper
and so it's visible again.

Before this commit, when you tried to run a tour by clicking on
"Start Tour" in the debug menu, nothing happened and a warning
message appeared in console:
"debug_manager.js:53 No handler for start_tour".
Now it will work on mobile too (debug mode only).

We had to do this to be able to run the main flow tour on mobile.

Note that another commit (in enterprise) will automatically consume
all tours to avoid to display it for demonstration purposes.

Task ID: 2149402

task-2196789

closes odoo/odoo#46298

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Previously the widget was not refreshed everytime it was opened.
Now that it is the case and since the color picker rerenders every time
we select a color:
It is no longer required to select/unselect the colors.
It is no longer required to add custom colors to existing colors.

Part of: https://github.com/odoo/odoo/pull/45872



task-2212288

closes odoo/odoo#47355

X-original-commit: 481fe703e9400fb64e96291914f76d4dca883e29
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

When a default color matches a theme color it will now select the theme
color class instead of a css attribute when clicked.

Part of: https://github.com/odoo/odoo/pull/45872

task-2212288

X-original-commit: d7b3538a814f0e53cd3c5816f8296ad5e4c5f41a

Purpose of this task is some people would like to make accrual in days
but currently accruals work on different periods(week,month,year).

So in this commit, we added "days" as "interval unit" for leave
allocation with type accrual.

closes odoo/odoo#46751

Taskid: 2168023
Closes: #46751
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Currently on a Sales Order Portal view, the field 'date'
under the delivery order shows the creation date of deliveries
linked to the SO,
After this commit it should display the 'effective date'
(or'scheduled date' if not yet delivered) of deliveries linked to
the SO

task:2180525

closes odoo/odoo#46633

Closes: #46633
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Previous implementation of patch (web.utils) only allows patching
methods. This commit allows patching getters as well.

closes odoo/odoo#47047

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

Avoid traceback when click on edit and nothing is editable on the
page.

task-2199214

closes odoo/odoo#47328

X-original-commit: fd92a78b
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Allow non-alphabetic unit (like percentage) as data-unit value.

task-2194309

closes odoo/odoo#47325

X-original-commit: 1f3dd221134b7b5e5b0eac0ab2ffe447771998b9
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Follow-up of d0c852f5

The parser of `many2one_reference` was not introduced when the new field
type was created and then later when the formatter was added, which
leads to errors when the web client is trying to set the value of such
fields.

Since the value of this field is an ID, it is parsed as an integer.

closes odoo/odoo#47330

X-original-commit: db1e16bc
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Allow to use custom product decscription on requisition line.

closes odoo/odoo#34174

Task: 1970476
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

_prepapre_tender_values in only call from purchase_requisition_stock.
It's not needed to have 2 functions, everything should be in
purchase_requisition_stock.

Allow to propagate custom information to upper document. It could be
usefull in many buisness that do custom stuff for people
(t-shirt with user defined text, poster with own pictures...)

The customes values are pass throught procurements'values and are
display on MO or purchase order line.

Task: 1970476

The report layout was refactored before, but we forgot
to give the specific German lay-out a name, although the field
was added.  This gave a traceback when we wanted to
select a lay-out or this particular lay-out (name False)
in the Settings.

closes odoo/odoo#47321

X-original-commit: 162eb091
Signed-off-by: Josse Colpaert <jco@openerp.com>

The unaccent extension was installed only at restore, not at creation
of a database.
Make both consistent.

closes odoo/odoo#46534

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Some option sections are feeling really laggy (especialy the theme ones
we now have in master/13.2). This was due to the "preview" activation of
the snippet being triggered on mouseover and not on mouseenter.

Introduced by: https://github.com/odoo/odoo/pull/36068



task-2198177

closes odoo/odoo#47303

X-original-commit: d85d912de513de5c81c85a8ff814e0af1e13cefd
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

This PR allows one to build the user documentation with python 3 and sphinx>= 2.4.0.
It also removes several warnings.
Remove autogenerated JS doc (backport from master)

closes odoo/odoo#47295

Forward-port-of: odoo/odoo#47169
Forward-port-of: odoo/odoo#46069
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Partial cherry pick of e4b75149
Sphinx 1.6.7 is the minimum in debian stable and ubuntu LTS

X-original-commit: 516e7854

Steps to reproduce:
  * Create a template with 2 variants
  * Archive one variant
  * Unarchive this same variant

--> the template is archived
This is due to commit 6a13b565cbbad89ff1c4177b171b01f30c83edf9. If the
variant is the only one, toggle_active on the variant should be
reflected on the template. The issue is that toggle active do not count
archived variant. One active variant and one archived variant are
counted as 1.
This commit make toggle_active count all variants

closes odoo/odoo#34769

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

Before this commit when a user archives the product, the barcode
field in its template used to get disappeared.

Since barcode field in template is a related field to product,
the field gets invisible in product template when the user archives
the related product.

After this commit, even when a product is archived,
its barcode will still be visible in template.

Here the barcode field is changed from related to computed.

task-1978559

If you want to de-activate the multi company ir.rule, those checks will
still raise an error.

Task 2198433

closes odoo/odoo#47291

X-original-commit: 12a81a3a
Signed-off-by: lul-odoo <LucasLefevre@users.noreply.github.com>

Issue

	- Install Sale
	- Create SO
	- Add a note line with a very looong word
	- Print PDF

	No line break, table is expending out of
	the visible report.

Cause

	There is no line break CSS rule

Solution

	Use word-break: break-word; in order to
	break line without cutting words.

OPW-2195984

closes odoo/odoo#47272

X-original-commit: af8fb786
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

Since 13.2, the cards cannot contain an overflowing element anymore as
we needed to enforce 'overflow: hidden' for the border-radius option.

Note: this commit adds data-vxml="001" on the snippet. This will allow
users which have already added the card version of the snippet in their
website to receive a notification that the snippet is deprecated once we
will have implemented that system (in progress).

task-2208802

closes odoo/odoo#47228

X-original-commit: 220ec38e7538389279eb2dce9c897052d680ea1a
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

No default url on countdown's urlpicker anymore. Only a placeholder.
Also redirect to homepage if no url.

Part of: https://github.com/odoo/odoo/pull/46640



task-2210358

closes odoo/odoo#47235

X-original-commit: a0d983e94e3681a3f3e55cc445defc1ec862c606
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

The urlpicker was not closing properly when a value was selected.

Part of: https://github.com/odoo/odoo/pull/46640

task-2210358

X-original-commit: 6f722d919cd650d5c0b1b9c4a878fd519267c348

Done at odoo/odoo#46379

closes odoo/odoo#47262

X-original-commit: 0741c8c13fa5e47e59d03cdaa77f166b03be7b7b
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

- Create 2 companies A & B
- Set the website in A
- Set the user in both companies, main company being A
- Create a SO template in company B
- Click on "Design Template"

An AccessError is raised because:
- `slug` accesses the `display_name` of the template which is in company
  B
- the `allowed_company_ids` is set to company A in [1]

A solution could be to always set:
```
context['allowed_company_ids'] = request.env.user.company_ids.ids
```

But the side-effects could cause other issues.

Therefore, we handle the `slug` manually.

[1] https://github.com/odoo/odoo/blob/af411b866aa2052c01168342f8f05ae3dabad83e/addons/website/models/ir_http.py#L203



opw-2194103

closes odoo/odoo#47249

X-original-commit: 0bcfffd2
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

As we don't support anymore Internet Explorer browser, we can safely
remove conditional comments targetting older versions of it (and even
not supported in IE since version 10).

Also, when executed, this could have added a second `<body>` tag (which
is not valid HTML document).

References:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/body
https://en.wikipedia.org/wiki/Conditional_comment



closes odoo/odoo#47170

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

This commit takes advantage of modern JS syntax (like Fetch API, arrow
functions) to shorten the `odoo.reloadMenus` function's implementation.

Original implementation of this function was in commit 8a28cc22

PURPOSE

Try to move from onchange / default_get to stored editable computed fields.
Behavior should be the same (computed or set by user), with support of
create / write / onchange field update without additional code.

SPECIFICATIONS: GLOBAL RULES

Update classic fields updated in some cases by onchange and/or default methods
by fields with store=True, readonly=False. It means their value comes either
from manual user input, either from trigger based computation.

Remove onchange and default_get when possible, leading to an unique computation
method and clearing fields definition.

Also clean some fields definition inconsistencies, notably required fields
that should instead be correctly computed or default that have no real meaning.

SPECIFICATIONS: OTHER COMMITS

Perform some light code cleaning before updating fields.

Keep some explicit onchanges:
  * onchange partner on registration: required as UI flow is a bit different
    from automated code update;
  * onchange track boolean on event: allow to simplify fields dependencies;

Rename event type default_registration_max to seats_max to match
naming.

Improve event type data and demo

See sub commits for more details.

LINKS

Task ID 2089156
Community PR #42911
Upgrade PR odoo/upgrade#912

Related: odoo/upgrade#912
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Purpose is to have matching names between event type and event to ease code
understanding.

LINKS

Task ID 2089156
Community PR odoo/odoo#42911
Upgrade PR odoo/upgrade#912