This traceback arises when the user selects multi
company records and click on the 'create report' button.

To reproduce this issue:

1) Install 'hr_expense'
2) Create a new company for example 'test'
3) Enable the 'test' company on the right corner
4) Now open 'employees' and change the company of the current user(Mitchel Admin)
   to the 'test'.
5) Open 'Expenses', create a new record, and change the company to 'test'.
6) Fill the required field values and save the record.
7) Now click 'My Expenses/My Expenses to report' and select all the records (Make sure
   'My Expenses' filter is applied)
8) Click on the 'Create Record' button

Error:- "ValueError: Expected singleton: res.company(2, 1)"

On the '_create_sheet_from_expenses' method, the value of 'company_id' is getting
through 'self.company_id.id'.
See:-
https://github.com/odoo/odoo/blob/f910987cb4af84c1e7afabf67f05d4eebc31e765/addons/hr_expense/models/hr_expense.py#L324-L335



But when user selects multi company recordsets
'self.company_id' has multi recordsets.

When 'company_id' is getting value through 'self.company_id.id', because of
'self.company_id' has multiple records, which leads
to the above traceback.

By applying this commit will resolve the issue by raising an exception,
when user selected multi company records to create report.

sentry-4465422743

closes odoo/odoo#136634

X-original-commit: 32cb39c9
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
Signed-off-by: Altaf Shaik (alsh) <alsh@odoo.com>

Steps to reproduce the bug:
- Create a storable “P1”:
   - tracking= serial
   - save
- Change the type of product to service

Problem:
some fields for tracked products are not hidden, because the product
tracking is not updated.

Solution:
Convert _onchange_type into compute methods.
The tracking is updated even if the change type is applied from the
"product.product" form.

opw-3499976

closes odoo/odoo#136451

X-original-commit: 495d5b555e69a319b48485e96a6ca4b61fb32347
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

Steps:
- Open Website > My Account > Projects
- Open the project in which the customer is not set
- Now perform 'group by customer' on that project.

Issue:
- A blank line is shown below the header line.

Cause:
- No condition is applied to it when we do not have a customer set.

Fix:
- Adding condition to display 'No Customer' instead of an empty block.

closes odoo/odoo#132149

Task: 3461563
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

This commit resolves the issue of content title overflow in both fullscreen
and non-fullscreen views by cropping the title and adding '...' at the end.

Task-3384661

closes odoo/odoo#136607

X-original-commit: b13da52bffaa91b9a63d386ba317acccab40c565
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Previous fix odoo/odoo#131279 missed marking component lines added in
from the consumption warning wizard as "additional". This made it so the
added line was also added into the backorder when it should NOT have
been (since the backorder should only be based on the original MO's
values).

Followup of task: 3456604

closes odoo/odoo#136019

Signed-off-by: Steve Van Essche <svs@odoo.com>

Description of the issue/feature this PR addresses:

-In the project module when the calendar view of a task is open click on any
  schedule, and popover is open.
-In popover tags colors are not visible

Current behavior before PR:
In the popover, tag field colors are not visible

Desired behavior after PR is merged:
tags colors are visible when opening the popover

Fix:
  we add options attribute in the many2many_tags widget.

task-3269548

closes odoo/odoo#120996

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Steps to reproduce:
- Create a transfer with a delivery method.
- Add a lot of characters in the tracking reference field.

Bug:
after saving the field overflows in the view

opw-3370813

closes odoo/odoo#136596

X-original-commit: 39eac4b9
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>

Since odoo/odoo#122569, we now try to import the `migrations`
sub-package of each module to find upgrade tests.
However, this badly written regex match the OCA module `base_maintenance`,
which generate a RecursionError.

closes odoo/odoo#136449

X-original-commit: abd9e668
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

Create an expense sheet (report)
Add 2+ expenses with 10% included tax to the same employee
Approve expenses and post journal entries
Bill will be created
Go to the tax report
Group by "Tax > Account" or "Account > Tax"

Issue: Bill line will have the tax basis calculated incorrectly
This occurs because the bill will have 2 separate tax line and the query
 does not handle this case

opw-3510371

closes odoo/odoo#136339

Signed-off-by: Laurent Smet (las) <las@odoo.com>

Description of the issue/feature this PR addresses:
In Dashboard module tasks section, two scorecard is showing same label
'Time to Assign'. Another scorecard is for closing day so that its label should
be 'Time to Close'.

Current behavior before PR:
two scorecard showing same label 'Time to assign'

Desired behavior after PR is merged:
label is change for one scorecard to 'Time to Close'

Fix:
Rename title of scorecard in json file.

task- 3346509

closes odoo/odoo#125564

Related: odoo/enterprise#42774
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Have an x2many component that calls replaceWith with a list of
ids s.t. there're added **and** removed ids comparing to the
current value (e.g. the relation is currently [1, 2], and
replaceWith is called with [1, 3]). Before this commit, this didn't
work, and the resulting list of ids was empty. We never saw it
because no standard component allows to both add and remove at the
same time, but this can happen in custom components.

Issue reported by the PS-tech

closes odoo/odoo#136602

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

When the user tries to modify the view with an invalid xpath expression,
an XPathSyntaxError traceback will appear.

Steps to produce:
1. Install the Accounting module.
2. Settings > Technical > UI > Views > Open any view
3. Invalidate expr syntax and try to save, thus an error will be generated.

Error: XPathSyntaxError: Invalid expression

This commit handles XPathSyntaxError by raising ValidationError
instead of a traceback.

sentry-4377014622

closes odoo/odoo#136523

X-original-commit: a0cf5d9d
Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>

When creating a new company with the italian fiscal localization, the
tax "0% EU" is not instanciated properly

Steps to reproduce:
1. Install Accounting and module l10n_it_edi
2. Create a new company and select it
3. Go to Settings > Accounting > Fiscal Localization, set it to `Italy -
   Generic Chart of Accounts` and save
4. Go to Accounting > Configuration > Taxes and open tax "0% EU"
5. The fields for the italian exoneration are not properly set, they
   should have the same values as the same tax for company "IT Company"
   of the demo data

Solution:
When we set the company chart template, update tax "0% EU" with the
correct values

opw-3414593

closes odoo/odoo#136439

X-original-commit: f6b386c3
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>

Versions:
---------
- 16.0
- saas-16.1

Issue:
------
In the Payroll module, in the Gantt view of work entries,
when a work entry is deleted, the wizard doesn't close.

Cause:
------
When we go to the Gantt view of work entries, we trigger
the function `_generateWorkEntries` (because we trigger an update at `start`).
An RPC call will be made, and the response will be the new work entries
that have been generated in string format (`'hr.work.entry()'`).
This response will always be interpreted as `true` in an if condition.
If there are new work entries, a reload is triggered,
leaving no time to close the wizard.
These steps are repeated
and we are "stuck" in an infinite loop.

Note:
The problem doesn't occur in the calendar view,
as a hook is provided for this purpose
and we will trigger the `generateWorkEntries` function
which won't have a reload effect if work entry has been generated.

Solution:
---------
Create a method that returns an array with
the ids of the new work entries generated.
This response will be more easily interpreted by the frontend
to decide whether or not we have to reload the page.

opw-3504435

closes odoo/odoo#136101

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

This PR adds the verification for user input fields related to Six
terminals on the IoT box homepage.
Since we are moving Six to IoT it can be dangerous to call C functions
with wrong arguments (this can lead to leaks, errors and crashes)

task-3031744

closes odoo/odoo#135667

Related: odoo/enterprise#47086
Signed-off-by: Yaroslav Soroko (yaso) <yaso@odoo.com>

Before this commit:

The text moves back to the left side on remove format even if the direction rtl
is applied.

After this commit:

The text will not move to the left side on remove format if the direction rtl is
applied.

task-3482193

closes odoo/odoo#136583

X-original-commit: 447c7eb2
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Bug
===
When searching for projects from the Outlook / Gmail addins, the names
were not translated into the user's language.

Task-3486324

closes odoo/odoo#136205

X-original-commit: 3cd3fb59
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce:
- In website, paste a URL like "odoo.com" as plain text.

The expected result is a transformed link, just like it happens when
pasting is done in an html field (ex: project.task description), but
a simple text node is inserted instead.

The reason for this is that an element created by the iframe document's
`createElement` method has in its prototype chain the iframe context's
global `Node` constructor, which is a distinct constructor object from the
main window's `Node` constructor.

task-3521152

closes odoo/odoo#136545

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Commits:
[IMP] devtools: add svg elements detection
[FIX] reactivity: do not notify for NOOPs on collections
[IMP] app: export apps set as static property
[IMP] runtime: do not check template equality outside dev mode
[FIX] runtime: properly support t-foreach on strings

More details: https://github.com/odoo/owl/releases/tag/v2.2.6



closes odoo/odoo#136455

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

When users try to apply for new job positions from the calendar view,
a traceback will occur.

Steps to reproduce:
- Install the "hr_recruitment" module.
- Go to the "Recruitment" icon; Kanban view will open;
choose any job position; and click on the "NEW APPLICATIONS" button.
- Then, select the "calendar" view and try to create a new record.
After that, a traceback error will occur.

Error:  KeyError: 'default_partner_ids'

When users try to apply for new job positions from the calendar view and
the 'default_partner_ids' key does not exist in the context dictionary,
a traceback occurs.
Code reference:
https://github.com/odoo/odoo/blob/16.0/addons/hr_recruitment/models/calendar.py#L18



sentry-4462451583

closes odoo/odoo#135253

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

steps to reproduce:
- enable analytic
- open journal items in list view
- select one item, set an analytic account
- select the same item, click on the analytic account, click on the save button (floppy disk)
- pop up opens
- close it

Issue:
Traceback

Cause:
In multiEdit mode, the main element cannot be focused in

opw-3463911

closes odoo/odoo#135141

Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>

Steps to reproduce:
1. Install hr_attendance
2. Go to attendances
3. Select any line
4. Change the check-out date to next day
5. Change the check-out time to 00:00:00
6. Export that line, file format xlsx
7. Favorites > import records
8. Upload the exported file > Test
9. Column check_out contains incorrect values.
Error in line 2: unconverted data remains: 2023-06-11

Cause of the issue:
options.get('date_format') is empty

opw-3374883

closes odoo/odoo#136393

X-original-commit: 973af585
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>

[Problem]
Before this commit, depreceted accounts were visible in the suggestions.
To reproduce:
- run odoo 16.0 (onward) with modules: account,account_accountant
- deprecate all, but 3 accounts (UPDATE account_account SET deprecated=true WHERE id>3;)
- go to: invoicing app -> Vendors -> Bills -> New
- pick a vendor -> add a line -> click on dropdown in the Account column
- see the deprecated accounts are showed in suggestion (we don't want deprecated accounts in suggestions)

[Solution]
Modified SQL query, such that only not deprecated accounts will appear.

[Testing]
Created test in test_account_account:
It runs function with modified sql query twice:
- with certain account not deprecated -> extected that this account appears in the results
- with the same account deprecated    -> extected that this account won't appears in the results

opw-3485768

closes odoo/odoo#135884

Signed-off-by: Andrea Grazioso (agr) <agr@odoo.com>

Currently, errors occur when generating the e-invoicing for
ZATCA (Saudi Arabia). This is because currently, users create invoices without
a tax, but in Saudi Arabia, the invoice line must require at least one tax.

The validation error is present at Line [1], but due to recent changes in
Code [1], the validation is not working. As a result, the user can create an
invoice line without tax.  see https://github.com/odoo/odoo/pull/130034.

This commit fixes the above issue by filtering invlocice line ids
that have display_type 'product'.

Line [1]-https://github.com/odoo/odoo/blob/d2f0a0f2c9a18a7a6cef8ca3be52324ad2a1dad6/addons/l10n_sa_edi/models/account_edi_format.py#L406


Code [1] odoo@d8d47f9#diff-78f3e1847de8ca0acf28d72a412947a549acdb08142d1dadf7646363d7972cb0R268-R280

sentry-4467808485, 4467794808

closes odoo/odoo#135737

Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>

To reproduce
============
- create a purchase order and confirm it
- create a Bill, set its Bill date and Accounting date to different dates
to today
- save it, then choose the created PO in autocomplete field
the Accounting day will be changed to today

Problem
=======
when calling the autocomplete, some values will be updated on the record,
where `move_type` is one of them, and updating this field will trigger the
compute of accounting date.

Solution
========
if the value of `move_type` on the record is the same as the one of the update,
it should not be taken into account which will avoid uneeded recompute.

opw-3381530

closes odoo/odoo#132841

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Steps to reproduce:
- Enable product packaging
- Create a Package for product P and set the barcode
- Delete product P
- Create a new Package with the same barcode

Bug:
barcode already exists

Fix:
delete Package when associated product is deleted

opw-3507931

closes odoo/odoo#136305

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

*: website_event

Without this, the seo saving would not forward the current website in
the context. It's especially bad in this case as it's writing on views
which are not triggering the COW due to the lack of a website_id in the
context.

Step to reproduce:
- Go to /shop (if you didn't do anything, this will be bound to the
  `website_sale.products` view which has no website_id set and is called
  a generic view)
- Open "Optimize SEO" dialog and type something in the title
- Save
- It saved the change on the mentioned view, without duplicating it
  (COW) before writing on it. The title you added is now applied to
  every websites and not only the one you edited, which is against the
  website holy grail rule: only the website you edit should be changed.

Technically, this is because we refactored that part of the code in Odoo
16: the website is now editable in the backend.

Note that this fix also revealed that a test for events (which has been
introduced with [1]) was relying on the bug: it tested the meta title of
a view that should (and will after this fix) have been COW'ed. This test
will now indirectly protects this bug from re-happening, although we
might want to write a dedicated test in the future as the behavior for
events might need some refactoring.

[1]: https://github.com/odoo/odoo/commit/2072a7739eb9a9ee87c8b3c7b0d43a82a7e2375f



opw-3499285

closes odoo/odoo#136084

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

payment_stripe was missing in .tx/config, resulting in the module not
being available for translation on Transifex.

closes odoo/odoo#136380

Signed-off-by: Louis Wicket (wil) <wil@odoo.com>

This is just a typo XD

closes odoo/odoo#135608

Signed-off-by: William André (wan) <wan@odoo.com>

Before this commit:

-With selection on checklist, on unchecking it toolbar is not updating.

After this commit:

-Now toolbar is updated when list unchecks.

task-3504398

closes odoo/odoo#135422

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Before this commit:

Indenting list using tab inside a table used to switch to the next cell.

After this commit:

Indenting list using tab inside a table now indents a list instead of switching
to the next cell.

task-3470092

closes odoo/odoo#132508

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Before this commit:

when selected cell is clicked, its selection collapses yet toolbar is visible.

After this commit:

Now toolbar is removed when selection collapses.

task-3458048

closes odoo/odoo#131339

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Report footer is sometimes misplaced in settings preview.
We change the css to always stick to the bottom of the preview,
no matter the content height.

Task-3145445

closes odoo/odoo#128552

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Report body size was too narrow to render bootstrap .col as column,
the media query consider the report as a mobile view.
We unlock this limitation to let customer add column in the footer.

Task-3145445

Part-of: odoo/odoo#128552

Before this commit:

When we load some themes without installing website the social media icons look
weired and margin between those icons is also weired.

After this commit:

Now when we load mass_mailing themes without installing website the social media
icons same as before and margin between those icon is also same.

Task-3347902

closes odoo/odoo#125527

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Upgrade (aka migration) scripts are a core part of Odoo, allowing
database manipulations for modules during version changes.

Any module, including custom ones can run upgrade scripts, even if the
`--upgrade-path` flag (and with it, the `odoo.upgrade` sub-module) is
not present. Currently only the "standard" modules benefit of easy
upgrade script testing. Any custom modules that want to run tests of
their upgrades have to import the tests in the usual `tests` folder,
which is not ideal.

Therefore, to allow TDD and programmatic testing of upgrade scripts in
custom modules, the test discovery is here modified to also parse the
module's `migrations` and `upgrades` sub-modules for tests.

closes odoo/odoo#136201

X-original-commit: e8683726
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

Steps:

In a website forum post without any previous scrolling, select some
text. A traceback appears due the fact that there's no .o_action_manager
element in website forum.

This commit uses the document body as a fallback for the scroll
container when the .o_action_manager element is not present.

task-3506312

closes odoo/odoo#135785

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Update of right state key for rerender the image on record change from OWL

Included tests from commit 94db69453616131f6913b65a58b76df712ede35d by @FrancoisGe

Fixes #134454

closes odoo/odoo#134477

Signed-off-by: Francois Georis (fge) <fge@odoo.com>

1. Backport of [1].
2. Steps to reproduce:
- Install website_crm
- Connect as Admin and remove the sales rights for Demo
- Check the website on a private window (to create an anonymous visit)
- Connect as Demo on the normal window
- Go to Website > Reporting > Visitors
=> It triggers an access error due to lead_ids being restricted to
sales_team.group_sale_salesman.
(Note: the error sometimes isn't triggered at that point. In that case,
click on the visitor: the same error will trigger.)

Considering the computed field doesn't do anything critical as it just
retrieves the email and phone number, the restriction is overridden on
the field.

[1]: https://github.com/odoo/odoo/commit/7de453477d7c23e607a15e0d60613080857e3371



opw-3475301

closes odoo/odoo#136353

X-original-commit: 70faf9bb
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Robin Lejeune (role) <role@odoo.com>

After commit [1], the check that the target url is different from
the current page's url has been removed thus leading to error that anchor
link always scroll down to element that have data-anchor enabled.

Steps to reproduce (the easiest way):
- Install Website Blog
- Turn on customize comment on post
- Go incognito then access any blog post, scroll down and click the
`Sign in to leave a comment` button
- Holy, the page scrolls down to the discussion section but doesn't go
to the login page

[1]: https://github.com/odoo/odoo/commit/fb087dbec96f5e533d1fdd9c2b0c2e00296c83de



closes odoo/odoo#136043

X-original-commit: f5fca171
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>