Skip to content
Snippets Groups Projects
  1. May 17, 2023
  2. May 14, 2023
  3. Apr 30, 2023
  4. Apr 23, 2023
  5. Apr 16, 2023
  6. Apr 12, 2023
  7. Apr 09, 2023
  8. Mar 30, 2023
    • Victor Piryns (pivi)'s avatar
      [FIX] hr_timesheet: timesheet uom fallback when AAL's company is False · b39642bf
      Victor Piryns (pivi) authored
      
      Current behaviour:
      When creating a timesheet, if in the vals passed the AAL doesn't
      have a company (possible since it's not required), then the `uom`
      of the timesheet is False, which doesn't make sense.
      
      Expected behaviour:
      The timesheet `uom` should fallback on the uom of the company
      of the project.
      
      Steps to reproduce:
      - Install hr_timesheet, Accounting
      - Activate the AAL in the settings
      - Create a project with an AAL
      - Remove the company on the AAL of the project
      - In that project create a task and log some timesheet.
      - `uom` field should be empty
      
      Reason for the problem:
      When setting the `product_uom_id` in the vals when creating/writing
      a timesheet, we just take the `project_time_mode_id` on the company
      linked to the AAL. The problem is that the company on an AAL is not
      a required field, so it can be `False`, leading the setting the val
      for `product_uom_id` to `False`.
      
      Fix:
      In case the AAL has no company, we get the `uom` from the company
      linked to the project.
      
      Affected versions:
      - 14.0
      - 15.0
      - saas-15.2
      - 16.0
      - saas-16.1
      - saas-16.2
      - master
      
      opw-3245671
      
      closes odoo/odoo#117012
      
      Signed-off-by: default avatarXavier Bol (xbo) <xbo@odoo.com>
      b39642bf
  9. Mar 26, 2023
  10. Mar 19, 2023
  11. Mar 10, 2023
  12. Mar 05, 2023
  13. Feb 26, 2023
  14. Feb 13, 2023
  15. Feb 05, 2023
  16. Jan 29, 2023
  17. Jan 22, 2023
  18. Jan 15, 2023
  19. Jan 08, 2023
  20. Dec 25, 2022
  21. Dec 18, 2022
  22. Dec 11, 2022
  23. Nov 20, 2022
  24. Nov 06, 2022
  25. Oct 30, 2022
  26. Oct 23, 2022
  27. Oct 16, 2022
  28. Oct 11, 2022
  29. Sep 25, 2022
  30. Sep 18, 2022
  31. Sep 04, 2022
  32. Aug 29, 2022
    • Jinjiu Liu's avatar
      [FIX] hr_timesheet: calculate effective_hours on all users' hours · 2033f113
      Jinjiu Liu authored
      
      Reproduction:
      1. Install Timesheet, and Project, check the timesheet box in the
      setting of Project
      2. Go to Setting->manage users, set access right for Marc Demo, Project
      as “User”, Timesheets as “See own timesheets”, and Helpdesk	as “User”
      3. Go to Project, create a task and assign it to Marc Demo, go to the
      timesheet tab, set Initially Planned Hours as 20 hours, click save
      4. Open an incognito page and log in as Marc Demo, go to this new task->
      timesheet, edit, log 5 hours, save. Hour spent is now 5
      5. Switch back to Mitchell Admin, refresh the task page, edit, log 3
      hours, save. Hour spent is now 8.
      6. Switch to the incognito page of Marc Demo, edit, log 2 hours and save
      Hour spent is now 7, which doesn’t consider the hours logged by Mitchell
      The right result should be 10 hours.
      7. Switch back as Mitchell Demo, the spent hours are also wrong
      
      Reason: The cause is that effective_hours is a stored computed field.
      When Marc Demo logs hours after Mithcell Admin, the hours from Mitchell
      do not show for Marc Demo. Marc Demo cannot get the hours from other
      users because he can only see his own timesheet. Thus the computation is
      wrong and because it’s a stored computed field, it won’t change even
      after switching back to Mitchell Admin
      
      Fix: Use read_group to get the grouped by value of the amount spent on
      the task. This makes sure that the value of Hours spent is correctly
      computed after saving. It also allows the onchange to take the change
      made by the user into account before saving.
      
      opw-2909444
      
      closes odoo/odoo#97241
      
      Signed-off-by: default avatarLaurent Stukkens (ltu) <ltu@odoo.com>
      2033f113
    • mafo-odoo's avatar
      [FIX] hr_timesheet: avoid setting an archived employee to a timesheet in the form view · dd9dd0a8
      mafo-odoo authored
      
      Steps to reproduce:
      - Install timesheet
      - Archive an employee
      - Create a timesheet
      
      Current behavior:
      You can select the archived employee
      
      Expected behavior:
      You can not select the archived employee
      
      Explanation:
      In commit 17b2b07e76121ebb0be16637bf4082e457c2ac63 the employee_id
      field of the timesheet was set to have context active_test to false.
      To fix this issue we reset the context for this field in every
      timesheet form and we add user errors if the employee is not active
      while the timesheet is created or edited.
      
      backport of odoo/odoo#94308
      
      opw-2887727
      opw-2870739
      
      closes odoo/odoo#97760
      
      Related: odoo/enterprise#30271
      Signed-off-by: default avatarNasreddin Boulif (bon) <bon@odoo.com>
      dd9dd0a8
    • Audric Onockx (auon)'s avatar
      [FIX] hr_timesheet : register ts in multi-company environment · d01c2010
      Audric Onockx (auon) authored
      Steps :
      Install project and employee.
      Create 3 company and an employee for you user in 2 of them.
      Switch to the one without employee.
      Create a new project and task.
      Register a timesheet.
      
      Issue :
      The timesheet has no employee.
      
      Fix :
      Display start button and set an employee on the ts
      only if user has an employee in the company
      or has only one employee for all companies.
      
      backport of odoo/odoo#85780
      
      opw-2745733
      
      Part-of: odoo/odoo#97760
      d01c2010
    • Audric Onockx (auon)'s avatar
      [FIX] hr_timesheet : display archived employee on timesheet · bd6a6415
      Audric Onockx (auon) authored
      Steps :
      Archive your employee, go to your timesheets and add time on a task T line
      Go to task T and note that a line have been added without any employe
      
      Cause :
      By default, views do not show archived values.
      
      Fix :
      Show archived employees with context key 'test_active=False'.
      
      backport of odoo/odoo#85481
      
      opw-2740228
      
      Part-of: odoo/odoo#97760
      bd6a6415
    • Laurent Stukkens (LTU)'s avatar
      [FIX] hr_timesheet: select correct employee in create · 30bf69a2
      Laurent Stukkens (LTU) authored
      Prior to this commit:
      
          - The employee was the first one returned through a search that
            was not taking the company into account.
      
      After this commit:
      
          - The employee will be selected according to the company.
      
      This issue arose with b5b105ea
      
      backport of odoo/odoo#81693
      
      Part-of: odoo/odoo#97760
      30bf69a2
  33. Aug 28, 2022
  34. Aug 14, 2022
  35. Aug 07, 2022
  36. Jul 31, 2022
Loading