Current behavior:
When an order contains a payment line with 0€, and a customer account
payment line. Then you close the PoS and invoice the order from an other
PoS session, you get an error.

Steps to reproduce:
- Open PoS, make a new order with a payment line of 0€ and a customer
  account payment line.
- Close the session and open a new one.
- Go in the paid order, and try to invoice it.
- You get an error.

Fix:
To fix the issue we just remove the useless 0€ payment line.

opw-3477486

closes odoo/odoo#134702

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

When rendering the sale order cancellation message,
the rendering should apply the current user record rules,
for instance the count of the partner sale orders should
match the count of what the salesman can see in his ui.
Otherwise he doesn't understand why he has a different count
in the UI and in the cancellation message.

In case you want the behavior of seeing all records
and not just the current salesman records only,
then you apply within the template itself the
`sudo()`.

Applying the `sudo` where you actually need it in the template,
and not computing the full subject/body as sudo,
offers more granularity.

closes odoo/odoo#135127

Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

Before this commit res.users.settings have no display_name.

closes odoo/odoo#135106

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

According to standard flow when a record is created by user we do not make
a model data entry and if he does any changes in standard record we change the
noupdate to true on conditional bases to keep the data same while upgrading
but in the case of user created record where there is no model data entry the
engine should consider it as noupdate true but without the model data entry
select query gets null resulting into engine considering it false and the update
case are designed to consider true or else  so for null case it falls under else
part hence creating issue in product_template name and cowed website menu
So,we have updated the case accordingly.

closes odoo/odoo#129518

Signed-off-by: Raphael Collet <rco@odoo.com>

- If default language of website is not en_US then it's
  translation will be lose after upgrade as till now we are
  considering en_US as a default language for all the records.

- In this commit, we have added translation for website which
  is having different default language.

Opw: 3186741, 3418725
Part-of: odoo/odoo#129518

Problem
---------
In 15, taxes are hidden from hr.expense when the expense category has a
cost. They can however be configured and added. The current behaviour is
counter intuitive.

Objective
---------
Don't hide taxes when product has cost in v15.

Solution
---------
Remove the `hidden` attribute in the expense xml form as well as the
`groups` attribute.

task-3491868

closes odoo/odoo#135076

X-original-commit: 7ee0770fdab75cd0ffd11d73ed3ae8d91ea60477
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Antoine Boonen (aboo) <aboo@odoo.com>

Steps to reproduce:

  On Odoo:
  - Install `Documents` module
  - Go to `Settings` and set a Custom Email Server(ex. `mydomain.com`)
  - Ensure an alias exist for the model `document.document` with
    `inbox-financial` as alias name

  In mail client:
  - Send a mail with an image in the body to the following email:
    inbox-financial@mydomain.com

Issue:

  Mail not received (traceback in logs)

Cause:

  Since we use the email alias `inbox-financial`, we process the mail
  through the `document.document` model where we have an override of the
  `_message_post_after_hook` method that is called after that the
  `msg_values` values are post-processed and where we do another
  message_post() for the new document create for the attachment (in
  this case, an image).

  https://github.com/odoo/enterprise/blob/2c3596e4e18c201809558d3ea878b141e366a027/documents/models/document.py#L305

  During the parsing, the mail values are updated through the
  `_process_attachments_for_post` method:

  https://github.com/odoo/odoo/blob/6c0d2d7a9d44459f3e09a38bd80ef9b018e8c946/addons/mail/models/mail_thread.py#L1881-L1904

  On posting the first time, the original type of the `body` value is a
  `str`, but the post-processed value (because there is some CIDS in the
  body) is of type `bytes` (because using `encoding='UTF-8'` with
  `lxml.html.tostring`).

  https://github.com/odoo/odoo/blob/510a997017a9cbe14522a0013a578f6d1d9b257a/addons/mail/models/mail_thread.py#L2209

  Then in the `_message_post_after_hook` we call post again on the
  newly created document record by using post-processed value of body
  who is of type `bytes`.

  On posting the second time (for the document record), the `body`
  value is of type `bytes` and when checking if the body is empty with
  `is_html_empty` that received a string as param, an error is
  raised.

Solution:

  Use `encoding='unicode'` to return a string instead of bytes.

  https://lxml.de/api/lxml.etree-module.html#tostring

ENT PR : https://github.com/odoo/enterprise/pull/42653



opw-3273583

closes odoo/odoo#135047

X-original-commit: f910987c
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

On a DB with 2M+ products, the computation of the
`_default_website_sequence` [1] takes several seconds. In case of a
product creation in batch, it can negatively affect the whole
server performance.

Adding an index solves the problem.

[1] https://github.com/odoo/odoo/blob/1b9c7fecc5b4031c5d7b9bbe4f26e1e510063d12/addons/website_sale/models/product_template.py#L368



closes odoo/odoo#135030

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, when `a` tag is in a td, the color of text ellipsis
(3 dots) is different than the text because the text-ellipsis is set on
the parent element, that is `td` element and the color is set on the `a`.

This commit sets the right color on td element when that element has `a`
element.

Limitation (only for td inside element with `o_portal_my_doc_table` class):
if the `td` element contains `a` tag and another element
then the color has to be set to that other html element otherwise,
the color will be the one of the a tag.

task-3251721

closes odoo/odoo#134491

X-original-commit: b28459dd
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Pratik Awasthi (praw) <praw@odoo.com>

Before the commit, the _get_seen_list() function in the mass_mailing module was
not able to correctly identify all the duplicate email addresses in a given mass
mailing. This was because the function chose and used only one way to find an
email address for each record in the mailing list, even though there are many
ways to find an email address for a record.

For example, a crm.lead record might have an email address in its partner_id
field, but it might also have an email address in its email_normalized field.
This can vary from record to record.

To fix this issue, the _get_seen_list() function was updated to only look at the
email address to which emails have already been sent, rather than trying to
fetch it from the record itself. This ensures that all duplicate emails are
correctly identified and that no duplicate emails are sent in the mass mailing.

Task-3234378

closes odoo/odoo#135022

X-original-commit: 66f9aa25
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

It is not possible to add a block at the bottom of the invoice report
with Studio

Steps to reproduce:
1. Install Invoicing and Studio
2. Open Invoicing, toggle Studio and open Reports
3. Open the Invoice report
4. Try to add a text block after the payment terms, Studio doesn't let
   you

Solution:
Put all the content of the invoice in the page div

opw-3443086

closes odoo/odoo#134651

Signed-off-by: William André (wan) <wan@odoo.com>

For model_terms translated fields if a translation for a lang(fr_FR) has never
been defined

before this commit
when update translations for both en_US and fr_FR, the new translation for fr_FR
cannot be saved.

after this commit
new translations can be correctly saved when en_US and fr_FR are updated at the
same time.

closes odoo/odoo#132540

Signed-off-by: Raphael Collet <rco@odoo.com>

the comment 'openerp-web' has been deprecated since odoo/odoo#105589, and there
is only JAVASCRIPT_TRANSLATION_COMMENT in the most po files of the source code
repository

closes odoo/odoo#124402

Signed-off-by: Raphael Collet <rco@odoo.com>

fix typo to log correct error message when the imported file is badly formatted

Part-of: odoo/odoo#124402

before this commit:
translations updated by `update_field_translation` api cannot be detected by
t-cache and some cached data whose model overrides `write` with an extra
'clear_caches()'

Step to reproduce:
- Create a mega menu, select any template, `Odoo Menu` for the example
- Install another language on the website
- Go to the translated version of your website and enter translate mode
- Change "Camera" in the mega menu to something else
- Save

The change won't be replicated, looking like it did nothing.
From there, removing or adding `edit_translations=1` in the URL will
use different cache version of the page's views and you will see the
outdated value on one and the correct on the other one.

after this commit:
`update_field_translation` will call `write`
it does the following 4 important things
1. mark field as modified
2. execute logics in the override `write` method
3. update write_date if needed to support t-cache

opw-3305117

Part-of: odoo/odoo#124402

Typo error detected on `/mrp/wizard/mrp_immediate_production_views.xml`.
It doesn't cause any issue on module installation or updates, but
it's probably gonna cause issue on view inheritance.

If you can confirm this is unintended typo I will edit commit msg.
I also detected this on version 15.0 and 16.0.

closes odoo/odoo#134788

X-original-commit: 80e8222f
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Steps to reproduce:

  - Install `account` module
  - Activate another language (e.g. French)
  - Create a partner with the new activated language
  - Create an invoice for this partner and sent it by mail

Issue:

  Some words in the external layout of the email are not translated;
  button and title

Cause:

  The language of the partner is not taken into account (except for the
  model name in the button) when creating the external layout of the
  mail.

Solution:

  Call send_mail with the partner language in the context.

opw-3301607

closes odoo/odoo#133744

Signed-off-by: William André (wan) <wan@odoo.com>

If a bank account is added through the onboarding step and the user creates one instead of linking it,
the dashboard is not reloaded to show the completion of the step and the new account.
To make sure that the view is reloaded to show new data,
the easiest fix would be to return a reload action in `validate`.

task-3431961

closes odoo/odoo#133057

Related: odoo/enterprise#46250
Signed-off-by: William André (wan) <wan@odoo.com>

Have a form view with a date or datetime field with onchange.
Change its value to trigger the onchange. If the onchange fails,
we want to revert the value to the original one. Before this commit
it didn't work, because the datepicker blocked the update when the
props were the same, which was the case in this situation.

Task~3498849

closes odoo/odoo#134792

Signed-off-by: Francois Georis (fge) <fge@odoo.com>

In a form view, have a field with an onchange that returns an
error. Before this commit, the error was displayed but the
faulty value that triggered the onchange (and thus the error)
was still displayed in the UI (even though in the model, the
previous value was still set).

This commit enforces an update of the UI when an error occurs,
such that the previous, valid, value is displayed again.

For instance:
Go to a customer invoice, open the Actions menu, click on
"generate a payment link", in the dialog, set an high amount.

Task~3498849

Part-of: odoo/odoo#134792

Steps to Reproduce the Bug:

- Create a storable product "P1" with 2 Bills of Materials:
   - BoM 1:
     - Component: C1
   - BoM 2:
     - Component: C2

- Create a MO:
   - Select BoM 1.
   - Save.
   - Select BoM 2 without saving. Result: The component C1 is deleted
   and replaced by the component of BoM 2.
   - Select BoM 1.

Problem:
The component of BoM 2 is not cleared. Because we check if the new BoM
is different from the original one, but since we didn't save the change
when selecting BoM 2, the `move_raw_ids` are not cleared.

Solution:
Clear the `move_raw_ids` if any move with `bom_line` is not linked to
the current BoM.

OPW-3473387

closes odoo/odoo#134718

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

BUG:
show +NAN on kanban view

FIX:
show +6 on kanban view

closes odoo/odoo#134623

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Task-2674716

Closes #78392

Signed-off-by: Christophe Matthieu (chm) <chm@odoo.com>

closes odoo/odoo#27664

Signed-off-by: Pierre Masereel (pim) <pim@odoo.com>

Description of the issue/feature this PR addresses:

when logged in user name is too long then it take whole header to display it
name.
In project module, if milestone name is long then name is overflowing.
Current behavior before PR:

whole header is occupied when username is long.
milestone name is overflowing when name is too long.
Desired behavior after PR is merged:

when username is long it would show with '...' format.
when milestone name is long it would show with '...' format.
Fix:

some property is added in oe_topbar_name class to display the username in short
and '...' format.
add some bootstrap class so that long name should be formatted in '...' .
task-3217427

closes odoo/odoo#133670

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Ravi Bhingradiya (ravb) <ravb@odoo.com>

When a user tries to import the CSV file with a different separator at that
time, the values in mapper and rows_to_import are not correctly mapped. So
the traceback will be generated.

Steps to reproduce:
1. Click on import in the bank statement.
2. Select any CSV file for the bank statement line or can download and import
this file https://drive.google.com/file/d/1lnScw4RN6T01pOkyNON8vvb3FQOPiy1O/view?usp=drive_link


3. Select any separator other than a comma.
4. Click on the test or Import button.
5. Error will occur.

Error: IndexError: list index out of range.

To solve this issue, a row's length is checked with the
number of fields.

sentry-4021250095

closes odoo/odoo#134502

X-original-commit: 62253417
Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>
Signed-off-by: Saurabh Choraria (sauc) <sauc@odoo.com>

This reverts commit e458a4c1 from
pull-request #129567, see #134791

closes odoo/odoo#134952

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

When getting the available quantity of a product, it is possible to
specify the warehouse and/or the location in the context. However,
it does not correctly work. For instance, if we provide the stock
location ID (8) and the warehouse ID (1): we first use the view
location of the warehouse, and we then get the intersection between
this view location and the provided locations: nothing. In such case,
we should keep the stock location. Few other examples are given in
the test.

OPW-3450169

closes odoo/odoo#134823

X-original-commit: 8b53464d
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart (awt) <awt@odoo.com>
Co-authored-by: Simon Schmid <simon.schmid@braintec.com>

Commit [1] introduced a stronger regex to detect urls. Unfortunately,
it did so using a negative lookbehind, which is is only supported on
very recent version of Safari iOS.

This commit is an attempt at reproducing the same behavior, albeit
with a more complicated regex, unfortunately.

[1]: https://github.com/odoo/odoo/commit/a42a19e484d63cebeaed10b75ac20e507ff85d56



closes odoo/odoo#134821

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Bug
===
When we enrich a partner we don't have access to, it will try to read
it, but because of the ACL if will crash. To fix that issue, we don't
return the partner if we can't access it and we show an error message
in the UI instead of letting it crash.

Task-3344536

closes odoo/odoo#134875

X-original-commit: a0290a9d
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

During this pr (https://github.com/odoo/odoo/pull/121413

), we have made a few
css changes on the din5008 format, some of them needed to be revert because they
 broke the layout.

closes odoo/odoo#134833

Task: 3495712
X-original-commit: c120d138
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>

There is code to block the UOM changing if there are done moves.

Because it searches in non-sudo mode, it does NOT currently
stop you changing the UOM if the product has moves in a different
company.

closes odoo/odoo#134807

X-original-commit: 42674464
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>

Implemented support for the BACS payment scheme as per the latest
technical specifications, enabling the processing of BACS Direct Credits
and Direct Debits. Included the mandatory requirement of a Service User
Number (SUN) for businesses conducting transactions via BACS.

closes odoo/odoo#128069

Task-id: 3326945
Related: odoo/enterprise#43923
Signed-off-by: Quentin De Paoli <qdp@odoo.com>

- Added ondelete='cascade' to account_payment_method_line's
field definition.
- Fixes the foreign key constraint failure during module uninstallation
by automatically deleting dependent records.

task-3326945

Part-of: odoo/odoo#128069

Steps to reproduce:
- Enable multistep routes (3 steps delivery)
- Create a new storable product (0 on hand quantity)
- Confirm an SO with that product

Bug:
forecast button is correctly red on the SO line but it's green on the
stock pickings

Fix:
button should be green if it's possible to reserve quantity red otherwise

opw-3440627

closes odoo/odoo#134841

X-original-commit: 0312c1bdc371e5a841b8d9e620c9fd7a49782b15
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>

Before this commit, the push to talk key combination was wrongly
detected. Indeed, it was dependent on which key was pressed first.

Steps to reproduce:
- Register "ctrl + alt" as the push to talk key
- Press control then alt, push to talk does not work
- Press alt then control, push to talk works
- If you unpress the alt key, the push to talk will stop as expected
- If you unpress the control key, the push to talk will keep going

This commit fixes the issue.

closes odoo/odoo#134728

X-original-commit: 224c23d9c28421e93ee317eebe9e7da25c6c5872
Signed-off-by: Thanh Son Dodeur (tso) <tso@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Currently, when a journal is created during import, we just use the journal name as the code.
However, that gets truncated to 5 characters on create, which can conflict with existing journals.
The import should be as flexible as possible, as it's better to let users import and fix things
after the import rather than debug the import file.
- If there is a journal with a shortcode that matches the truncated name of the new journal,
  just use the existing journal (enterprise PR)
- If the shortcode conflict arises within the imported file
  (so the journals don't exist before the import), keep track of the codes in `vals_list`.
  The `get_next_bank_cash_default_code` is modified to avoid duplicating code.

See also odoo/enterprise#46101

closes odoo/odoo#132715

Signed-off-by: Laurent Smet (las) <las@odoo.com>

after using the token to link a database to an iot box, the odoo service
 is not restarted and therefore no box is visible in the database.
Now we apply the odoo_restart() function regardless of the platform used

closes odoo/odoo#134829

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Steps to reproduce:

- Install Loyalty module
- Go to Website and buy a gift card
- Checkout and pay the order

Issue:

  Only 'Order Confirmation' email is sent directly to the customer,
  gift card email is queued and sent later.

Cause:

  `send_email` method is called with `force_send=False` by default,
  which queues the email to be sent later.

Solution:

  Add optional parameter `send_force` (default to `False`) to
  `_send_creation_communication` method and call it with
  `send_force=True` when confirming a sale order.

opw-3324386

closes odoo/odoo#133427

Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>