Skip to content
Snippets Groups Projects
  1. Jun 18, 2020
    • Martin Trigaux's avatar
      [IMP] *: replace to new _() syntax · ba244cef
      Martin Trigaux authored
      Using a few regex like
      \((_\(.*%s.*)(\) % )([\w\[\]][\w .\[\]\(\)'"]*)\)
      ($1, $3))
      
      Old syntax is still compatible but starts the migration to the new
      syntax that catches error.
      ba244cef
    • Martin Trigaux's avatar
      [IMP] tools: add placeholder support to _ · 3c3b88f6
      Martin Trigaux authored
      Mimic the syntax of logging to use placeholders in translatable
      message.
      The main advantage is to be able to fallback on the source term if the
      translation can not be formatted properly.
      It is very common to have errors in translations with missing
      placeholders or badly translated (ie. the source
           "%(subject)s" -> "%(sujet)s").
      
      Instead of blocking the execution of the code, fallback on source
      string.
      
      Task-id: 1853119
      3c3b88f6
  2. Jun 17, 2020
    • Dharmraj Jhala's avatar
      [FIX] tools: fix tool method to check empty html content · 5af661da
      Dharmraj Jhala authored
      Since a recent commit[1], we have a utility method in tools named
      'is_html_empty'  that checks whether the given html content is
      void(containing only formatting tags) or not. However, the re from
      this method does not consider the case of self closing tags, fox ex
      `<br/>`. In such cases, the method returns Falsy value even if the
      content is void.
      
      This commit fixes the issue by considering self-closing void tags
      in the regular expression.
      
      commit[1] - https://github.com/odoo/odoo/commit/974f512f5f5d3b9f80a8c3fcde290e4f55cf1230
      
      
      
      Task - 2267689
      
      closes odoo/odoo#53167
      
      X-original-commit: 0fd6c9388dc959a9b6b7828850683175edb05b9d
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      5af661da
    • Nidhi Patel's avatar
      [FIX] hr_expense: Fix traceback on access of expense view. · 0871c107
      Nidhi Patel authored
      
      Currently, when a user created with default access rights,
      but doesn't have employee linked with user then it will generate a
      traceback because if user is not linked with employee then
      it will return null so due to that while rednering the template
      error was generated.
      
      So in this commit, fix the treaceback by returning default values
      if the current user had no employee
      
      closes odoo/odoo#53161
      
      Taskid: 2262636
      Closes: #51687
      X-original-commit: 96de35eda1a8e6e5086eb8221e939f3f737a9a6c
      Signed-off-by: default avatarYannick Tivisse (yti) <yti@odoo.com>
      0871c107
    • Andrea Grazioso (agr-odoo)'s avatar
      [FIX] sale: delete draft invoices with downpayments · dc1bb36d
      Andrea Grazioso (agr-odoo) authored
      
      Create a SO, Validate it.
      Create Invoice: down payment (fixed amount) and validate invoice
      Now back to the SO. Create Invoice: Invoiceable lines (deduct down payments).
      A draft invoice is created. Try to delete it.
      
      User gets an error, this occur because the second invoice creation bind
      another invoice_line to the downpayment sale order line (first line was
      added when making the downpayment). When the user delete the invoice
      the sale order line should be deleted as well, but is still linked to an
      invoice so the error raise.
      Unlinking only unbinded sol fix the issue
      
      opw-2258218
      
      closes odoo/odoo#53144
      
      X-original-commit: 7c7275b8
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      dc1bb36d
    • Robin Heinz's avatar
      [IMP] point_of_sale: Back2Basics. · b3665011
      Robin Heinz authored
      Allow the user to archive the payment methods and the floor plans.
      Change some typo.
      Allow manager to have access to the cash closing control wizard.
      Allow the user to set cash in or out in the wizard.
      
      closes odoo/odoo#45719
      
      Task-id: 2125227
      Related: odoo/enterprise#8562
      Signed-off-by: default avatarpimodoo <pimodoo@users.noreply.github.com>
      b3665011
    • Odoo's Mergebot's avatar
      [IMP] project: populate · eb5ebc80
      Odoo's Mergebot authored
      
      New populate feature (#48479) now allows to define model generation methods to populate the database with model records for performance testing.
      
      This PR aims to implement database population for the `project` App.
      Furthermore, to reduce population time, a first performance improvement is applied to create `project.task` records in batch.
      
      --
      I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
      
      closes odoo/odoo#50405
      
      Signed-off-by: default avatarYannick Tivisse (yti) <yti@odoo.com>
      Unverified
      eb5ebc80
    • jvm-odoo's avatar
      [FIX] web: load_translation fallback to url language · 93479ad0
      jvm-odoo authored
      
      This commit is fine tuning of 9f142c8ff5a383.
      
      Apparently, context_get callback is never called. I
      guess this is due to the fact that we are higher.
      
      context_get is defined in public/public_root.js and
      we are in core/session.js
      
      The only way to fix is to retrieve the HTML tag language.
      
      OPW-2244843
      
      closes odoo/odoo#53155
      
      X-original-commit: 2bbb8fbf
      Signed-off-by: default avatarJason Van Malder (jvm) <jvm@odoo.com>
      93479ad0
    • qmo-odoo's avatar
      [FIX] event: hide lone fa-map-marker icon on kanban view when no location · 546709da
      qmo-odoo authored
      
      The purpose of this commit is to hide the icon fa-map-marker in the event
      kanban view in case no address_id is set on the event.
      
      Task ID 2184037
      PR #53119
      
      closes odoo/odoo#53152
      
      X-original-commit: 7aab71db8588286d6b746f0243fa356d220439d8
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      546709da
    • Thibault Delavallée's avatar
      [FIX] event_sale, mass_mailing_event: add groups on app-specific fields · 3ecb5c56
      Thibault Delavallée authored
      Currently if you configure an user without sales and mass mailing
      rights you run into issues with links modules as
      
        * sales data is computed on form view and requires sales access
          rights;
        * invite and contact buttons lead to tracebacks as their action
          require mailing access rights;
      
      In this commit we fix those issues by correctly setting groups
      on fields.
      
      Task ID 2184037
      PR #53119
      
      X-original-commit: af1a5d294b235e33a48b87c89886b24ea145450d
      3ecb5c56
    • jvm-odoo's avatar
      [FIX] web: fix in and not in js domain · 61400fda
      jvm-odoo authored
      
      This commit fix the in and not in operators
      in domain.js.
      
      _.contains works only if you have an array
      in the left part.
      
      So if you have an array in the right part
      it will not work correctly.
      
      Using _.intersection solves the problem.
      
      OPW-2274990
      
      closes odoo/odoo#53150
      
      X-original-commit: 7e3fbfaf
      Signed-off-by: default avatarNicolas Lempereur (nle) <nle@odoo.com>
      Signed-off-by: default avatarJason Van Malder (jvm) <jvm@odoo.com>
      61400fda
  3. Jun 15, 2020
  4. Jun 02, 2020
    • Urvi Soni's avatar
      [FIX] sale_timesheet: Display of SOL field on task only if timesheet exist. · 8060abaf
      Urvi Soni authored
      
      Currently, the SOL field is visible on task form view even if there are
      no timesheets linked to the task.
      
      So in this commit the SOL field should not be visible on task form view
      if there are no timesheets linked to the task. The SOL field is only
      visible incase when there is multiple soline is linked with timesheet
      so to make that field visibile/invisible there is has_multi_sol
      compute field. so we will only display the field if timesheet_id is
      exist.
      
      closes odoo/odoo#52218
      
      Taskid: 2266104
      Closes: #52218
      Signed-off-by: default avatarYannick Tivisse (yti) <yti@odoo.com>
      8060abaf
  5. Jun 17, 2020
  6. Jun 16, 2020
    • Goffin Simon's avatar
      [FIX] odoo: Traceback when creating a new contact · f5089a0b
      Goffin Simon authored
      
      Steps to reproduce the bug:
      
      - Let's consider a new instance with default installed language 'en_US'
      - Install CRM
      - Activate a second language (e.g. en_GB)
      - Set that language in all users
      - Inactivate default language 'en_US'
      - Reset the language of your current user (no value)
      - Go to contact and try to create a new one
      
      Bug:
      
      A traceback was raised because the lang en_US did not exist.
      
      opw:2267711
      
      closes odoo/odoo#53064
      
      X-original-commit: c43647f0
      Signed-off-by: default avatarSimon Goffin (sig) <sig@openerp.com>
      f5089a0b
    • Nicolas Martinelli's avatar
      [FIX] sale_mrp: delivered qty on sub-kits · 435e5db0
      Nicolas Martinelli authored
      
      - Create 4 products A, B, C, D
      - Create a product AB, which is a kit made from A & B
      - Create a product CD, which is a kit made from C & D
      - Create a product ABCD, which is a kit made from AB & CD
      - Create a SO with 1 unit of ABCD, validate
        => a picking with A, B, C and D is created
      - Validate the picking
      
      The delivered quantity remains zero on the SO.
      
      This happens because we don't find any `relevant_bom`. Indeed, the
      `bom_line_id` written on the stock moves correspond to products AB & CD,
      but they do not correspond to ABCD.
      
      We fall back on the 'all-or-nothing' policy.
      
      opw-2273392
      
      closes odoo/odoo#53091
      
      X-original-commit: 972eab4b
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      435e5db0
    • Sébastien Theys's avatar
      [FIX] mail: add focus to composer when showing it from chatter · 47aea7ab
      Sébastien Theys authored
      
      task-2224442
      
      closes odoo/odoo#53096
      
      X-original-commit: 7f571e490204d71882baf5a45b0b40cbada8d8da
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      47aea7ab
    • Sébastien Theys's avatar
      [FIX] mail: restore style of messaging menu icon · ac5138b1
      Sébastien Theys authored
      
      - restore "solid" icon
      - restore muted style when no notification
      - opportunity is taken to fix off-pixel of activity menu
      
      task-2278416
      
      closes odoo/odoo#53094
      
      X-original-commit: 1164b37c5fb33d124ede52356c613b7cd31ac8e1
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      ac5138b1
    • Sébastien Theys's avatar
      [FIX] mail: fix messaging menu top alignment with other systray menu · 97794679
      Sébastien Theys authored
      
      task-2276039
      
      closes odoo/odoo#53089
      
      X-original-commit: 35cf5d4a186c51b2d43ff9a63b833767a65059f6
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      97794679
    • Xavier Dubuc's avatar
      [FIX] mail: mark message as seen only when thread composer is focused · 4ca54925
      Xavier Dubuc authored
      
      task-2272510
      
      closes odoo/odoo#53088
      
      X-original-commit: edf356c2022b3039e53e82a092fc64533f59df27
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      4ca54925
    • Arnold Moyaux's avatar
      [FIX] mrp: reference to enterprise variable · 57a32316
      Arnold Moyaux authored
      
      Usecase to reproduce:
      - Create 2 table(MTO)
      - Produce 1 and use BO button
      
      Traceback due to a reference to enterprise field.
      
      closes odoo/odoo#53077
      
      X-original-commit: 2fffc12f8e3cdccba4b1c9820f997f4b10dac330
      Related: odoo/enterprise#11191
      Signed-off-by: default avatarArnold Moyaux <amoyaux@users.noreply.github.com>
      57a32316
    • Rémy Voet (ryv)'s avatar
      [FIX] mrp: singleton issue · e0059ad5
      Rémy Voet (ryv) authored
      
      Fix singleton error when trying to backorder several MO
      
      task-2278147
      
      closes odoo/odoo#53078
      
      X-original-commit: 3a317ccd3fe407f732607343ca5ce351602b56e7
      Signed-off-by: default avatarArnold Moyaux <amoyaux@users.noreply.github.com>
      Signed-off-by: default avatarRémy Voet <ryv-odoo@users.noreply.github.com>
      e0059ad5
    • lejeune quentin's avatar
      [FIX] hw_drivers: Fix issue with printer device-id · 5a097e5c
      lejeune quentin authored
      
      When we print a ticket status with a thermal printer we need printer's device-id
      But if we add manually a printer this device-id doesn't exist
      So now we update de devices list with a supported = True if
      printer are manually added
      
      closes odoo/odoo#53072
      
      X-original-commit: 89bbc555ecf520ee34a9b1292a2bdb5c937b18e2
      Signed-off-by: default avatarQuentin Lejeune (qle) <qle@odoo.com>
      5a097e5c
    • Daniel Blanco's avatar
      [FIX] l10n_cl: Several fixes and improvements for l10n_cl · f3a66dd6
      Daniel Blanco authored
      [FIX] l10n_cl: format RUT/VAT as used in Chile (99999999-X)
      [FIX] l10n_cl: prevent errors with domain of available documents in invoice view.
      [FIX] l10n_cl: allow to select document types when partner is empty
      [ADD] l10n_cl: add ILA taxes (purchase and sale) and assign account to taxes
      [ADD] l10n_cl: add fiscal position exempt for purchases and sales
      [IMP] l10n_cl: configure accounts used in inventory valuation
      [FIX] l10n_cl prevent to put unneeded sales documents in sales journal
      [FIX] l10n_cl limit revision of document types and partner constrains only for sale and purchase journals
      [FIX] l10n_cl: add extra validation to know wether there is a latam_document_type_code selected
      [ADD] l10n_cl: add document type '801' Orden de compra
      [WIP] add tag to costo de ventas account
      [FIX] l10n_cl: fiscal position templates: fix supermarket tax
      [FIX] l10n_cl: change order for boletas
      [WIP] l10n_cl: fix the compute document types method
      [FIX] l10n_cl: prevent expected singleton error (checked in tests) in post
      [I18N] l10n_cl: add new translations
      [I18N] l10n_cl: reduce size of taxes names and abbreviation for invoices (probably more work to add here)
      [FIX] l10n_cl: remove countries from accounts
      [FIX] l10n_cl: remove recalc of domain when journal changes
      [FIX] l10n_cl: remove sale constraint
      
      closes odoo/odoo#53068
      
      X-original-commit: 060f083879f6094941f746928832fec253a23bb0
      Signed-off-by: default avatarJosse Colpaert <jco@openerp.com>
      f3a66dd6
    • Xavier Dubuc's avatar
      [IMP] mail: add docstring for unescaped fields · d85ed515
      Xavier Dubuc authored
      
      task-2269440
      
      closes odoo/odoo#53051
      
      X-original-commit: 683a524ac6fa74e786e13e6c1c0d6808b10b41ba
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      d85ed515
    • Goffin Simon's avatar
      [FIX] event_sale: Coding error · 06310c62
      Goffin Simon authored
      
      Coding error
      
      opw:2276815
      
      closes odoo/odoo#53048
      
      X-original-commit: 7a70249f
      Signed-off-by: default avatarSimon Goffin (sig) <sig@openerp.com>
      06310c62
    • Bruno Boi's avatar
      [FIX] google_calendar: Avoid syncing events several times · 1c340b60
      Bruno Boi authored
      
      Could happen when a partner is linked to several users.
      
      closes odoo/odoo#51983
      
      Signed-off-by: default avatarYannick Tivisse (yti) <yti@odoo.com>
      1c340b60
    • Bruno Boi's avatar
      [IMP] calendar: Use the avatar widget on event popover · fcf616c2
      Bruno Boi authored
      The responsible of an event will now appear through the avatar widget.
      
      Taskid: 2263837
      fcf616c2
    • Mahendra Barad's avatar
      [IMP] lunch: Improve the views and multi-company behaviour · 231eaa0f
      Mahendra Barad authored
      
      Purpose
      =======
      
      Improve the lunch categories and mutli-company environment.
      
      Specifications
      ============
      
      - Able to archive a product category and this should archive/unarchive
      all the products in that category also added the filter for same.
      when unrchive the product if category is archived then raise the
      Validation to change the category OR unarchive the category.
      - add a default image for lunch categories
      - Adapt the size of the default image, currently it's too big,
      - On lunch order form view if product images is not set then display
      the category image same as kanban image.
      
      - Add a company field on the Product categories (it's already there
      but it should be visible on the view form). Added the multi company
      rule for the product category and if company is not set on category
      then it will be sharable by all the company. so default company on
      product category null.
      also on lunch product and report check the multi company and display
      the product accroding to company.
      
      closes odoo/odoo#45797
      
      Taskid: 2200002
      Closes: #45797
      Signed-off-by: default avatarYannick Tivisse (yti) <yti@odoo.com>
      231eaa0f
    • Priyanka Kakadiya's avatar
      [IMP] mail: set default activity summary only if there is any · 77c23121
      Priyanka Kakadiya authored
      
      PURPOSE
      
      Currently, there is an on-change to set an activity summary to the default
      summary of an activity type. This can be useful if types are properly
      configured. The problem is, the activity summary will be updated even if there
      isn't any default summary on the type. Meaning that it simply removing a
      relevant custom summary the user might have already entered.
      
      SPECIFICATIONS
      
      When triggering the on-change on activity_type_id, only update the activity
      summary to the default summary if there is a default summary defined on the
      activity type.
      
      LINKS
      
      Task-2254825
      PR #51373
      
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      77c23121
    • Julien Castiaux's avatar
      [FIX] mail: cannot route catchall bounced email · 696a5ecf
      Julien Castiaux authored
      
      Configure a catchall address in Odoo, send an email to that very
      address, it should bounce back to the user asking him not to send any
      email to the catchall but the email is never sent.
      
      Internally, Odoo reply to the user using the `To` header of the original
      email as `From` of the bounced email. It should never use the catchall
      address as it is not a valid email to send email from.
      
      closes odoo/odoo#53036
      
      Task: 2277661
      X-original-commit: 86c8f0960f709692aa787ae62d446b4427a7c312
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      696a5ecf
    • Odoo's Mergebot's avatar
      [FW][MERGE][FIX] event: correctly manage configuration coming from template · dab0fc2f
      Odoo's Mergebot authored
      
      PURPOSE
      
      Fix various issues spotted in 13.3 when testing event. Notably
      computation of 2many fields coming from template.
      
      SPECIFICATIONS
      
      When updating template on an event, one2many fields should be better managed.
      Previous heuristic was
      
        * if event type uses o2m configuration (use_ticket / _schedule / _question)
          and has lines
      
         * erase existing lines;
         * create new lines based on old one;
      
      This has the drawback of loosing information of what is sent (mail) or
      sold (tickets) or answered( questions). Another drawback is that only
      types having line are synchronized. This means that if updating several
      times the event type you could end up with an XMas configuration with
      lines coming from different event types, depending on their o2m configuration.
      
      We choose a better heuristic that should solve this issue
      
        * every time we change type, independently of its use_* field that is used
          mainly for UX on the type itself:
      
          * erase existing lines that have not been used yet (no mail sent, no
            ticket linked to registrations, no answer linked to registrations)
          * create new lines based on old one; if type has no lines, event will
            have its old empty line erased as well;
      
      It means that we try to synchronize more the type to the event while keeping
      configuration line already used in some registrations.
      
      Also provide some other fixes like deletion restrictions or better domain
      for UX purpose. See sub commits for more details.
      
      LINKS
      
      Task ID 2244487
      PR odoo/odoo#52923
      
      closes odoo/odoo#53034
      
      Forward-port-of: odoo/odoo#52998
      Forward-port-of: odoo/odoo#52923
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      Unverified
      dab0fc2f
    • Thibault Delavallée's avatar
      [FIX] website_event_questions: add domain on answer question_id · 9194c183
      Thibault Delavallée authored
      Add a domain on question_id. Its event should be the same as registration
      event. Otherwise when editing in backend all questions are available while
      only those related to the registration's event should be.
      
      Task ID 2244487
      PR odoo/odoo#52998
      FwdPort of odoo/odoo#52923
      
      X-original-commit: 25d53430f32598a5db65be807756182d2063b3ee
      9194c183
    • Thibault Delavallée's avatar
      [FIX] event: avoid removing tickets with registrations · 3f387d08
      Thibault Delavallée authored
      Prevent to unlink tickets when having registrations by adding an ondelete
      restrict attribute. Otherwise billing information may be lost.
      
      Task ID 2244487
      PR odoo/odoo#52998
      FwdPort of odoo/odoo#52923
      
      X-original-commit: 5322d76d378e4bd88a42dc0e4b01bb46c7b3546a
      3f387d08
    • Thibault Delavallée's avatar
      [FIX] event: do not set a void timezone from type · 8385c880
      Thibault Delavallée authored
      Synchronize only timezone value from event type if set. Otherwise keep the
      existing one or fallback on user defined one.
      
      Task ID 2244487
      PR odoo/odoo#52998
      FwdPort of odoo/odoo#52923
      
      X-original-commit: 10094beec786ef0ea6e32e621d4e026fedeba19a
      8385c880
    • Thibault Delavallée's avatar
      [FIX] event: always synchronize tags, seats_max and auto_confirm with category · b14b5b91
      Thibault Delavallée authored
      We consider that changing category should always update value of those fields
      to avoid having oddly-configured events. Indeed if you choose a new event
      category most of its configuration should be propagated to the event.
      
      Task ID 2244487
      PR odoo/odoo#52998
      FwdPort of odoo/odoo#52923
      
      X-original-commit: f7e747886caebf37d60037a3e0e760f95bd0fb68
      b14b5b91
    • Sébastien Mottet (oms)'s avatar
      [FIX] event(_questions): take better care of 2many fields when updating from event type · be11161a
      Sébastien Mottet (oms) authored
      
      PURPOSE
      
      Fix various issues spotted in 13.3 when testing event. Notably
      computation of 2many fields coming from template.
      
      SPECIFICATIONS
      
      When updating template on an event, one2many fields should be better managed.
      Previous heuristic was
      
        * if event type uses o2m configuration (use_ticket / _schedule / _question)
          and has lines
      
         * erase existing lines;
         * create new lines based on old one;
      
      This has the drawback of loosing information of what is sent (mail) or
      sold (tickets) or answered( questions). Another drawback is that only
      types having line are synchronized. This means that if updating several
      times the event type you could end up with an XMas configuration with
      lines coming from different event types, depending on their o2m configuration.
      
      We choose a better heuristic that should solve this issue
      
        * every time we change type, independently of its use_* field that is used
          mainly for UX on the type itself:
      
          * erase existing lines that have not been used yet (no mail sent, no
            ticket linked to registrations, no answer linked to registrations)
          * create new lines based on old one; if type has no lines, event will
            have its old empty line erased as well;
      
      It means that we try to synchronize more the type to the event while keeping
      configuration line already used in some registrations.
      
      Also provide some other fixes like deletion restrictions or better domain
      for UX purpose. See sub commits for more details.
      
      LINKS
      
      Task ID 2244487
      PR odoo/odoo#52998
      FwdPort of odoo/odoo#52923
      
      X-original-commit: 645f70cad033083e82a3ef9102c694c331badef9
      Co-authored-by: default avatarSebastien Mottet <oms@odoo.com>
      Co-authored-by: default avatarThibault Delavallée <tde@odoo.com>
      be11161a
Loading