Skip to content
Snippets Groups Projects
  1. Jan 28, 2019
  2. Jan 25, 2019
    • qha-odoo's avatar
      [IMP] website_event, *: refactor website events layouts · 5b563549
      qha-odoo authored
      * base, portal, website, website_event_sale, website_event_track
      
      - The previous event registration form was not clear on mobile
      
      - Review some layouts to match the new design general idea, using cards
        (see forum refactoring of https://github.com/odoo/odoo/pull/29235)
      
      - Use correct bootstrap components (like a menu instead of a breadcrumb
        on event pages)
      
      - Review options to be able to disable the left / right column and
        choose the exact options you want to appear in them
      
      task-1858034
      
      closes odoo/odoo#30559
      5b563549
    • Florent de Labarre's avatar
      [IMP] hr_holidays: archived leave type · 340bc5c4
      Florent de Labarre authored
      Add a filter for archived leace types.
      
      closes odoo/odoo#30279
      340bc5c4
    • Siddarth Gajjar's avatar
      [FIX] mass_mailing: restore email templates · b43fcd67
      Siddarth Gajjar authored
      Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
      the classes 'o_mail_wrapper' and 'o_mail_wrapper_td' were renamed to
      'o_mailWrapper' and 'o_mailWrapper_td' because of what appears to be a
      JS-variable-search-replace fail. Strange enough, the scss was not
      impacted which allowed to see the bug in master.
      
      closes odoo/odoo#30544
      b43fcd67
    • Robot Odoo's avatar
      [MERGE][REF] survey: further refine access mode · 26f828e6
      Robot Odoo authored
      Purpose of this merge is to improve access mode and authentication management
      introduced at 9771fdfe . Purpose of this cleaning is to simplify options and make
      them clearer. Instead of a selection with 4 entries we propose to use two
      fields on survey model :
      
       * access_mode: everyone with a public link can access and answer; or only
         invited people;
       * login required: whether people have to login to answer or not;
      
      All main use cases are covered with combination of those two options.
      
      In this merge we also refine survey routes now using an access token defined
      on survey model instead of its ID. It allows to keep surveys somehow private
      especially for surveys on invitation only.
      
      Some fixes related to last changes are also done in this merge. Some
      improvements in survey templates are also provided to ease their update.
      
      This merge is linked to task ID 1932508 and PR #30508.
      Unverified
      26f828e6
    • Thibault Delavallée's avatar
      [IMP] survey: slightly improve result template · 61bce695
      Thibault Delavallée authored
      Purpose is to remove an unnecessary template by directly including the "no
      result" inside the main result template. It eases understanding and updating
      of templates.
      
      This commit is linked to task ID 1932508 and PR #30508.
      61bce695
    • Thibault Delavallée's avatar
      [IMP] survey: improve token and answer management · 2e4ea7c4
      Thibault Delavallée authored
      Purpose of this commit is to improve a bit management of user input tokens
      and state
      
       * allow to test closed surveys;
       * better management of answers already filled;
      
      This commit is linked to task ID 1932508 and PR #30508.
      2e4ea7c4
    • Thibault Delavallée's avatar
      [IMP] survey: better manage login required and signup · 82f5ec04
      Thibault Delavallée authored
      Purpose of this commit is to provide a real signup URL and redirection when
      login is required on survey. It depends correctly on current partner state
      and auth signup parameters. Redirection is now correctly managed so that
      customer will be back on survey with their token.
      
      This commit is linked to task ID 1932508 and PR #30508.
      82f5ec04
    • Thibault Delavallée's avatar
      [IMP] survey: refine access mode option on survey · e65bcb24
      Thibault Delavallée authored
      Purpose of this merge is to improve access mode and authentication management
      introduced at 9771fdfe . Purpose of this cleaning is to simplify options and make
      them clearer. Instead of a selection with 4 entries we propose to use two
      fields on survey model :
      
       * access_mode: everyone with a public link can access and answer; or only
         invited people;
       * login required: whether people have to login to answer or not;
      
      All main use cases are covered with combination of those two options.
      
      This commit is linked to task ID 1932508 and PR #30508.
      e65bcb24
    • Thibault Delavallée's avatar
      [IMP] survey: access survey through access tokens · c801eecf
      Thibault Delavallée authored
      Purpose of this commit is to use an access token to access survey instead
      of their ID. Routes are updated to use that token instead of the survey ID.
      Purpose is to have less discoverable routes and be able to control a bit more
      survey access even if it is not really a security parameter.
      
      Some renaming is performed to avoid confusion in terms. Survey token and
      answer token are now clearly labeled differently in the code to know which
      model we are working on.
      
      Some templates are updated to directly use the answer as base record to
      have access to token and test_entry fields instead of giving those parameter
      values directly in the controller. It makes some more diff but also allow
      easier edition and improvement in templates when having directly survey
      and answer record available.
      
      This commit is linked to task ID 1932508 and PR #30508.
      c801eecf
    • Thibault Delavallée's avatar
      [IMP] auth_signup: allow direct URL redirection instead of action when computing signup URL · 970cb47f
      Thibault Delavallée authored
      Purpose of this commit is to improve the redirection done after signup.
      Currently everything is tailored to create an Odoo action (action, model,
      res_id, ...). This action is used to forge an URL that is the redirection
      URL after signup. In some cases you would like to directly give the redirection
      URL when no Odoo standard action is involved.
      
      An example of use is the redirection when subscribing to take a survey. We
      want customers to be back on survey that is a frontend URL, not a backend
      URL linked to an action.
      
      This commit is linked to task ID 1932508 and PR #30508.
      970cb47f
    • Pierre Paridans's avatar
      [IMP] web: Deactivate swipe between form view in mobile · 9f7e6bb7
      Pierre Paridans authored
      The swipe between the form view is taking too long to load, and the pager is a
      more clean option to switch between form view.
      Moreover, the swipe on tabs is not clear anymore.
      
      - Deactivate swipe between form view
      - Swipe should only be available on tabs when tabs are too long to fit in one screen.
      
      Was originally introduced by https://github.com/odoo/odoo/commit/f4ee61f950dc1eeb7b3653ca96ea72721512b5e5
      
      Related task: 1924764
      
      closes odoo/odoo#30413
      9f7e6bb7
  3. Jan 23, 2019
    • David Beguin's avatar
      [IMP] sale_crm : review quotations and sales smart buttons on opportunity · 3dac18f9
      David Beguin authored
      various improvements and fixes:
          - View quotations was incorrect
              -> should be real quotation view and not SO view
          - Cotation count was incorrect
              -> Should only include Quotations with state='draft' or state='sent'
          - SO button should be visible if number of SO > 0 and not the total amount
      
      Task ID : 1908622
      Closes PR #29461
      3dac18f9
    • David Beguin's avatar
      [IMP] crm : prefill partner info based on opportunity info · 73e9647b
      David Beguin authored
      If the user is creating a res.partner from the partner_id m2o on crm.lead,
      prefill contact information from the opp in it
      (email, phone, mobile, street, street2, etc.).
      
      If 'contact_name' is set on crm.lead, the created res.partner should have:
          > is_company = False
          > name = contact_name (from crm.lead)
          > company_name = company_name (from crm.lead)
      
      If 'contact_name' is not set on crm.lead, the created res.partner should have:
          > is_company = True
          > name = company_name (from crm.lead)
      
      Task ID : 1908622
      Closes PR #29461
      73e9647b
  4. Jan 25, 2019
  5. Jan 14, 2019
  6. Jan 22, 2019
  7. Jan 25, 2019
    • Robot Odoo's avatar
      [MERGE][IMP] survey : add datetime format and various improvements · 0f6b38b2
      Robot Odoo authored
      Purpose of this merge is to add support of both date and datetime questions
      in survey. Validation and check is added accordingly to current survey
      question type support.
      
      In this merge we also add some various improvements
      
       * Change the default value of the Validation Error message on
         the Date : "The answer you entered is not valid."
       * If long page, click on next and one error, the page should go up
         to allow the visitor to see where the error is.
      
      This merge is related to task ID 1911291 and closes PR #29054.
      Unverified
      0f6b38b2
  8. Jan 24, 2019
    • Antoine Prieels (ANP)'s avatar
      [IMP] mail, snailmail, snailmail_account: improve error management · 8f486db5
      Antoine Prieels (ANP) authored
      When a letter is sent through snailmail and encounter an error, it used
      to create an activity to the user to notify him that there was an error
      with its letter.
      
      When a user had this activity, he didn't have any clues of what was the
      error and how to manage it. So we decided to better handle snailmail
      errors and give the possibility to the user to easily fix the source of
      the snailmail errors.
      
      First to give a better feedback on the letters in errors, we've made
      features similar to ones existing for emails:
       - We add a mail message on the document that sent the letter, and put a
         small paper plane icon, which is red when an error occurs (like the
         envelope for email)
       - As letters can be sent in batch, we've also added an entry in the
         systray to easily manage the different documents having snailmail
         errors like for emails.
      
      Then we identified, the most common errors encountered with the
      snailmail letters and give proper way to let the user fix them:
       - Missing Required Field:
          - The address is not complete, some of the fields are empty.
          - We open a wizard allowing the user to modify the partner address
            and we try to resend all letters having this error on the modified
            partner.
          - We also try to avoid this error, by opening the wizard before
            sending the letter, but it only works for single documents, not
            for batch.
       - Trial/Credit Error:
          - The user has not enough credits to send letters anymore.
          - We open a wizard that give a redirection lnk to add credits on its
            iap account.
       - No Price Available:
          - The destination country is not supported by any of our providers,
            and we cannot do anything to send this letter.
       - Format Error:
          - The format of the pdf report send by the user is refused by our
            providers, because some visual stuffs are not respected, for
            example blank zone to print barcode or margins.
          - We show a wizard to the user letting him check a setting option
            that add a cover page in the envelope and the documents will be
            send with this extra page containing the address.
       - Unknown Error:
          - This is not one of the listed error above.
          - A wizard suggesting the user to contact support is displayed.
      
      The cron that try to resend letters on error, has been addapted to only
      try to send the error of type Trial/No Credit, because the account might
      have been reloaded, and other errors, won't change if they have not been
      fixed locally.
      
      closes odoo/odoo#29685
      8f486db5
    • RomainLibert's avatar
      [REF] l10n_be_hr_payroll: Replace computed fields · 7274c0aa
      RomainLibert authored
      The double holidays and the thirteen months fields are used for the salary
      package configurator. But these fields are computed as in a perfect world.
      
      As these values are now available with a specific salary structure,
      replace the computed values in the salary package and remove the fields
      
      closes odoo/odoo#30516
      7274c0aa
    • RomainLibert's avatar
      [IMP] l10n_be_hr_payroll: add Double Holidays/13 Month salary structures · 5232670a
      RomainLibert authored
      Adds the salary structure for 13th month
      Adds the salary structure for double pecule
      5232670a
    • Yannick Tivisse's avatar
      [IMP] hr_holidays: Avoid 2 leaves on the same day when changing state · c89c0e70
      Yannick Tivisse authored
      Purpose
      =======
      
      There is already a check triggered when we modify the start/end date.
      
      But it's still possible to:
      - Create a leave A
      - Refuse it
      - Create a leave B on the same day
      - Reset the leave A in draft state
      
      Specification
      =============
      
      The test should also be done when modifying the employee or the state.
      
      closes odoo/odoo#30480
      c89c0e70
    • Rohan Patel's avatar
      [IMP] hr_expense: improve mail gateaway · 4ba8f51d
      Rohan Patel authored
      
      1/ Send mail notification if expense is registered successfully
      
      Before this commit, when user submits the expense via email, user is not getting
      information about whether expense is registered or not. After this commit user
      will get a confirmation email.
      
      Few other usability improvements,
      - Improved tooltip for the field 'default_code' in expense's form and in the
      'Emails' config setting.
      - Added product's default code in product's kanban view
      - Filtered uom based on category of product's uom.
      
      2/ Better parsing of expense mail subject
      
      Criteria for matching expense product from email subject is changed,
        - The product code should be the first word of the subject.
        - Only expense products are allowed, previously there was no filter and user was
          able to select any product in expense via mail.
      
      Currency support is added,
        - Now user can specify currency symbols and ISO code in expense mail subject.
        - If subject contains multiple numbers in that case, number with currency will
          get higher priory, and it selected as an amount in expense.
        - If multi currency is active, user can use any active currency symbol/ISO code
          in mail subject. Respective currency will be selected in registered expense.
        - If multi currency is not active, user can only pass company currency. Other
          currencies are ignored and expense will be registered as default company currency
        - If user pass non active currency in subject then that currency will be ignored
          and expense will be registered as default company currency
      
      Examples:
      PROD_CODE 2 foo $1205.91 baz
      
      Added python test cases for mail subject parsing.
      
      Related to task #35093
      closes #22168
      
      Co-authored-by: default avatarLucas Lefèvre <lul@odoo.com>
      4ba8f51d
    • Robot Odoo's avatar
      [IMP] hr_payroll_account: Include employee's contract analytic account · af1728fd
      Robot Odoo authored
      If the employee's contract has an analytic account it should be considered for the payroll.
      This is actually the way analytic accounts are meant to be used in the payroll, to segregate
      information based on specific groups of employees or departments.
      
      This does not override the default behavior, it just uses the analytic account on the
      contract if it has it and the salary rule doesn't.
      
      Ticket #1927941
      Closes #30119
      
      closes odoo/odoo#30491
      Unverified
      af1728fd
    • Gustavo Valverde's avatar
      [IMP] hr_payroll_account: Include employee's contract analytic account · 691712eb
      Gustavo Valverde authored
      If the employee's contract has an analytic account it should be considered for the payroll.
      This is actually the way analytic accounts are meant to be used in the payroll, to segregate
      information based on specific groups of employees or departments.
      
      This does not override the default behavior, it just uses the analytic account on the
      contract if it has it and the salary rule doesn't.
      
      Ticket #1927941
      Closes #30119
      691712eb
  9. Jan 23, 2019
  10. Jan 11, 2019
  11. Jan 24, 2019
    • qsm-odoo's avatar
      [FIX] website, *: restore 'animation' system to the way it worked · a00e6f3d
      qsm-odoo authored
      * website_forum
      
      Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
      the website 'animation' system was 'extended' to vaguely use a
      'Registry' instance instead of an object. This was however left
      undocumented, with a require in the middle of a file, restarting all
      animations when used, only used by website_forum... with more code for
      no reason at all, ...
      
      This commit restores the system to the way it was before and re-adapts
      website_forum:
      - No need to check if website_forum is in the DOM as it is already
        checked by the animation system (on top of that... the new code was
        checking the DOM before it was ready...).
      - No need of a dynamic add on a registry, this is always done before the
        DOM is ready, so before the animations are started.
      - No need to know the root instance in website forum, just use the
        animation as the Wysiwyg instance's parent.
      
      The goal of this commit is also to avoid useless conflicts with
      https://github.com/odoo/odoo/pull/29442 (that should not have had any
      conflict at all as totally independent of the editor task...)
      
      closes odoo/odoo#30478
      a00e6f3d
    • Yannick Tivisse's avatar
      [IMP] hr_contract_salary: Change the legal/extra legal leaves behavior · 7a2394c6
      Yannick Tivisse authored
      purpose
      ======
      
      In salary configurator, improve the cusrsor to select only extra leaves.
      
      Specification
      =============
      
      Specification
      ==========
      
      Section legal leaves:
      - Rename "Legal leaves" into "Extra Time Off"
      - change the cursor  0 -> 15
      
      Change the text (rmove completely old one if you go below 20)
      
      In addition to your legal leaves, you can choose any number of extra time off you want. If you worked a full time 12 months last year, you will get a total of  [  27   ]  day(s) off.
      The amount of annual time off (legal leaves) you get depends on your work schedule in the previous year. A full-time work schedule through the 12 months of the last year will grant you 20 annual time off (legal leaves)
      
      In yearly advantages (on the right right)
      - Cash                          4000 €
      - Annual Time Off         20  day(s)
      - Extra Time Off             7  day(s)
      
      closes odoo/odoo#30425
      7a2394c6
    • qsm-odoo's avatar
      [FIX] portal: remove useless dependency to 'web_editor.ready' · 0be8a1e4
      qsm-odoo authored
      Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
      the 'web_editor.ready' module was moved to website without caring about
      where it was used.
      
      Fortunately the only non-website app which uses it is portal in a module
      which in fact does not need it.
      It would probably make more sense if it was in portal though (see
      https://github.com/odoo/odoo/pull/30409) but as an upcoming PR is about
      to fix those problems (https://github.com/odoo/odoo/pull/29442), this
      can stay in website for now.
      
      closes odoo/odoo#30473
      0be8a1e4
  12. Dec 12, 2018
Loading