When the number of mail.activities for a user was getting too big, the whole database is getting slowed down as the activities are recomputed each time a page is loaded.

The issue was mostly brought by commit [03c3d440](https://github.com/odoo/odoo/commit/03c3d440ae31baa0400b7adba7f6373556ff5c38

).

The time was recorded when refreshing the home page of the site.

|     |     |     |
| --- | --- | --- |
| #activities | before PR | after PR |
| 100 000 on 1 model | 22.66s (single test) | 0.408s (worst of few runs) |
| 40 on 40 models | 0.06s worst, 0.037s best | 0.053s (worst of few) (0.038s best) |

closes odoo/odoo#136137

X-original-commit: bba39fa8
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Reproduction:
1. Create a link right after some text
2. Remove the whole line by backspace character by character(this should
give the p element a history steps id)
3. Try to create a link again
4. The new link is invisible and actually created in br when inspecting
the page

Reason: this is an edge case on Chrome that the document.getSelection()
returns a selection which has br element as the anchorNode. It may
happen when the parent element of the br has history steps and only has
this br element. However, the same steps done on Firefox return the
correct selection on the parent element.

Fix: we make a special case when the selection is a caret type and the
anchorNode is a br element, we re-select the parent element and collapse
the selection to the start. This is trying to mimic the normal case of
adding a link to an empty p element, e.g selection anchorNode is p,
offset is 0.

task-3181486

closes odoo/odoo#131509

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

This way, it can be used without having to add the dependency to
`base_vat`. For instance, in `account_edi_ubl_cii` in
`_import_retrieve_and_fill_partner`.

This commit essentially backports part of commit
212be2920affdab5baf14b3025ef31ee2d6a652b

closes odoo/odoo#135977

Signed-off-by: Laurent Smet (las) <las@odoo.com>

Description of the issue:
remaining hour field was visible to all users

Desired behavior after PR is merged:
remaining hour will only visible to that user who have timesheet access this
field will invisible if user doesn't have timesheet access

task-3484290

closes odoo/odoo#135171

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Issue:
-------------------
In the lead forward mail template, there are some broken links, when we click on those links they are appended to the current url and redirect to a non-expected page.

Steps to reproduce:
-------------------
1. Go to CRM -> Create a new opportunity
2. Click on this new opportunity -> Assigned Partner
3. Select an assigned partner and click “Send Email”
4. Go to Settings -> Technical -> Emails
5. When clicking on “Partner Portal” it redirects to a non-existing page

Cause:
-------------------
The issue is happening because the urls are badly formatted and not using the correct tags

OPW-3074049

closes odoo/odoo#130300

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

This commit fixes the overflow of content title on without fullscreen view(Exit-
Fullscreen) of content page by cropping the title and adding  '...' at end.

Task-3384661

closes odoo/odoo#136608

X-original-commit: 6b27a6f8
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Since odoo/odoo#122569, we now try to import the `migrations`
sub-package of each module to find upgrade tests.
However, this badly written regex match the OCA module `base_maintenance`,
which generate a RecursionError.

closes odoo/odoo#136412

X-original-commit: abd9e668
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

This traceback arises when the user selects multi
company records and click on the 'create report' button.

To reproduce this issue:

1) Install 'hr_expense'
2) Create a new company for example 'test'
3) Enable the 'test' company on the right corner
4) Now open 'employees' and change the company of the current user(Mitchel Admin)
   to the 'test'.
5) Open 'Expenses', create a new record, and change the company to 'test'.
6) Fill the required field values and save the record.
7) Now click 'My Expenses/My Expenses to report' and select all the records (Make sure
   'My Expenses' filter is applied)
8) Click on the 'Create Record' button

Error:- "ValueError: Expected singleton: res.company(2, 1)"

On the '_create_sheet_from_expenses' method, the value of 'company_id' is getting
through 'self.company_id.id'.
See:-
https://github.com/odoo/odoo/blob/f910987cb4af84c1e7afabf67f05d4eebc31e765/addons/hr_expense/models/hr_expense.py#L324-L335



But when user selects multi company recordsets
'self.company_id' has multi recordsets.

When 'company_id' is getting value through 'self.company_id.id', because of
'self.company_id' has multiple records, which leads
to the above traceback.

By applying this commit will resolve the issue by raising an exception,
when user selected multi company records to create report.

sentry-4465422743

closes odoo/odoo#136261

X-original-commit: 883c03a0
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
Signed-off-by: Altaf Shaik (alsh) <alsh@odoo.com>

When creating a new company with the italian fiscal localization, the
tax "0% EU" is not instanciated properly

Steps to reproduce:
1. Install Accounting and module l10n_it_edi
2. Create a new company and select it
3. Go to Settings > Accounting > Fiscal Localization, set it to `Italy -
   Generic Chart of Accounts` and save
4. Go to Accounting > Configuration > Taxes and open tax "0% EU"
5. The fields for the italian exoneration are not properly set, they
   should have the same values as the same tax for company "IT Company"
   of the demo data

Solution:
When we set the company chart template, update tax "0% EU" with the
correct values

opw-3414593

closes odoo/odoo#136404

X-original-commit: f6b386c3
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>

This commit resolves the issue of content title overflow in both fullscreen
and non-fullscreen views by cropping the title and adding '...' at the end.

Task-3384661

closes odoo/odoo#136422

X-original-commit: febb7989
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce:
- Create a transfer with a delivery method.
- Add a lot of characters in the tracking reference field.

Bug:
after saving the field overflows in the view

opw-3370813

closes odoo/odoo#135941

Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

Set the default sale and purchase taxes for the mexican CoA.

Before introducing the IEPS taxes in commit
734e18eb, the default taxes were the 16%
IVA taxes (when loading the CoA, the default is simply the first
possible match with the lowest sequence). As the IEPS taxes now have the
lowest sequence, they are incorrectly selected as the defaults. This
commit fixes this.

task-3507155

closes odoo/odoo#135858

X-original-commit: 5d98384e
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Julien Van Roy (juvr) <juvr@odoo.com>

Before this commit:

The text moves back to the left side on remove format even if the direction rtl
is applied.

After this commit:

The text will not move to the left side on remove format if the direction rtl is
applied.

task-3482193

closes odoo/odoo#134240

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Before this commit:

when performing a shift paste of copied VS Code content, the indentation was
lost.

After this commit:

Now, when you perform a shift paste of copied VS Code content, the indentation
is preserved

Task-2884491

closes odoo/odoo#122828

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

When the user tries to modify the view with an invalid xpath expression,
an XPathSyntaxError traceback will appear.

Steps to produce:
1. Install the Accounting module.
2. Settings > Technical > UI > Views > Open any view
3. Invalidate expr syntax and try to save, thus an error will be generated.

Error: XPathSyntaxError: Invalid expression

This commit handles XPathSyntaxError by raising ValidationError
instead of a traceback.

sentry-4377014622

closes odoo/odoo#135614

X-original-commit: 58e463e7
Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>

Before this commit, when removing an animation from an element, all the
animation related classes and styles were not removed, leaving the DOM
in an inconsistent state.

This commit fixes that.

task-3497015

closes odoo/odoo#134624

Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>

Before this commit:
When returning a dropshipping, the valuation layers created do not have
the correct accounts on it:
 - Valuation -> Input   for the first SVL
 - Output -> Valuation  for the second SVL

After this commit:
For a dropshipped move, valuation layers have the following chain
of accounts:
 - Input -> Valuation   for the first SVL
 - Valuation -> Output  for the second SVL
Therefore, the return should have it reversed:
 - Output -> Valuation  for the first SVL
 - Valuation -> Input   for the second SVL

Steps to reproduce:
1. Create a dropship product with automated inventory valuation
2. Create a Sales Order, go on the PO and confirm it
3. Set quantities and validate dropshipping
4. Return delivered product (dropship return)

opw-3391174

closes odoo/odoo#136024

X-original-commit: 30de83a5
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

After commit [1], the check that the target url is different from
the current page's url has been removed thus leading to error that anchor
link always scroll down to element that have data-anchor enabled.

Steps to reproduce (the easiest way):
- Install Website Blog
- Turn on customize comment on post
- Go incognito then access any blog post, scroll down and click the
`Sign in to leave a comment` button
- Holy, the page scrolls down to the discussion section but doesn't go
to the login page

[1]: https://github.com/odoo/odoo/commit/fb087dbec96f5e533d1fdd9c2b0c2e00296c83de



closes odoo/odoo#136012

X-original-commit: f5fca171
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>

closes odoo/odoo#33682

Signed-off-by: bve-odoo <bve@odoo.com>

Steps to reproduce:
1. Install hr_attendance
2. Go to attendances
3. Select any line
4. Change the check-out date to next day
5. Change the check-out time to 00:00:00
6. Export that line, file format xlsx
7. Favorites > import records
8. Upload the exported file > Test
9. Column check_out contains incorrect values.
Error in line 2: unconverted data remains: 2023-06-11

Cause of the issue:
options.get('date_format') is empty

opw-3374883

closes odoo/odoo#133424

Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>

1. Backport of [1].
2. Steps to reproduce:
- Install website_crm
- Connect as Admin and remove the sales rights for Demo
- Check the website on a private window (to create an anonymous visit)
- Connect as Demo on the normal window
- Go to Website > Reporting > Visitors
=> It triggers an access error due to lead_ids being restricted to
sales_team.group_sale_salesman.
(Note: the error sometimes isn't triggered at that point. In that case,
click on the visitor: the same error will trigger.)

Considering the computed field doesn't do anything critical as it just
retrieves the email and phone number, the restriction is overridden on
the field.

[1]: https://github.com/odoo/odoo/commit/7de453477d7c23e607a15e0d60613080857e3371



opw-3475301

closes odoo/odoo#136194

X-original-commit: 5ba09c2c
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

In the din5008, there has been problem in the display of the paper format either
in the pdf or the preview.

In the preview we had a part of the page on the right that wasn't used caused by
the negative margin and the width of 180mm. But by removing that the pdf is
broken, the header is hiding some information.

To deal with that, we will add the width and negative margin only for the pdf
by adding a conditional css classes.

Also,it seems the footer with the company details can go out of page, by adding
a text-wrap on it, it solves this issue.

(In this commit, we override part of those commit:
https://github.com/odoo/odoo/commit/481f442f4ef176072edf3261415dbb06f8a3bc6f
https://github.com/odoo/odoo/commit/f7812ae848e0a79adcd11f936f6cd7890da00112

)

closes odoo/odoo#136293

X-original-commit: 96b09395
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>

- Create a move
- Add a line and set a custom tax tag on it
- Add a new line to balance the move
=> The tax tag is gone.

This is because the code is recomputing taxes when adding a new line.

closes odoo/odoo#136047

Opw: 3487465
X-original-commit: 1cad85f7
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Laurent Smet (las) <las@odoo.com>

Steps to reproduce:

- Enable the merge on account.account in data cleaning APP (in debug)
- Create an invoice with a receivable account = A
- Define a lock  date after the invoice date
- Go to chart of accounts
- Select your receivable = A et receivable = B
- Action = Merge accounts where B is the MASTER

Issue:
Upon revisiting the customer invoice: Notice that the journal items have been updated.

Solution:
We simply prevent ~~the use of a nuclear weapon~~ the merge of `account.account` as there other possibilities less dangerous such as multi-edit + archiving

We also prevent the merge of `res.partner` if this one is used in hashed entries

oe:https://github.com/odoo/enterprise/pull/47053



opw-3389157

closes odoo/odoo#134634

Related: odoo/enterprise#47053
Signed-off-by: William André (wan) <wan@odoo.com>

If somehow there is no selection but the `_handleShortcuts` handler still gets
called with `CTRL+A`, `container` would be a JQUERY object instead of an
element leading to a crash in `selectNodeContents` which expects a `Node`.

task-3506666

closes odoo/odoo#136289

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Prior this commit:
The mail scheduler of the event notifies the attendees even when the event is
no longer active.

After this commit:
Inactive events no longer notify attendees.

Task-3381876

closes odoo/odoo#136225

X-original-commit: 10c4091f
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Before this commit:

While saving the body_html a traceback occurred regarding reading HTML
in commit changes as it could not find the editable.

After this commit:

Now while saving the body_html the commit changes could read HTML in editable.

task-3496863

closes odoo/odoo#134614

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Upgrade (aka migration) scripts are a core part of Odoo, allowing
database manipulations for modules during version changes.

Any module, including custom ones can run upgrade scripts, even if the
`--upgrade-path` flag (and with it, the `odoo.upgrade` sub-module) is
not present. Currently only the "standard" modules benefit of easy
upgrade script testing. Any custom modules that want to run tests of
their upgrades have to import the tests in the usual `tests` folder,
which is not ideal.

Therefore, to allow TDD and programmatic testing of upgrade scripts in
custom modules, the test discovery is here modified to also parse the
module's `migrations` and `upgrades` sub-modules for tests.

closes odoo/odoo#136175

X-original-commit: e8683726
Signed-off-by: Vranckx Florian (flvr) <flvr@odoo.com>
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

Steps to reproduce:
1. Have 2 companies, and select the one w/ the highest ID
2. Create a new product tracked by lot + expiration date
3. Receive product
4. Set the received lot's expiration and alert dates in the past
5. Inventory > Operations > Run scheduler

Before this commit:
An activity is created on the lot for OdooBot,
despite the product's responsible set to the current user.
It happens because the default value for `responsible_id` is the current
user, but the value is only set for the current company. When the
scheduler runs, it doesn't set the company; therefore, it takes the
product's responsible user for the company with the lowest ID, which is
not set.

After this commit:
The activity is created for the product's responsible user using
the lot's company.

opw-3489340

closes odoo/odoo#136110

X-original-commit: dacfa844
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Signed-off-by: Walravens Mathieu (wama) <wama@odoo.com>

The method get_resource_path is redundant with file_path but without
all the checks.
The method will be deprecated in master but make it use file_path in
stable.

closes odoo/odoo#135896

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Bug
===
When searching for projects from the Outlook / Gmail addins, the names
were not translated into the user's language.

Task-3486324

closes odoo/odoo#133704

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce
==================

- Use a mobile viewport
- Create a quotation
- Add an order line
- Set a packaging
-> The Packaging Quantity field is missing

The same happens on purchase orders

---

opw-3504829

closes odoo/odoo#135928

Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>

The condition for which the Fiscal Position's Note is shown only in Customer Invoices is removed because unnecessary.
A check has been added on the company's country to be 'IT'.

Task link: https://www.odoo.com/web#id=3420752&model=project.task


task-3420752

closes odoo/odoo#135955

X-original-commit: c32720db
Signed-off-by: John Laterre (jol) <jol@odoo.com>

Steps to reproduce the bug:
- Create a storable “P1”:
   - tracking= serial
   - save
- Change the type of product to service

Problem:
some fields for tracked products are not hidden, because the product
tracking is not updated.

Solution:
Convert _onchange_type into compute methods.
The tracking is updated even if the change type is applied from the
"product.product" form.

opw-3499976

closes odoo/odoo#135912

X-original-commit: d3808a5d
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

purchase_stock, point_of_sale, sale_mrp

What are the steps to reproduce your issue?
When Odoo.sh runs unit tests on a development branch,
it tests the code in the MRP module for rounding errors.

What is the current behavior that you observe?
I had a customization that introduced a rounding error in the standard MRP module.
When the unit tests ran on the development branch, I got a traceback.

What would be your expected behavior in this case?
The rounding error should be reported as a failed test with a message. No traceback.

opw-3454998

closes odoo/odoo#135849

X-original-commit: 74416a2e
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Gaetan Vanden Bergh (gavb) <gavb@odoo.com>

Current behavior:
When refunding an order, the lot_id of the original order was not set
on the refund order.

Steps to reproduce:
- Create a product with tracking by lot
- Open the POS and add the product to the order
- Set a lot on the product
- Pay the order
- Refund the order
- Check the lot on the refund order, there is no lot set

opw-3485740

closes odoo/odoo#135056

Signed-off-by: Robin Heinz (rhe) <rhe@odoo.com>

Steps to reproduce:

- Go to Website > Add menu items to activate the "auto-hide" (to set the
overflowing menu items in a "+" dropdown).
- Go to "edit" mode > While resizing the window width, the "auto-hide"
menu adaptation is disabled, and overflowing menu items are visible.

The goal of this commit is to fix the behaviour described above (and
potentially, issues that can result from the editor's "unbreakable"
rollbacks on top menu) by preventing the unbreakable mechanism from
detecting header changes and cancelling the auto-hide updates.

Related to opw-3484742

closes odoo/odoo#134185

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Steps to reproduce:
-------------------
- add an allocation for an employee;
- add a leave with this allocation;
- validate the leave;
- refuse the leave;
- in action menu, click on "Time off Analysis by Employee and Time Off Type".

Issue:
------
The report does not take into account refused allocations and leaves.

Solution:
---------
Add a condition to take a number of days equal to zero
if the allocation or leave is in a refused state.

Handled the case where no record is found for leave
(with `COALESCE` because `value - NULL = NULL`).

opw-3503617

closes odoo/odoo#135748

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

To reproduce the issue:
1. In Settings, enable "Multi Routes"
2. Edit the warehouse:
   - Manufacture: 2 steps
3. Create three storable products P1, P2, P3
4. Create and confirm a MO for 1 x P1 with 1 x P2
   - It should create the PBM picking
5. Add a component line for P3
6. (Because the MO is locked, the user can not edit the 'to consume'
   quantity, so) Unlock the MO
7. Set the 'to consume' qty to 1
8. Save the MO

Error: P3 is not added to PBM picking. Worst: suppose the user does
the internal transfer and then checks the availability of P3, the
line will still be unreserved

Step 6, when unlocking the MO, it also triggers a save. As a result,
the SM for P3 is created with its demand defined to 0. When adding
such SM, we do several things through this method call:
https://github.com/odoo/odoo/blob/be0b61cbaf3d3b7082aca8f96dcf8a6ee7885fea/addons/mrp/models/mrp_production.py#L776


- We will adapt its procure method (here, because of 2-steps
  manufacturing, it will be MTO)
- We will confirm the new SM -> we will run a procurement for a zero
  quantity -> it will not generate any new SM

Then, when updating the SM quantity (step 7), nothing will run a new
procurement.

Moreover, this also explains why trying to reserve the SM does not
work: it's an MTO one, but it does not have any `move_orig_ids`, so
it is not possible to assign it.

Solutions:
- It should be possible to edit the 'to consume' qty of a new SM,
  even on a locked and confirmed MO
- A procurement should be executed when updating the demand of an SM
  from 0 to >0. From 16.1, a procurement will always be executed
  each time the quantity changed (see [1]). Here, we want to limit
  the impact/risk of the fix

[1] 1f4fb64a

OPW-3253204

closes odoo/odoo#135478

Signed-off-by: William Henrotin (whe) <whe@odoo.com>