- Create a product with traceability per LOT enabled and a barcode;
- Enable the option “Delivery Packages” in the inventory settings;
- Go to "Barcode" app;
- Scan EAN, the product line will be selected;
- Scan a LOT, a unit of quantity is incremented at each time the LOT is
  scanned;
- Put in Pack;
- Scan again the same EAN to register the next LOT, the product line
  will be selected with remaining quantities;
- Scan a new LOT number.

Before this commit, as the product line will remain with the old LOT
number, when the new LOT number is scanned a new line is created. This
line will miss the initial quantity and the quantities added to this new
line will not decrement the original line quantity.

Now, the old LOT number is clean when the Put in Pack function is
called.

opw-2270781

closes odoo/odoo#53319

X-original-commit: 01bf263acbe406d45a4b7a5358bdcdfb70c1d9ed
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

- Modify `timesheet_action_all` to display the tree view before the grid
  view
- In the quotation tree view, order by Status, group by Salesman and
  save as filter
- Open a SO with timesheets
- Clck on the 'Timesheets' stat button

An error occurs because the `orderedBy` context key is added in the
action context.

The purpose of replacing the action context is to remove the default
filters. We can simply set an empty dict to avoid any unwanted keys.

opw-2278618

closes odoo/odoo#53302

X-original-commit: 4fc6ec94
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Update translation files to match the latest content

Load also translations for fr_BE
It's common to use fr_BE for Belgian people working in Luxembourg

opw-2278849

closes odoo/odoo#53288

Related: odoo/enterprise#11287
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Bug
===
Install CRM, then go to the lead kanban view and try to generate leads.
An error will be raised.

Technical
=========
In the "iap.account" model, in the `get` method, we can create the IAP
account if it doesn't exist yet. Since 5307f47d
the operation is done in a different SQL cursor than the current one.

The reason is that we need to commit the change, and committing the current
SQL cursor can cause issue and break some flows (mainly if it's not done
at the very beginning/end of the flow).

In the current code, we cache the `account_token` to be able to read it
with the current SQL cursor (otherwise, the current cursor has no access
to the field because change has not yet being committing for it).

But, the cache is invalidated when the "IAP account SQL cursor" is closed.

```python
with self.pool.cursor() as cr:
    ...
    IapAccount = self.with_env(self.env(cr=cr))
    account = IapAccount.search(domain, order='id desc', limit=1)
    if not account:
        if not force_create:
            return account
        account = IapAccount.create({'service_name': service_name})
    # fetch 'account_token' into cache with this cursor,
    # as self's cursor cannot see this account
    account.account_token
    # <---- Cache is invalidated here
...
```

So we can not access the the field value after the invalidation.

Solution
========
The solution is the store the `account_token` value before closing the
"IAP account SQL cursor" and then, after closing it, we add it in the cache.

Task-2277733

closes odoo/odoo#53285

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

[FIX] l10n_ae: fix bad forward port of https://github.com/odoo/odoo/commit/83b8e2d962a2422876b0ed967ebb97f71625301f



closes odoo/odoo#53202

X-original-commit: 7c3d357badcf07155fc847f638e3ed28397658f2
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Before that, just one pixel from the bottom of the QR-bill frame passed got out of the page, and end out creating a second, empty page.

Since this error was probably due to some rounding issue in the way A4 dimensions were compared to the layout specified by the scss file, we solve it by rounding the height of this section a little more, removing 0.25mm from it.

[FIX] l10n_ch: qr bill report: display the payment ref under "reference" and the invoice's name as additional information

closes odoo/odoo#53260

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

This is a fine tuning of 7b9f8db08db428c2329 where I forgot
to put the `query` variable into the string parameters.

OPW-2275928

closes odoo/odoo#53280

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

On ir.property model, do get the field_id using the cached result from
ir.model.fields _get_id() method instead of issuing a direct SQL query

OPW-2067461

closes odoo/odoo#53275

X-original-commit: 47f64ed1
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

Create a purchase order
Confirm
Create the bill from the PO
Some fields related to the partner are left empty, shipping address,
incoterms, ...

While the account.move related to the bill is created,
all onchanges triggered by partner_id change are called on an empty
record.
This will mess up all the fields that should be pre filled
based on the partner_id record

opw-2276391

closes odoo/odoo#53286

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Done at odoo/odoo#53103

closes odoo/odoo#53262

X-original-commit: b6bce16b
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

This reverts commit c43647f0.

That change was not tested properly and can cause unforeseen errors
because it has far-reaching consequences, modifying the fallback
language on all requests.

One of the consequences is an alteration of the behavior of the
translation function `_()` due to the absence of a default language. For
users with no language set, it will now translate False/None values as
False/None, rather than the empty string fallback. Code that was not
prepared to deal with those non-str translations will now crash.

Besides, 'en_US' is a hardcoded default used in many areas of the code,
and we cannot get rid of it like this, especially in a stable series.

Cfr #52758

closes odoo/odoo#53254

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

Issue

	- Install website slides
	- Create a slide with document url =
	  a youtube video URL with params like ?rel=0
	- Check it on the website with debugger

	The iframe url doesn't have ?rel=0

Cause

	We only take the video ID and pass it
	to a predefined string. We add light
	theme params too.

Solution

	Split the given url in order to
	get the params and pass it to
	the predefined string.

OPW-2275928

closes odoo/odoo#53233

X-original-commit: c9bd6267
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Fix forward-port issue introduced in 3d05714f

OPW-2192639

closes odoo/odoo#53215

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

The superuser is already used to check whether modules are installed
with demo data and create the notification.

It was not used for accessing the admin partner though, so in the case
where a user is logging in with the password "admin" and with no
access to `partner_admin` it's going to blow up the login process
despite no reason to.

Admittedly this is somewhat difficult to achieve in "standard" odoo,
it was only discovered because 2FA (odoo/odoo#33928) can reach this
point without having a "proper" session set up as that set up is
delayed until after the MFA step has succeeded while
`_admin_password_warn` is part of the redirection flow from the
initial login (user/password input).

closes odoo/odoo#53203

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

In case no lang is set on the current user, we should fallback on the first
langage installed using get_lang tool.

closes odoo/odoo#53213

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue

	- Install Sales
	- Enable discounts & pricelists
	- Create a product
		- 2 variants:
			- first with "create variant" set to Always
			- second set to Never
	- Create a SO
	- Pricelist setting "without_discount"
	- Add the product with product configurator

	The line price is not correct (only Always taken in account)

Cause

	When the variant has Create Variant set to Never
	we pass the extra money in the context.

	When we have a pricelist with "without_discount"
	this context is not propagated correctly and it's lost

Solution

	Pass the product directly if it's not empty which
	have the context set.

OPW-2246102

closes odoo/odoo#53200

X-original-commit: 68628206
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

closes odoo/odoo#52850

Related: odoo/enterprise#11098
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

- Create an opportunity
- Set some tags
- Generate a quotation from the opportunity

The tags are not carried over to the quotation.

opw-2277010

closes odoo/odoo#53207

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Consider a multi-company database with user A allowed on multiple
companies (ex: YourCompany (USD), Belgian Company (EUR))

- user A switch to "YourCompany"
- Go to Accounting / Sales / Documents / Payment
- Create a new payment, with:

  * Payment Type = "Received Money"
  * Partner Type = "Customer"
  * Partner = "Agrolait"
  * Payment Journal = "Bank (EUR)"
    (i.e. journal of "Belgiam Company")
  * Payment Amount = "200" "EUR"

- Click on "Confirm"

=> An error is raised "Cannot create moves for different companies."

This commit ensure that when creating the payment journal entry, the
`destination account` is always computed relative to the payment's
company and not the current company of the user.

OPW-2192639

closes odoo/odoo#53039

X-original-commit: 0bcf3518
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

1. Create a vendor bill with 1 line @ 1000$ and Tax 15%. Post.
2. Go to Accounting>vendor>payment. Create a payment to the same
vendor for 1149.99
There is a difference of 0.01 between the payment and the vendor bill.
3. Reconcile bill and payment, but write-off 0.01 and place a tax of 15%
included

The user receive the following error once he click on reconcile.
"Something went wrong! You are trying to reconcile some entries
that are already reconciled."
Indeed the writeoff line create a 0.0 credit/debit tax line which is
automatically reconciled on creation

opw-2267900

closes odoo/odoo#53115

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

- Use an User with Accounting access rights, but without Admin access rights (e.g. Marc Demo)
- Go to Accounting > Reporting > Tax Report
An access rights error is triggered.

opw-2275552
opw-2275115

closes odoo/odoo#53168

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Create 2 companies A & B
- Create a product with automatic valuation
- Switch to company A
- Create a SO for 1 unit of the product, validate and deliver
- Genrerate the invoice
- Switch to company B, but keep company A allowed
- Post the invoice

An error is raised because of inconsistent company:

> Some records are incompatible with the company...

This occurs because the anglo-saxon lines are created in accounts
belonging to company B instead of company A.

Since the product accounts are property fields, using `force_company` in
the context allows the selection of the right accounts.

opw-2276657

closes odoo/odoo#53158

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

On a SO, you can set a default delivery address or a default invoicing address according to the customer.
The same behavior has been applied on repair order.

opw:2277679

closes odoo/odoo#53117

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Translate the sale description for products and operations.

opw-2274120

closes odoo/odoo#53130

X-original-commit: f713994e
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

This commit is fine tuning of 9f142c8ff5a383.

Apparently, context_get callback is never called. I
guess this is due to the fact that we are higher.

context_get is defined in public/public_root.js and
we are in core/session.js

The only way to fix is to retrieve the HTML tag language.

OPW-2244843

closes odoo/odoo#53116

Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

This commit fix the in and not in operators
in domain.js.

_.contains works only if you have an array
in the left part.

So if you have an array in the right part
it will not work correctly.

Using _.intersection solves the problem.

OPW-2274990

closes odoo/odoo#52966

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Issue

	- Configure bank journal to post at bank reconciliation
	- Create 2 expenses paid by company
	- Create a report for the two expenses
	  (make sure bank journal configured in the first step is used)
	- Submit, approve and post journal entries

	Error message : "You cannot modify a journal entry linked to
	a posted payment."

Cause

	Since the payment state of expenses lines is updated one by one
	in related move, the first expense had already a 'posted'
	state when updating second expense line, who go against
	_validate_move_modification validation.

Solution

	Update payments state only after updating all moves lines.

opw-2275686

closes odoo/odoo#53080

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Create a SO, Validate it.
Create Invoice: down payment (fixed amount) and validate invoice
Now back to the SO. Create Invoice: Invoiceable lines (deduct down payments).
A draft invoice is created. Try to delete it.

User gets an error, this occur because the second invoice creation bind
another invoice_line to the downpayment sale order line (first line was
added when making the downpayment). When the user delete the invoice
the sale order line should be deleted as well, but is still linked to an
invoice so the error raise.
Unlinking only unbinded sol fix the issue

opw-2258218

closes odoo/odoo#52648

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

l10n_se_ocr: Adding support of OCR Number for Invoice and Vendor Bill. Invoice supports OCR level 1 to 4 on both Parter ref and Invoice. Vendor Bill supports default vendor OCR number and OCR checksum.

closes odoo/odoo#52034

Signed-off-by: Josse Colpaert <jco@openerp.com>

Every call of initialize_sys_path was adding two new hooks to the
sys.meta_path, resulting in very long loading times on databases having
a lot of modules.

For example, 2.27s instead of 752 on a database having 130 installed
modules.

References:
- odoo/odoo#45780
- odoo/odoo#45662

closes odoo/odoo#53098

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

- Create 4 products A, B, C, D
- Create a product AB, which is a kit made from A & B
- Create a product CD, which is a kit made from C & D
- Create a product ABCD, which is a kit made from AB & CD
- Create a SO with 1 unit of ABCD, validate
  => a picking with A, B, C and D is created
- Validate the picking

The delivered quantity remains zero on the SO.

This happens because we don't find any `relevant_bom`. Indeed, the
`bom_line_id` written on the stock moves correspond to products AB & CD,
but they do not correspond to ABCD.

We fall back on the 'all-or-nothing' policy.

opw-2273392

closes odoo/odoo#53075

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce:
- install contacts
- go to any 2 contacts and add a message and an activity to the chatter
- go to the list view > select the 2 contacts > action > merge
- click on the remaining contact and refresh

Previous behavior:
the activities have not been merged

Current behavior:
activities are merged

opw-2263853

closes odoo/odoo#53049

X-original-commit: 9960def5
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: mightyjol <jhk-odoo@users.noreply.github.com>

Before this, it was impossible to reconcile an invoice with a credit note, as the tax_audit field's computation found two invoice lines while it expected only one, and crashed.

Note that our current tax report does still not handle all the cases properly:

- Invoices with negative lines using cash basis taxes won't work well, as we can't differentiate a credit note from an invoice using only debit and credit.

- Misc entries reconciled together with cash basis taxes on them ("faking" the invoice and payment) won't work well either, as both of them have the 'entry' type.

>> This commit is a temporary fix, essentially made to unlock customers blocked byt this issue. Another, more complete, fix is coming soon.

closes odoo/odoo#53038

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Steps to reproduce the bug:

- Let's consider two companies C1 and C2
- Let's consider that the default company of the current user U is C1
- Log in C2 (only)
- Print the POS details report

Bug:

The header of C1 was displayed.

opw:2274282

closes odoo/odoo#52985

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Steps to reproduce the bug:

- Let's consider a new instance with default installed language 'en_US'
- Install CRM
- Activate a second language (e.g. en_GB)
- Set that language in all users
- Inactivate default language 'en_US'
- Reset the language of your current user (no value)
- Go to contact and try to create a new one

Bug:

A traceback was raised because the lang en_US did not exist.

opw:2267711

closes odoo/odoo#52758

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Coding error

opw:2276815

closes odoo/odoo#52963

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Date correction for 56b0155b
We are matching a statement line, corresponding to a payment,
so we should use the statement_line date

Adding a test as well to check the whole flow

opw-2261134

closes odoo/odoo#52980

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

current expression implies that any payment of a quote from the portal (/my/quotes) will try to save a token whenever the user says they want the customer to pay online, which seems bizarre. Normally you'd only want that for quotes with subscription products, and there is an override of that method in sale_subscription for that specific case.

closes odoo/odoo#52896

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Steps to reproduce:
- install crm
- go to crm > configuration > settings > activate leads
- go to a contact > click the "opportunity" smart button >
create an opportunity > select the newly created opportunity > click
the "meetings" smart button

Previous behavior:
meetings are filtered with 'search_default_opportunity_id' set to active_id.
active_id is referring to the partner_id in this case. this leads to
a cache miss error.

Current behavior:
meetings are filtered by the right opportunity (current id).

opw-2272325

closes odoo/odoo#52947

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Steps to reproduce the bug:

- Let's consider a storable product P with automatic inventory valuation and re-invoicing policy at cost
- Create a SO with P, generate an invoice I and validate I

Bug:

A new line was added in the SO (related to the anglo saxon move line)

PS: In 12.0, no line was added on the SO when I was validated.

opw:2247915

closes odoo/odoo#52873

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>