time.clock is deprecated since python 3.3 and no longer exists in python 3.8
time.process_time was introduced in python 3.3

Replace "is" by "==" as this produces a SyntaxWarning in python 3.8

Fixes odoo/odoo#41313

closes odoo/odoo#44332

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps to reproduce:
- install pos
- install the hebrew language and set it as preferred language
- start a pos session with the virtual keyboard option activated
- try to search a product

Previous behavior:
the keyboard keys are reversed

Current behavior:
the keyboard keys are not reversed

opw-2171278

closes odoo/odoo#44377

X-original-commit: 37e3fe90
Signed-off-by: mightyjol <jhk-odoo@users.noreply.github.com>

Archived or deleted products shouldn't be counted in the comparison
widget count anymore.

The current behavior did only reset the cookie (and the count) when
products were added/removed from the comparison, but didn't consider
the case when the products currently in the cookie weren't all existing/valid.

Fixes #44049

closes odoo/odoo#44309

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

-github issue: 14673

closes odoo/odoo#44280

-task: 2007300
X-original-commit: 9b7d14c6b3caba5cde0b98bfaf8aaf887fc94abd
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Use the 'Volume' decimal precision on all `volume` fields.

Complement of commit c1a5221b

opw-2185374

closes odoo/odoo#44446

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Linked to issue: https://github.com/odoo/odoo/issues/43745



At slide creation, as image_1920 was in readonly mode in form view when type is
video, document or presentation, the field was not sent in value to the create.

There is no reason to set this field readonly. If the user want to modify the
thumbnail, that his responsability.

This commit remove the readonly flag for slide.image_1920 field to allow
computed thumbnail to be saved at slide creation.

Task ID: 2182638
PR #44405

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

If an automated action raises an exception, in the traceback modal:
 - For admins, display Disable & Edit automated action buttons
   to be able to directly know with wihch automated action the error occurred,
   and to give the possibility to edit or disable it quickly,
 - For regular users, just add a paragraph to tell with which automated action the error occurred,
   so they can give this useful information to their administrator

This is specially useful for databases which have just been
upgraded to a newer version, and for which the server action
is failing because its code is no longer supported.

closes odoo/odoo#42481

Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

When the multi-location is enabled, in the stock picking form, when
the picking is unlocked, we can't modify move lines in the wizard,
due to a bad readonly attribute which doesn't take in account
'is_locked' field.

closes odoo/odoo#44416

X-original-commit: 7f312fe5
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

`AccessError` requires the argument `msg`. Therefore, even if this error
is catched, we need to provide one, otherwise a `TypeError` is raised.

opw-2183184

closes odoo/odoo#44447

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- In an e-commerce with automatic invoice set;
- Buy something as public user;
- Pay the order;

Before this commit, the client don't receive the invoice confirmation
email.

opw-2176506

closes odoo/odoo#44396

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

Before this change we were letting the user to create a journal with a
AFIP POS Number they like, and where they try to post an invoice in that
jounrals they receive an error message telling that the document has not
valid POS Number.

In order to avoid this we add as part of the constraint where we check
the validity of the AFIP POS Number which is: should be greater that 0,
and should be 5 digits max.

closes odoo/odoo#43879

Signed-off-by: Josse Colpaert <jco@openerp.com>

The law itself said that you can use 4 or 5 digits, but some customers
complains that they want 5 (for eg. 00001) because some suppliers reject
the invoice if only 4 digits (that is wrong, but suppliers do anything
to avoid paying).

We've check and AFIP online invoices use 5 digits always. So, to satisfy
customers/suppliers and make code simpler, we think using 5 digits is a
better option.

To be able to flash the partition on which the IoT Box is executed,
we must create a third partition and install an OS there to be able
to boot on it and flash the partition of the IoT Box

- Creation of the third partition
- Raspbian download and checksum verification
- Installation of Raspbian on the third partition
- Download the IoT image on the Raspbian partition and check the checksum
- Reboot on the Raspbian partition
- Installation of the IoT image on the second partition
- Reboot on the IoT partition
- Cleaning and deleting the third partition

closes odoo/odoo#43591

Task: 2161955
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

We move the main.py controller and the upgrade.html view
in the hw_posbox_homepage module for more consistency

Extend boot partition to 512Mo to be compatible
with a future version of Raspbian and auto flash

Displays the responses of commands
during the execution of the build of an IoT Box

Stock moves records can be unlinked in some cases, for example when
confirming a move containing a kit, the original move is unlinked and
replaced by the moves of the components of the kit.

This commit adds two indices to accelerate the unlink of stock move
records. The fields were the indices are added are foreign key on stock
move, and postgres checks the foreign keys of the rows before deleting
them.

closes odoo/odoo#44337

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

When the "Show Detailed Operations" is enabled on a picking type,
create a immediate transfers with it, validate, unlock and readd
a new detailed operation, save and it will create a move line without
any state. Due this lack of state, the quant won't be updated.

Fix by remove the readonly=False in the state fields
(3f4f77fd), to avoid sending
state:False by the web client.

closes odoo/odoo#44273

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

Issue

    - Studio
    - Add an required html field
    - Create new record
    - Leave it empty

    It is saved

Cause

    The isSet function of FieldHtml widget, have a "/" in the <br> tag
    and summernote empty = <p><br></p>. If you add a space, the value
    becomes <p>&nbsp;&nbsp;   <p>.

Solution

    Remove the "/" and the spaces, check if value != <p></p> &&
    <p><br></p>

OPW-2183687

closes odoo/odoo#44250

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

When a tag has a very long name, on a screen too narrow, the sidebar
overflows outside of the screen and a horizontal scrollbar appears.

By allowing the tags to wrap, the overflow does not occur any more,
excepted if there is a very long word. In that case, we truncate it.

Same goes in the short blog post template, excepted that the parent's
width is already specified.

closes odoo/odoo#44206

Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>

Issue

    - Install eCommerce
    - Add Stripe
    - Pay with invalid cart

    Traceback

Cause

    When I improved stripe error, I didn't checked if
    an error could have no event

Solution

    Check if the error has an event

OPW-2186385

closes odoo/odoo#44398

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

closes odoo/odoo#43312

Signed-off-by: Josse Colpaert <jco@openerp.com>

Steps to reproduce:
- install sales
- create a new quotation

Previous behavior:
the avatar next to the author's name is empty in the mailthread

Current behavior:
avatar is displayed as expected

opw-2187231

closes odoo/odoo#44379

Signed-off-by: mightyjol <jhk-odoo@users.noreply.github.com>

- Activate automatic invoicing after successful payment
- Go to the eCommerce with the public user
- Purchase an item

An error occurs because a `list` has no attribute `id`.

The root cause is the following line:

https://github.com/odoo/odoo/commit/3abe78087a0426ad2783942baa01e1d5fbdff2d9#diff-39d0613187d36f16c541734e80925e9dR556



We want to allow the following scenarios:
- a saleman generates an invoice for its customer but doesn't have
  accounting rights
  => check on `sale.order`
- an accountant generates an invoice from a SO he can read but not
  modify
  => check on `account.move`
- an invoice is generated from a purchase on the ecommerce
  => use of `sudo` in calling methods

opw-2185680

closes odoo/odoo#44364

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Co-authored-by: alt-odoo <alt@odoo.com>
Co-authored-by: Thibault Francois <tfr@openerp.com>

The following steps will reproduce the issue:

1. Activate invoicing in the pos config
2. Start a new session
3. Switch browser to offline mode (or stop the odoo server)
4. Make an order
5. Invoice the order during payment
6. Validate
7. Error shows (which is okay)
8. The problem is that the receipt screen is not shown after validation.
The intended behavior is that the receipt screen will show with
an additional Print Invoice button above the receipt.

The problem is caused by wrong signature of the thrown error
when the _save_to_server is called. The signature understood by
the error handlers is the one by `error` and not by `reason`.

See _handleFailedPushForInvoice which is the main consumer of the
error thrown by the _save_to_server call.

closes odoo/odoo#44355

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Purpose of this commit is pricelist/pricelist item can not
created/modifided linking records of diffrent companies together

closes odoo/odoo#39169

Task: 2090409
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

closes odoo/odoo#43839

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

The copy of a payment acquirer should be disabled by default.

purpose of this commit is to make import template compatible with v13

task-2146510
closes-#42279

closes odoo/odoo#42279

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

As the keywords are added in the DOM and its' table is also toggled at
the same time, we've to put the toggling of the table after the keywords
pushed in to the DOM.

task-2063206

closes odoo/odoo#38931

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

The access right on payment_token is based on the partner_id
linked with the user

If there is token link with the public user,
they are shown for every request were the partner_id is not defined
If you are logged with an internal user with sales access right,
you'll see all the payment_token linked with the acquirer

We should avoid both situation and show only the payment_token
from the legit partner_id
the one of the current user or the one given as parameter

closes odoo/odoo#44319

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
Co-authored-by: Damien Bouvy <dbo@odoo.com>

Open POS, make an order, on the payment screen select email, select a
customer, pay and validate.

The receipt will be not an attachment, but a code image. The side effect
is the visualization dependant on the viewer (email client, webmail,
etc.)

opw-2179303

closes odoo/odoo#44316

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

When revamping the message fetching from the headless browser, since
stacktraces are available (by default) on console.error and
console.warning events I assumed it could / would be useful to show
them in the Python-level log. And they *were* quite useful during the
original fixing stage.

However they turn out not to be very useful day-to-day:

* they add a lot of noise and lead to the error message itself being
  lost in a big block of red / logging.error
* when a tour fails (which is the vast majority of the failures) the
  JS stacktrace always points to the same location in the tour
  manager (the one which goes "this step never succeeded") which is
  completely useless
* aside from being bundled, normal JS code (where the stacktrace could
  be useful) doesn't generally use console.warn or console.error, it's
  going to straight blow up with an exception in which case we always
  get a stacktrace

Leave the stacktrace formatting for console.trace as that's pretty
much the only point of using this instead of console.log.

closes odoo/odoo#44311

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Before this commit, when typing something in the search view in
Japanese, and then clicking on a suggestion from the IME dropdown
menu, the search view menu did not update with selection.

Steps to reproduce:

- Enable Japanese IME in hiragana mode;
- Type "test" in search view;
- Soft-select another suggestion item, e.g. "テスト";
- Double-click on suggestion item "test";

=> The search view menu still detects "テスト".

As a result, clicking on any of these search view suggested filters
picks "テスト" instead of "test".

This commit fixes the issue by updating search menu when clicking
in a suggestion in the IME menu.

opw-2061590

closes odoo/odoo#44304

X-original-commit: 0bca4c0883f2b58842da6a8c1a4e26bf2444d5f3
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

There is nothing left preventing to delete an account.move.line making
the related account.move unbalanced.

closes odoo/odoo#44171

--issue: 2185112
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Under Projects, click on Overview, click on the smart button "Vendor
Bills".

The list will display account moves based only on the analytic account
and not the actual type of the move

opw-2180598

closes odoo/odoo#44302

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, when clicking on a channel mention from a chat
window, it crashed with the following error:

`TypeError: channel.detach is not a function`

This happens due to `MailService.joinChannel()` returning a promise
that is resolved with channel ID, instead of a channel object.
`channel.detach()` becomes `<Number>.detach()`, which is treated
like `undefined()`, hence crash.

closes odoo/odoo#44293

X-original-commit: 80650eb360caff76181c0d919a3c62e602375931
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

`action_invoice_paid` should be called when the computed field
`invoice_payment_state` is set. However, the recomputation doesn't go
through `create` or `write` (since the field is protected).

A workaround  is to call it at reconciliation. Indeed, an invoice can
only be paid when it is reconciled. For invoices with an amount of zero,
we call the method at posting.

closes odoo/odoo#44259

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Fill bank account information for the current company
Create an Invoice by hand, under "Other info" tab the Bank Account
section is filled.
Now create a Sale order, confirm it and create the invoice.

The invoice created from the sale order is missing the Bank Account
section, this in turn disable the QR code generation. Adding th
erequired information when creating the invoice from the sale
order fix the issue

opw-2181580

closes odoo/odoo#44245

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>