Before this commit "parallax" animation was not working in modals.

This commit adds a parameter to the animation effects to enable
animations (triggered by the scroll) in the modals.

Note that for the "Newsletter" popup we have hidden the "parallax"
options. To make them work, it would be necessary to review the
structure of the "Newsletter" popup so that the vertical scrollbar is in
the same location as the "s_popup" snippet (on the ".modal" element).

task-2971402

closes odoo/odoo#111018

X-original-commit: e97f6134
Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>

Since [1] when selecting item images, the 'Blocks' tab is displayed
while the options are refreshed. This is visible because the image
selection awaits an RPC which therefore allows the browser to render
the 'Blocks' tab selected version of the display.

This commit prevents the return to the 'Blocks' tab to be rendered by
waiting for the image info to be obtained on start.

Steps to reproduce:
- Drop an "Items" block.
- Click on an image.
- Click on another image.
=> The options panel flickers on the 'Blocks' tab before showing the
second image's options.

[1]: https://github.com/odoo/odoo/commit/0acc5e784b15d9c963660da3781763448503f33e



task-2821398

closes odoo/odoo#91929

Signed-off-by: Guillaume-gdi <gdi@odoo.com>
Co-authored-by: Benoit Socias <bso@odoo.com>

After unlock a picking/MO, it's possible to change the qty_done of a
cancelled move. This change won't have any result on product's stock.
In this commit, we raise an error when user changing cancelled moves.
We advise user to create a new line instead.

Task-3116125

closes odoo/odoo#110988

X-original-commit: 30737797
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Yuchen Huang (yhu) <yhu@odoo.com>

Steps to reproduce the issue:
. Change the decimal accuracy of the product price to 0
. Create a storable product and set the Vendor Tax
. Create a purchase order with that item.
. Set the unit price to have 0 decimal places. E.g: 20
. Change the demand quantities to 10
. Confirm the purchase order -> Traceback

Bug:
wrong key word arg used for _float_compare for this PR [1]

opw-3136160
[1]:https://github.com/odoo/odoo/pull/105080



closes odoo/odoo#110948

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Currently the Spanish address format does not include the province/state.

This change adds the province between parentheses after the zip code and city.

task-3147965

closes odoo/odoo#110983

X-original-commit: 2c31ad84
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
Signed-off-by: Dylan Kiss (dyki) <dyki@odoo.com>

On tablet view, if the user selects another lot than the one
reserved, we will still keep a reservation for the old one

To reproduce the issue:
(Need mrp_workorder)
1. Create two products P_finished, P_compo:
   - Storable
   - Tracked by SN
2. Update on hand quantity of P_compo:
   - 1 x SN01
   - 1 x SN02
   - 1 x SN03
3. Create a BoM:
   - Product: P_finished
   - Components: 1 x P_compo
   - Operations: 1 x a new operation
4. Create, confirm and assign a MO for 2 x P_finished
5. Start the WO
6. Set a finished lot
7. The consumed lot is SN01, set it to SN03
8. Validate the WO
9. Mark WO as done
   - Do not close the MO
10. Open the detailed operations of the MO

Error: There is a line that consumes SN03, but there is also a line
for SN01's reservation. This is incorrect, while the MO is not
closed, the quant of SN01 has its available quantity equal to 0.

Since we have to create a backorder, we split all SM. Then, we
remove the excess reservation. To do so, we unreserve the raw SM and
then assign it again. Here is the issue: we run the generic assign
process, so it will not consider that there is already a SML with a
done quantity, i.e.: it will ignore the consumed lot and will just
try to reserve the first one it finds (-> SN01)

OPW-3104930

closes odoo/odoo#110950

X-original-commit: b710b230
Related: odoo/enterprise#36265
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

Steps to reproduce the bug:
- Create a storable product “P1”
    - costing method: avco
- Create a PO:
    - Add the product “P1”:
        - Line 1: Qty= 10, price= $50
        - Line 2: Qty=1, price= $10
    - Confirm the PO and receive the product

- Go to purchase → Reporting → Purchase Analysis

Problem:
The average price is incorrect, the current calculation is:

(50 + 10) / 2 = 30

The average should take into account the quantities purchased in each
line, And not simply the number of line, so the correct calculation
should be:

((10 * 50) + (10 * 1)) / 11 = 46.36

The SQL query is correct, it is when applying the read_group that the
calculation is incorrect, we should override it to make a personalized
calculation of the average.

opw-3136406

closes odoo/odoo#110975

X-original-commit: 1369cd18
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

In case of subcontracting, it is not straightforward for a user to
select the appropriate MO on the landed costs form.

To reproduce the issue:
(Need stock_landed_costs)
1. Create two products P_compo, P_finished
    - Storable
    - P_finished:
        - Add a vendor V
2. Create a BoM:
   - Product: P_finished
   - Type: Subcontracting
   - Subcontractors: V
   - Components: 1 x P_compo
3. Process a receipt R:
   - From: V
   - Operations: 1 x P
4. Open the form to create a landed cost
5. Set the Apply On to Manufacturing orders
6. Try to find R

Error: There isn't any reference for R. There is actually the
reference of the manufacturing order (for instance WH/SBC/00001) but
the user can't know that this MO is related to R.

A part of the solution is the partial backport of [1]. Thanks to
this commit, the method `name_get` of the MO will include the name
of the associated receipt in case of subcontracting.

[1] 0e26ed69

OPW-3070543

closes odoo/odoo#110927

X-original-commit: b4bbf30b
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

Currently, the `Send E-waybill` button show in all company no matter what
company is installed.

So In this commit, we check whether the invoice company country code is `IN` or not,
based on that we hide/unhide the `Send E-waybill` button.

closes odoo/odoo#110239

Signed-off-by: Josse Colpaert <jco@odoo.com>

The current VAT check doesn't pass for valid Venezuelan VAT numbers (RIF). Venezuela has a specific method to validate their RIF, very different from the standard VIES check.

This commit adds an implementation of the VAT number validation in Venezuela. The validation is based on
(1) pattern matching
(2) checksum validation

Task id=3094593

closes odoo/odoo#110936

X-original-commit: 4fca8ed2
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Popeler Antoine (anpp) <anpp@odoo.com>

How to reproduce
=================

When entering a very long table name and / or a very long table name on
the point of sale application, the text displayed on the "go back" button of the interface will overflow,
making the name unreadable and not very pleasing to see.

How the fix works
=================

The fix just cut and hide the part of the text that is overflowing

opw-3102914

closes odoo/odoo#108913

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Before this commit, if if the discount policy of the pricelist is set
to "show public price & discount to the customer" and then the unit
price of a product is changed frompoint of sale, a note is added to
the invoice, that shows a "price discount".

This also happens in case of a price increase, which should not happen.

opw-3121143

closes odoo/odoo#110823

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

'survey.user_input' model has an inherit in hr_recruitment_survey module to
link survey answers to applicants. The field is named 'applicant_id' which
leads to issues with 'default_applicant_id' is present in context. This
happens quite often when going from a kanban view notably, as it adds this
filter in context when displaying applicants. Trying to send a recruitment
survey to this applicant fails as it tries to set an ID in a o2m.

In this commit we simply remove the default value in context to avoid issues.
As anyway this model is technical it should not depend on default values.

In master we will rename the field to avoid issues.

Followup of odoo/odoo#63946

Task-3093257 (Mail: The Composer Update)

closes odoo/odoo#110880

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Step:
- Create a product with sale price 120 USD
- Create a giftcard with balance 40 uSD
- Create a free Shipping cost of 40 USD fixed price and freeing above 100 USD
- Go to website->shop, select the product and checkout the cart(the shipping is free because price exceeds 100)
- Add the gift card to payment

Issue:
The shipping price gets from free to 40

Cause:
When computing the cost of the shipping the fact of the presence of a giftcard is not considered.

Solution:
Create a method to returns the amount of giftcard from a sale order and add to total price to check if the shipping is free

opw-3107284

closes odoo/odoo#109298

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

closes odoo/odoo#109418

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

When activating the option "Restrict Template Rendering" the employee
group no longer gets the group automatically via the Implied Groups
field. However this did not have much effect because
- all the existing employees still had the group
- new users had the group via the template user

Remove the group with active_test=False to include the Default
Template User in the list.

Before this commit it was a bit confusing that new users still got the
group by default, even after deactivating the option in the settings.

closes odoo/odoo#109856

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#110824

X-original-commit: 90d2f7bf
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#110778

X-original-commit: 6e1ad549
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

To reproduce the issue:
1. Install Inventory & Purchase apps
2. Toggle on Settings > Inventory > Purchase Agreements and save
3. Go to Purchase
- [Products] > [Products]: add a product w/ internal reference and w/o
- [Orders] > [Blanket Orders]: create a blanket order with the products
- Save, Confirm and click Print icon to generate the said report in pdf

Desired behavior: Do not show brackets for null internal reference

opw-3138636

closes odoo/odoo#110770

X-original-commit: fb0567ee
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Lee, Hansun (hale) <hale@odoo.com>

Prior to this commit, the recipient in the SMS wizard
shows The name of the record.

In this commit, we make the partner the recipient instead
showing The name of the record itself.

task-3000243

closes odoo/odoo#110707

X-original-commit: 16e25eda
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Because of the M2M relation, an account.move.line can be linked to
several sale.order.lines, making the cardinality of sale_line_ids
superior to 1.
Even if it is not possible to obtain this result with standard code,
a custom module could create this situation and posting the invoice
would result in a "ValueError: Expected singleton" exception.

This commit prevents this exception by checking whether the line is
linked to at least one downpayment SO line in the method action_post.
The test also checks that the methods button_draft and button_cancel
behave properly (spoiler alert: they will fail too in 16.0).

closes odoo/odoo#110624

X-original-commit: 3645c8f6
Signed-off-by: Paul Morelle (pmo) <pmo@odoo.com>

before this commit, in the draft state the l10n_de_document_title field value is computed as Repair Order and in other state it is computed as Repair Quotation.

after this commit, in draft state Repair Quotation and in other state Repair Order will be computed in field l10n_de_document_title

closes odoo/odoo#110756

X-original-commit: 542e860c
Signed-off-by: John Laterre (jol) <jol@odoo.com>

Steps to reproduce the bug :
    - In Website (edit mode), drag & drop a "text-image" snippet.
    - Click on the button.
    - Change the size of the button to "small".
    - Click outside the button.
    - Re-click on the button.
    - The size selected in the options is "medium" and not "small".

Note that the same bug exist in backend with the link dialog.

This bug was introduced in ([1]), the code of the "else" (which was
removed by it) made it possible to take into account the cases where the
option had no "value" (e.g. "medium" size button). And so, without this
"else", the options without "value" were activated in any case.

This previous commit, which fixed an issue with the presence of the
"btn-success" class on a link, could in fact be based on what had
already been done for the links with the "btn-link" class (in [2]).

In this commit, this issue with the "btn-success" class is handled the
same way as for "btn-link".

[1]: https://github.com/odoo/odoo/commit/4c68b3e923610e1d573b4bd2b241b2fc5923c412
[2]: https://github.com/odoo/odoo/commit/c3e08e7a7baab1035c3d5c48d668cc02a232e1ac



task-3002177

closes odoo/odoo#102632

Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>

- Install website and set in French
- in the robot wizard you see:
Exemple de règle :
Refuser : /web/login
Autoriser : *

closes odoo/odoo#110706

X-original-commit: 3f8ff00c
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Before this commit, there is no verification while changing a product's
company. That can lead to issue where some operations cannot be done
because of access errors.
To avoid that, this commit prevents to change the product's company if
some quants for this product exist in another company's location.

How to reproduce:
- Have at least two different companies (let say CompA and CompB);
- Create a new product who belong to no company;
- For this product, add quantity on hand in a CompA location;
- Now, change the product's company for the CompB;
- While selected only the CompA, go into the Inventory Adjustments and
  try to create a new inventory adjustment for the CompA location with
  this product's quant -> Access Error.

opw-3095984

closes odoo/odoo#110690

X-original-commit: c123220e
Signed-off-by: Tiffany Chang <tic@odoo.com>

* account, purchase, mrp_account

before this commit, the action name was not getting translated to user language.

after this commit, the action name will get translated to user language.

closes odoo/odoo#110646

Signed-off-by: Tiffany Chang <tic@odoo.com>

before this commit, the lots info shown in the products were always computed, no matter if they were printed or
not.

after this commit, the lot info only is computed when is actually used and will be printed: that is when the user has the
stock_account.group_lot_on_invoice group.

closes odoo/odoo#110642

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Prior to this commit the limit set on accrual plans was in hours but
effectively used as a limit in days in the code.
Meaning that a level with a limit of 240 hours effectively applied a
limit of 240 days (or 1920 hours with 8 hour days).

TaskId-3145560

closes odoo/odoo#110658

Signed-off-by: Kevin Baptiste <kba@odoo.com>

closes odoo/odoo#110675

X-original-commit: d90a7f7b
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

closes odoo/odoo#110671

Signed-off-by: Josse Colpaert <jco@odoo.com>

when bill to is registered person but ship to is unregistered person then we need to set this

Part-of: odoo/odoo#110671

before this commit, in the uninstall hook, the key which is trying to remove from the ir.config.parameter is not existing one.

after this commit, the google.pse.id key will get removed from the icp.

closes odoo/odoo#110650

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Before this commit: if you install the `pos_cache` module and load a point
of sale session it would show the following error:

```
Traceback:
TypeError: Cannot read properties of undefined (reading 'fields')
    at child._loadMissingProducts (.../point_of_sale/static/src/js/models.js:826:37)
```

The problem is that we removed the `product.product` model before
loading the server data to prevent loading them directly.

The solution is to add its model after loading server data.

opw-3115318

closes odoo/odoo#110502

X-original-commit: 2589a2a7
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Current behaviour:
When having the `external_layout_bold` as Document layout,
when printing timesheets, the date column takes too much width
of the table.

Expected behaviour:
Have the columns be proportional, similar to the
`external_layout_standard` layout.

Steps to reproduce:
- Install Timesheet
- Activate Dev Mode
- Change the Document layout to `external_layout_bold`
- Timesheets > List View > Select an item > Print
- Observe that the first columns (with Date) is taking 1/2 of the width

Reason for the problem:
I presume some leftover legacy styling with a `width:48%` for the
first column of a bold_layout table.

Fix:
Remove that legacy styling.

Affected versions:
- 15.0
- saas-15.2
- saas-15.3
- 16.0
- master

opw-3114053

closes odoo/odoo#109626

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Based on RFC3462, a Content-Type text/rfc822-headers
exists and provide a mechanism to label and return
only the RFC 822 headers of a failed message (bounce)

These are only the headers and not the full message.

The Content-Type-Encoding should be either 7-bit(US-ASCII)
or Quoted-Printable (QP) as in the section 2 of the RFC.

Spawn the error:
After getting reported by a customer, I had to reproduce
by spamming wrong outlook addresses and add logging
in a sh database on the message_process of mail_thread.py
and logged the `message` variable.

After few retry, I got one of the part that was defined
as followed:
Content-Description: Undelivered Message Headers
Content-Type: text/rfc822-headers
Content-Transfer-Encoding: quoted-printable

The `get_payload()`function used was only assuming
that there is a full email on that part and that
it could only be encoded as an email, which was not
the case in this situation (quoted-printable:
76 characters per line, character `=` used
as the end of line character).

opw-3064589
task-3131561

closes odoo/odoo#110580

X-original-commit: 4e30d7b6
Signed-off-by: Julien Castiaux <juc@odoo.com>
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Co-authored-by: Baptiste Vergote <bve@odoo.com>

This commit fixes the traceback when the user push the start button
in the Work Order list View of a work order without a date_planned_start.
To recreate the traceback, the order must be based on a manufacturing order
with multiple work orders, with at least one with a scheduled start date and
one without a scheduled start date.
When creating the manufacturing order, it is important to make sure that
only the confirm button is pressed.

closes odoo/odoo#110538

X-original-commit: c4d16a57
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

- Create un SO in EUR with a product with service_to_purchase, with supplier A
- Supplier A work in USD
--> Confirm order
Issue fields.datetime.now() doesn't exist.

closes odoo/odoo#110537

X-original-commit: 39b9bc63
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

The percentage used for A/B test was applied even when
A/B testing was disabled. As that value is 10% by default
the 'total' was innacurate by 90% for most mailings.

task - 3008627

closes odoo/odoo#105834

Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

- Added tags for the new Modelo 303 tax grids: 150, 152, 153, 155, 156, 158
- Added new 0% and 5% taxes (used for ceratain food and electricity)
- Added new 0% and 0.62% Recargo de Equivalencia taxes
- Added fiscal position and Modelo 303 tag mappings for all new taxes

References:
- https://sede.agenciatributaria.gob.es/static_files/Sede/Disenyo_registro/DR_300_399/archivos_23/DR303e23.xlsx
- https://www.boe.es/buscar/doc.php?lang=es&id=BOE-A-2022-22685



Thanks to @pedrobaeza for the input

task-2993087

closes odoo/odoo#110592

Related: odoo/enterprise#36115
Signed-off-by: Josse Colpaert <jco@odoo.com>

For companies having a Chart of Accounts that inherits from an ancestor CoA linked to the taxes, the current tax update script did not work.
This change also supports this case.

Part-of: odoo/odoo#110592