MailTemplate model has a 'partner_to' field is dynamically rendered to contain
partners being recipients. After rendering it should hold a comma-separated
list of partner IDs.

However as we are unsure it was correctly written better be defensive. We now
check that we can effectively transform items to IDs using 'isdigit()'.

Task-2612945 (Mail: Defensive email formatting)

Part-of: odoo/odoo#74474

If leads are created using live chat, users without CRM rights cannot
access the visitors list anymore because the lead/opportunity
information is not available to them.

This commit limits the display of `lead_count` to the
`sales_team.group_sale_salesman` group.

In 14.0, the column still appeared without the `lead_count` value
displayed, but clicking on it raised a traceback.

Steps to reproduce:
- Install `website_crm_livechat`
- Login as Mitchell Admin
- Send a message in the live chat
- Go to Discuss
- Answer the livechat message with `/lead New`
- Go to Settings / Users / Marc Demo
- Remove the Sales rights
- Logout
- Login as Marc Demo
- Go to the Website / Reporting / Visitors page

=> The page could not be reached and an access right error message was
generated.

opw-3475301

closes odoo/odoo#133581

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Apparently `lxml.html.document_fromstring` (and possibly other
`lxml.html` loaders) parses byte-strings as latin1 regardless of their
actual encoding, maybe because python2, maybe because there's a super
legacy html4 parser underlying it.

Either way that means ever since loading
`static/description/index.html` files was added 10 years
ago (4bf6a7ea) `_get_desc` has been
loading these files in latin1 rather than the utf8 most people would
expect.

Add an explicit decoding phase to try and load html description files
in UTF8. Fall back to latin1 in case there are description files which
are genuinely in latin1, or even just some random-ass broken stuff
which very much isn't utf8 (the extended-ascii encodings -- of which
latin1 is one -- will happily accept and mangle any input as every
byte value is valid, utf8 is a lot more structured).

Closes #127846

closes odoo/odoo#133731

X-original-commit: 4dbc3b00
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

In Saudi Arabia, the InvoiceLine/ID should not be greater than 6 digits.
Using the move.line_id, this limit can be exceeded.

Simply count the invoice line ids starting from 1 instead.

In master, add a parameter `line_id` to `_get_invoice_line_vals`.

closes odoo/odoo#133590

Signed-off-by: Josse Colpaert <jco@odoo.com>

Bug:
When printing DDT documents for a delivery with a pricelist applied, the
total value shown comes from the product's original price and not the
modified pricelist price.

Setup:
- install `sale_management` and `l10n_it_stock_ddt`
- have a product P with a price A
- create a pricelist that where P has a price B

Steps to reproduce:
- activate DDT report printing
- create a quotation set the pricelist you created and the product P
- validate the quotation
- go to the associated delivery and validate it
- print the DDT report

You should see that the price mentioned on the DDT report does not
account for the pricelist. (price A is shown, instead of B)

opw-3171295

closes odoo/odoo#121424

Signed-off-by: Josse Colpaert <jco@odoo.com>

For some reason, “New” has been translated as “Nieuw” in Bulgarian, but
this is not Bulgarian, this is Dutch.

This commit replaces all occurrences of “Nieuw” with “Нов”, which is the
correct translation for “New” in Bulgarian.

closes odoo/odoo#133582

Related: odoo/enterprise#46542
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>

The test `test_ddt_flow` was failing because the picking types were created
without a ddt sequence. This is because the picking types were created
at the moment the company was created. However, the country of the company
was set after the setup of the CoA. This means that when we were creating
the picking types, the company's country was not Italy, therefore no
DDT sequence was created.

This commit fixes this by overriding the `setup_company_data` method to
add the country while creating the company and its CoA.

Fixes runbot error 24396 & 24397

closes odoo/odoo#133434

Signed-off-by: Josse Colpaert <jco@odoo.com>

Don't do it only at install.

closes odoo/odoo#132062

Signed-off-by: Nicolas Seinlet (nse) <nse@odoo.com>

A check was added to prevent importing records with prefixes of existing
modules: https://github.com/odoo/odoo/pull/130825

 . This queries the
known modules, but non-admin users don't have access to that by default,
causing the import to fail for them. Allow the module query regardless
of access rights.

closes odoo/odoo#133300

Signed-off-by: Raphael Collet <rco@odoo.com>

After this commit, we prevent the slideshow from appearing when clicking
on an "Images Wall" snippet image that has been set as a link.

Steps to reproduce the bug:

- Drag and drop an "Images Wall" snippet onto the page.
- Add some images in the snippet.
- Click on an image within the snippet.
- In the editor text toolbar, click on the "Link" button.
- Set the URL of the link to "/contactus".
- Click on the "Save" button in the modal.
- Save the page.
- Click on the image with the link.
- Bug: The slideshow briefly appears before redirecting to the "contact
us" page.

task-3425624

closes odoo/odoo#128885

Signed-off-by: Colin Louis (loco) <loco@odoo.com>

The condition to create is wrongly evaluated and does not take into account
the country code and the picking type code. This commit fixes this by
reordering the conditions.

closes odoo/odoo#133146

Signed-off-by: Josse Colpaert <jco@odoo.com>

When a model selection record is going to be deleted, a _process_ondelete method is called in order to delete all the records of the corresponding model that have that selection. These records are obtained by calling _get_records, which uses a query that needs a table. Thus, we should avoid cases for non-abstract models that have _auto = False.

closes odoo/odoo#132751

Signed-off-by: Raphael Collet <rco@odoo.com>

It's possible to specify an existing module as the xml id prefix when
importing records from a file. This will result in `ir_module_data`
records being created with `noupdate` set to False. When the module is
upgraded, these records will be deleted.

This can lead to undesired side effects like journal items for
accounts imported this way being deleted.

This change prevents creating new records linked to existing modules
when importing from a file. Instead, the user should either use no
prefix or the name of a non-existent module, like `__import__`.

opw-3231987

closes odoo/odoo#130825

Signed-off-by: Merel Geens <mege@odoo.com>

closes odoo/odoo#68375

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

Part-of: odoo/odoo#68375

This reverts commit 95468505.

The commits break the preview, as docs is not defined in preview (while done in real printing).
Not sure what we will do, with a check on the presence of the field or not, as it was working fine before, only a wrong modification of a view made it visible.
Linked to runbot error 24276

closes odoo/odoo#132639

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

This PR odoo/odoo#125747 missed the account 973, which is still not in Ukrainian.
This account should be translated as well.

closes odoo/odoo#132866

Signed-off-by: Josse Colpaert <jco@odoo.com>

The overriding of the placeholder does not work.
It's done to be different than the standard translation (Ciudad).
Modified it to be standard way of overriding placeholders.
Linked to runbot error 6175

closes odoo/odoo#132833

Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>

steps to reproduce it:
1. Create a storable product, add a Purchase vendor with
 start date = 20/6/2022 and delay = 56
2. Create another storable product, add the same Purchase vendor with
 start date = 11/01/2023 and delay = 21
3. For both products, add Routes "MTO".
4. Create a SO with those 2 products, and confirm it
5. As you can see, the price of the first product is correctly set
but not the second product

BUG:
This is due of "Order Deadline" (date_order) being set to an old date,
which is before the second product date_order.

FIX:
set max PO date as today

opw-3167094

closes odoo/odoo#124448

Related: odoo/enterprise#44391
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

There was inconsistency in the translation for the words "price unit", with this
 commit all the "price unit" are translated the same.

closes odoo/odoo#121413

Task-id: 3262408
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

This PR solve two things:
- Preview: due to the hardcoded width the preview didn't take all the page and
was push on the left.
- PDF: Weird stuff happened with the header, he was hiding information below
 the header.

Task-id: 3262408
Part-of: odoo/odoo#121413

Before this PR, when there is no shipping address, the pdf show an empty
"Shipping Address" header. By changing the colspan dynamically we can manage to
keep the layout like it was and remove the useless section.

Task-id: 3262408
Part-of: odoo/odoo#121413

When the user tries to import the invoice file with space on both sides
of the date value the error will be generated.

Steps to reproduce:
1. Install the `account_edi_ubl_cii` module.
2. Generate one `factur-x.xml` file or import this file
https://drive.google.com/file/d/1RCqLT37j2g6LPkauf75LpOzZt64XHd_L/view?usp=drive_link
3. Go to the invoice app and click the `upload` button.
4. Select the `factur-x.xml` file and an error will be generated at the backend
and nothing to be imported.

This commit fixes the issue by removing the extra spaces in the date value,
if user gives the spaces in the invoice file.

see-
https://github.com/odoo/odoo/blob/a0ea6302a574624604cad7d0903711b30a4802a6/addons/account_edi_ubl_cii/models/account_edi_xml_cii_facturx.py#L315



sentry-4331059603

closes odoo/odoo#129374

Signed-off-by: Laurent Smet (las) <las@odoo.com>

1) The aim of this commit is to make the tax template more consistent with
the instanciated tax.
Indeed a tax wouldn't pass the constrains if it hadn't all its
repartition line.

2) Make the refund consistent with the rest of the taxes.

closes odoo/odoo#130706

Task-id: None
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

When the user configures the 'external_layout_din5008' layout template in the
general settings and tries to any QWeb reports, that case generates the
traceback.

Steps to reproduce:
- Install the 'l10n_de' and 'sale_timesheet' modules.
- Settings > General Settings
- Search for 'Document Layout' and configure the 'external_layout_din5008'
  layout.
- Settings > Technical > User Interface > Views
- Search the 'external_layout_din5008'  QWeb template view.
- Search  '<span t-if="not o and not docs">
<t t-esc="company.l10n_de_document_title"/></span>'
  line and replace by,
'<span t-if="company"><t t-esc="company.l10n_de_document_title"/></span>'
- Go to the Sales menu and print any reports from the print menu.
After that, a traceback was generated.
Error:
AttributeError: 'res.company' object has no attribute 'l10n_de_document_title'
Template: l10n_de.external_layout_din5008

The 'l10n_de_document_title' field does not exist in the 'res.company'
object and also this field used in 'l10n_de.external_layout_din5008'
template, and this template is configured as layout.  So, remove this line from
this template.
Code reference:
https://github.com/odoo/odoo/blob/14.0/addons/l10n_de/report/din5008_report.xml#L109



Sentry-4283510443

closes odoo/odoo#128559

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

Turkey has adapted its standard VAT from 18% up to 20%
This commit sets the 18% VAT taxes and its tax group to inactive and
introduces the respective 20% taxes and a 20% tax group.

closes odoo/odoo#132340

Task-id: None
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Co-authored-by: Ramazan Subaşı <subasiramazan@gmail.com>

The error can be raised either when a move is in state done or cancel. However, the error message only says we cannot split split if the move is in done, which can be misleading.

closes odoo/odoo#132205

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

before this commit, in date field browser is
showing previously selected values as autocomplete
suggestions, which makes hard for end user to
select date from the date picker

after this commit, browser autocomplete is
disabled from date picker

closes odoo/odoo#123606

Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>

Steps to reproduce
==================

- Go on a 14.0 runbot
- Open dashboard

```
TypeError: Cannot read properties of undefined (reading 'split')
    at Class.changeLayout
```

Cause of the issue
==================

`.oe_dashboard` isn't rendered on an empty dashboard

opw-3469183

closes odoo/odoo#132254

Signed-off-by: Romain Estievenart (res) <res@odoo.com>

before this commit, the confirmation message
to use web printer was not translatable
to user language

after this commit, confirmation message will
be shown in user's language

closes odoo/odoo#127930

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

In odoo/odoo/pull/126249 the german balance sheet report was updated and tag tag_de_liabilities_bs_B was removed from account_account_tags_data.xml. This deletes it from ir_model_data so that the ORM doesn't delete this record. This is done so that it doesn't break if another table was already using this tag.

closes odoo/odoo#131530

Signed-off-by: Laurent Smet (las) <las@odoo.com>

This field was never intended to be editable, and indeed all the views
on mail.channel.partner I could find either don't list the field at
all, or explicitly make it readonly.

The editability is actually an artefact from when related fields were
changed from editable by default to readonly by default, all existing
fields were bulk-set to `readonly=False` in
3f4f77fd with the intent of eventually
reviewing this status. That eventuality apparently never came to be,
and so most of those fields are probably flagged `readonly=False` for
no reason to this day.

closes odoo/odoo#126641

Signed-off-by: Louis Wicket (wil) <wil@odoo.com>

Broken by commit [1], where only the `url_to` should've been part of the
check for 301/302. The rest of the `if` was about relative URL check,
routing map check and converter check, all related to 308 only.

Note that in the meantime, commit [2] was added in those checks and
needs to be part of 301/302 too.

[1]: https://github.com/odoo/odoo/commit/14a850976711431f36b7f889ea9cf31b1114513d
[2]: https://github.com/odoo/odoo/commit/26fa923f6ab01298bf1a1e9f6a615c9aa9e2e5ed

Fixes https://github.com/odoo/odoo/issues/129290



closes odoo/odoo#129410

Signed-off-by: Benoit Socias (bso) <bso@odoo.com>

Steps to reproduce:
- Go to `/blog`.
- Enable "Show Sidebar" in the "Customize" menu.
- Edit the page.
- Click on an icon of the "Follow Us" section of the sidebar.
- Click on the "Link" icon of the editor toolbar.

=> An error popup appears.

In further versions, the link parameters can be edited - but they are
lost upon save.

The social media links sections of the blog and blog post pages is
generated and is not supposed to be editable.

This commits makes these social media links sections non editable.

If a user needs to configure such a content specifically, it can be done
inside the "About Us" section of the sidebar above.
E.g.:
- Deactivate the "Follow Us" section from the "Customize" menu.
- You can use copy/paste to duplicate the existing style of the
"About Us" section if you want.
- Click on the "File / Image" icon of the editor toolbar (or type
"/image" to use the Power Box as of 15.0).
- Select a pictogram.
- Click on the "Shape: Circle" icon of the editor toolbar.
- Select the "Font Color" from the editor toolbar.
- Click on the "Link" icon of the editor toolbar to specify an URL.

opw-3450880

closes odoo/odoo#131058

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Some external tools send email as pure html (no multipart) and when
parsing such email we ends up having the raw HTML as body (text)

This commit ensure we correctly parse and sanitize the body as HTML
for such emails.

closes odoo/odoo#130489

Task-id: 3451889
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#129482

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Currently, When the user is adding a double hyphen or space or anything within a
comment in a view's architecture and tries to save the view, then an error
occurs.

To reproduce the issue:
1. Go to Settings > Technical > Views > open a view.
2. In View Architecture comment out a line.
3. Add a double hyphen or space or anything within the comment.
4. Then save manually, the error will occur.

To solve this issue the error has been handled using a try-except block in
'parse_html' method.

sentry-4306359331

closes odoo/odoo#129969

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>