closes odoo/odoo#43312

Signed-off-by: Josse Colpaert <jco@openerp.com>

Steps to reproduce:
- install sales
- create a new quotation

Previous behavior:
the avatar next to the author's name is empty in the mailthread

Current behavior:
avatar is displayed as expected

opw-2187231

closes odoo/odoo#44379

Signed-off-by: mightyjol <jhk-odoo@users.noreply.github.com>

- Activate automatic invoicing after successful payment
- Go to the eCommerce with the public user
- Purchase an item

An error occurs because a `list` has no attribute `id`.

The root cause is the following line:

https://github.com/odoo/odoo/commit/3abe78087a0426ad2783942baa01e1d5fbdff2d9#diff-39d0613187d36f16c541734e80925e9dR556



We want to allow the following scenarios:
- a saleman generates an invoice for its customer but doesn't have
  accounting rights
  => check on `sale.order`
- an accountant generates an invoice from a SO he can read but not
  modify
  => check on `account.move`
- an invoice is generated from a purchase on the ecommerce
  => use of `sudo` in calling methods

opw-2185680

closes odoo/odoo#44364

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Co-authored-by: alt-odoo <alt@odoo.com>
Co-authored-by: Thibault Francois <tfr@openerp.com>

The following steps will reproduce the issue:

1. Activate invoicing in the pos config
2. Start a new session
3. Switch browser to offline mode (or stop the odoo server)
4. Make an order
5. Invoice the order during payment
6. Validate
7. Error shows (which is okay)
8. The problem is that the receipt screen is not shown after validation.
The intended behavior is that the receipt screen will show with
an additional Print Invoice button above the receipt.

The problem is caused by wrong signature of the thrown error
when the _save_to_server is called. The signature understood by
the error handlers is the one by `error` and not by `reason`.

See _handleFailedPushForInvoice which is the main consumer of the
error thrown by the _save_to_server call.

closes odoo/odoo#44355

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Purpose of this commit is pricelist/pricelist item can not
created/modifided linking records of diffrent companies together

closes odoo/odoo#39169

Task: 2090409
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

closes odoo/odoo#43839

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

The copy of a payment acquirer should be disabled by default.

purpose of this commit is to make import template compatible with v13

task-2146510
closes-#42279

closes odoo/odoo#42279

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

As the keywords are added in the DOM and its' table is also toggled at
the same time, we've to put the toggling of the table after the keywords
pushed in to the DOM.

task-2063206

closes odoo/odoo#38931

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

The access right on payment_token is based on the partner_id
linked with the user

If there is token link with the public user,
they are shown for every request were the partner_id is not defined
If you are logged with an internal user with sales access right,
you'll see all the payment_token linked with the acquirer

We should avoid both situation and show only the payment_token
from the legit partner_id
the one of the current user or the one given as parameter

closes odoo/odoo#44319

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
Co-authored-by: Damien Bouvy <dbo@odoo.com>

Open POS, make an order, on the payment screen select email, select a
customer, pay and validate.

The receipt will be not an attachment, but a code image. The side effect
is the visualization dependant on the viewer (email client, webmail,
etc.)

opw-2179303

closes odoo/odoo#44316

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

When revamping the message fetching from the headless browser, since
stacktraces are available (by default) on console.error and
console.warning events I assumed it could / would be useful to show
them in the Python-level log. And they *were* quite useful during the
original fixing stage.

However they turn out not to be very useful day-to-day:

* they add a lot of noise and lead to the error message itself being
  lost in a big block of red / logging.error
* when a tour fails (which is the vast majority of the failures) the
  JS stacktrace always points to the same location in the tour
  manager (the one which goes "this step never succeeded") which is
  completely useless
* aside from being bundled, normal JS code (where the stacktrace could
  be useful) doesn't generally use console.warn or console.error, it's
  going to straight blow up with an exception in which case we always
  get a stacktrace

Leave the stacktrace formatting for console.trace as that's pretty
much the only point of using this instead of console.log.

closes odoo/odoo#44311

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Before this commit, when typing something in the search view in
Japanese, and then clicking on a suggestion from the IME dropdown
menu, the search view menu did not update with selection.

Steps to reproduce:

- Enable Japanese IME in hiragana mode;
- Type "test" in search view;
- Soft-select another suggestion item, e.g. "テスト";
- Double-click on suggestion item "test";

=> The search view menu still detects "テスト".

As a result, clicking on any of these search view suggested filters
picks "テスト" instead of "test".

This commit fixes the issue by updating search menu when clicking
in a suggestion in the IME menu.

opw-2061590

closes odoo/odoo#44304

X-original-commit: 0bca4c0883f2b58842da6a8c1a4e26bf2444d5f3
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

There is nothing left preventing to delete an account.move.line making
the related account.move unbalanced.

closes odoo/odoo#44171

--issue: 2185112
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Under Projects, click on Overview, click on the smart button "Vendor
Bills".

The list will display account moves based only on the analytic account
and not the actual type of the move

opw-2180598

closes odoo/odoo#44302

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, when clicking on a channel mention from a chat
window, it crashed with the following error:

`TypeError: channel.detach is not a function`

This happens due to `MailService.joinChannel()` returning a promise
that is resolved with channel ID, instead of a channel object.
`channel.detach()` becomes `<Number>.detach()`, which is treated
like `undefined()`, hence crash.

closes odoo/odoo#44293

X-original-commit: 80650eb360caff76181c0d919a3c62e602375931
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

`action_invoice_paid` should be called when the computed field
`invoice_payment_state` is set. However, the recomputation doesn't go
through `create` or `write` (since the field is protected).

A workaround  is to call it at reconciliation. Indeed, an invoice can
only be paid when it is reconciled. For invoices with an amount of zero,
we call the method at posting.

closes odoo/odoo#44259

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Fill bank account information for the current company
Create an Invoice by hand, under "Other info" tab the Bank Account
section is filled.
Now create a Sale order, confirm it and create the invoice.

The invoice created from the sale order is missing the Bank Account
section, this in turn disable the QR code generation. Adding th
erequired information when creating the invoice from the sale
order fix the issue

opw-2181580

closes odoo/odoo#44245

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce the problem:

- Have user A with B2B group.
- Have user B with B2C group.
- Add simultaneously on both - via write - another group (or call `_check_one_user_type`).

Expected result:

- No problem

Got result:

- Error "A user cannot have both Tax B2B and Tax B2C..."

That's because the check is performed for more than one user each time, while it has
to be record per record. The implementation of `_has_multiple_groups` actually
checks if the passed recordset is only one record, and if not, it looks directly for all
existing users, so also the case of both users A and B being in the same B2x group, but
having a 3rd user in the other group will fail.

Revisiting the query in `_has_multiple_groups`, there's a hidden error when you use it
for only one ID because a missing space.

closes odoo/odoo#44282

X-original-commit: 83f104b2
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Activate the VIES online check
- Create a partner of type Company and add several contacts
- Set the VAT number, save

A call to VIES is done for each contact.

The field VAT is propagated from the parent company to the children,
triggering the check on all partners. This is not problematic for local
checks since those are fast. However, online checks take time which can
lead to a timeout of the request if there are many contacts.

Since the check is triggered through a constraint (`check_vat`), only
one record at a time is checked. Therefore, it is not possible to build
a local list of the VAT numbers to avoid duplicated verifications inside
a single transaction.

The solution is to store the result in cache. Since the call to the
external API may fail (e.g. timeout), we extract the check to store only
the successful calls.

Closes #43939
opw-2181744

closes odoo/odoo#44281

X-original-commit: 0c7a3e95
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#44244

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

* remove misleading documentation about a "test failed" message, in
  13.0 any uncaught exception or console.error will cause the current
  test to be interpreted as failed
* fix tour manager to console.error its step and not add a second
  useless error message
* fix menu tester to try and display the failure cause on failure
* improve qunit's test reporter to print the number of tests failed in
  case of test suite failure

Should make test failures in tours a bit clearer.

closes odoo/odoo#44264

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

The issue is: the user wants to send an invoice to a customer, changes
the email template, and after the onchange, the field "Template" of the
wizard is empty.

Here is what happens.  The onchange on the template renders a PDF file
with the corresponding invoice document.  The rendering builds some
assets to convert the invoice to a PDF document, and former assets are
deleted.  The deletion of former assets (`ir.attachment` records)
invalidates the whole record cache, which implicitly clears all the
fields of the record of the onchange.

The problem is that the asset is systematically invalidated by the
rendering of the report itself.  This hack changes the CSS assets to
introduce company-specific colors for the rendering of reports.  This
implementation is actually not consistent with the fact that assets are
kept in cache by the server.

This patch does not fix the root cause of the problem, but it reduces
the sides effects of it, and makes the issue above less frequent.  It
simply consists in not updating the asset's attachment when its value is
already correct.

OPW 2168623
OPW 2171040

closes odoo/odoo#44225

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

opw-2122776
* CompAuxNum should be the code of the account concatenated with the id
of the client
* It should be popuated only if it is a receivable/payable

The problem is the export of the partner ID in the column G
"CompAuxNum". We only export the ID of the linked customer/vendor. When
they import the FEC into their software to make tax declarations and
annual accounts. The system will notice if an account is filled in in
the column G and will override the account in column E with the ID of
the partner. As the ID is not a real account, they cannot use the FEC to
import correctly.

closes odoo/odoo#43985

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Was still using the old "selection:" form instead of ir.model.field.selection

closes odoo/odoo#44221

Related: odoo/enterprise#8014
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#44212

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Fixes #44133
Before this commit, the Bank account on the new Bill created from the PO was not set due to missing methods to set those fields.

This commits adds missing methods to set Bank account.

closes odoo/odoo#44136

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

match_total_amount_param on account.reconciliation.model is not
respected when paying a vendor bill through bank statement because
the amounts from both the statement line and the move line that
are used in the comparison will be negative.

closes odoo/odoo#44230

X-original-commit: 1a9221584f78fc7619277c2c0e9b9659e7c80ee2
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

The default journal depends on the company define in the context or the company in the environment
In case of online signature/payment of a SO in a different company then the public user
The company will be wrong and the journal_id as well
It lead to a fail of the payment since the payment could not be reconciled with the invoices

This is happening because the force_company is not taken into account for the default journal

This commit take the force_company into account, it take the precedences on the default_company

closes odoo/odoo#44231

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

As this race condition seems not possible to be reproduced in local, all this
is an assumption based on the logs.

After the checkout, the user is redirected to `/shop/confirmation` where there
is RPCs fired every seconds to fetch the payment status
(`/shop/payment/get_status`).

As the test was considered as finished on that page, sometimes the RPC would
still be processed in python while the tour was considered done and killed,
thus also the cookies, session & co.
From that point, the python would crash when accessing the session.
In the logs, the python crash in the RPC call occurs after the test is done.

closes odoo/odoo#44222

X-original-commit: bc11b1ec
Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>

closes odoo/odoo#44189

X-original-commit: 7b259eb4
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Issue

    - Contacts
    - Import a contact that will be a portal user
    - Test import

    Activation email sent

Cause

    Testing an import do the whole process including sending an email
    because of force_send (email not rollbacked).

Solution

    Check if we are testing the import. If yes, do not force
    send the email. So, the email will be rollbacked.

OPW-2168868

closes odoo/odoo#43724

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue

    If month - 1 or month - 2 are in the previous year, the filter is
    incorrect.

    ex: Date = Jan. 2020, Filter = Dec. 2019
        => last_year__last_month = 2018-12 instead 2019-12

Cause

    If date is 2020-01-20

    Selecting December => adding param "last_month"
    Selecting 2019 => adding param "last_year"

    Applying "last_month" => date become 2019-12-01
    Applying "last_year" => date become 2018-12-01

Solution

    Detect the right year to activate by default
    when a month is selected and no year is selected.
    With that solution it is not possible to get records in Jan. 2020
    or in Dec. 2019 only for instance but the global functioning
    of date filters stays the same as before.

OPW-2169528

closes odoo/odoo#44092

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Co-authored-by: Jason Van Malder <jvm@odoo.com>

- Create and validate a leave
- Go to Time Off > Everyone
- In the Gantt view, move the leave

Nothing prevents the modification of the leave while is it validated.

opw-2179839

closes odoo/odoo#44096

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

When we name_search a res.user, we have a special hack so we will
firstly perform an exact search on the res.users login, if none is found
we will search over res.users name.

This is intended but in the case of negative search since 660cebb4,
for example operator='not ilike' and name='test' would probably just
return all user that do not have a login that is exactly test.

This is not the intended behavior, in this instance we should just
return user that do not have "test" in their names.

Without fix, added test would fail on:

- .name_search('vlad', operator='not ilike') => finding everyone but
  user with exactly login vlad instead of user not containing vlad in
  their name

- .name_search('', operator='not ilike') => find all users instead of
  finding no user

- .name_search('lad', operator='not ilike') => find all users instead of
  just finding "Nothing similar"

opw-2170517
closes #44040

closes odoo/odoo#44148

X-original-commit: 2378fb63
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

This commit fixes the traceback while previewing SMS template when there
are no records available.

TaskID 2180132
PR #44080

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Before this commit, while retaking a survey with 'Retry' button, the test
mode was not retained leading to unexpected behavior. This commit fixes the
issue by populating required parameters while retrying the survey that ensures
proper behavior for both test and non-test entries.

Task ID 2170720
Closes #43806

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Avoid display errors with special characters when copying the href attribute
of links in the web editor.

opw-2078313

closes odoo/odoo#44163

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The delivery slip report on stock picking always read the product
description not the one the picker set on stock moves.

This commit takes the stock move description for the report when displaying
stock moves and stock move lines

Task : 2180347

closes odoo/odoo#43878

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

The 'Show Detailled Operation' setting on picking type makes the
entire operation tab readonly if set to 'True'.
This could be confusing as the description and date expected fields are
readonly depending on this setting.

This commit makes sure the stock move fields keep their readonly
attribute (or not) independently of the show detailled setting.

Task : 2180347