Somehow followup of dbb6cfdb . Purpose is
to use formataddr from tools instead of manually handcrafting the full
email address format. Indeed the tools one correctly encapsulates and
format name and email.

Task ID 2068986

Otherwise status of notifications is not correctly updated when sending them
on the bus.

Task ID 2068986

closes odoo/odoo#39062

X-original-commit: f097f07f
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Before this commit, if the user clicked on a company which have no company logo, the system did not let him create a contact.

opw-2086824

closes odoo/odoo#39054

X-original-commit: e3fe7a9af00b7afa5b03d5dcaac1d8f135cb1ea5
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>

60 is different of 060. The 060 is the correct value for the afip code
in this case (EUR). Apply to all the numeric values in the currency afip
codes.

closes odoo/odoo#38953

X-original-commit: 8c47c7f0
Signed-off-by: Josse Colpaert <jco@openerp.com>

X-original-commit: 4a0c8846

Since we are not using document only in invoice by now we remove the
option to incoude receipts.

closes odoo/odoo#38842

X-original-commit: af0703f9
Signed-off-by: Josse Colpaert <jco@openerp.com>

Have an event in Mexico timezone
As a begin date, choose something in the morning
As a end date, choose 18:00 in that timezone (or later)
in the same day
The end date will be written as the day after at 00:00 in UTC

Before this commit, the event was considered taking more than one day
Also, the rendering on the website took the wrong widget, and did not
transform the UTC dates into their TZ value

After this commit, the event is considered taking place in the same day
The rendering on the website is correct

OPW 2087828

closes odoo/odoo#39060

X-original-commit: 4514ff30
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

Tests can fail when they are run at the moment when `fields.Date.today`
is different from `fields.Date.context_today`.

closes odoo/odoo#39079

X-original-commit: 0405f4a3
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Instead of showing a traceback, show a user-friendly error message
to the user to avoid recursive pos.category.

closes odoo/odoo#38803

X-original-commit: babcbf8a
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#39067

X-original-commit: e398db87
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

* Install pos_hr
* Create new user [DEMO] (change password and save the user id)
* In POS session settings, uncheck "Login with Employees"
* Log in with [DEMO]
* Start a new POS session
* From the Employee page delete the record matching [DEMO] user id
* Process a transaction from the POS

Several error message will popup. This is due to
https://github.com/odoo/odoo/commit/26274dbb9720743461be2a70de02bf4c1ea377f4


which introduced a faulty matching between the id of user who start the pos
and an employee with the same id.
Assigning the single properties as before the change fix the issue

opw-2087591

closes odoo/odoo#39052

X-original-commit: c51e91cd
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#39042

Taskid: 2081660
X-original-commit: 5f3f58a4
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Install Accounting, create a journal entry, post it, reverse it with
a date in the future.

The reverse entry will be posted, instead it should stay a draft (with
the appropriate 'auto_post' set to True)

opw-2083121

closes odoo/odoo#38802

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

On a time off request, if the 'Time Off Responsible' (leave_manager_id)
is not set, then the SUPERUSER_ID is taken as time off responsible for the
validation.

Before falling back on OdooBot, include the parent_id of the employee,
aka the manager, as a valid responsible.

closes odoo/odoo#39041

Task: 2072111
X-original-commit: 1e1b9b40
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Task 2034073
The reconciliation widget is now entirely part of the enterprise version
as it is an advanced accounting feature

closes odoo/odoo#38424

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

- added CoA
- added standard input/output taxes with rate 17% and few others

closes odoo/odoo#39045

Task: 1966308
X-original-commit: eea6171d6990e98f99f14bb511b5fd08d0c0d7e7
Signed-off-by: Josse Colpaert <jco@openerp.com>

A user get a AccessError during a valid flow on the website shop
due to a attachment search (with website_sale_digital installed) :
- As a portal user buy a product and pay with wire tranfer (or other)
- Check the your quotation with this user and we get a AccessError
for the read ir.attachment model.

The bug comes from the website_sale_digital module which add a search
on ir.attachment for each product (allows digital product sell,
eg. ebook) on the controller rendering orders. To fix this issue, add
a sudo call before the search. It is legit because only the name and
date is retrieved and the download (of the digital product) checks
the access of this product attachment (if user already paid for it).

TASK_ID : 2004031

closes odoo/odoo#39043

X-original-commit: c757e14c
Signed-off-by: ryv-odoo <ryv-odoo@users.noreply.github.com>

Description of the issue/feature this PR addresses:
In pivot, when we click on '+', it must open the selection box at
the point where we click.

Current behavior before PR:
The box opens at the top of the page

Desired behavior after PR is merged:
The box opens at the point where we click

id=2066675

closes odoo/odoo#39034

X-original-commit: 989df08f
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Purpose
=======

Let's say that the field 'foo' is tracked and defined with a res.group.

When the field is modified, a mail.tracking.value is generated, but the
reference to the field name is a char field.

When displaying the mail.tracking.values on the chatter, a check is done
according to the field group to decide whether we should display it or not
to the user. See: odoo/odoo@c7aa8c5#diff-ad8b6db158187579d2208f233d993c3cR43

So if I rename the field, and if the mail.tracking.value is not modified,
the mail.tracking.value magically appears to the users who shouldn't
access it before.

Note: If the migration is correctly handled, this shouldn't be the case.
But manual manipulations on the database could lead to this issue.

Specification
=============

If the field referenced by the mail_tracking_value doesn't seem to exist,
then display its value to system users only, by security.

closes odoo/odoo#39033

Taskid: 2088634
X-original-commit: ae1e70eb
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

When timeoff is 1 day or 0.5 days then it was not going to
correctly display timeoff number on approval page due to momment.

For 1 day leave the date_to and date_from as equal so momment diff will
be 0 days and floating is off for diff so not display 0.5 for floating leave.
even we enable floating it will display the wrong floating based
on 24 hours instead of 8 working hours a day.

so get the number_of_days from db and display on leave same as department
leave summary.

Task-2071031

closes odoo/odoo#39032

X-original-commit: 6953620f
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Replace lunch.order.temp wizard by lunch.order (fp request)

closes odoo/odoo#35585

Taskid: 2048667
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

This test was raising an assert error if the DB has other websites than  the
data/demo ones.

As we have a new module in Odoo 13.0 (https://github.com/odoo/design-themes/pull/178

)
which is creating 25 websites, and since the design-themes runbot is now
running tests, we were having a red design-themes runbot.

closes odoo/odoo#39008

X-original-commit: 5c7b4463
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Before this commit, the trash icons and "OR" indicator of each filter
was too far and couldn't be seen

Now, both of them are closer to the filter and can be seen in any circumstance.

Task 2073707

closes odoo/odoo#39026

X-original-commit: 87a91c78
Signed-off-by: Julien Mougenot (JUM) <Arcasias@users.noreply.github.com>

Since 62c9deda, when accessing a website
connected as portal or public user, the themes images are not showed. An
error is arose 'Sorry, you are not allowed to access documents of type
'Attachment' (ir.attachment)'.

Now, the portal and public user have access to the themes images.

opw-2082468

closes odoo/odoo#39025

X-original-commit: 9b8c390cd5526556346356f260a9cfe1b90cd510
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Co-authored-by: Lucas Perais <lpe@odoo.com>

Since https://github.com/odoo/odoo/commit/f896afcc8a54eae3efcdf034e3fd256942f7fa78

,
(un)archive all triggered toggle_active on all records, which doesn't consider
whether we want to archive/unarchive and on which records...

Closes #38903

closes odoo/odoo#39022

X-original-commit: 2c89cb0c
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Snippets with side margins look quite compressed between full width
snippets. This commit adds an option in the side-menu to control whether
a section is stretched or not. This option is available everywhere it
would have a reasonable visual impact (the cutoff was arbitrarily chosen
to be that the stretched section is at least 5% larger than the
unstretched version)

task-2080570

closes odoo/odoo#38852

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Assets bundle creation will try to find previous version of assets and unlink them.
This needs to invalidate ormcache to notify other workers.

Since assets are never commited during test, assets will be generate at each request if request is
not commited (cursor closed) whtch is the case with 404.

Invalidating the orm cache only when a previous attachement was existing will help to
mitigate the problem, and slightly improve HTTPCases test speed.

closes odoo/odoo#38979

X-original-commit: d4d63549
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

A 404 will take 3 to 5 seconds to be resolved and execute +- 1900 query, to return
a rendered page which is quite expensive, especially when multiple missing images
are rendered in a view.

Catching static route and marking them as not frontend will help to avoid to handle miss
on static resources. In this case server returns a standard 404.

This commit also fix a iframe src in order to avoid a 404 on
/web/(test )/report/html/some_report (thx to aab-odoo)

X-original-commit: 818d0cb5

Without this patch, if a view defines a `<label for="forbidden_field"/>` anywhere, the web client tries to fetch the field data, but since the user has no access, it gets an error.

Now, if the label targets a forbidden field, it gets removed from the view, as happens with the related field. The client doesn't know of that field's existence and no errors happen.

closes odoo/odoo#38876

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Update the translation files to reflect the changes

closes odoo/odoo#38999

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#38967

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

Before this commit launch a server with --db-filter that match at least 2 dbs name
Try to authenticate

You will have an error request is unbound when you try to access request.env

Now we retrieve the user from self instead of the request.

New test to ensure rpc authentication is tested.

Related to commit 245ef4b1

closes odoo/odoo#38969

X-original-commit: 4b3400c4
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

closes odoo/odoo#37987

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

To be compliant with the indian law, some informations should be
displayed on the receipt in the POS.

So we've added the customer name and phone nulber if any. We've also
added the HSN code of products for each line.

closes odoo/odoo#36590

Task-id: 2000231
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Commits df2ea31f and 55ed70f4 moved things around,
"without any functional change".
They made it so that if you add twice a product to the cart,
they are added in different lines instead of merged.

There are two issues:
- the `if line_id: return lines` made sense when the post-filtering
was in the same function, since it could readily be avoided
- conversely the post-filtering was avoided in the function that was added with
the only goal to do it, except in the case where it was useless
(the case where lines is an empty recordset).

opw 2083729

closes odoo/odoo#38938

X-original-commit: c9c0a0c322f02974bc6395410ca3d7213899c7e0
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

Users sometimes define custom models on SQL views
e.g. @nseinlet
In such a case, Odoo should not attempt to create foreign keys
as it just cannot work on views.

This could prevent the migration of a database
with such a custom model using a view
when it attempted to fix the missing foreign keys
when updating the modules.

closes odoo/odoo#38988

X-original-commit: dfaea03d
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

closes odoo/odoo#38986

X-original-commit: 534e5fbc
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

- Buy anything with de POS and generate a receipt.

Before this commit:

The currency symbol is missing everywhere.

After this commit:

The currency symbol is present next to any price.

closes odoo/odoo#38970

Opw: 2083186
X-original-commit: e6528dd8
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, the account_render_report tour assumed that
account_accountant was installed on any enterprise database.

Now, the account_accountant steps are only inserted in the tour
when the module is installed.

closes odoo/odoo#38963

X-original-commit: a45a4b6c
Signed-off-by: Julien Mougenot (JUM) <Arcasias@users.noreply.github.com>