The function `_get_possible_combinations` generates possibles combinations
 for the product template attribute values (ptav) of each product template
 attribute line (ptal) of a given product template. It used to iterate over
 them using a cartesian product. A combination can be invalid if it
 contains two incompatibles ptav. The problem is that it used to filter out
 invalid combinations after generating them. It's a problem because there
 can be a lot of invalid combinations to filter out before finding a valid
 combination. Even before the first valid combination if the first ptav of
 the two first ptal are incompatible.

The solution brought by this commit is to reject the invalid combinations
 while building them rather than after. It does so by using a cartesian
 product implementation with early rejection. The algorithm tests each
 ptav when incorporating it in a partial combination and if it's
 incompatible, it goes to the next partial combination and thus skips all
 combinations starting with the invalid partial combination.

The client that reported the issue has a product template with about 25
 ptal with an average of 9 ptav. The ptav of the first ptal was
 incompatible with the first ptav of second ptal. It had to build and
 filter out 5.76*10^15 ptav before finding the first valid ptav. If we
 generate 10^6 ptav by second (it's much less) user would get first ptav
 after 182 years. Now it's instantaneous.

opw-2335936

closes odoo/odoo#65089

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Because of context:

{'search_default_account_id': [active_id]}

refreshing on the tax audit action could cause an error because in normal
use case we have active_id that is never an account.account id (but for
example an account.tax.report.line).

There doesn't seem to be any use case where that context is useful since
it was introduced in 2017 (81089042), this action is always used with an
overriden context. So this commit is removing it.

opw-2388448

closes odoo/odoo#65698

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

such fields have store=True, but they don't exist in table.

---

https://github.com/odoo/odoo/pull/65232#issuecomment-773298323
https://github.com/odoo/odoo/commit/02417290191c22c9c99e6dc96a572c21f38e64f1



closes odoo/odoo#65535

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

The Lesotho Loti has the symbol M and not L
Example of use:
http://lestimes.com/businessman-xie-in-m27-million-scandal/
http://lra.org.ls/sites/default/files/2020-10/LRA%20Integrated%20Annual%20Report%202019.pdf



Fixes odoo/odoo#62807

closes odoo/odoo#65633

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Previously, the many2one widget from the web_editor used jQuery's
'.html()' method when inserting a record name into the page. The record
name was not HTML-escaped before this, which may have unexpect result
and break the layout.

This commit fixes that by using the '.text()' method instead.

This bug only affects pages containing a many2one (contact excluded)
at the time of selection and not after the selection.
e.g. on the /event page, changing the category of an existing event
via the website editor

closes odoo/odoo#65610

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#65590

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

- Install stock
- Go to Inventory > Configuration > Settings and enable "Lots" and "Storage Locations"
- Create a Product tracked By Lots (i.e. Product X)
- Go to Inventory > Operations > Inventory Adjustments
- Create an Inventory Adjustment for Product X:

     Product   |   Location   |   Lot/SN   |   Real Quantity
 -------------------------------------------------------------
    Product X  |   WH/Stock   |   LOT 01   |       20
    Product X  |   WH/Stock   |            |       10

- Validate Inventory
- Go to Inventory > Operations > Transfers and create one:
  * Source Location: WH/Stock
  * Destination Location: WH/Stock/Shelf1
  * Operation Type: Internal Transfers
  * Operations:
    [Product: Product X, Initial Demand: 25]
- Save Transfer, Mark As Todo and Check availability
- Click on list icon of Operation line for Product X to display Detailed Operations
- 20 units of LOT 01 and 5 units without lot have been reserved
- Set LOT 01 for the 5 reserved units without lot and confirm
- Open Detailed Operations again
- There are now 20 units of LOT 01 and 5 units of LOT 01
- Remove the row with 5 units and confirm
- Check availability and open Detailed Operation
- There is now only a row with 25 reserved units of LOT 01
- Unreserve
The following errror is raised:
"It is not possible to unreserve more products of P than you have in stock."

It happens because the system is not able to manage quants with lots and
wihtout lots at the same time. When modifying the move line to 25
reserved units. It's composed of 20 quants with lot and 5 quants without
lot. And when unreserving it will check if there is a quants with 25
units with the lot and if it's not found 25 units without lot. But never
25 units of quants with lots and without lots.

opw-2419444

Close #64497

closes odoo/odoo#65057

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Follow-up of https://github.com/odoo/odoo/pull/65357



closes odoo/odoo#65470

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Steps:
- Install mrp, stock
- Go to Inventory > Configuration > Operation Types
- Edit Delivery Orders:
  - Show Detailed Operations: Checked
- Go to Master Data > Products
- Create two products (1) (2)
- Click (1)
- Click the "Bill of Material" smart button
- Create a BoM:
  - BoM Type: Kit
  - Component: (2)
- Go to Overview
- Click Delivery Orders
- Create a Delivery Order:
  - Add (1) with an initial demand of 1
- Mark as ToDo
- Click Edit:
  - Detailed Operations tab:
    - Add (1) with a done quantity of 1
- Validate and create a Backorder

Bug:
Record does not exist or has been deleted.
(Record: stock.move(60,), User: 2)

Explanation:
When confirming a `stock.picking` with `mrp` installed, the action goes
through `action_explode()`.
https://github.com/odoo/odoo/blob/d9ea1d5f054f05197581acf67c8a9c1e6acb8d02/addons/mrp/models/stock_move.py#L154
This action splits the components of the product with a Kit (`phantom`)
BoM instead of manufacturing it. When everything is split, the
`stock.move` unlinks itself because it has been replaced with its
components. `action_explode()` then returns the new components. Trying
to call a method on the unlinked move will result in an error.

This commit replaces the move with the newly generated component moves.

This is safe to do in `stock` because the non-overridden
`_action_confirm()` returns the move it was called on as seen here:
https://github.com/odoo/odoo/blob/d9ea1d5f054f05197581acf67c8a9c1e6acb8d02/addons/stock/models/stock_move.py#L790



opw:2450016

closes odoo/odoo#65462

Signed-off-by: backspac <backspac@users.noreply.github.com>

Steps:
- Edit the current company (1):
  - Country: Switzerland
  - Currency: CHF
- Install l10n_ch
- Go to Invoicing > Configuration > Bank Accounts
- Edit Bank:
  - Bank Account: create a new one:
    - Account Holder: (1)
- Go to Configuration > Journal
- Edit Customer Invoices:
  - Advanced Settings tab:
    - Communication Standards: Switzerland
- Go to Customers > Customers
- Create a new customer (2):
  - Fill in street, city, zip code and country
- Edit (2):
  - Contacts & Addresses tab:
    - Add:
      - Select Invoice Address
      - Contact Name: Keep this field blank
- Go to Customers > Invoices
- Create a new one:
  - Customer: "(2), Invoice Address"
  - Add a product
- Validate it
- Click Print QR-Bill

Bug:
Traceback here:
https://github.com/odoo/odoo/blob/b76e9ef658bde0178fa1660b6ad27b880e91632a/addons/l10n_ch/models/res_bank.py#L129


TypeError: 'bool' object is not subscriptable

Explanation:
The contact name of an address is optional. When nothing is filled in
that field, it returns `False`, hence the error.
Using the commercial company name ensures a name is put in the invoice,
even if the contact doesn't belong to a company.

opw:2447158

closes odoo/odoo#65357

Signed-off-by: backspac <backspac@users.noreply.github.com>

Filling the new column in SQL is dramatically faster than doing it via
the ORM, which iterates over all the records in the table.

The test case is creating a related field for 100+ records with distinct
values.  Setting the field's value was taking more than 100 queries.  It
now takes 3 queries.

task-2449313
opw-2380445
opw-2389376
https://github.com/odoo/enterprise/pull/15910



closes odoo/odoo#65232

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

In a multicompany environment, when a expense is created from the
expense email alias, the expense account is computed with SUPERUSER
context, so depending on the SUPERUSER set company, we could get
a mismatch of expense and employee's company and the account one, wich
causes a subsequent error when trying to post the expense.

closes odoo/odoo#63188

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

When using the windows installer in French language, the `Hôte` label
used to configure postgresql server does not display correctly.

The LangString documentation does not specify how to use the special
characters but after some tests, specifying a BOM for the nsi file seems
to be the way to go.

closes odoo/odoo#65354

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Steps:
- Go to Accounting > Configuration > Accounting > Bank Accounts
- Create a new Bank Account
  - "Bank Account" field: create and edit a new one
    - Account Holder: Anyone but your company
- Save

Bug:
Validation Error: The holder of a journal's bank account must be the
company (YourCompany).

Explanation:
The error is not clear enough. Users may be confused because this
validation error appears upon saving a "Bank Account Journal"
(`account.journal`) but is talking about "Partner Bank Account"
(`res.partner.bank`) which is a field of the "Bank Account Journal".

opw:2448183

closes odoo/odoo#65281

Signed-off-by: backspac <backspac@users.noreply.github.com>

closes odoo/odoo#65228

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

We should open the cashdrawer when paying with a non cash payment
method if change should be returned to the customer.

Use case: The customer wants to pay 10€ more with his card to get 10€
in cash in return.

closes odoo/odoo#65246

Taskid: 2449312
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Before this commit, the o_we_selected_image class was not removed from
forum post when saving.

task-2312878

closes odoo/odoo#63071

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Before this commit, the preview of the dragged snippet didn't work
when moving a dragged snippet from a drop zone to an other drop zone
when there was no space between those drop zones.

It is because, in this case, the over event of the second drop zone is
triggered before the out event of the first drop zone.

task-2312878

closes odoo/odoo#61871

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Issue occurs due to the way we compute the default value in base ir ui view.
The method _compute_defaults don't set extension mode under some condition
even if we provide an inherit_id view.

This commit double fix it, we use now self.env['ir.ui.view'] to create the
new view and so always compute the mode based on 'if inherit id or not'.
Second fixes is to explicitely set mode manually as 'extension'.

before commit:
when you drop snippet to blog sidebar and click save button.
The changes of user is not visible in sidebar because view created in mode
'primary' and not 'extension'

task-2311520

closes odoo/odoo#65182

X-original-commit: a944ce9b
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: jpr-odoo <jpr@openerp.com>
Co-authored-by: Jairo Llopis <jairo.llopis@tecnativa.com>

Since 129de297, the port was no longer
added to the URL of the box when using HTTP.

closes odoo/odoo#65179

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

task-2312878

closes odoo/odoo#64740

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Manual backport of commit done in 13.0 odoo/odoo@227c8fb53265de03b202133c4e8012b8bcce01b4

before this commit:

while changing subtypes of the project it was only
propagating those subtypes to the task, whose parent_id is set.
internal subtypes are not propagating in the task of a project.

So, filter internal subtypes and concat them with the subtypes which
have parent_id.

after this commit:
internal subtypes will also propagate to their tasks

LINKS

Task ID-2205643
Task ID-2241688
COM PR #56775

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Currently, the subtype checked selection is not saved when the user adds and
removes subtypes. Indeed either an addition is performed, either a removal
but having both is not correctly taken into account when updating an existing
subscription.

How to reproduce
  * click on the pencil icon to edit the subscription of the follower;
  * as an example default "Discussions" will be the only one selected;
  * check "Notes" and save;
  * -> this works;
  * click again on the pencil icon and uncheck "Notes" and check "Activities"
    then save;
  * -> this does not work as only removal is performed (Activities is not
    checked);

The problem only occurs when you unchecked subtypes and checked other ones.

This commit fixes that behavior by taking into consideration both new
subtypes and subtypes to remove.

LINKS

Task ID-2205643
Task ID-2241688
COM PR #56775

Co-Authored-By: Thibault Delavallee <tde@odoo.com>
Co-Authored-By: Shahista Pathan <sat@odoo.com>

Manual backport of commit done in 13.0 odoo/odoo@9e7092a03f6c44287c661e2b39a943d240aa2bde

This commit contains a followup / rewrite / backport of #34150 :

  * odoo/odoo@16dd3da
  * odoo/odoo@0b11ed8

Fix: propagate generic internal subtypes from parent to childs with auto
subscribe.

  With this commit, when the user subscribes to internal subtypes like
  activities on a parent record (e.g. a project) then the user follows them
  by default on every sub record creation (e.g. all new tasks of this project).

Fix: do not reset existing subtypes when changing parent of a record using
auto subscribe mechanism.

  With this commit, when changing subtype subscription from a parent record
  (e.g. project) avoid resetting all subtypes subscription on existing sub
  records (e.g. all new tasks of this project). Only new records will use the
  parent chosen subtypes. This is done through propagation of followers
  existing policy (see Follower._insert_followers() for more details);

Note that fix done here is slightly different from the one done in odoo/odoo@16dd3da
as there was some mismatch with internal model-related subtypes. Thix fix
will be forward ported and improve the previous one.

Task ID-2205643
Task ID-2241688
COM PR #56775

Co-Authored-By: Thibault Delavallee <tde@odoo.com>
Co-Authored-By: Alexandre Khun <aku@odoo.com>
Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

Manual backport of commit done in 13.0 odoo/odoo@ad210729da4bf72dad77acc4030a38478340f4c6

We recently found a bug about generic internal subtypes not being correctly
propagated when doing auto subscribe.

For example: subscribe to a project, check an internal subtype like activities.
Auto subscribe done on project tasks should include actitivities subtype but
is currently not the case.

This test highlights the issue and a fix will be provided soon. In this test
we check both

  * generic subtype propagation (comment- or activities- like subtypes);
  * model-specific subtype propagation through parent relationship (like
    following New Task on project to follow New on task);
  * internal subtypes not being propagated to portal users;
  * auto subscribe at create with both create and parent follower reasons;

LINKS

Task ID-2205643
Task ID-2241688
COM PR #56775

Co-Authored-By: Thibault Delavallee <tde@odoo.com>
Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

Steps to reproduce the bug:

- Let's consider 3 companies C1, C2, C3 where C1 and C2 are childs of C3
- Let's consider 3 employees E1, E2, E3 respectively in C1, C2, C3
- Create a user U with administrator access rights in Leaves and U is linked to E3
- Log as U in C3
- Create a Leave Type LT with no company
- Create a leave LT  LT1 for E1 and LT2 for E2
- Change your current company to C2
- Click on LT1

Bug:

An access right error was raised

opw:2431572

closes odoo/odoo#65068

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Force the quantity reserved on stock move line to be readonly to avoid
de-synchronisation with the reserved quantity on the quants.

Back-port of 08394c89

closes odoo/odoo#65044

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

The protocol and port to use when printing orders were hardcoded. This
resulted in errors when using the POS in HTTPS as the browser blocked
non-HTTPS requests on the page.

closes odoo/odoo#64814

Taskid: 2413240
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

closes odoo/odoo#64953

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

When installing Odoo dependencies (from `requirements.txt`)
in Python 3.8, the installatio process of psycopg2 2.7.3.1 fails.

closes odoo/odoo#64612

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Due to this commit https://github.com/odoo/odoo/commit/1d00daf235b654018162138efac09efb56aa7c98

It was not possible to set an analytic account/tag with no company on a reconcialtion model

Ps: The field company on model account.analytic.account/account.analytic.tag is not required

Backport of https://github.com/odoo/odoo/commit/733582516f8797ec51066fd94d644c43a959b2e5



opw:2426413

closes odoo/odoo#64842

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

The answers are currently added to question from the event_type_id on
create. This caused that if you duplicated an event, the answers would
be duplicated since we go through create a second time.

opw-2425120
closes #64795

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Steps to reproduce:

1. Enable Project Subtasks
2. On the "Office Design" Project, select a Task and create a subtask for it
3. Go to the Project Overview and Create Sales Order
4. Enter timesheets: 11 hours for the parent task, and 10 hours for the subtask
5.  On the created Sales Order check the invoiced time

Current behavior:
The 11 hours form the parent task are shown as delivered in the Sales Order, but the 10 hours from the subtask are not.

Expected behavior:
Both the parent ans subtask time should be shown as delivered, so that it can be invoices.

Closes #63930

opw:2426098

closes odoo/odoo#64791

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Issue

	- Connect on smartphone (or use chrome debug mode to switch to mobile view)
	- Install "Ecommerce" module
	- Add a delivery method D with a price on product P
	  and publish it
	- Go to shop and add product P to your cart
	- Go to payment and switch delivery method

	Total amount above the summary is not updated.

Cause

	Update is done on JS when delivery method is changed.
	No targeting Total Amount in summary head card (seen only on small device).

Solution

	Add ID on Total Amount in summary head card element and update it with JS
	in same time as other fields (taxes, total, ...).

opw-2424355

closes odoo/odoo#64640

Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

Before this commit, a participating badge was displayed on the event even if
the user's registration has been canceled. This is a strange behavior.

After this commit, the participating badge will be hidden if all the user's
registration have been canceled.

Task ID-2432546

closes odoo/odoo#64422

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#64644

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>