When using the windows installer in French language, the `Hôte` label
used to configure postgresql server does not display correctly.

The LangString documentation does not specify how to use the special
characters but after some tests, specifying a BOM for the nsi file seems
to be the way to go.

closes odoo/odoo#65354

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Steps:
- Go to Accounting > Configuration > Accounting > Bank Accounts
- Create a new Bank Account
  - "Bank Account" field: create and edit a new one
    - Account Holder: Anyone but your company
- Save

Bug:
Validation Error: The holder of a journal's bank account must be the
company (YourCompany).

Explanation:
The error is not clear enough. Users may be confused because this
validation error appears upon saving a "Bank Account Journal"
(`account.journal`) but is talking about "Partner Bank Account"
(`res.partner.bank`) which is a field of the "Bank Account Journal".

opw:2448183

closes odoo/odoo#65281

Signed-off-by: backspac <backspac@users.noreply.github.com>

closes odoo/odoo#65228

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

We should open the cashdrawer when paying with a non cash payment
method if change should be returned to the customer.

Use case: The customer wants to pay 10€ more with his card to get 10€
in cash in return.

closes odoo/odoo#65246

Taskid: 2449312
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Before this commit, the o_we_selected_image class was not removed from
forum post when saving.

task-2312878

closes odoo/odoo#63071

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Before this commit, the preview of the dragged snippet didn't work
when moving a dragged snippet from a drop zone to an other drop zone
when there was no space between those drop zones.

It is because, in this case, the over event of the second drop zone is
triggered before the out event of the first drop zone.

task-2312878

closes odoo/odoo#61871

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Issue occurs due to the way we compute the default value in base ir ui view.
The method _compute_defaults don't set extension mode under some condition
even if we provide an inherit_id view.

This commit double fix it, we use now self.env['ir.ui.view'] to create the
new view and so always compute the mode based on 'if inherit id or not'.
Second fixes is to explicitely set mode manually as 'extension'.

before commit:
when you drop snippet to blog sidebar and click save button.
The changes of user is not visible in sidebar because view created in mode
'primary' and not 'extension'

task-2311520

closes odoo/odoo#65182

X-original-commit: a944ce9b
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: jpr-odoo <jpr@openerp.com>
Co-authored-by: Jairo Llopis <jairo.llopis@tecnativa.com>

Since 129de297, the port was no longer
added to the URL of the box when using HTTP.

closes odoo/odoo#65179

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

task-2312878

closes odoo/odoo#64740

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Manual backport of commit done in 13.0 odoo/odoo@227c8fb53265de03b202133c4e8012b8bcce01b4

before this commit:

while changing subtypes of the project it was only
propagating those subtypes to the task, whose parent_id is set.
internal subtypes are not propagating in the task of a project.

So, filter internal subtypes and concat them with the subtypes which
have parent_id.

after this commit:
internal subtypes will also propagate to their tasks

LINKS

Task ID-2205643
Task ID-2241688
COM PR #56775

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Currently, the subtype checked selection is not saved when the user adds and
removes subtypes. Indeed either an addition is performed, either a removal
but having both is not correctly taken into account when updating an existing
subscription.

How to reproduce
  * click on the pencil icon to edit the subscription of the follower;
  * as an example default "Discussions" will be the only one selected;
  * check "Notes" and save;
  * -> this works;
  * click again on the pencil icon and uncheck "Notes" and check "Activities"
    then save;
  * -> this does not work as only removal is performed (Activities is not
    checked);

The problem only occurs when you unchecked subtypes and checked other ones.

This commit fixes that behavior by taking into consideration both new
subtypes and subtypes to remove.

LINKS

Task ID-2205643
Task ID-2241688
COM PR #56775

Co-Authored-By: Thibault Delavallee <tde@odoo.com>
Co-Authored-By: Shahista Pathan <sat@odoo.com>

Manual backport of commit done in 13.0 odoo/odoo@9e7092a03f6c44287c661e2b39a943d240aa2bde

This commit contains a followup / rewrite / backport of #34150 :

  * odoo/odoo@16dd3da
  * odoo/odoo@0b11ed8

Fix: propagate generic internal subtypes from parent to childs with auto
subscribe.

  With this commit, when the user subscribes to internal subtypes like
  activities on a parent record (e.g. a project) then the user follows them
  by default on every sub record creation (e.g. all new tasks of this project).

Fix: do not reset existing subtypes when changing parent of a record using
auto subscribe mechanism.

  With this commit, when changing subtype subscription from a parent record
  (e.g. project) avoid resetting all subtypes subscription on existing sub
  records (e.g. all new tasks of this project). Only new records will use the
  parent chosen subtypes. This is done through propagation of followers
  existing policy (see Follower._insert_followers() for more details);

Note that fix done here is slightly different from the one done in odoo/odoo@16dd3da
as there was some mismatch with internal model-related subtypes. Thix fix
will be forward ported and improve the previous one.

Task ID-2205643
Task ID-2241688
COM PR #56775

Co-Authored-By: Thibault Delavallee <tde@odoo.com>
Co-Authored-By: Alexandre Khun <aku@odoo.com>
Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

Manual backport of commit done in 13.0 odoo/odoo@ad210729da4bf72dad77acc4030a38478340f4c6

We recently found a bug about generic internal subtypes not being correctly
propagated when doing auto subscribe.

For example: subscribe to a project, check an internal subtype like activities.
Auto subscribe done on project tasks should include actitivities subtype but
is currently not the case.

This test highlights the issue and a fix will be provided soon. In this test
we check both

  * generic subtype propagation (comment- or activities- like subtypes);
  * model-specific subtype propagation through parent relationship (like
    following New Task on project to follow New on task);
  * internal subtypes not being propagated to portal users;
  * auto subscribe at create with both create and parent follower reasons;

LINKS

Task ID-2205643
Task ID-2241688
COM PR #56775

Co-Authored-By: Thibault Delavallee <tde@odoo.com>
Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

Steps to reproduce the bug:

- Let's consider 3 companies C1, C2, C3 where C1 and C2 are childs of C3
- Let's consider 3 employees E1, E2, E3 respectively in C1, C2, C3
- Create a user U with administrator access rights in Leaves and U is linked to E3
- Log as U in C3
- Create a Leave Type LT with no company
- Create a leave LT  LT1 for E1 and LT2 for E2
- Change your current company to C2
- Click on LT1

Bug:

An access right error was raised

opw:2431572

closes odoo/odoo#65068

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Force the quantity reserved on stock move line to be readonly to avoid
de-synchronisation with the reserved quantity on the quants.

Back-port of 08394c89

closes odoo/odoo#65044

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

The protocol and port to use when printing orders were hardcoded. This
resulted in errors when using the POS in HTTPS as the browser blocked
non-HTTPS requests on the page.

closes odoo/odoo#64814

Taskid: 2413240
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

closes odoo/odoo#64953

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

When installing Odoo dependencies (from `requirements.txt`)
in Python 3.8, the installatio process of psycopg2 2.7.3.1 fails.

closes odoo/odoo#64612

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Due to this commit https://github.com/odoo/odoo/commit/1d00daf235b654018162138efac09efb56aa7c98

It was not possible to set an analytic account/tag with no company on a reconcialtion model

Ps: The field company on model account.analytic.account/account.analytic.tag is not required

Backport of https://github.com/odoo/odoo/commit/733582516f8797ec51066fd94d644c43a959b2e5



opw:2426413

closes odoo/odoo#64842

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

The answers are currently added to question from the event_type_id on
create. This caused that if you duplicated an event, the answers would
be duplicated since we go through create a second time.

opw-2425120
closes #64795

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Steps to reproduce:

1. Enable Project Subtasks
2. On the "Office Design" Project, select a Task and create a subtask for it
3. Go to the Project Overview and Create Sales Order
4. Enter timesheets: 11 hours for the parent task, and 10 hours for the subtask
5.  On the created Sales Order check the invoiced time

Current behavior:
The 11 hours form the parent task are shown as delivered in the Sales Order, but the 10 hours from the subtask are not.

Expected behavior:
Both the parent ans subtask time should be shown as delivered, so that it can be invoices.

Closes #63930

opw:2426098

closes odoo/odoo#64791

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Issue

	- Connect on smartphone (or use chrome debug mode to switch to mobile view)
	- Install "Ecommerce" module
	- Add a delivery method D with a price on product P
	  and publish it
	- Go to shop and add product P to your cart
	- Go to payment and switch delivery method

	Total amount above the summary is not updated.

Cause

	Update is done on JS when delivery method is changed.
	No targeting Total Amount in summary head card (seen only on small device).

Solution

	Add ID on Total Amount in summary head card element and update it with JS
	in same time as other fields (taxes, total, ...).

opw-2424355

closes odoo/odoo#64640

Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

Before this commit, a participating badge was displayed on the event even if
the user's registration has been canceled. This is a strange behavior.

After this commit, the participating badge will be hidden if all the user's
registration have been canceled.

Task ID-2432546

closes odoo/odoo#64422

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#64644

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

This fixes some details and reorganize the order of the tutorial. It
also introduces a more detailed section for the SCSS customization. A
very detailed and updated version of this tutorial is being made for the
14.0 version and later.

task-2440442

closes odoo/odoo#64593

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

closes odoo/odoo#64656

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

If we're to change the invoice policy of a product we'd provoke a
chained computation of every sale line and sale order containing such
product. This change goes along with the policy of applying such changes
only to future orders, as stated here: https://github.com/odoo/odoo/pull/61135



closes odoo/odoo#64506

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

This reverts commit c071f0255fba3b8340182607fe4ef70321691341
(See PR https://github.com/odoo/odoo/pull/64201)

Reason: the fix is incorrect, it creates another issue:
https://github.com/odoo/odoo/issues/64548



closes odoo/odoo#64597

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Before this commit, if the user had a fiscal position for his current country,
it wouldn't be used to compute the price of the products on the eshop.
Note that:
  - the price would be correct on the cart, as those prices are coming from a
    sale order which correctly retrieves the fiscal position.
  - if the fiscal position is directly set on the partner, prices are correct
    on the eshop

Step to reproduce:
  - Set Belgium as country on Portal user's partner
  - Create a 0% tax and a 15% tax
  - Create a fiscal position mapping 15% tax to 0% tax for Belgium country
    automatically detected
  - Create a product with 1000$ price and 15% tax set on it
  - Enable pricelist and select tax included in settings
  - Create a pricelist for Belgium and add a rule for the product you created
    to set a fixed price of 500$
  - Now visit eshop with Portal user

The test product show 575$ instead of 500$ in eshop, while it will correctly
show 500$ in cart.

opw-2423215

closes odoo/odoo#64477

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

If an email was sent with empty "To:" and a proper alias in "CC:" (or any of the similar valid headers that conform the `rpc_tos_localparts` array), before 40ae36b7 the email wouldn't get rejected. After that commit it would get bounced.

This comes from the not-so-obvious new python idiom used, `all()`. Check this out:

```python
>>> all([False])
False
>>> all([])
True
```

So, apart from the fix introduced in that commit, which seems valid, we have to make sure `email_to_localparts` actually has contents. Otherwise we are producing false bounces here.

@Tecnativa TT23437

closes odoo/odoo#49656

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Before this commit:

-when moving a snippet using the drag and drop button, two drop zones
instead of one was added at the initial location of the dragged
snippet.

-when moving a snippet using the drag and drop button, no drop zone
was added at the initial location of the dragged snippet if the snippet
was alone in its parent. For example, the left jumbotron in the banner
snippet.

-the drop zones handled by the "children rules" were never vertical
when it was necessary.

This commit also refactors the code to avoid some duplicated lines.

task-2312878

closes odoo/odoo#61336

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

This is mandatory for PA customers, and required by several enterprise customers as well.

Related Ticket: 2425845

closes odoo/odoo#64056

Signed-off-by: Josse Colpaert <jco@openerp.com>

If we change ``active_model`` in context, we have to reset active_id(s),
otherwise we read a random records which may not exist.

STEPS:
1. Activate Developer mode
2. Go to Settings > Technical > Automation > Automated Actions
3. Define a new Automated Action with the following settings:
- Model: Lead/Opportunity
- Action To Do: Execute Python Code
- Trigger: Based on Form Modification
- Trigger Fields: Customer (crm.lead)
- Python Code:
```
raise Warning(records)
```
4. Go to Contacts, create a new contact and save it.
5. Click on the "Opportunities" Smart Button on the top left of the contact record.
6. Click "Create".

BEFORE: ``records`` in context read crm.lead, while id is for res.partner
record

AFTER: ``records`` is None

---

opw-2424392

closes odoo/odoo#64223

Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

This fix partly reverts the commit db691dbe
The latter is fully reverted in v13: 6a5271b7

When having an invoice with total equals to 0, it still adds a line to
the follow-up report.

To reproduce the error:
1. Go to Accounting > Customers > Invoices
2. Create an invoice without Payment Terms and product at 0$ to have a total of 0$
3. Go to Accounting > Customers > Follow-up Reports > [Select the partner]
4. The invoice is present with a total due of 0$

Err: the invoice shouldn't be in the follow-up report.

OPW-2419268

closes odoo/odoo#64214

Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

Issues
- In a database with a lot of locations (more than 10K)
- Search by location in the product tree view with the complete name of
the most "parent" location
- We get a memorry error due to a giant SQL request:
`psycopg2.ProgrammingError: memory exausted at near "(" ...`
It is due to the `_get_domain_locations_new` which return a giant domain
with a tons of `(location_id.parent_path', '=like', ...)` for location.
Because the `_get_domain_locations` makes a ilike on the complete name,
it will match parent but also all child of this parent (because of the
complete works expected if there are loc of type 'view' between).
If there are 10K child location of `WH/Stock`, it will
match all child and the `_get_domain_locations_new` will return
a extremely huge domain with a lot of useless condition.

To Solve
Minimize the domain created by the
`_get_domain_locations_new`, avoid duplicate `parent_path` condition:
e.g. `'|', ('location_id.parent_path', '=like', 'WH/Stock/%')
('location_id.parent_path', '=like', 'WH/Stock/Shell/%')`
can be represented only by the first condition.
We can also search all childs and add condition on ids before
but it removes the optimization done in this method.

opw-2379464

closes odoo/odoo#64133

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

backport of 58456523

closes odoo/odoo#64308

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>