Before this commit, the selector 'o_cp_top_left' was used to target
a descendent element. The 'o_cp_top_left' class was added in this commit
odoo/odoo@533db5991a5bb871198485cd71a63f75a8c6becf
But 'o_cp_top_left' class is only available on desktop.
On mobile the layout of the control panel is different.
This produce a bug on Mobile.

After this commit, we use a less restrictive querySelector to match
the element in mobile too.

Note: we remove the 'div' for clarity/consistency

Steps to reproduce:
* Open Odoo in "Mobile mode" (small screen)
* Go to Apps
* Install a module that need website or website it self
* You are redirect to the "chose theme" => Bug

closes odoo/odoo#66613

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

When we double click a form submit anchor, and depending on the selected
element before click, the selection range ("document.getSelection()") can
start from a parent of the targeted node. This will send a wrong range
to be used in LinkDialog widget.

The goal of this commit is to prevent this behaviour by adjusting the range
if it starts from anchor parent.

Note: the bug only occurred in Firefox.

Part of https://github.com/odoo/odoo/pull/62206


task-2381305

closes odoo/odoo#62206

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Part of https://github.com/odoo/odoo/pull/62206
task-2381305

*: web_editor, website_mass_mailing

When we double click a link/button, a link dialog appears
to update the target properties, and since the current link dialog
can only handle anchor targets, using it on buttons leads to some
inconsistencies :

- visible href options for button & url required to save changes.
- missing preview when button style changed.
...

The goal of this commit is to add a fix (with minimum of code) on
summernote linkdialog to handle button elements using the same logic as
anchor nodes.

Also, update website form test tour to test those new changes.

Part of https://github.com/odoo/odoo/pull/62206
task-2381305

Before this commit:

In edit mode, glitching of chatter is visible in project.task's form view
(without sheet tag).

After this commit:

Removed this glinch of chatter and displaying it with full width in the form
(without sheet tag).

Links

PR https://github.com/odoo/odoo/pull/65447


Task- 2411632

closes odoo/odoo#66799

X-original-commit: f2f27b6d
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Before this commit, a page reload or a redirect could raise following
error:

```
Uncaught (in promise) TypeError: this.env.services.bus_service is undefined
```

This happens due to `Messaging` model relying on `bus_service` in its
teardown method `_willDelete`. This is sometimes unsafe because the
bus service may not have been deployed yet.

Task-2468469

closes odoo/odoo#66818

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

When reconciling a statement line from the bank reconciliation widget, the journal entry of the statement line is already posted and then, the analytic lines was never created.
This commit fixes the issue by refreshing the analytic lines at the end of the statement line's reconciliation.

closes odoo/odoo#66800

Opw: 2466236
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

A move with type 'entry' cannot be posted in a 'sales' journal. It should be
the default 'miscellaneous' journal instead.

closes odoo/odoo#66729

Signed-off-by: William André (wan) <wan@odoo.com>

In case a yearly sequence is set for out_invoice/in_invoice types and if we set
a monthly sequence on the corresponding out_refund/in_refund type, we will not be
able to validate the refund the next month as it will be wrongly identified as a
yearly sequence. We should include the move type when retrieving the last
sequence name instead.

None is not a valid return value for xmlrpc
https://github.com/odoo/odoo/pull/65774#issuecomment-777327354



closes odoo/odoo#66243

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

- install e-commerce and l10n_ar;
- as a Public user open a product on the shop.

Before this commit, an 403 error was raised.

Now, the public user can navigate through the products.

opw-2462477

closes odoo/odoo#66795

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

Before this commit:

For chatter in window, the name of the record is not in an appropriate place in
header as there is an empty space before name.

After this commit:

The name of the record is aligned to the left, and there is no empty space
before the name.

LINKS

Task- 2442652
PR https://github.com/odoo/odoo/pull/65600



closes odoo/odoo#65600

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Only the 'action' requests have the 'data' parameter set, so any other
request triggering a 'device_changed' failed.

closes odoo/odoo#66792

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Suppose an invoice of 1200USD = 3600EUR reconciled with a payment 1800USD = 3600EUR.

The generated exchange difference journal entry is:
600USD = 0EUR because 1800 - 1200 - 600 = 0 and 3600 - 3600 = 0
=> Everything is reconciled and all residual amounts are 0.

Remove the reconciliation. The exchange difference entry is reversed in other to cancel it.
Because the current exchange difference entry contains a line of 600USD, the reversal is creating a line of -600USD.

Before this commit:

Because both lines were sharing the same foreign currency (EUR) but have an amount_residual_currency of 0, no partial was created and then, a new exchange difference was generated in order to fix the amount_residual of 600 in USD.

After this commit:

A partial is created to handle the residual amount in USD even the residual amount in foreign currency is already zero.

Note: this issue is also there when the reconciliation is made using the company's currency with different foreign currencies.
In that case, amount_residual is zero but not amount_residual_currency.

closes odoo/odoo#66653

Opw: 2450699
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Zeep replaced suds but Debian and Rpm packaging were not updated.
Ofxparse is required but did not appear in Debian nor Rpm packaging.

closes odoo/odoo#66784

X-original-commit: 39738f2b
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Before this commit:

In edit mode, glitching of chatter is visible in project.project's form view
(without sheet tag).

After this commit:

Removed this glinch of chatter and displaying it with full width in the form
(without sheet tag).

LINKS

PR https://github.com/odoo/odoo/pull/65448


Task- 2411632

closes odoo/odoo#65448

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

When we want to send the invoice to the client, a hack was made in account_edi
to make sure that we put the XML of the electronic invoice formats as well, in
the case of web services such that the client has the XML we sent to the government.

For MX however, we also send the payment to the government.  However when we wanted
to send the confirmation about the different changes, we still needed to add the XML
manually before this fix.  Now it should be added manually even when manually composing
the mail to the customer with the payment receipt confirmation.  (but we hope it dies)

closes odoo/odoo#66728

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Some json files are necessary for some modules but are not included in
packaging.

closes odoo/odoo#66772

X-original-commit: d33c05b6
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Before this commit, display mode is changed to block after hiding it on mobile mode.
After this commit, only change display mode for mobile and use inherited mode otherwise.

task-2431659

closes odoo/odoo#65716

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Before this commit, the user can select a sales order which is always a
quotation and he cannot select a sales order line because the state of
the sales order is not equal to 'sale' or 'done'.

This commit adds ('state', 'in' ['sale', 'done']) in the domain of the
sale_order_id field in project.project model.

closes odoo/odoo#66756

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

When printing an invoice, the server tries to register one attachment as
main one (see #65320). However, if there is not any attachment, this
will raise an error.

OPW-2465995

closes odoo/odoo#66747

X-original-commit: 03d2e457
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

Have an empty database
Install Recruitment
Employee>Departments>Administration(3 dots)>Recruitments

Missing record message raise
This occur because of an access to a record that may not exists

opw-2431929

closes odoo/odoo#66650

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

AFIP give us new resolution 4291 that request to print QR code in
printed version of electronic invoices. For that we:

1) update the xml report footer style
2) add generic method to sanitze the identification number we are
sending, the sanitize method is added here in order to be re used for
other functionalities across electronic invoice and reports. If we are
not able to sanitize the number then we show an error to the user
3) update translations to add new raise message translated term

closes odoo/odoo#65033

Related: odoo/enterprise#15948
Signed-off-by: Josse Colpaert <jco@openerp.com>

Steps to reproduce the bug:

- Create a multi-company environment with two companies A & B
- Create two sales taxes TA & TB, one for company A & one for company B
- Created a shared product P and assign both TA & TB
- Create a fiscal position FP that maps TA and TB to other taxes
- Login with user having access of both companies
- Enable a POS session S with fiscal position and select FP
- Open S and select P as product

Bug:

A traceback was raised

PS: Only the taxes of company's user are loaded in taxes_by_id
So when trying to fetch taxes from a product with function get_taxes,
the taxes from other companies than company's user must be ignored.

opw:2448785

closes odoo/odoo#66717

X-original-commit: 5dcfdcb2
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Change Delete secondary button to Archive on calendar popover for
synced calendar event. This makes it easier to delete synced button
from the calendar view.

(This commit is roughly the same as the one for google calendar, with
an additional check in MicrosoftCalendarPopover.js)

closes odoo/odoo#65539

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Change Delete secondary button on calendar popover to Archive
for synced calendar event. This makes it easier to delete synced
calendar events.

Now that a test exists to enforce `__init__.py` in odoo module, we must
ensure that we keep the feature.

For that reason, a white-list system is added in `test_dunderinit` and a
test is added in order to be sure that a module without `__init__.py` can
be exists.

This this is made of a fake module `test_data_module` without
 `__init__.py` and a test module which ensure the fake module was
installed.

closes odoo/odoo#66651

Related: odoo/enterprise#16596
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Odoo modules without `__init__.py` are not recognized as python modules
and therefore not packaged by standard tools.

When a module is added, it happens that the `__init__.py` file is
forgotten. In that case, those modules are not packaged.

With this commit, a test is added to check that each Odoo module has the
file.

Issue

	- Install Inventory module
	- Go to Inventory -> Reporting -> Inventory Valuation
	- Click on "Inventory At Date" button
	- Select any date

	The datetime in breadcrumb is displayed in UTC.

Solution

	Display datetime in current user timezone.

opw-2464744

closes odoo/odoo#66713

X-original-commit: 235386e4
Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

To reproduce:

1. Activate pos_hr feature.
2. Authorize an employee with pin.
3. Open a pos session and login with that employee.
4. [BUG] The popup to input pin is broken.

This is because of the 'minus' button. In this commit, we make sure
to hide the 'minus' button when the popup is used to ask for pin.

closes odoo/odoo#66688

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

A leave manager should be able to approve a time off that already begun.

opw:2447240

closes odoo/odoo#66481

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Co-authored-by: simongoffin <sig@odoo.com>

This commit unpins a livechat channel initiated by an admin when
it's closed and no message has been sent

closes odoo/odoo#66178

Task-id: 2276571
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Scenario:

- set new background image
- set parallax
- save

=> on next edition, the editor doesn't work on background anymore

Why:

- backgroundOptimize copy attributes of the original image to the real
  target element on save
- parallax change the real target element to a new child

=> so if the original element was an editor (with data-oe-model, ...)
   attributes, with the combination of the two options we will save
   these editing attribute on the child element which is wrong (the
   editing attributes are added dynamically and should not be saved).

With this changeset, we don't copy the editing attributes in
backgroundOptimize when we copy the original target image.

opw-2427560
opw-2429340

closes odoo/odoo#66665

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

This fix (odoo/odoo#46850) was too permissive and fix too much
stock valuation issues (other than rounding error) under the hood.
The problem of the "too permissive" is will hide some errors
without get any feedback about them. Also, it changes the SVL value
without any explanation.

To avoid the first issue, apply a threshold on the rounding adjustment.
This threshold is '(quantity_out * smallest_value_of_the_currency) / 2'
(`smallest_value_of_the_currency` = `rounding` field of the related
currency).
Also to improve debugging, add a line in the description
about the rounding adjustment done in a SVL

task-2452786

closes odoo/odoo#66662

X-original-commit: 74ba8039
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Steps:
- Install Inventory
- Make sure Units of Measure are activated in the settings
- Go to Inventory > Configuration > Units of Measure > UoM
- Delete m³
- Go to Products > Products
- Click any product

Bug:
Traceback here:
https://github.com/odoo/odoo/blob/5324f7a6aa757ff6a728258ea1877ded4a6f86cd/addons/product/models/product_template.py#L315
ValueError: External ID not found in the system:
uom.product_uom_cubic_meter

Explanation:
Products refer to UoM since this commit: https://github.com/odoo/odoo/commit/2c079fcd107caec3a25e2a78d4d0e5af1d8237da


Deleting a referenced UoM will most probably break things in the future.
This commit prevents users from deleting UoM that are referenced by an
external ID.

opw:2457057

closes odoo/odoo#66656

Signed-off-by: backspac <backspac@users.noreply.github.com>

The `mail` module logs bus notifications it does not handle. However, some
notifications are not meant to be handled by `mail` and it's perfectly fine.

This commit removes the log to avoid useless noise in the console.

closes odoo/odoo#66661

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

instead of using ad-hoc weirds

closes odoo/odoo#66649

X-original-commit: 9a129ca9
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

The executing function for FieldCommand should return boolean value
to indicate whether the value changed for triggering the re-computation.

closes odoo/odoo#66648

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Do a transfer in two steps with several move lines (e.g.: Vendors => Input => Stock).

In the first picking, set quantity = 0 on a single line. Transfer it and say 'No backorder'.

In the second picking, set all quantities (you have two move lines confirmed and one canceled). Validate the
transfer. The backorder wizard is launched. It should not.

closes odoo/odoo#66272

X-original-commit: 25ae2416
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>