This commit patches the font awesome library to add an icon for the
TikTok social network. Users are now able to add these icons with the
media dialog. Now, the TikTok icon works like all other font awesome
icons, with the new class introduced by this commit: `fa-tiktok`.

Technical note:
In order to add this new icon, a new font that contains only the TikTok
logo has been created.

task-3235451

closes odoo/odoo#116383

Signed-off-by: Vray Benjamin (bvr) <bvr@odoo.com>

Steps to reproduce:

  - Configure incoming mail server and set it to create X record
    on incoming mails (X can be any model with a chatter)
  - Create a CSV file and set the encoding to UTF-16
  - Send the CSV file through Gmail to the Odoo instance
  - Go to model X and open the created record
  - In the chatter, click/download the CSV file
  - Open the downloaded file with Geany (or any file editor that can
    show the file encoding)

Issue:

  The file encoding is not the same as the original file (utf-8 instead
  of utf-16).
  Working with Outlook.

Cause:

  The difference between Outlook and Gmail is that Gmail provides the
  charset of the file.

  The content of the mail is retrieved using `email` python lib.
  The lib will try to retrieve the charset of the file and fallback
  on `ASCII` if not available, then return the decode content.

```python
  def get_text_content(msg, errors='replace'):
    content = msg.get_payload(decode=True)
    charset = msg.get_param('charset', 'ASCII')
    return content.decode(charset, errors=errors)
```

  Example:
  content = b'd\x00a\x00,\x00,\x00,\......'
  Outlook:
  charset = 'ASCII'
  return => 'd\x00a\x00,\x00,\x00...'
  Gmail:
  charset = 'UTF-16LE'
  return => 'da,,,,,\n,,,,,\....'

  In the post process of the attachment, the content is encoded in
  'utf-8' (to then encoded in base64) before creating the attachment
  record.

  Content encoded to 'utf-8':
  Outlook: b'd\x00a\x00,\x00,\x00...'
  Gmail:  b'da,,,,,\n,,,,,\n....'

  Therefore, when writing the file on the disk, the encoding is based
  on the binary content.

Solution:

  When parsing the mail, add the encoding charset to the `info` variable.
  Then, when creating the attachment, use the charset in `info` (or
  fallback on 'utf'8' if no charset set) to encode the content.

opw-3089009

closes odoo/odoo#111298

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Issue:
When a project is shared with portal users,
only timesheets that are linked to tasks will be displayed.

Solution:
Change the domain that selects the timesheets to be displayed
to take into account timesheets that are not linked to a task,
but are in a project to which the portal user has access.

opw-3253632

closes odoo/odoo#118329

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Tracked binary fields do not produce any message in the chatter

Steps to reproduce:
1. Install Sales and Studio
2. Open any quotation
3. Trigger Studio and add a signature field to the form
4. With debug mode enabled, edit the field (by clicking on MORE when the
   field is selected) and set the Enable Ordered Tracking to 1
5. Close Studio
6. Edit the signature and save
7. No message appears in the chatter to track the value

Solution:
Remove the `tracking` field from binary fields to prevent the user from
trying to track it

Problem:
We shouldn't track binary data in the chatter and we cannot use the
filenames

opw-3055108
task-3255810

closes odoo/odoo#117821

Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>

Making a test post_install using @tagged should always remove the
at_install tag.

The main reason for that is that runbot split config select if an
at_install or post_install tests should be executed is using negation:
`--test-tags -post_install`. The reason for that is that giving a positive tag will
replace the "standard" tag and non standard tag could be executed if
giving `--test-tags at_install` (without negation)

Since runbot tests in parallel builds, one of them using
`--test-tags -post_install` and the other `--test-tags -at_install`,
a test that is both post install and at install wont be executed at all.

Also, a tests with both tags will be executed twice
in a normal flow, usually not intended.

The correct way to make a test post_install is to use

@tagged('post_install', '-at_install')

closes odoo/odoo#118042

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

"ERROR: Unknown Unsplash URL!" is generated when we try to add premium
Unsplash images. This is because when we add the unsplash image, it accepts the
image whose URL starts with "https://images.unsplash.com/" but the premium
image URL starts with "https://plus.unsplash.com/

".

This commit solves the above issue by checking that the premium splash
image link starts with the correct format.

sentry-4075507166

closes odoo/odoo#118147

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

before this commit, on clicking the picking calendar view, it allows the quick adding from the calendar view and entered value is going to the name field of stock.picking model.

after this commit, quick adding will be disabled and on clicking form will be opened with selected date.

closes odoo/odoo#112605

Signed-off-by: Tiffany Chang <tic@odoo.com>

This commit prevents inclusion of negative qty SO products from
the calculation of its estimated shipping weight. Negative qtys can
indicate a return, which would be a separate picking from the delivery
 => we shouldn't subtract their weight from the delivery. This
subtraction, may have resulted in shipping rates being calculated as
lower than they should have been within the SO.

Additionally fixes the following use case (requires Fedex connector):
- create a SO with 2 products with the same weight
- set 1st product qty = 1
- set 2nd product qty = -1
- add shipping => Shipping Method = Fedex US
- click on "Get Rate"

An error will occur because the SO._get_estimated_weight() = 0, and
you cannot have a rate for weight = 0

TaskId - 3028023

closes odoo/odoo#104658

Signed-off-by: Tiffany Chang <tic@odoo.com>

before this commit, while duplicating an user,
karma points is also getting copied to newly
created user

after this commit, the copying of karma on
duplicating an user will be stopped.

closes odoo/odoo#118155

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

As a developer,
when you craft your records set manually,
and wrongly use the API and set something weird in `ids`,
something else than a tuple of integers,
`repr` should help you to understand you did something wrong.

e.g.

before
```py
In [1]: env['res.partner']._browse(self.env, '(1,)', 'bar')
Out[1]: res.partner(1,)
```

after
```py
In [1]: env['res.partner']._browse(self.env, '(1,)', 'bar')
Out[1]: res.partner'(1,)'
```

We could put an assert in `_browse` to make sure `ids`
is a tuple of integers, but this is considered a non-stable
change, as it will suddenly crashes when you will update
Odoo while it wasn't the case before.

closes odoo/odoo#118076

Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

before this commit, the controllers directory is
imported twice in the init file.

after this commit, the duplicated import is
removed.

closes odoo/odoo#118069

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

After 863fa450, the UBLVersionId node
was removed from the Bis 3 and its inheriting formats.

Thus, the fonction infering the format from an xml etree needed to be
apdated too, since we can no longer rely on the `UBLVersionID` node for
UBL Bis 3 and its inheriting formats. The `CustomizationID` node is
used.

closes odoo/odoo#118043

Signed-off-by: Josse Colpaert <jco@odoo.com>

In case of the amount of the transaction is not the same of the order. A customer can be a misunderstanding between the amount paid with the acquirer and the amount show in the confirmation page.

closes odoo/odoo#117869

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Precommit hooks would stock data until a call to ``cr.flush`` was made.
Notably, this happens when the ``assertRaises`` method is called.
Functions were applied on records already cleared from the cache.

This change adds a cleanup call for `SavepointCase` as it keeps
the same cursor for all tests. Cursor precommits can now
be safely executed inside tests.

Task-2834304

closes odoo/odoo#117555

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce:

- Install Sales as an example.
- Go to Products, and try to filter them by Sales Price.
- You have 0.0 as default value, now try to remove it and put 5.

Issue: We can't delete the leading 0 even though the filter is still
working as expected.

Solution: Changed the `t-on-input` to match `t-on-change` as this is
what we use in future versions, like 15.0.

opw-3131261

closes odoo/odoo#114837

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

__Current behavior before PR:__
The `abort_and_redirect` method uses `werkzeug.utils.redirect` which converts the input URL to a string in werkzeug 0.16.1.
However when running odoo with python 3.10, [werkzeug version 2.0.2 is used](https://github.com/odoo/odoo/blob/8985426bf38affedb82990bd2158049b4d6b0bce/requirements.txt#L58).
In this version if the input is not a string `TypeError: replace() takes 1 positional argument but 3 were given - - -` is raised.

__Description of the fix:__
Calls `to_url` method on `url_redirect` to convert it into a string before passing it to `abort_and_redirect`.

__Steps to reproduce the issue:__
1. Run odoo-bin with python 3.10 **or** directly use `werkzeug` version 2.0.2 (`pip install werkzeug==2.0.2`).
2. Go to http://localhost:8069/web/database/selector (in private window)
3. Open a database in Odoo 14
↳ Internal Server Error

Closes: https://github.com/odoo/odoo/issues/111490



opw-3222058

closes odoo/odoo#117959

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

The content of the override of `can_be_merged_with` should only be executed when we're
in France.
The previous implementation resulted in breaking the `test_05_tip_screen` when this module
was installed with pos_restaurant.

closes odoo/odoo#117942

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

closes odoo/odoo#117891

X-original-commit: c38b5baaeac28a7952601878a5b5efadf7f52984
Signed-off-by: Christophe Simonis <chs@odoo.com>

Steps to reproduce:
- company currency = USD
- set a partner P with a `property_purchase_currency_id` in EUR
- create a bill with Azure partner and set an bill line
- change to partner P
issue -> the currency of the line has not been change
- change to Azure
issue -> no change about the currency

Cause:
- We update the move.currency_id but not the line_ids.currency_id
- after setting Partner P, we try to set a partner that no `property_purchase_currency_id`, we do not enter in the condition

opw-3233527

closes odoo/odoo#116852

Signed-off-by: Cedric Snauwaert <csn@odoo.com>

Tag UBLVersionID should not be present for UBL Bis 3 and its inheriting
formats.

opw-3249153

closes odoo/odoo#117792

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

Recently the tax report was updated with new tax report lines, but translations weren't added.
This commit adds translations in FR, DE.

task-3264626

closes odoo/odoo#117790

Related: odoo/enterprise#39373
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

When assigned the role of restricted editor, there are many ways to
break the web_editor when trying to do actions that should be
unavailable. There is a traceback for the following scenarios under
some circumstances (mainly because of pages without editable areas or
features without the proper access rights):

- Drag and dropping snippet when Restricted Editor.
- Clicking on product when Restricted Editor in /shop.
- Clicking on product image on specific product page.
- Clicking on user name (e.g. Marc Demo).
- Clicking on menu items or logo.
- Clicking on a blog's image in /blog.
- Clicking on a blog's image on specific blog page.
- Clicking on calendar's image in /calendar.

There is now no longer a traceback which makes the editor crash or
freeze. This mimics the behavior in other cases where the editor does
not show a traceback, but there is no message indicating that the action
is unauthorized.

When accessing a menu that cannot be edited, the "Edit the menu" button
is not shown to the restricted editor.

task-2747895
opw-3164176

closes odoo/odoo#76900

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: Benjamin Vray <bvr@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

before this commit, on creating a vendor bill with
landed cost product, is not allowing to save the bill,
it shows the exception that missing required account
on accountable invoice line.

steps to reproduce:

* create a product category with inventory
valuation set as Manual
* create a landed cost product using above category
* enable anglo saxon accounting in accounting settings
* create a vendor bill with this product and click save
* exception is shown: missing required account
on accountable invoice line

after this commit, the exception wont be shown

closes odoo/odoo#117474

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

closes odoo/odoo#117727

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

duration_percent field is a stored integer.
In postgresql, integer are 4 Bytes long, which create a range of -2147483648 to +2147483647.
With a small duration_expected, and a big duration, we can easily break these limits.

OPW-3253333

closes odoo/odoo#117590

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Incorporate Andy Quijada (ajqn9094) as Vauxoo's contributor.

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#117550

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

This will prevent a "Title underline too short" warning
at module install.

closes odoo/odoo#117614

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

The method `price_compute` on `product.product` model was wrongly
using the product `company_id` field as `company` for the currency
conversion call.

Indeed, products do not always have a company (they can be shared
across companies) and when they don't, `_convert` will fail, raising
an AssertionError as it expects a valid company record.

This commit makes sure the method will work as expected even for
products shared between companies, and harmonizes both `price_compute`
methods (on `product.product` & `product.template` models) by using
the given company (or the company of the environment) for the conversion
as we want the returned price to be computed for the given company,
not for the product company anyway.

closes odoo/odoo#117435

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Part-of: odoo/odoo#117435

Based on change from PR odoo@df74fb6, the rule stated on the document attached has been reverted. It should be using the customer's tax address rather than the delivery address'. One of Indonesian customers are getting a warning letter from the government regarding this.

3230742

closes odoo/odoo#116140

Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

Steps to reproduce the bug:
- Go to the warehouse settings:
    - enable “3 steps for manufacturing”
- Create a storable product “P1” with 2 BoM
- Create an orderpoint:
    - Preferred route: Manufacturing
    - Product: “P1”
    - BoM: select the second BoM
    - To order: 1

- Click on the “Order once” button

Problem:
The manufacturing order is created with the first BoM instead of the
second.

As we are in 3 steps, the “run_pull” function is triggered first, with
values prepared from the orderpoint so the bom is well set:
https://github.com/odoo/odoo/blob/16.0/addons/stock/models/stock_orderpoint.py#L515-L523

Then the “run_manufacture” function is triggered but with vals prepared
from the move, not from the orderpoint, so we lose the BoM information
that the user has selected:
https://github.com/odoo/odoo/blob/16.0/addons/stock/models/stock_move.py#L1334-L1340



opw-3217945

closes odoo/odoo#116685

Signed-off-by: Tiffany Chang <tic@odoo.com>

The list of attendees to contact for an event is wrong.

Steps to reproduce the error:
1-In the event app , have a canceled attendee
2-Send an Email to attendees
bug : the email will be sent to canceled attendees as well

The problem was originated from the domain given by the inherited
class, there was no condition on the state of the attendees.

opw-3240100

closes odoo/odoo#117499

Signed-off-by: Adrien Widart <awt@odoo.com>

Incorporate Rolando Duarte (rolandojduartem) as Vauxoo's contributor.

I confirm I have signed the CLA and read the PR guidelines at:
www.odoo.com/submit-pr

closes odoo/odoo#117545

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Since [1] when a `/` was added as default text when no option is
selected in dropdown options, the selected font name is not displayed
anymore inside font options because they both rely on specifying a
`content` on the `::before` pseudo-element inside the `we-toggler`.
Because the empty value text also includes a `:empty` inside its
selector, that rule wins over the font name.

This commit makes the font name rule `!important` so that it gets
applied instead of the empty selection rule.

[1]: https://github.com/odoo/odoo/commit/dc6ff20386567abbabcb2d35388a3dc8995cab28



task-3256509

closes odoo/odoo#117448

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Since [1] the font family parameter was encoded twice when adding a new
google font. This causes an issue for fonts that contain spaces in their
name.

This commit removes that additional encoding and highlights the fact
that it already is an encoded parameter.

Steps to reproduce:
- Go to the Options tab while editing a website page.
- Open the Font Family dropdown.
- Select "Add a Google Font".
- In the "Google Font address" enter
`https://fonts.google.com/specimen/Open+Sans`.
- Click on "Save & Reload".

=> Field was highlighted as being wrong.

[1]: https://github.com/odoo/odoo/commit/d8cff9a37ba51c64628085b48d071ecb24e70f07

task-3256509

Part-of: odoo/odoo#117448

- Create an account of type current asset
- Add him a Sales Tax and a Purchase Tax
- Create invoice
- Add a line
- Remove the taxes from this line
- Change the account to the one you created

=> A purchase tax is applied to the line.
It should not happen, so we prevent it.

closes odoo/odoo#115196

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

As we have a team dedicated to work on analysing tracebacks
with sentry, and to takedown all tracebacks occuring on the saas,
we do an effort to avoid unecessary warnings and tracebacks
for both sentry and the runbot.

closes odoo/odoo#112101

Signed-off-by: Rémy Voet <ryv@odoo.com>

Incorporate Isaac López (isaako34) as Vauxoo's contributor.

closes odoo/odoo#117428

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this commit: if the user wanted to generate a
POS Inalterability Check statement, an IndexError was raised.
This commit raises a more understandable error.

opw-3237383

closes odoo/odoo#116386

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>