Skip to content
Snippets Groups Projects
  1. Oct 11, 2019
  2. Oct 10, 2019
    • Lucas Perais (lpe)'s avatar
      [FIX] website: oe_no_empty only in edit mode · fca9a109
      Lucas Perais (lpe) authored
      
      Test case;
      The user as edition rights on the website
      Install quotation builder
      Have a sale order with many lines
      Click preview > you end up on the portal view
      
      Before this commit, there was a blank space just before the
      sale order lines per se
      This was because the sale order's lines website description
      were in the dom and took some fixed space, which is a feature
      meant for the edit mode by using the class oe_no_empty
      
      After this commit, we restrict the effect of that class concerning
      the fixed height only to edit mode
      There is no more gaps in the sale order preview
      
      In master, one should check whether the class / rule is still relevant
      
      OPW 2082267
      
      closes odoo/odoo#38429
      
      X-original-commit: 4b177412
      Signed-off-by: default avatarLucas Perais (lpe) <lpe@odoo.com>
      fca9a109
  3. Oct 11, 2019
    • Nans Lefebvre's avatar
      [FIX] sale: small cleanup of line computations · 30cf4b37
      Nans Lefebvre authored
      
      Initially a forward-port of 5aecd365, which needed f407e60a to work.
      
      The do_in_onchange was removed inbetween, but it is not needed anymore here.
      The issue was caused by the fact that the cache values given for each
      environment, whereas in the new ORM the values are now shared across all.
      
      The other potential issue caught by this test was that the company of the taxes
      could be incorrect. This is problematic for the end user, since relational that
      violates inter-company rules mean that they won't be able to read or write
      the records without sudo. However the model now has _check_company_auto,
      handled by the ORM, so the issue should not arise anymore.
      
      closes odoo/odoo#38377
      
      Signed-off-by: default avatarNans Lefebvre (len) <len@odoo.com>
      30cf4b37
    • fw-bot's avatar
      [FIX] base: value_to_html doens't keep the minus sign for times between 0 and 1 · b12374a2
      fw-bot authored
      
      - Install timesheets and studio.
      - In timesheets add a time of -0.5 (minus half an hour).
      - Enter studio
      - Switch to the Reports tab, and click Timesheet Entries.
      
      Before this commit:
      
      The time is displayed as 00:30.
      
      After this commit:
      
      The time is displayed as -00:30.
      
      closes odoo/odoo#38354
      
      Opw: 2036188
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      b12374a2
    • Nans Lefebvre's avatar
      [FIX] models, test_access_rights: restore normal ACL check · cff5cc8c
      Nans Lefebvre authored
      
      Because of 4b1cb41c, we might try to read
      the field 'active' on a record on which we can't read fields besides the name.
      This thus triggers an access error where there should not have been.
      
      In particular, this is the case for portal users: most often the records they
      can access point to records that they can't read
      (e.g. the partner of the internal user assigned to the ticket).
      As a result, clicking on any link creates an ACL, and thus redirects to the
      home page.
      
      It turns out that filtered_domain was primarily used on already loaded records,
      typically for the write, so it was assumed that the records could be read
      in the first place.
      However in the use-case of the portal, there is an explicit check on the read
      rights with the portal user, explaining the discrepancy.
      
      Since in the general case filtered_domain should be able to read all fields
      to evaluate the domain, we put it in sudo.
      
      fix co-authored with @rco
      
      closes odoo/odoo#38198
      
      Signed-off-by: default avatarNans Lefebvre (len) <len@odoo.com>
      cff5cc8c
  4. Oct 08, 2019
  5. Oct 10, 2019
  6. Oct 11, 2019
  7. Oct 10, 2019
  8. Oct 11, 2019
  9. Oct 10, 2019
  10. Oct 11, 2019
    • fw-bot's avatar
      [FIX] web: use language week_start in datepickers · eeb51831
      fw-bot authored
      
      Before this rev., if the week_start param (the first day of week)
      of the user language was changed, it wasn't reflected on datepickers
      (however, it worked fine in the calendar view). This rev. makes this
      work by updating the moment locale with the corresponding param.
      
      Fixes #36450
      Closes #36532
      
      closes odoo/odoo#38398
      
      Signed-off-by: default avatarAaron Bohy (aab) <aab@odoo.com>
      eeb51831
  11. Oct 10, 2019
    • jbm-odoo's avatar
      [FIX] web: List editable top select last row · 996f77b0
      jbm-odoo authored
      
      Before this commit, when we have a list (editable top) in a form
      with some mandatory fields and some existing rows. If we click on
      'add a line', a new empty line appear on the top, then we click on
      the last row, the empty row will disappear and we will have a
      traceback.
      
      After this commit, if we repeat this scenario, we click on the last
      row, we will be able to edit this last row.
      
      closes odoo/odoo#38302
      
      Signed-off-by: default avatarVincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
      996f77b0
  12. Oct 09, 2019
  13. Oct 10, 2019
    • Pedro M. Baeza's avatar
      [IMP] purchase: Take into account purchase order date for sequence · ce423e6a
      Pedro M. Baeza authored
      
      **Steps to reproduce**
      
      * Define "Purchase Order" sequence for using date ranges checking "Use subsequences per date_range".
      * Change sequence prefix to "PO/%(year)s/".
      * Create a purchase order with order date in 2020 (a different year than current one).
      
      **Current behavior**
      
      Got a purchase order with 2019 (current year) number.
      
      **Expected behavior**
      
      Got a purchase order with 2020 number.
      
      closes odoo/odoo#37762
      
      Signed-off-by: default avatarDamien Bouvy (dbo) <dbo@odoo.com>
      ce423e6a
    • Pedro M. Baeza's avatar
      [IMP] sale: Take into account sales order date for sequence · 20baf00d
      Pedro M. Baeza authored
      **Steps to reproduce**
      
      * Define "Sales Order" sequence for using date ranges checking "Use subsequences per date_range".
      * Change sequence prefix to "SO/%(year)s/".
      * Create a sales order with order date in 2020 (a different year than current one).
      
      **Current behavior**
      
      Got a sales order with 2019 (current year) number.
      
      **Expected behavior**
      
      Got a sales order with 2020 number.
      20baf00d
    • fw-bot's avatar
      [FIX] l10n_mx: Transition Tax Accounts must be reconcilable · 3a4d8475
      fw-bot authored
      This issue is relevant for MX Localization because Cash Basis is created
      with the rate of the payment, and not with the rate of the invoice as is
      done for odoo core.
      
      closes odoo/odoo#38386
      
      X-original-commit: 10bb81c8
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      3a4d8475
    • Antoine Prieels's avatar
      [FIX] pos_hr: res.users loaded twice · 26274dbb
      Antoine Prieels authored
      
      When pos_hr was installed, `load_models` was called twice for res.users
      and calls to `load_fields` were not processed correctly.
      
      closes odoo/odoo#38374
      
      Signed-off-by: default avatarpimodoo <pimodoo@users.noreply.github.com>
      26274dbb
    • Antoine Prieels's avatar
      [FIX] point_of_sale: Scrollbar on receipt print · 84418ae5
      Antoine Prieels authored
      A scrollbar appeared every time a receipt was printed. To fix this,
      we put a height of 0 to the div that contains the receipt.
      
      html2canvas then had trouble computing the height of the background.
      There's a `height` option that can be given to the library but if the
      logo on the receipt was not loaded yet, the size we computed was wrong.
      We then compute the height only once the images have been loaded, in
      the `onparsed` method.
      
      We also remove a CSS class that wasn't used anymore.
      84418ae5
    • Nans Lefebvre's avatar
      [FIX] website: fix _update_visitor_last_visit concurrency issues · cc88a367
      Nans Lefebvre authored
      
      Install the website, install a second language.
      Switch the language on the website: error 500.
      
      The function opened a new cursor, to update website_visitor.
      It did so at the end of the query dispatch.
      However when switching the language of the website, the lang is written on the
      website visitor. This is done at the flush, done at the end (exit) of the query.
      This is done on the cursor that was used for all the transaction.
      Therefore that write would systemically fail on a
      ERROR: could not serialize access due to concurrent update
      
      opw 2080986
      
      closes odoo/odoo#38372
      
      Signed-off-by: default avatarNans Lefebvre (len) <len@odoo.com>
      cc88a367
  14. Oct 11, 2019
  15. Oct 10, 2019
Loading