Skip to content
Snippets Groups Projects
  1. Apr 18, 2017
    • Ankit Joshi's avatar
      [ADD] stock: add the field 'description_picking' in picking report · 7591f59c
      Ankit Joshi authored
      The field is defined but never user. It could be useful to indicate
      to the delivery guy that the product is 'fragile' or whatever.
      
      opw-728874
      7591f59c
    • Nicolas Martinelli's avatar
      [FIX] sale: set timesheet line to zero · b4193cd3
      Nicolas Martinelli authored
      - Create a SO with a product that is a service and will be invoiced
        based in delivery quantities and will be tracked on timesheets and
        contract.
      - Confirm
      - Use a simple user that only has for rights: "Employee"
      - Create a timesheet as the employee for the contract created by the sale
      - Log some time
      - Save it
      - Check the SO: ok the number of hours should be "to be invoiced"
      - Edit the timesheet and set one day to 0 hours => Access Error
      
      In case of a zero value, the timesheet widget sends an unlink command
      for the corresponding entry. In this case, the `sudo` is not set at the
      appropropriate moment since the context key `force_so_lines` will resue
      lines which are not defined in the `sudo` environment.
      
      opw-728453
      b4193cd3
  2. Apr 16, 2017
  3. Apr 12, 2017
  4. Apr 11, 2017
    • Goffin Simon's avatar
      [FIX] sale: _compute_analytic with amount=0 · a0fed3b8
      Goffin Simon authored
      Steps to reproduce:
      -Create a product P  with a standard price = 0 and its internal category
      is in perpetual valuation
      -Create a SO with an analytic account and a line with one product P
      -Confirm the SO
      -Create and validate the invoice
      
      Bug: The delivered qty on the SO was equal to 2 instead of 1 because two
      analytic lines are created by function create_analytic_lines with amount=0.
      So in function _compute_analytic, the domain was [('so_line', 'in', self.ids), ('amount', '<=', 0.0)]
      and it summed the two analytic lines for these two lines. Now analytic lines with amount=0 and linked
      to a move line are summed if the they are linked to entries for an account of type "Expenses"(user_type_id).
      
      opw:727302
      a0fed3b8
    • Goffin Simon's avatar
      [FIX] account: Making a refund with modified taxes · 1dc36170
      Goffin Simon authored
      Step to reproduce the bug:
      1.Create a product with a customer tax(15%) for a price=100
      2.Create a customer invoice with this product
      3.Change the amount of the tax to 10(instead of 15)
      4.Validate the invoice
      5.Click on "Refund invoice"
      6.Select the refund method "Modify: create refund, reconcile
      and create a new draft invoice"
      
      Bug the new draft invoice has 15 as amount of tax
      
      Now all the taxes from the invoice when preparing the refund in function
      _prepare_refund, in this it keeps all the modified taxes.
      
      opw:726491
      1dc36170
    • Nicolas Martinelli's avatar
      [FIX] stock: reordering rules of archived products · 8c326c5c
      Nicolas Martinelli authored
      When the scheduler is run, the reordering rules of archived products are
      selected.
      
      opw-728316
      8c326c5c
    • Nicolas Seinlet's avatar
      [FIX] ir.rule: use rules at most once (#15843) · ded636ea
      Nicolas Seinlet authored
      When a user belongs to multiple groups, and an ir.rule is applicable for some of
      them, the rule is added multiple times in the domain. Just do it once. This
      makes the query shorter and easier to debug.
      ded636ea
  5. Apr 10, 2017
  6. Apr 09, 2017
  7. Apr 07, 2017
  8. Apr 06, 2017
    • Goffin Simon's avatar
      [FIX] website_sale: Updating price on Optional Products · c8a43430
      Goffin Simon authored
      When changing the quantity of a product in Optional Products modal
      in the shop, the price was not updated according to the pricelist.
      
      opw:726686
      c8a43430
    • Raphael Collet's avatar
      [FIX] expression: avoid useless query when searching on x2many sub-field · 6595cfdf
      Raphael Collet authored
      Searching on a domain like `[('m2m.sub', operator, value)]` currently does
      something like:
      
          right_ids = comodel.search([('sub', operator, value)]).ids
          table_ids = model.search([('m2m', 'in', right_ids)]).ids
      
      and reduces the domain triple to `('id', 'in', table_ids)`.
      
      The domain triple can actually be reduced to `('m2m', 'in', right_ids)`.  With
      this reduction, the search on the field `m2m` will be done as part of the main
      query.  And this will also enable the optimization of the former fix!
      6595cfdf
    • Raphael Collet's avatar
      [FIX] expression: use sub-select when searching on many2many field · 3c2065c8
      Raphael Collet authored
      Avoid pathological performance issue caused by injecting ids retrieved with
      another query.
      
      Consider a domain like `[('m2m', 'in', ids)]` on a many2many field.  The
      current implementation will perform the subquery:
      
          SELECT m2m_id1 FROM m2m_table WHERE m2m_id2 IN (ids)
      
      and inject its result into the main query as:
      
          SELECT id FROM ... WHERE id IN (result_ids)
      
      The latter may be very slow if `result_ids` is a huge list of ids.
      
      The fix injects the first query into the main query as:
      
          SELECT id FROM ... WHERE id IN (
              SELECT m2m_id1 FROM m2m_table WHERE m2m_id2 IN (ids)
          )
      
      As a result, the database will typically JOIN both tables, and avoid generating
      the whole list from the subquery.
      3c2065c8
    • Thomas Binsfeld's avatar
      [FIX] account: browse only one record · 01add1fe
      Thomas Binsfeld authored
      Part of #16282
      01add1fe
    • Christophe Simonis's avatar
      271067f5
    • Goffin Simon's avatar
      [FIX] l10n_at: Vorsteuer 2500 account · d444fbcc
      Goffin Simon authored
      The type of account Vorsteuer 2500 is Non-current Assets(like in l10n_be).
      In this way, the amount due will include the taxes Vorsteuer 10%
      and Vorsteuer 20% when computing the amount due with _compute_residual
      because the account is not receivable or payable.
      
      opw:725619
      d444fbcc
  9. Apr 05, 2017
  10. Apr 04, 2017
    • Nicolas Lempereur's avatar
      [FIX] web: editable list view regression bc031379 (9.0) · 0b2fd600
      Nicolas Lempereur authored
      In 9.0 in some particular instances with embedded views, if:
      
      - an x2many list view is editable,
      - we go from a form view of an existing record to creating a record,
      - the timings of deferred resolving are in a certain order
      
      the x2many list view could be tought as loaded whilst in reality it is
      the 'editable list view' row editing 'form view' that has been loaded.
      
      This could cause sometimes issues after bc031379 because the onchange
      computation would happen before the list view is really loaded.
      
      This is probably an issue with the deferred system in one of the views,
      but it would be rather hard and dangerous to change it.
      
      So this fix introduce an additional test which ignore relational views
      if there is an embedded view.
      
      opw-726701
      opw-726768
      
      note: only needed for 9.0, the relational views have been changed as of
      saas-11 and this issue is not present.
      0b2fd600
    • Thibault Delavallée's avatar
      [FIX] event: correctly compute 'done' state of mail scheduler · 4d3fc120
      Thibault Delavallée authored
      Currently line was incorrect as the purpose is to ensure all lines of
      the scheduler are sent. Currently not send lines are filetered and therefore
      not taken into account. This commits fixes it.
      4d3fc120
  11. Apr 03, 2017
    • Denis Ledoux's avatar
      [FIX] web: textarea of editable list above everything · 75949216
      Denis Ledoux authored
      When expanding a textarea of an editable list,
      by putting a long description for instnace,
      with multiple lines,
      some elements were put above the textarea,
      making the content partially hidden
      
      opw-709894
      Closes #16083
      75949216
    • Pedro M. Baeza's avatar
      [FIX] account: determinist view swticher order · 65910371
      Pedro M. Baeza authored
      Both tree and form view have the same sequence, which haas, at best no effect,
      at worst, shows the form before the tree view.
      In the second case, making that clicking on the bank journal name drives you to
      a new bank statement instead of the list of existing ones.
      
      Closes #16187
      65910371
    • Cédric Pigeon's avatar
      [FIX] stock: new cursor for orderpoint · a1aada9f
      Cédric Pigeon authored
      On large databases, the orderpoint calculation can fail due to the huge
      cache used diring the process.
      
      Instead of using one cursor for the transaction, we create a new cursor
      every 100 orderpoints, to limit the cache size and speed up the
      performances.
      
      opw-726711
      Closes #16158
      a1aada9f
    • Jeremy Kersten's avatar
      [FIX] res_users: show the computed base.user_groups_view view in dev mode · 7db14bbe
      Jeremy Kersten authored
      Before this commit, in dev mode, the view was read from xml with the dummy
      template. Set arch_fs to False will force to use the view in database and so
      the automatically computed view.
      
      This commit closes #16179
      7db14bbe
  12. Apr 02, 2017
Loading