closes odoo/odoo#120250

X-original-commit: 44458824
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Adapting the field faq to the new sanitize api of 16.0

closes odoo/odoo#119369

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

  Fixes a situation where users who are part of the Attendances Officer (or Manager) group but
  without access to private employee data would see the following error when trying to book time
  off.

  `ValueError: Invalid field 'last_check_in' on model 'hr.employee.public'`

  Other instances of the same ValueError were observed by managers trying to approve employee leave
  and employee expenses.

  As per hr/models/hr_employee.py:22-26 fields not available on hr.employee.public should have
  groups='hr.group_hr_user' and this was not the case in hr_attendance.

closes odoo/odoo#120259

X-original-commit: d0aad0bf
Signed-off-by: Kevin Baptiste <kba@odoo.com>

In the Invoicing dashboard, the "Average Invoice" scorecoard displays
the wrong amount of invoices. It displays the number of
"account.invoice.report" lines.

This commit fixes the issue by displaying the count_unique measure
of "move_id"

task 3180524

closes odoo/odoo#120253

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Deleting a kit BoM will lead to an error if the kit is in the middle
of a sale process

To reproduce the issue:
1. In Settings, enable UoM
2. Create a product category PC:
   - AVCO
   - Auto
3. Create three storable products P_kit, P_01, P_02
   - UoM of P_01: `m`
   - UoM of P_02: `kg`
4. Create a BoM:
   - Product: P_kit
   - Type: kit
   - Components:
     - 1 x P_01
     - 1 x P_02
5. Create and confirm a SO with 1 x P_kit
6. Force the delivery
7. Delete the BoM
8. Create and confirm the SO's invoice

Error: a traceback appears "ValueError: Expected singleton: uom.uom..."

Because of the configuration, when posting the invoice, we compute
the COGS. During that process, we need the average price of P_kit
https://github.com/odoo/odoo/blob/640907ec1852c4e477957c865549a87d3ae840dd/addons/sale_stock/models/account_move.py#L133
We give to that method the components' SMs. In
`_compute_average_price`, since we don't find a BoM, we will bypass
the mrp override
https://github.com/odoo/odoo/blob/419e42132d9526e9d98c2126158d4f88716d17c4/addons/mrp_account/models/product.py#L48-L50
As a result, it leads to
https://github.com/odoo/odoo/blob/640907ec1852c4e477957c865549a87d3ae840dd/addons/stock_account/models/product.py#L680-L684
Where we will have the candidates of all components (i.e., several
different products). But that method is not designed for such a
situation. This is the reason why, when calling `_consume_all`, it
will fail:
https://github.com/odoo/odoo/blob/858d24a611c4c8af0dcae82a6eb4077e391398ed/addons/stock_account/models/stock_valuation_layer.py#L85


We try to get the rounding of the product, but there are actually
two of them (the two components) -> singleton error

OPW-3218141

closes odoo/odoo#120251

X-original-commit: d38afd77645b6855d45d709d52fecaae3c86bbda
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

[FIX] account_stock, purchase_stock: prevent AttributeError when confirm vendor BILL/refund with FIFO/AVCO

AttributeError "account.move.line" object has no attribute "purchase_line_id"
occurs in `stock_account` when we confirm vendor BILL or REFUND with product
costing method "first in first out" or "average cost".

With the recent reflacted changes in commit[1], the `purchase_line_id`
field is used and it belongs to `purchase`, but it is not installed and does
not depend, so it causes an error.

The above issue is solved by removing some code in commit[1] from
`stock_account` and adding it to `purchase_stock`.

committ[1] - https://github.com/odoo/odoo/pull/99411/commits/e9ce88a9372843abef7cf8fc94c4dbe5f16c5fa3#diff-e6134a1a5a13058e35f86426a96db0acac44553fa3b0ca26716390f7b19fc96cR318



sentry-3975529425

closes odoo/odoo#117876

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

This PR reverts https://github.com/odoo/odoo/pull/119912 and
https://github.com/odoo/odoo/pull/119380 because of rounding issues
with `float_round` method. The rounding should be added to the carriers
if it is needed in the future.
(e.g. https://github.com/odoo/enterprise/pull/40536

)

opw-3289042

closes odoo/odoo#120232

Signed-off-by: Tiffany Chang <tic@odoo.com>

closes odoo/odoo#120167

X-original-commit: f8d36d4a
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

Steps to reproduce the bug:
- Go to Decimal accuracy:
    - Select the “Product Unit of Measure”
    - Set the Value to “4”

- Create a storable product with BoM:
    - add any product as component
    - save
    - Click on the BoM overview widget

Problem:
The “Product UoM” precision is not used

opw-3288403

closes odoo/odoo#120079

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

closes odoo/odoo#119775

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this PR from version 15 to 16.1, the approval date was not populated so
when you were in studio and add this field manually. The field stayed empty
which wasn't the behaviour we wanted.

When clicking the approve button, the approval date is now populated with the
complete date.

closes odoo/odoo#120165

Task-id: 3254147
X-original-commit: ef5715c3
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>

Steps to reproduce:
- activate `group_stock_reception_report` in settings
- activate `auto_show_reception_report` for the "Receipts" operation type
- create a receipt w/ any product + confirm
- create a return w/any product + confirm
- select both the receipt + return in the (Operations > Transfers) list
  view > action > Validate

Expected result: both pickings are validated
Actual result: stacktrace due to expected singleton ValueError

enterprise PR : https://github.com/odoo/enterprise/pull/37518


task-3204596

closes odoo/odoo#120159

X-original-commit: b2ac4b2f30e15c4b8a50628798b2fc39d7d43331
Related: odoo/enterprise#40552
Signed-off-by: Tiffany Chang <tic@odoo.com>

Starting with Firefox 109, a widget element prototype that is put
inside an iframe will not be instanceof its original constructor.
See: https://github.com/webcompat/web-bugs/issues/118350

This is because a node that is adopted by an iframe will have its
prototype changed to match the constructor from within the iframe
instead of its original one. This has been the case for a long time.
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1470017

It largely went unnoticed because of another quirk of Firefox related
to the use of instanceof which was fixed in version 109.
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1360715



Since this bug was fixed it became apparent, in the form of a
traceback, that the wrong instance of ClipboardJS was being used
in the case of Firefox, due to the forced prototype change.

This commit could be reverted once Firefox is fixed.

Steps to reproduce the issue in Firefox > 109:
- Create a new mass mailing.
- Choose the third template with "Thank you for joining us!".
- Click on the "LOGIN" button link inside the email.
- Get a traceback about a paremeter not being the right type.

Task-3186513
OPW-3172914

closes odoo/odoo#120122

X-original-commit: c0da01c7
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Co-authored-by: Jinjiu Liu <jili@odoo.com>
Co-authored-by: David Monjoie <dmo@odoo.com>

Stock valuation layers are generated for storable and consumable products. However, given that we don't keep track of its quants we hide those layers by default.
by adding a domain [('product_id.type', '=', 'product')].
On the dashboard, such domain is currently not present. As a result, our inventory valuation value is not the same if we look at it though the dashboard.
This commit adds the same domain so that the value of the inventory shown is always the same (which means not including consumable products).

OPW-3275521

closes odoo/odoo#120118

Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

closes odoo/odoo#118159

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Co-authored-by: Loan (LSE) <lse@odoo.com>

closes odoo/odoo#117021

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps to reproduce:

- Install crm
- Go to settings and activate leads in crm.
- Go to leads list and select any lead, now mark it as lost.

Issue:

It will ask for lost reason. But if we do it from the Leads form view,
we don't get to set any reason. I discussed with the PO and we don't
want to add the lost reason in the leads.

Solution:

Modified action of lost so it takes leads into account.

opw-3119748

closes odoo/odoo#119987

X-original-commit: 3834577a
Signed-off-by: Maruan Aguerdouh Mohtar (magm) <magm@odoo.com>
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce:
- install website_sale and website_sale_loyalty;
- activate Payment Providers Demo and Wire Transfer;
- put them in 'test mode';
- go to ecommerce;
- add a gift card;
- process the checkout.

Issue:
Depending on the configuration of the payment acquirer used,
sometimes the amount displayed is doubled
(in the display of the gift card amount
after the payment process in brackets).

- Demo in test mode: amount will be doubled
- Wire Transfer in test mode: amount will not be doubled

Remark:
The amounts are correct in the backend.

Cause:
Sometimes the `action_confirm` function is used and sometimes it is not.
When you enter it, the points of the coupon are already set.
Therefore, we add the amount again in the `_get_real_points_for_coupon`.

Solution:
Display the information of the gift card only
when the sale order is validated.
Therefore, there is no need to bypass (with `post_confirm`)
to add the points that will be valid when the sale order is confirmed.
Because with the display correction, we won't see the points.

opw-3166164

closes odoo/odoo#113246

Signed-off-by: Lefebvre Thomas (thle) <thle@odoo.com>

On Debian based systems, the `tzdata` package is maintained to reflect changes
in timezones and there is no need to upgrade the `python3-tz` package.
On the other hand, for those who are using `pip` and thus our `requirements.txt`,
the package needs to be up to date. By unpinning it in the requirements.txt:

- new installations based on pip will be up to date
- older installations based on pip can easily upgrade
- debian based installations have to maintain the tzdata package
- mixed installs like on runbot will rely on Debian tzdata

closes odoo/odoo#117527

closes odoo/odoo#120155

closes odoo/odoo#120164

X-original-commit: 710a2b2a
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Before this commit
==================
Test connection without checking GST number.

After this commit
=================
This commit adds functionality to check whether the GST number is present
or not before testing the connection.

Task id - 3246786

closes odoo/odoo#120100

Related: odoo/enterprise#40522
Signed-off-by: Josse Colpaert <jco@odoo.com>

Commits:

[FIX] components: properly differentiate t-call subcomponents
[REF] devtools: Better messages forwarding
[FIX] devtools: Fix app methods patching
[DOC] Fix a code bug in the example of slots

See https://github.com/odoo/owl/releases/tag/v2.1.3



closes odoo/odoo#120193

Signed-off-by: Géry Debongnie <ged@odoo.com>

Sales profit tax witholds should not affect the tax report 103, it should be empty

closes odoo/odoo#119133

Signed-off-by: Josse Colpaert <jco@odoo.com>

- Adds early pay discounts, cash dicounts accounts
- Sets the ecuadorian chart of accounts as updatable (same as most
localizations)
- Fix the account type, many should be liability current and not liability payable (otherwise the usage of these accounts affects the payable/receivable reports)

closes odoo/odoo#118559

Signed-off-by: Josse Colpaert <jco@odoo.com>

When settling a sale.order from the pos app, it's possible that the sale.order
have different partners assigned to it (partner_id, partner_shipping_id,
partner_invoice_id). After this commit, we are now properly assigning these
partners to the generated invoice.

Additionally, this commit makes the settling of sale.order more robust by
avoiding issue on having multiple incompatible sale.orders in a pos.order (more
than 2 sale.orders and their partners are not the same). After this commit, we
are only reusing the current pos.order as container of the new sale.order to
settle if the sale.order is compatible to the current pos.order. Basically, we
now only allow adding new sale order to the current order if the partner_id,
partner_invoice_id and partner_shipping_id of the new sale.order are the same to
the current pos.order's linked sale.order. In other words, if the new sale.order
to settle is incompatible to the current pos.order, we create a new pos.order to
settle that sale.order.

closes odoo/odoo#118492

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/e06ca832 [REL] 16.0.9
https://github.com/odoo/o-spreadsheet/commit/196f8a3f [FIX] tests: Use only faketimers in find&replace Task: 3293232
https://github.com/odoo/o-spreadsheet/commit/b3996689 [FIX] xlsx: export computed format
https://github.com/odoo/o-spreadsheet/commit/35410ab1 [FIX] xlsx: Always export value of unsupported formulas Task: 3276929
https://github.com/odoo/o-spreadsheet/commit/084ffb45 [FIX] sheet: add allowDispatch on ADD_COLUMNS_ROWS Task: 3272589
https://github.com/odoo/o-spreadsheet/commit/c0a09560

 [FIX] core: Prevent dispatch of invalid command payloads Task: 3272589

closes odoo/odoo#120107

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Steps to reproduce:
- create a product;
- disable the continue selling option for the out-of-stock;
- do not have a stock quantity for this product.
- go to ecommerce;
- without click on the product, add it in the cart with the cart icon (on the picture).

Issue:
It is possible to add the product to the cart.
If we repeat this several times, we will create quotations.

Solution:
Hide the button if the product is a storable product
and we don't want to sell it if we have no stock.
We also check the quantity available.

opw-3148069

closes odoo/odoo#119982

X-original-commit: 37c7c02b83c2257278e78d218e7a4098a5630c33
Signed-off-by: Lefebvre Thomas (thle) <thle@odoo.com>
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

This commit updates the documentation URLs to the current URLs, although
there are already redirect rules in place as fallback.

Related odoo/documentation pull requests:

Calendar:
https://github.com/odoo/documentation/pull/4032
task-3217827

POS
https://github.com/odoo/documentation/pull/4226
task-3284514

Inventory
https://github.com/odoo/documentation/pull/2556



closes odoo/odoo#119824

Related: odoo/enterprise#40372
Signed-off-by: Raphael Collet <rco@odoo.com>

Step:
- Create a product with sale price 120 USD
- Create a giftcard with balance 40 uSD
- Create a free Shipping cost of 40 USD fixed price and freeing above 100 USD
- Go to website->shop, select the product and checkout the cart(the shipping is free because price exceeds 100)
- Add the gift card to payment

Issue:
The shipping price gets from free to 40

Cause:
When computing the cost of the shipping the fact of the presence of a giftcard is not considered.

Solution:
Create a method to returns the amount of giftcard from a sale order and add to total price to check if the shipping is free

opw-3107284

closes odoo/odoo#110952

X-original-commit: 05e3f4dfc16f96cf31d9cf7afd1e25dc2f607d67
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>
Signed-off-by: Djoumatchoua Eteil Junior (etdj) <etdj@odoo.com>

Usecase to reproduce:
- Set the currencies as 1€ = 2$ ($ as company currency)
- Create a PO for a product in AVCO auto with a price of 100€
- Do the receipt
- Change the rate as 1€ = 4$
- Bill the PO

Expected behavior:
- One correction account.move.line for the 200$ and the stock
interim receipt account reconciled.

Current behavior:
- An aml from the price difference with the 200$
- Another from the currency exchange also for 200$
- The line from the price diff is not reconcile

`_stock_account_anglo_saxon_reconcile_valuation` should never reconcile
account.move.line from a price difference correction without the context
key no_exchange_difference because the currency correction is already
handle in the correction layer.

closes odoo/odoo#118626

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Steps to reproduce:

- Install `E-learning` module
- Create a user X with only "Officer" as rights for `E-learning`
- Login with user X
- Go to `E-learning` and open any course
- Ensure that the user X is not the responsible and that the course
  enroll policy is set to "On invitation"
- Invite any user not already a member

Issue:

  No user was invited (not added as member) and no warning message
  raised.

Cause:

  Due to the ir.rule "Channel: officer: create/write own only", the
  `Officer` user can only edit (and therefore invite members) on
  courses where he is responsible.

Solution:

  In the wizard, we check if the user has the rights to invite members
  on the course when sending the invitation. If not, we raise an error.

opw-3133733

closes odoo/odoo#119724

X-original-commit: 0d0fb3a4
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>

Before this commit, a race condition could occur between the unpin
of a channel and the registration as the partner as actively typing.

This resulted in the following traceback:

```
Uncaught Promise > Cannot set properties of undefined (setting '_inverse_Thread/orderedTypingMembers')
TypeError: Cannot set properties of undefined (setting '_inverse_Thread/orderedTypingMembers')
    at ModelField._insertOtherRecord (https://www.odoo.com/web/assets/37899128-d607482/web.assets_backend.min.js:8547:361)
    at ModelField._setRelationInsertAndReplace (https://www.odoo.com/web/assets/37899128-d607482/web.assets_backend.min.js:8552:71)
    at ModelField.parseAndExecuteCommands (https://www.odoo.com/web/assets/37899128-d607482/web.assets_backend.min.js:8532:40)
    at ModelManager._update (https://www.odoo.com/web/assets/37899128-d607482/web.assets_backend.min.js:8850:40)
    at ModelManager.update (https://www.odoo.com/web/assets/37899128-d607482/web.assets_backend.min.js:8706:36)
    at model.update (https://www.odoo.com/web/assets/37899128-d607482/web.assets_backend.min.js:8876:137)
    at model.registerCurrentPartnerIsTyping (https://www.odoo.com/web/assets/37899128-d607482/web.assets_backend.min.js:10699:659)
    at model.handleCurrentPartnerIsTyping (https://www.odoo.com/web/assets/37899128-d607482/web.assets_backend.min.js:9528:179)
    at model.onInputTextarea (https://www.odoo.com/web/assets/37899128-d607482/web.assets_backend.min.js:9543:100

)
```

This commit fixes the issue by avoiding adding an undefined member to
the typing members of a channel.

closes odoo/odoo#120052

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Steps to reproduce:

  - Install 'CRM' module (for test purpose)
  - Configure the google calendar credentials on Odoo
  - Go to CRM -> Configuration -> Activity Types and create a new one
  - Set 'Meeting' as Action
  - As default note, add some bullet points:
    ```
    Hello :
      - First point
      - Second point
      - Third point
    ```
  - Open any Opportunity and create a new Activity (in the chatter)
  - Select 'Meeting' as activity type and open the calendar
  - Add a new event (description should be field with the default note)
  - Open the event (on Odoo and/or Google Calendar)

Issue:

  The description of the event is broken (bullet points missing).

Cause:

  When syncing the event from Odoo to Google Calendar, the description
  is converted to plain text (using `html2plaintext` function).
  Then, when syncing the event from Google Calendar to Odoo,
  the description is also updated locally with the remote one.

Solution:

  Don't convert the description to plain text but use
  `tools.html_sanitize` on the html content instead to sanitize it.

opw-3105194

closes odoo/odoo#119646

X-original-commit: 21f3f9aa
Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>

Steps to reproduce
==================

- Use an IOS device
- Open a view with a float field
- Try to edit it

The virtual keyboard displayed is missing a dot, so you can only input
integers

Cause of the issue
==================

For fields that should accept a float value, the inputmode attribute
should be decimal.
Also, specifically on IOS, even with the inputmode set to decimal, it
isn't possible to enter a negative value.

> decimal:
> Fractional numeric input keyboard containing the digits and decimal separator
> Devices may or may not show a minus key (-)

Source: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode



Solution
========

For IOS, remove the inputmode attribute so that the default keyboard
shows. For other devices, use the decimal/numeric value depending on
whether a float should be accepted.

opw-3269275

closes odoo/odoo#119540

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

opw-3289147

closes odoo/odoo#119963

Related: odoo/enterprise#40443
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

DataURL returns 'data:' in Chrome for empty files which is not valid dataURLas
it expects 'data:<mimetype>;base64' . This DataURL method is used to obtain
base64 representation of the file data,. That's why the 'data' argument is
missing and error is being generated.

Steps to reproduce:
1) Open Notes and create a new Note in Chrome.
2) Add a new attachment using /image command.
3) Add an empty file.

By applying this,it will return proper format for empty file.

sentry - 3749971166

closes odoo/odoo#112416

Signed-off-by: Samuel Degueldre <sad@odoo.com>

Scenario:

- set a quotation template on a quotation that adds lines ordered with
  a sequence (eg. 3 lines with sequences 10, 11, 12)
- add lines in this quotation
- save

Issue:

The added lines have sequence 10 and the seen order changes.

This is caused by 6f11060d that tries to
mitigate a more rare issue when there is more than one page of lines.

Solution:

Reverting the previous fix, and setting the sequence of the first line
to -99:

- when resequencing the first page, the sequence will be -99 to -60 =>
  records from the second page will not get in the first page

- new lines will be added at the end

Issues still present:

- when resequencing the second page, item from 3 pages get into it (it
  was already the case before 6f11060d)

- when adding a new line (without resequencing), it is added at the end
  and not at the beginning of the next page

But those are just behavior in any list view (as is the original issue
of 6f11060d, but since it was partially
fixed for a year, this patch try to give an in-between solution instead
of just reverting it).

opw-2833913

closes odoo/odoo#119890

X-original-commit: e342f3dd3d9454cae50515b9f75603579051daca
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

- process modules to uninstall individually in order to better handle
  their state at that point
- uninstall (and reinstall) modules in provided order, rather than
  whatever postgres feels like (or a sort which might not match what
  we want), mostly useful when uninstalling modules in bulk
- warn if a module is either missing or already uninstalled, rather
  than silently do nothing

closes odoo/odoo#119848

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

- switch to `dictConfig` for easier bulk-manipulation of loggers
- set `unlink` and `ir_model` loggers to warning, to limit the
  humongous spam that is a normal uninstall session

Part-of: odoo/odoo#119848

Add subcommands to make running the script clearer (as exclusive
switches is a bit weird nowadays).

Keep the old `--uninstall` and `--standalone` switches, but make them
mutually exclusive (and optional) to retain current behaviour.

Part-of: odoo/odoo#119848