Steps to reproduce the bug:

- Let's consider a user U with a related partner P
- Log with an internal user IU without Admnistration/Settings and Employee Officer access rights
- Create an employee E with address_home_id = P and save

Bug:

An access right was raised because the mobile of P was written on P and
the error was raised at https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/models/res_partner.py#L531



Due to this bug, only internal user with Admnistration/Settings access rights can create an employee
linked to a contact of an internal user.

opw:2445953

closes odoo/odoo#65848

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

closes odoo/odoo#65796

X-original-commit: 054f3a53
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps:
- Install mrp
- Go to Manufacturing > Master Data > Bills of Materials
- Create a BoM
  - Components:
    - Add a component
- Save
- Click the component
- Close the modal window
- Click the component once more

Bug:
Traceback here:
https://github.com/odoo/odoo/blob/55a6642a9621fa9683895d5d45a015bb04c3017b/addons/web/static/src/js/views/basic/basic_view.js#L147
Error: can't convert undefined to object

Explanation:
As seen on the line just above:
https://github.com/odoo/odoo/blob/55a6642a9621fa9683895d5d45a015bb04c3017b/addons/web/static/src/js/views/basic/basic_view.js#L146


`fieldsInfo` might not have the view we are looking for.

opw:2452142

closes odoo/odoo#65737

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

The function `_get_possible_combinations` generates possibles combinations
 for the product template attribute values (ptav) of each product template
 attribute line (ptal) of a given product template. It used to iterate over
 them using a cartesian product. A combination can be invalid if it
 contains two incompatibles ptav. The problem is that it used to filter out
 invalid combinations after generating them. It's a problem because there
 can be a lot of invalid combinations to filter out before finding a valid
 combination. Even before the first valid combination if the first ptav of
 the two first ptal are incompatible.

The solution brought by this commit is to reject the invalid combinations
 while building them rather than after. It does so by using a cartesian
 product implementation with early rejection. The algorithm tests each
 ptav when incorporating it in a partial combination and if it's
 incompatible, it goes to the next partial combination and thus skips all
 combinations starting with the invalid partial combination.

The client that reported the issue has a product template with about 25
 ptal with an average of 9 ptav. The ptav of the first ptal was
 incompatible with the first ptav of second ptal. It had to build and
 filter out 5.76*10^15 ptav before finding the first valid ptav. If we
 generate 10^6 ptav by second (it's much less) user would get first ptav
 after 182 years. Now it's instantaneous.

opw-2335936

closes odoo/odoo#65723

X-original-commit: 2e5634fa
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

In a previous fix [0], the call to exif_transpose was kept to allow
rotation of images format different than `JPEG`.

After a small test, it appeared that the call would crash if the image
in another format had the same `LensInfo` tag.
So it's safer to not call this method at all.

With this commit, the rotation tag is retrieved disregarding the file
format by using the `getexif` method if available, falling back to the
private method for Pillow < 6 support.

As a bonus, a test is also added with a small embedded `JPEG` image,
crafted with an `Orientation` exif tag and, for reference,  the
`LensInfo`tag that caused so much trouble.

[0] b83c48d5

closes odoo/odoo#65653

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

In "Inventory Valuation", when click "Inventory at Date" then "confirm".
Record for consumable products will be shown in the report.

Previously fix in #62622 which disabled svl for consumable products,
then rolled back in #63386 due to mrp need to create svl for consumables
to analyse cost.

In this commit, we add a domian filter to not show consumables in
"Inventory Valuation"

Task 2449211
PR #65726

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Because of context:

{'search_default_account_id': [active_id]}

refreshing on the tax audit action could cause an error because in normal
use case we have active_id that is never an account.account id (but for
example an account.tax.report.line).

There doesn't seem to be any use case where that context is useful since
it was introduced in 2017 (81089042), this action is always used with an
overriden context. So this commit is removing it.

opw-2388448

closes odoo/odoo#65754

X-original-commit: f7998c04813c65ba0b8ba046c052332ede2ba1cb
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Previously, the many2one widget from the web_editor used jQuery's
'.html()' method when inserting a record name into the page. The record
name was not HTML-escaped before this, which may have unexpect result
and break the layout.

This commit fixes that by using the '.text()' method instead.

This bug only affects pages containing a many2one (contact excluded)
at the time of selection and not after the selection.
e.g. on the /event page, changing the category of an existing event
via the website editor

closes odoo/odoo#65639

X-original-commit: 53aff7f0
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

This commit makes it so when the bom structure report (Structure & Cost
smartbutton) is opened the product quantity defaults to the BoM's
`product_qty` amount rather than 1.

Steps to reproduce:
- Create/open a BoM
- Set `product_qty` to any value greater than 1
- Click on "Structure & Cost" button.

Expected result: product quantities scaled to the `product_qty`
Actual result: product quantities scaled to Quantity = 1

closes odoo/odoo#65732

Task: 2429885
X-original-commit: 30c05ad9
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

When `qty_available` was being called
for a kit and its components at the same time,
e.g.:
 - Kit product
   - Product 1
   - Product 2

The kit product available qty was always computed to `0.0`,
because when computing its component available quantity,
they were computed to `0.0` because they were marked
as `protected` by the ORM when calling the compute method
for these records at the first call.
When the `qty_available` compute method for the kit
then called recursively the `qty_available` compute
method for the component, as the component record
were marked as protected,
the ORM filled their value with the Falsy value `0.0`.

This issue occured particularly in the upgrade integrity unit test
which makes sure the available quantities of the products remain
unchanged after upgrade. This test computes the available
quantities for a bunch of products at the same time,
and its therefore likely a kit product gets its available
quantity computed as the same time than its components.

upg-3185
upg-4215
upg-4228
upg-5558
upg-5745
upg-5856
upg-6012
upg-6064
upg-6076
upg-6306
upg-6514
upg-6588
upg-6729

closes odoo/odoo#65701

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Loop inner calls should use mailing not self.

Task ID-2455433

closes odoo/odoo#65739

X-original-commit: 3ff00944
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

such fields have store=True, but they don't exist in table.

---

https://github.com/odoo/odoo/pull/65232#issuecomment-773298323
https://github.com/odoo/odoo/commit/02417290191c22c9c99e6dc96a572c21f38e64f1



closes odoo/odoo#65652

X-original-commit: 2eee717d
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

The Lesotho Loti has the symbol M and not L
Example of use:
http://lestimes.com/businessman-xie-in-m27-million-scandal/
http://lra.org.ls/sites/default/files/2020-10/LRA%20Integrated%20Annual%20Report%202019.pdf



Fixes odoo/odoo#62807

closes odoo/odoo#65644

X-original-commit: f6b55a46
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

When using command "6" (SET), the one2many field's inverse was not
assigned on the lines.

closes odoo/odoo#65618

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

closes odoo/odoo#65614

X-original-commit: 4a08c12a
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

On odoo.sh, in some circumstances, when uploading an image as attachment
in odoo leads to a blank image thumbnail. The same image was
successfully uploaded in the same odoo version on runbot instance.

After some investigations, it appears that the issue comes from the
python-pillow version used. A few bugs exists [0,1,2] in python-pillow
7.0.0 (packaged in ubuntu Focal) that are now fixed in version 8.1.0
[3,4,5] (packaged in Debian and specified in Odoo requirements.txt),
that causes the `ImageOps.exif_transpose` method to fail.

The present issue can be considered as a corner case as only images with
particular exif tags cause the issue.

The present fix is a simple workaround by first checking the presence of
the orientation tag and using it, we can avoid a call to the
`exif_transpose` method.

opw-2369166

[0] python-pillow/Pillow#4346
[1] python-pillow/Pillow#3973
[2] python-pillow/Pillow#4238
[3] python-pillow/Pillow#4637
[4] python-pillow/Pillow#3980
[5] python-pillow/Pillow#4009

closes odoo/odoo#65584

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

- Install product_margin
- Go to Invoicing > Customers > Invoices and create an Invoice
- Add a Credit Note
- Go to Accounting > Reporting > Product Margins and check Product used in the Invoice
The "Avg. Sale Unit Price" is incorrect. It should be 0 as it is for "# Invoiced in Sale"

Credit Notes are not taken into consideration when computing "Avg. Sale Unit Price".
This is also the case for discount.

opw-2382797

closes odoo/odoo#65464

Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>

This commit partially reverts commit [1], and backports commit
[2] from 14.0.

Even though [1] correctly fixes the faulty scenario, there is a
variation of this scenario which isn't handled. It has been
fixed in 14.0 by [2], and that fix also fixes the original
issue of [1]. So we keep the tests of both [1] and [2], and
the fix of [2].

[1] dd97d446ee94a32089f200bb7122139d31e69873
[2] f6c06bd0

closes odoo/odoo#65540

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

Before this commit, it was not possible to center a button using the
editor option 'align center'.

It is because, using document.execCommand(), the Chrome browser doesnt
want apply 'text-align: center' on nodes with centered children. And
the buttons have the boostrap class '.btn' which adds text-align:
center.

So the hack here is disabling the text-align property from the '.btn'
class during the execution of document.execCommand().

task-2423935

closes odoo/odoo#64461

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

PR [1] recently backported a several tricky x2many fixes from 14.0
to 13.0. Unfortunately, in 13.0, there is a scenario (that isn't
in 14.0) for which commit [2] produces a crash:

 - have an x2many field A (displayed as a list) that contains
   another x2many field, say B
 - B is also in A's form view, but it is 'invisible="1"'

Before this commit, it crashes when you tried to open A's form
view.

For instance, go to Manufacturing > Bill of Materials > form view
> click on a component line.

Since B is invisible in A's form view, we don't load its
fieldsInfo (as we won't need to display it). This commit refines
[2] to detect this case and avoid the crash.

[1] https://github.com/odoo/odoo/pull/65101/
[2] https://github.com/odoo/odoo/pull/65101/commits/ab7b7cfe5365a37fcf44f98154f1b48c754ea80c



opw 2452732

closes odoo/odoo#65525

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

closes odoo/odoo#62702

Signed-off-by: Josse Colpaert <jco@openerp.com>

Follow-up of https://github.com/odoo/odoo/pull/65357



closes odoo/odoo#65494

X-original-commit: 87b59a83
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: backspac <backspac@users.noreply.github.com>

Steps:
- Install mrp, stock
- Go to Inventory > Configuration > Operation Types
- Edit Delivery Orders:
  - Show Detailed Operations: Checked
- Go to Master Data > Products
- Create two products (1) (2)
- Click (1)
- Click the "Bill of Material" smart button
- Create a BoM:
  - BoM Type: Kit
  - Component: (2)
- Go to Overview
- Click Delivery Orders
- Create a Delivery Order:
  - Add (1) with an initial demand of 1
- Mark as ToDo
- Click Edit:
  - Detailed Operations tab:
    - Add (1) with a done quantity of 1
- Validate and create a Backorder

Bug:
Record does not exist or has been deleted.
(Record: stock.move(60,), User: 2)

Explanation:
When confirming a `stock.picking` with `mrp` installed, the action goes
through `action_explode()`.
https://github.com/odoo/odoo/blob/d9ea1d5f054f05197581acf67c8a9c1e6acb8d02/addons/mrp/models/stock_move.py#L154
This action splits the components of the product with a Kit (`phantom`)
BoM instead of manufacturing it. When everything is split, the
`stock.move` unlinks itself because it has been replaced with its
components. `action_explode()` then returns the new components. Trying
to call a method on the unlinked move will result in an error.

This commit replaces the move with the newly generated component moves.

This is safe to do in `stock` because the non-overridden
`_action_confirm()` returns the move it was called on as seen here:
https://github.com/odoo/odoo/blob/d9ea1d5f054f05197581acf67c8a9c1e6acb8d02/addons/stock/models/stock_move.py#L790



opw:2450016

closes odoo/odoo#65493

X-original-commit: 67b52df6
Signed-off-by: backspac <backspac@users.noreply.github.com>

Steps to reproduce the bug:

- Accounting - Journal Entries - form view - Print - Invoices

Bug:

A UserError was raised 'Only invoices could be printed.' but in the attachment,
the PDF was generated.

opw:2452278

closes odoo/odoo#65446

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Currently, the subtype checked selection is not saved when the user adds and
removes subtypes. Indeed either an addition is performed, either a removal
but having both is not correctly taken into account when updating an existing
subscription.

How to reproduce
  * click on the pencil icon to edit the subscription of the follower;
  * as an example default "Discussions" will be the only one selected;
  * check "Notes" and save;
  * -> this works;
  * click again on the pencil icon and uncheck "Notes" and check "Activities"
    then save;
  * -> this does not work as only removal is performed (Activities is not
    checked);

The problem only occurs when you unchecked subtypes and checked other ones.

This commit fixes that behavior by taking into consideration both new
subtypes and subtypes to remove.

LINKS

Task ID-2205643
Task ID-2241688
COM PR #56775

X-Original-Commit odoo/odoo@d16b03663823ea5a8192ef863c9975af0f4b246d

closes odoo/odoo#65315

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Co-authored-by: Thibault Delavallee <tde@odoo.com>
Co-authored-by: Shahista Pathan <sat@odoo.com>

Issue

	- Install "Field Service" app
	- Create new task
	- Try to select Planned start/end date and valid

	Daterange picker is hiding when trying to scroll down to valid selection.

Cause

	The daterange picker is closed when ev.target is not inside the picker,
	however ev.target always return the document element.

Solution

	Do not hide daterange picker on scrolling if on mobile.

	Note : It will only apply if scrolling on the daterange picker and
	       will still hide if scrolling outside this last one.

opw-2428099

closes odoo/odoo#64406

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

Filling the new column in SQL is dramatically faster than doing it via
the ORM, which iterates over all the records in the table.

The test case is creating a related field for 100+ records with distinct
values.  Setting the field's value was taking more than 100 queries.  It
now takes 3 queries.

task-2449313
opw-2380445
opw-2389376
https://github.com/odoo/enterprise/pull/15910



closes odoo/odoo#65409

X-original-commit: 57a7496ec6ae06cfc41536ceee9c3a819603e889
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

Steps:
- Edit the current company (1):
  - Country: Switzerland
  - Currency: CHF
- Install l10n_ch
- Go to Invoicing > Configuration > Bank Accounts
- Edit Bank:
  - Bank Account: create a new one:
    - Account Holder: (1)
- Go to Configuration > Journal
- Edit Customer Invoices:
  - Advanced Settings tab:
    - Communication Standards: Switzerland
- Go to Customers > Customers
- Create a new customer (2):
  - Fill in street, city, zip code and country
- Edit (2):
  - Contacts & Addresses tab:
    - Add:
      - Select Invoice Address
      - Contact Name: Keep this field blank
- Go to Customers > Invoices
- Create a new one:
  - Customer: "(2), Invoice Address"
  - Add a product
- Validate it
- Click Print QR-Bill

Bug:
Traceback here:
https://github.com/odoo/odoo/blob/b76e9ef658bde0178fa1660b6ad27b880e91632a/addons/l10n_ch/models/res_bank.py#L129


TypeError: 'bool' object is not subscriptable

Explanation:
The contact name of an address is optional. When nothing is filled in
that field, it returns `False`, hence the error.
Using the commercial company name ensures a name is put in the invoice,
even if the contact doesn't belong to a company.

opw:2447158

closes odoo/odoo#65394

X-original-commit: d9ea1d5f
Signed-off-by: backspac <backspac@users.noreply.github.com>

Steps to reproduce the bug:

- Let's consider a storable product P with cost = 10€
- Let's update quantity to 10 units
- Export an update of P in an xlsx file F
- Change in F the cost of P from 10€ to 20€
- Import F
- Go to Inventory valuation

Bug:

The valuation of P was still 100€ instead of 200€

opw:2424292

closes odoo/odoo#65324

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Steps to reproduce the bug:

When trying to import or create a expense product with supplier taxes,
the supplier taxes were removed.

PS: The field vendor taxes is available in the expense product view

opw:2444551

closes odoo/odoo#65191

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

In a multicompany environment, when a expense is created from the
expense email alias, the expense account is computed with SUPERUSER
context, so depending on the SUPERUSER set company, we could get
a mismatch of expense and employee's company and the account one, wich
causes a subsequent error when trying to post the expense.

closes odoo/odoo#65366

X-original-commit: dca2127f
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Co-authored-by: simongoffin <sig@odoo.com>

Error message should not be copied for obvious reason.

Backport of a49e3887

opw:2440558

closes odoo/odoo#65363

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

We should open the cashdrawer when paying with a non cash payment
method if change should be returned to the customer.

Use case: The customer wants to pay 10€ more with his card to get 10€
in cash in return.

closes odoo/odoo#65257

Taskid: 2449312
X-original-commit: 92b1d673
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
Signed-off-by: Antoine Prieëls <aprieels@users.noreply.github.com>

When using the windows installer in French language, the `Hôte` label
used to configure postgresql server does not display correctly.

The LangString documentation does not specify how to use the special
characters but after some tests, specifying a BOM for the nsi file seems
to be the way to go.

closes odoo/odoo#65362

X-original-commit: 3d0871d1
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Currently, when exporting move lines via for example the partner ledger,
we are not displaying the currency in any way in the xlsx.

For some company, this can be limiting since they may want to do
post-treatment inside the file after export, which can require such
information.

This change will add the 'always_set_currency_id' field as optional
into the list view of the amls, allowing to keep the information about
the currency when exporting if needed.

task id #2381355

closes odoo/odoo#61821

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Steps:
- Go to Accounting > Configuration > Accounting > Bank Accounts
- Create a new Bank Account
  - "Bank Account" field: create and edit a new one
    - Account Holder: Anyone but your company
- Save

Bug:
Validation Error: The holder of a journal's bank account must be the
company (YourCompany).

Explanation:
The error is not clear enough. Users may be confused because this
validation error appears upon saving a "Bank Account Journal"
(`account.journal`) but is talking about "Partner Bank Account"
(`res.partner.bank`) which is a field of the "Bank Account Journal".

opw:2448183

closes odoo/odoo#65322

X-original-commit: b76e9ef6
Signed-off-by: backspac <backspac@users.noreply.github.com>

Steps:
- As admin, go to Settings > Users & Companies > Users
- Edit Mark Demo (demo)
- In Human Resources > Attendances, select Manual Attendance or blank
- As demo, go to My Profile
- Click the smart button showing the hours worked for the last month
- Remove all filters

Bug:
The demo user, who hasn't the rights to see the other employees
attendances, can see them.

Explanation:
Every user must have the right to read attendances in order to see their
own attendances. Not giving the users the read rights in the security
record rule prevents the record rule from being applied when reading
attendances. This makes the read access rights the only rule and allows
everyone to see the attendances of the others.

This commit also fixes the default selected employee when going to the
attendances tree view on these paths:
- User
- Employee
- User > Employee

In fact, sometime, `active_id` is the ÌD of the user and not of the
employee. This leads to incorrect results since another employee's
attendances are shown.

Finally, this commit prevents users from creating attendances from other
apps since only attendance officers and above can have access to the
creation form within the Attendances app.

opw:2440117

closes odoo/odoo#64866

Signed-off-by: backspac <backspac@users.noreply.github.com>

- Go to Point of Sale > Configuration > Settings & enable "Cash Rounding"
- Configure POS:
  * Enable Invoicing
  * Enable "Cash Rounding" and "Only on cash methods"
  * Select 0.05 HALF-UP Rounding Method
- Start POS session
- Select a Product and change its Price to a value that should be rounded (i.e. $ 16.51)
- Select a Customer
- Proceed to Payment
- Enable Invoice
- Select Bank Payment method
- Validate
An error is raised: "Could not fully process the POS Order: Order / is not fully paid.".
And a popup is diplayed: "Please print the invoice from backend"

The issue comes from the fact that amount is also rounded for other payment methods
than cash, even if "Only on cash methods" has been enabled.

opw-2449222

closes odoo/odoo#65297

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>