Skip to content
Snippets Groups Projects
  1. Jan 23, 2019
  2. Jan 17, 2019
    • Christophe Simonis's avatar
      17adccd9
    • wan's avatar
      [FIX] account: journal dashboard graph wrong value · 50bae1c0
      wan authored
      OPW 1918926
      
      Current behavior:
        The sql query groups by date,id in a intermediary table instead of the result. This allows to get data in the wrong order if the statements were not produced sequentially. The fill values are computed in the wrong order and may override correct values.
      
      Desired behavior:
        There is no override of the values correctly computed.
      
      closes odoo/odoo#29936
      50bae1c0
    • Lucas Perais (lpe)'s avatar
      [FIX] base: merge contacts linked to by an o2m field with caps · ba39efdf
      Lucas Perais (lpe) authored
      Define a field on a model as:
      - o2m to res.partner
      - the field's column, hence its name, has capital letters in it
      (studio does that)
      
      create two objects of that class, each one linked to a different partner with the new o2m
      
      merge the partners
      
      Before this commit, the object linked to the second partner, was deleted
      This was because merge partner sql requests did not quote the column name
      
      After this commit, the second object still exists
      
      This commit is tested in v12.0 with PR #30300 only. In v10.0 it is not testable as
      the model concerned is in CRM, and that no new fields in business modules can be added in stable
      
      OPW 1925060
      
      closes odoo/odoo#30301
      ba39efdf
  3. Jan 15, 2019
    • Denis Ledoux's avatar
      [FIX] ir_ui_view: do not change view mode when just changing the inherit · a4096276
      Denis Ledoux authored
      Some views have the primary mode while having an inherit_id view
      In such views, if the user wants to change the inherit_id,
      the mode must remain primary.
      
      The use case behind this is a user who want to change
      the inherit_id view of the view
      product.product.form (product.product_normal_form_view)
      to another view.
      This view is in primary mode while having an inherit_id
      (product.product_template_form_view).
      In such a case, the primary mode must remain,
      otherwise the view will no longer be opened by default
      when opening a product.
      Indeed, when searching the default form view of a model,
      it only searches for primary mode views for this model.
      
      The `all` is there because this is an `api.multi` method.
      We could consider adding a `self.ensure_one`,
      but it breaks the API if someones calls this method with multiple records.
      This is likely to happen, as this method is used
      in `write` which is likely to be called with multiple records.
      
      In my opinion, in master, this should be replaced by an
      onchange so the user can see the change of mode
      when he adds or remove an inherit_id for a view.
      
      opw-1916324
      
      closes odoo/odoo#30241
      a4096276
  4. Jan 22, 2019
  5. Jan 18, 2019
  6. Jan 15, 2019
  7. Jan 16, 2019
    • Nicolas Martinelli's avatar
      [FIX] product: unwanted attribute values in name · 180ace7b
      Nicolas Martinelli authored
      - Create the following attributes with values:
        Size: S, M, L, XL
        Color: Black, White
      - Create a product template with the following attribute values:
        Size: S, M, L, XL
        Color: Black
      
      The `name_get` of `product.product` returns `Name (SIZE, Black)` while
      it should only return `Name (SIZE)`.
      
      When using `attribute_id.value_ids`, the list of values contains all
      possible values of the attribute, not only the values which apply to the
      given product. In this case, it contains 'Black' and 'White', therefore
      the condition `> 1` is verified and the attribute is kept for display.
      
      We go back to the original filtering, and add `attribute_line_ids` in
      the list fields read in order to avoid prefetching.
      
      opw-1922140
      opw-1922447
      
      closes odoo/odoo#30273
      180ace7b
    • Joren Van Onder's avatar
      [FIX] point_of_sale: allow refunds on non-cash journals · 302d8a52
      Joren Van Onder authored
      Cherry pick of 5b769650 in version 11.0
      
      A customer can pay an order with a non-cash journal (e.g. a credit
      card through a stand-alone terminal).
      
      When this order has to be refunded later it should be possible to do
      so on that same journal.
      
      Some code prevented this from happening, notably a check in
      order_is_valid which explicitly prevented this for an unknown
      reason. There is no explanation in the
      commit (4647f896) introducing that.
      
      This commit allows the following:
      
      1. input what you want to refund with a negative qty
      2. click 'Payment'
      3. click the Credit Card (type Bank) journal
      4. (amount is auto-populated)
      5. click 'Validate'
      
      opw-805302
      opw-1913731
      
      closes odoo/odoo#30218
      302d8a52
    • Nicolas Martinelli's avatar
      [FIX] account: bank statement with many AML · 614babd1
      Nicolas Martinelli authored
      - Create a bank statement with more than 80 lines (therefore more than
        80 AML)
      - Reconcile the lines
      - Go back to the bank statement, and try to add a new line
      
      An error arise:
      "You cannot do this modification on a posted journal entry, you can just
      change some non legal fields"
      
      The error arise on the `move_line_ids` field on which the web client
      tries to write.
      
      Actually, this field is hidden since it is only used in the domain of a
      stat button. We can make it read-only.
      
      opw-1921138
      
      closes odoo/odoo#30266
      614babd1
    • Iryna Vyshnevska's avatar
      [CLA] signature for ivyshnevska · 92e4c4c3
      Iryna Vyshnevska authored
      Backport to 10.0 of 3b14a7da
      
      closes odoo/odoo#30090
      92e4c4c3
    • Manuel Vázquez Acosta's avatar
      [FIX] survey: don't disclose the survey via print · 6ac32c65
      Manuel Vázquez Acosta authored
      To avoid bigger changes, only verify if the login is required.
      A proper refactoring has been implemented in master at 9771fdfe
      
      Closes odoo/odoo#30166
      6ac32c65
  8. Jan 14, 2019
    • larisa's avatar
      [FIX] hr_payroll_account: correct account move lines creation · 6edfadbd
      larisa authored
      The super call of action_payslip_done executes the method compute_sheet.
      Without this compute_sheet call, there is no salary lines and no accounting
      move is created.
      
      closes odoo/odoo#29737
      6edfadbd
    • Manuel Vázquez Acosta's avatar
      9c6d9697
    • Filippo Iovine's avatar
      [CLA] add Filippo Iovine to levelprime CCLA · 169843d8
      Filippo Iovine authored
      closes odoo/odoo#29072
      169843d8
    • Jeremy Kersten's avatar
      [FIX] payment_sips: allow to customize key_version · 6e3661d5
      Jeremy Kersten authored
      Some sips provider don't use 2 as key_version.
      E.g. mercanet uses '1' as production key.
      
      Now we allow to override it in Ir Config Parameter for stable version.
      
      Todo:
      Need to make it customizable by end user into the configuration of acquirer.
      
      Courtesy of BEK for reporting
      
      opw-1916316
      
      closes odoo/odoo#30185
      6e3661d5
    • Adrian Torres's avatar
      [FIX] ir_model: add constraint on domain field · f3de712d
      Adrian Torres authored
      Previous to this commit, if one were to create an ir.model.field with a
      poorly constructed domain (read: SyntaxError), the server would properly
      send an error message stating that an Error occurred, however this would
      be too late as the registry with the bad code would have already been
      reloaded, this meant that the registry would be left in an unstable
      state (read: crashed).
      
      With this commit, a constraint on the domain is added so that we confirm
      that the code in the domain field is properly constructed, thus no need
      to reload the registry and therefore no crash.
      
      closes odoo/odoo#30157
      f3de712d
  9. Jan 10, 2019
  10. Jan 08, 2019
    • Jorge Pinna Puissant's avatar
      [FIX] account: error in Base amount tax · b1316589
      Jorge Pinna Puissant authored
      opw-1917605
      
      Before this commit, when accounting is set to global rounding, the base
      amount per tax is not correctly calculated.
      
      Now, the Base amount per tax is calculated adding the rounded lines.
      
      To test this issue, you need to set to global rounding and create a
      customer invoice with the following lines :
      line 1 = Qty:40; unit price:2.27; tax:15%; discount: 10%
      line 2 = Qty:21; unit price:2.77; tax:15%; discount: 10%
      line 3 = Qty:21; unit price:2.77; tax:15%; discount: 10%
      
      When the invoce is printed, you would notice that the amount is 186.43
      and it should be 186.42.
      
      closes odoo/odoo#30021
      b1316589
  11. Jan 07, 2019
  12. Jan 04, 2019
  13. Jan 03, 2019
    • Raphael Collet's avatar
      [FIX] models: avoid prefetch hell when reading fields · a07a076c
      Raphael Collet authored
      The method `read()` may be very slow when reading relational fields and
      computed fields, because the computed fields can be computed on a recordset
      that is larger than expected.
      
      The issue occurs on model 'res.partner' when reading fields 'child_ids' and
      'purchase_order_count', for instance.  Suppose we read those two fields on a
      partner with 1000 contacts.  First, the one2many field is read from the
      database and stored to the cache; the latter adds the value ids to the
      prefetching of 'res.partner'.  Then, the fields are fetched from the cache.
      When 'purchase_order_count' is accessed on the partner, the field is computed
      on all its children as well...
      
      closes odoo/odoo#29867
      a07a076c
  14. Jan 02, 2019
    • Denis Vermylen's avatar
      [FIX] purchase: loading time on partners with many children · e1767490
      Denis Vermylen authored
      When loading a partner form view, the ORM prefetches the computed fields
      purchase_order_count and supplier_invoice_count for all the related
      partners as well (parent, children, ..).
      
      Instead of reading the orders and invoices once per partner, we group
      them all together.
      
      opw 1919933
      
      closes odoo/odoo#29788
      e1767490
  15. Jan 11, 2019
    • Raphael Collet's avatar
      [FIX] models: make prefetching more specific in read() · 1b434ed8
      Raphael Collet authored
      Commit a07a076c restricts the prefetching to
      `self` when accessing the fields to return.  This is too restrictive, as it
      cancels prefetching of secondary records in computed fields.  In this commit we
      limit the scope of the restriction to `self`'s model only; this fixes the
      original issue without impacting other models.
      
      closes odoo/odoo#30133
      1b434ed8
  16. Jan 10, 2019
  17. Jan 02, 2019
  18. Dec 28, 2018
Loading