- Jan 23, 2019
-
-
Christophe Simonis authored
-
Christophe Simonis authored
-
Nicolas Seinlet authored
Use read_group is faster than the python equivalent, and then don't push ids in ORM cache, which makes the ORM faster later in the process. Also unlink in batch.
-
Nicolas Lempereur authored
For editing many2one fields (and partially many2many) most widget show an autocompleting list of targeted records. They thus have `autocomplete="off"` to prevent browser completion. But chromium has an history of breaking `autocomplete="off"`, see: - https://caniuse.com/#search=autocomplete - https://crbug.com/468153 - https://crbug.com/587466 - https://crbug.com/914451 - https://crbug.com/923895 It seems that since chromium 71, the heuristic to ignore `autocomplete="off"` has become more aggressive and for example if there is at least 3 fields like an address in a page, chromium will ignore `autocomplete="off"` for the fields like an address. So for example the eidting the many2One field with placeholder "Country" in a contact page now has a browser autocomplete menu that is: - hidding the many2one autocomplete - going to save empty country it appeared visually filled if the autocomplete result was selected. With this changeset, the placeholder in the many2one instance is interspersed with U+FEFF charcters (ZERO WIDTH NO-BREAK SPACE) so the browser does enable the autocomplete feature by force. This should thus remove the issue (until it is fixed by chromium) in the case of field named "Country" or matching other regexes in this file: https://github.com/chromium/chromium/blob/cdb1b2073f12/components/autofill/core/common/autofill_regex_constants.cc U+FEFF has been chosen instead of more recommended characters because other have been shown erroneous for printing in some windows configuration (see cb2a3afa). 10.0 version of #30439 opw-1930588 closes #30439 closes #30449
-
Florent de Labarre authored
closes odoo/odoo#30455
-
- Jan 17, 2019
-
-
Christophe Simonis authored
-
wan authored
OPW 1918926 Current behavior: The sql query groups by date,id in a intermediary table instead of the result. This allows to get data in the wrong order if the statements were not produced sequentially. The fill values are computed in the wrong order and may override correct values. Desired behavior: There is no override of the values correctly computed. closes odoo/odoo#29936
-
Lucas Perais (lpe) authored
Define a field on a model as: - o2m to res.partner - the field's column, hence its name, has capital letters in it (studio does that) create two objects of that class, each one linked to a different partner with the new o2m merge the partners Before this commit, the object linked to the second partner, was deleted This was because merge partner sql requests did not quote the column name After this commit, the second object still exists This commit is tested in v12.0 with PR #30300 only. In v10.0 it is not testable as the model concerned is in CRM, and that no new fields in business modules can be added in stable OPW 1925060 closes odoo/odoo#30301
-
- Jan 15, 2019
-
-
Denis Ledoux authored
Some views have the primary mode while having an inherit_id view In such views, if the user wants to change the inherit_id, the mode must remain primary. The use case behind this is a user who want to change the inherit_id view of the view product.product.form (product.product_normal_form_view) to another view. This view is in primary mode while having an inherit_id (product.product_template_form_view). In such a case, the primary mode must remain, otherwise the view will no longer be opened by default when opening a product. Indeed, when searching the default form view of a model, it only searches for primary mode views for this model. The `all` is there because this is an `api.multi` method. We could consider adding a `self.ensure_one`, but it breaks the API if someones calls this method with multiple records. This is likely to happen, as this method is used in `write` which is likely to be called with multiple records. In my opinion, in master, this should be replaced by an onchange so the user can see the change of mode when he adds or remove an inherit_id for a view. opw-1916324 closes odoo/odoo#30241
-
- Jan 22, 2019
-
-
Quentin De Paoli authored
This is essentially a backport of module l10n_be_intrastat_2019 made for Enterprise v12 + the refactoring needed on the original v10 module to allow the changes to apply where needed. Was requested by opw-1887019 closes odoo/odoo#30400
-
- Jan 18, 2019
-
-
Christophe Simonis authored
closes odoo/odoo#30344
-
- Jan 15, 2019
-
-
Christophe Simonis authored
-
Julien (juc) Castiaux authored
When posting a URL containing a semicolon, odoo stops the link before the semicolon instead of continuing the link to the end although it is a valid characters in URL (see RFC-3986) e.g. the url "example.com&foo;bar" matches "example.com&foo" instead of the whole link opw-1918367 closes odoo/odoo#30198
-
- Jan 16, 2019
-
-
Nicolas Martinelli authored
- Create the following attributes with values: Size: S, M, L, XL Color: Black, White - Create a product template with the following attribute values: Size: S, M, L, XL Color: Black The `name_get` of `product.product` returns `Name (SIZE, Black)` while it should only return `Name (SIZE)`. When using `attribute_id.value_ids`, the list of values contains all possible values of the attribute, not only the values which apply to the given product. In this case, it contains 'Black' and 'White', therefore the condition `> 1` is verified and the attribute is kept for display. We go back to the original filtering, and add `attribute_line_ids` in the list fields read in order to avoid prefetching. opw-1922140 opw-1922447 closes odoo/odoo#30273
-
Joren Van Onder authored
Cherry pick of 5b769650 in version 11.0 A customer can pay an order with a non-cash journal (e.g. a credit card through a stand-alone terminal). When this order has to be refunded later it should be possible to do so on that same journal. Some code prevented this from happening, notably a check in order_is_valid which explicitly prevented this for an unknown reason. There is no explanation in the commit (4647f896) introducing that. This commit allows the following: 1. input what you want to refund with a negative qty 2. click 'Payment' 3. click the Credit Card (type Bank) journal 4. (amount is auto-populated) 5. click 'Validate' opw-805302 opw-1913731 closes odoo/odoo#30218
-
Nicolas Martinelli authored
- Create a bank statement with more than 80 lines (therefore more than 80 AML) - Reconcile the lines - Go back to the bank statement, and try to add a new line An error arise: "You cannot do this modification on a posted journal entry, you can just change some non legal fields" The error arise on the `move_line_ids` field on which the web client tries to write. Actually, this field is hidden since it is only used in the domain of a stat button. We can make it read-only. opw-1921138 closes odoo/odoo#30266
-
Iryna Vyshnevska authored
Backport to 10.0 of 3b14a7da closes odoo/odoo#30090
-
Manuel Vázquez Acosta authored
To avoid bigger changes, only verify if the login is required. A proper refactoring has been implemented in master at 9771fdfe Closes odoo/odoo#30166
-
- Jan 14, 2019
-
-
larisa authored
The super call of action_payslip_done executes the method compute_sheet. Without this compute_sheet call, there is no salary lines and no accounting move is created. closes odoo/odoo#29737
-
Manuel Vázquez Acosta authored
-
Filippo Iovine authored
closes odoo/odoo#29072
-
Jeremy Kersten authored
Some sips provider don't use 2 as key_version. E.g. mercanet uses '1' as production key. Now we allow to override it in Ir Config Parameter for stable version. Todo: Need to make it customizable by end user into the configuration of acquirer. Courtesy of BEK for reporting opw-1916316 closes odoo/odoo#30185
-
Adrian Torres authored
Previous to this commit, if one were to create an ir.model.field with a poorly constructed domain (read: SyntaxError), the server would properly send an error message stating that an Error occurred, however this would be too late as the registry with the bad code would have already been reloaded, this meant that the registry would be left in an unstable state (read: crashed). With this commit, a constraint on the domain is added so that we confirm that the code in the domain field is properly constructed, thus no need to reload the registry and therefore no crash. closes odoo/odoo#30157
-
- Jan 10, 2019
-
-
Christophe Simonis authored
-
Christophe Simonis authored
SQL improve the speed of the implied group VS the orm version. closes odoo/odoo#30108
-
Christophe Simonis authored
-
- Jan 08, 2019
-
-
Jorge Pinna Puissant authored
opw-1917605 Before this commit, when accounting is set to global rounding, the base amount per tax is not correctly calculated. Now, the Base amount per tax is calculated adding the rounded lines. To test this issue, you need to set to global rounding and create a customer invoice with the following lines : line 1 = Qty:40; unit price:2.27; tax:15%; discount: 10% line 2 = Qty:21; unit price:2.77; tax:15%; discount: 10% line 3 = Qty:21; unit price:2.77; tax:15%; discount: 10% When the invoce is printed, you would notice that the amount is 186.43 and it should be 186.42. closes odoo/odoo#30021
-
- Jan 07, 2019
-
-
Christophe Simonis authored
-
Francisco Fernández authored
-
- Jan 04, 2019
-
-
Lucas Perais (lpe) authored
Have a RFQ in draft. Log a note or send a new message, but use the full composer to do it. Before this commit, the RFQ was set to sent After this commit, it stays rightfully in draft It is mark as sent, only if the button SEND RFQ is used OPW 1908094 closes odoo/odoo#29902
-
Jorge Pinna Puissant authored
Before this commit, when the fiscal year was setting to 29/02. The function that compute the fiscal year dates gives an error. This occurs when the date passed as parameter wasn't a leap year. Now, for the non leap years we use the 28/02. opw-1917035 closes odoo/odoo#29932
-
Alexey Pelykh authored
The condition was never validated closes odoo/odoo#29898
-
Alexey Pelykh authored
-
- Jan 03, 2019
-
-
Raphael Collet authored
The method `read()` may be very slow when reading relational fields and computed fields, because the computed fields can be computed on a recordset that is larger than expected. The issue occurs on model 'res.partner' when reading fields 'child_ids' and 'purchase_order_count', for instance. Suppose we read those two fields on a partner with 1000 contacts. First, the one2many field is read from the database and stored to the cache; the latter adds the value ids to the prefetching of 'res.partner'. Then, the fields are fetched from the cache. When 'purchase_order_count' is accessed on the partner, the field is computed on all its children as well... closes odoo/odoo#29867
-
- Jan 02, 2019
-
-
Denis Vermylen authored
When loading a partner form view, the ORM prefetches the computed fields purchase_order_count and supplier_invoice_count for all the related partners as well (parent, children, ..). Instead of reading the orders and invoices once per partner, we group them all together. opw 1919933 closes odoo/odoo#29788
-
- Jan 11, 2019
-
-
Raphael Collet authored
Commit a07a076c restricts the prefetching to `self` when accessing the fields to return. This is too restrictive, as it cancels prefetching of secondary records in computed fields. In this commit we limit the scope of the restriction to `self`'s model only; this fixes the original issue without impacting other models. closes odoo/odoo#30133
-
- Jan 10, 2019
-
-
Aurélien Warnon authored
Task #1923443 Purpose ======= The slides on the website showed the 'download' button regardless of the value of the 'download_security' field. If the value is 'none', meaning that the slides are never downloadable, the button should be hidden. closes #29904 closes odoo/odoo#30051
-
- Jan 02, 2019
-
-
Christophe Simonis authored
Oversight of previous forward-port when adapting cc217569
-
Christophe Simonis authored
-
- Dec 28, 2018
-
-
Nans Lefebvre authored
Default time was set to default=fields.Datetime.now() instead of default=lambda self: fields.Datetime.now(), resulting in a discrepancy when printing the report. opw 1917523
-