Following 873d6d92, the forecast would now redirect correctly to the
corresponding bom when a `product.product` was used.
The issue is that `bom_variant_ids` doesn't exist on `product.template`,
raising a traceback when the forecast was accessed through the product
themselves instead of their variants

closes odoo/odoo#115716

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

**TO REPRODUCE**

- open contacts
- open a contact with a picture (for ex, douglas fletcher)
- change the picture => new picture is displayed
- click on cloud icon to force save => new picture is displayed
- repeat: After repeating, the old picture will be displayed.

**SOLUTION**

Before this change, `getUrl` is bound to the rendering context
instead of the component and it will write to the rendering context.
This is introduced in this commit: https://github.com/odoo/owl/commit/df59ec49aefce2e0913fdc1792d42b9680fb28b6



The following excerpt from the mentioned commit explains:

"A side-effect of this change is that now the rendering context is no
longer the instance of the component by default, but is always an object
with the component in its prototype chain."

To make sure that `getUrl` is properly bound to the component,
we should call it from the `this` of the rendering context.

closes odoo/odoo#115692

Task-id: 3204546
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Steps to reproduce:
- Switch to German
- Go to project and select a project
- Go to the quick create interface

Current behaviour:
The buttons label are too long and the buttons overflow the width
of the card.

Expected behaviour:
Text in buttons are truncated to respect the kanban card width.

taskid-3234707

closes odoo/odoo#115626

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Some users were updating their access rights to allow for direct
deletion of quants. This could lead to the infamous:

"It is not possible to unreserve more products of %s than you have in stock."

error since directly deleting a quant bypasses the flows of correctly
unreserving the amounts you are deleting. Therefore we now restrict
the unlinking to:
- when in sudo mode, since the automatic unlinking of zero quants always
  occurs in sudo mode.
- stock manager when unlink access right = True. Normally we would allow
  any user with the unlink access to do it, but since we are using the
  existing `_apply_inventory` to ensure that reserved qtys of the
  quant are correctly unreserved before the unlinking, only stock
  managers will correctly do this unreservation.

It is expected that some custom code may break due to this restriction,
but if custom code is directly unlinking quants without a sudo or with a
non-stock manager, then the code in these cases probably need to be
fixed anyways since this will cause inconsistent db data and lead to
the error above.

closes odoo/odoo#115588

X-original-commit: c99bfce4
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Tiffany Chang <tic@odoo.com>

Incorrect error (ValueError) was being thrown instead of the proper
ValidationError.

Fixes: odoo/odoo#92799
X-original-commit: 02561fed
Part-of: odoo/odoo#115588

This commit fix a traceback when printing the repair quotation
using the DIN 5008 repair module.
The field updated was not the correct one

task id : 3178931

closes odoo/odoo#115393

X-original-commit: 008cd881abcc9856de8bd7a7a8a5382fc31dc272
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

 It's causing an operator precedence error

closes odoo/odoo#114786

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Part-of: odoo/odoo#114786

Before this commit, if a single analytic line in the database
has an inconsistent company with it's anlytic account, all creation
of an analytic account was impossible because the constraint
_check_company_consistency is checked on the entire table.

This commit restrict the _check_company_consistency only
on the current record set.

closes odoo/odoo#115698

Signed-off-by: William André (wan) <wan@odoo.com>

Before this commit, deleting a record containing
changes (dirty) recreated the record when leaving the view.
Now, the changes are discarded when deleting the
record so it is not marked as dirty and not recreated.

task id: 3063834

closes odoo/odoo#115685

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

This commit avoids to update the related daterange field (aka. end date
when changing start date, and vice-versa) when this field is not present
in the DOM (could be 'invisible' field or hidden column in list).

Steps to reproduce:
- Open Field Service
- Switch to list view
- hide the End date column
- select record(s) to enter multi edit mode
- click on the Start date of the selected record to open the date range
  picker
- select a new range
- click Apply
==> Error saying that cannot read setStartDate from undefined

task-3200845

closes odoo/odoo#115658

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Before this commit, you could search `account.tax.repartition.line`
and get records from all the existing companies,
which is not supposed to happen.

It should only return records of the `active_company_ids`.

That was because there were no `ir.rule` preventing that.
This fixes the issue.

closes odoo/odoo#115493

X-original-commit: 1d11d1cb
Related: odoo/enterprise#38274
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

A header in the mail gives the amount and the validity date of a
quotation. Its means the quotation will expire at this date, and is not
related to any missing payment. The validity date has no meaning on a
confirmed sale order and is therefore removed.

task-3185072

closes odoo/odoo#115323

Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>

This commit fixes an issue that causes thin spacing to appear between
two snippets containing shapes. This bug had already been fixed in this
commit [1] but the theme snippets have not been adapted to the changes.

With this commit, the shapes of theme snippets are automatically adapted
when they are dropped on the page.

Steps to reproduce the bug:

- Choose the "Clean Theme" for a website.
- Drag and drop a "Call to action" snippet on the page.
- Drag and drop a "Text" snippet with a dark background before it.
- Resize the window to change the window width.
- At some points, the gap will appear.

[1]: https://github.com/odoo/odoo/commit/42b3ad10e0b32b7fc72f801e2c67d6baf938c566



task-2824607
opw-3069213
opw-3057533

closes odoo/odoo#115001

X-original-commit: 256ff539
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Added views and menuitems for account_edi.document
and account_edi_proxy_client.user, so that our technical team
will be autonomous in its investigations.

Task link: https://www.odoo.com/web#model=project.task&id=3204255


Task-3204255

closes odoo/odoo#113577

Signed-off-by: Josse Colpaert <jco@odoo.com>

"Invoice Address", "Shipping Address",
"Invoice and Shipping Address" were not
translated because they were not in
.po file.

opw-3198115

closes odoo/odoo#115667

Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>

In a grouped kanban view, drag a record and drop it in a folded
column. Before this commit, it opened and loaded the target column.
It shouldn't, the column should remain folded. This behavior has
been introduced in v16 with the wowl views.

This commit restores the legacy kanban behavior, which keeps the
target column folded and thus doesn't load it. We ensure that
the progressbar of the source column is correctly updated though.

Task 3208098

closes odoo/odoo#115628

Signed-off-by: Géry Debongnie <ged@odoo.com>

In cases where the progress record does not yet exist, it is not
possible to toggle the visibility of the onboarding panel.

Therefore, we hide said button.

Task-3192327

closes odoo/odoo#112928

Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

Before this commit, when over a man2one avatar, on a task project for
instance, we don't have any information about the user.

Now, a tooltip with the name is shown, note that this was already the
behavior in previous versions.

task-id = 3148168

closes odoo/odoo#115635

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

On listview, a m2m_tags takes two lines when it's not needed to avoid
this effect we reduce the flex basic value by half wide should still be
plenty enough space to be an easy target to hit.

Task ID: 3074587

closes odoo/odoo#115625

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Before this commit, when a record had a very long
display name, the name could be cut in the middle of a
word in the many2one's dropdown.
Now, these names are truncated and have ellipsis to tell
the text continues.

task id: 3234714

closes odoo/odoo#115624

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

**ISSUE**

A header button in the list view with "confirm" attribute doesn't
show a confirmation dialog when clicked. This is different to the
header buttons from the form view.

**SOLUTION**

In order to achieve similar behaviour, we reuse the BUTTON_CLICK_PARAMS
which originated from thew view_compiler and make sure that
buttons parsed from the other views also contain the correct set
of clickParams.

closes odoo/odoo#115542

Task-id: 3216357
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

The translation alert banner is an old remaining edit/save feature that
is not relevant anymore with the new "always edit" and the "save when
leave" features.

closes odoo/odoo#115315

Task-id: 3232795
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

after odoo #113888
when copy translations from one record to another, translations for
non-installed languages may raise error.

These translations may be
1. created before the langauge is deactivated
2. en_US which is always available for non falsy translated field value

this commit drops translations for uninstalled languages except 'en_US' when
copy and prevents raising error when users want to translate en_US when en_US is
not activated

closes odoo/odoo#115239

Signed-off-by: Raphael Collet <rco@odoo.com>

If we mix two types of global discounts, then one of the line is recomputed
again and messes up all the numbers.

STEPS:

* configure global discount 10% and "discount on order" via coupons
* Open POS > Add Large Meeting Table $ 3600
* Apply coupon, then apply global discount

The problem happens because `baseToDiscount` already includes "discount on
order", which is later recomputed again at
https://github.com/odoo/odoo/blob/a3c236ef0e047127583f6565461f0b90781584e4/addons/pos_loyalty/static/src/js/Loyalty.js#L452-L455

BEFORE:

```
Large Meeting Table: $3600.00
[DISC] Discount (10%, No tax): -$324.00
10% on you order: -$327.60
```

AFTER:

```
Large Meeting Table: $3600.00
[DISC] Discount (10%, No tax): -$324.00
10% on you order: -$360
```

The problem is not reproduced in 16.2 since the following refactoring
https://github.com/odoo/odoo/commit/c7fbae7a343dd90f8449ed94530f1fa2e6070690



opw-3187406

closes odoo/odoo#113762

Signed-off-by: Ivan Elizaryev (iel) <iel@odoo.com>

To reproduce the issue:
1. Create a product:
   - Type: Storable
   - Category:
     - Costing Method: AVCO
2. IN 2 @ 4.63/u
3. IN 5 @ 3.04/u
4. OUT 0.1
5. Repeat step 4 70 time in total, so that the final quantity is 0
6. Open the inventory valuation of the product

Error: the total value is $-0.04 instead of $0.
The compensation of rounding issue is stuck by a check that ensure we don't erase a valuation error.

However, this check can never succeed with small quantities, here is the mathematical proof:
°Current check: rounding_error <= qty * curr_rounding / 2
With:
1) rounding_error >= curr_rounding
2) 0 < qty < 2
3) v1 = rounding_error / curr_rounding
4) v2 = qty / 2
We can be sure that:
5) v1 >= 1 because of 1)
6) v2 < 1 because of 2)
7) v1 > v2 because of 5) and 6)

° rounding_error <= qty * curr_rounding / 2
° rounding_error * curr_rounding <= qty * curr_rounding / 2 * curr_rounding
° rounding_error / curr_rounding <= qty / 2
° v1 <= v2
==>> This contradict 7), hence this check can never be True for qty < 2

To fix this issue, we change the check to:
 ° rounding_error <= qty * curr_rounding / 2 OR rounding_error <= curr_rounding
 Where the 1st part doesn't change, but the second one is true when rounding_error == curr_rounding

closes odoo/odoo#115606

X-original-commit: a76fb7ff
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: David <dafr@odoo.com>

Steps to reproduce:
- open Discuss app with "General" as active thread
- open call settings in the inspector
- open a mailbox as active thread

Crash:
```
Cannot read showOnlyVideo of undefined
```

This happens because discuss has a single thread view
that is shared for any selected thread. However, the
call settings menu only makes sense for thread that
have call feature, which applies for only channels.
Mailboxes should not have any call settings menu.

closes odoo/odoo#115537

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

In some databases, there are multiple bank statement lines linked to the
same move. Example:

* account_move:

id | statement_line_id
---+------------------
 5 |                20

* bank_statement_line:

id   | move_id
-----+--------
  20 |       5
  21 |       5

Thus, joining both tables should be done using the
account_move.id and the bank_statement_line.move_id. Otherwise, some
bank_statement_lines will be missed.

opw-3202392

closes odoo/odoo#115060

Related: odoo/enterprise#38071
Signed-off-by: Laurent Smet <las@odoo.com>

This commit makes the pricelist item selection
in the get_price function inheritable

replaces #97517

Description of the issue/feature this PR addresses:

Help inherit the pricelist item selection in the pos get_price function

Current behavior before PR:

pricelist item in the pos get_price selection is not easily inheritable

Desired behavior after PR is merged:

pricelist item in the pos get_price selection is easily inheritable

closes odoo/odoo#110375

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

avaid to compute the list of category_ids on every get_price call

Part-of: odoo/odoo#110375

This commit makes the pricelist item selection
in the get_price function inheritable

Part-of: odoo/odoo#110375

When the user schedules a datetime for the emailing campaign, it creates
a ir.cron.trigger entry that should run the Mail Marketing: Process queue.
This fix tries to take this into account to calculate a next_departure
datetime closer to the true moment job will be run.

When the schedule datetime is between now() and the next call datetime
for the cron job (nextcall field), current logic will always chose
nextcall given the use of max(). This can be confusing for the end-user
as the information banner in the form view will indicate the nextcall date,
which in some cases can be way farther in the futur.

While a ir.cron.trigger is not a 100% guarantee that the cron job will
run at that specific time, it will give better feedback to the user for
when he should expected his mailing campaign to be send out.

Main changes:

    simplified logic in _compute_next_departure to take into account
    the implicit creation of cron.triggers (methods action_launch and
    action_schedule)

    added test_mailing_next_departure to simulate "Send", "Cancel" and
    "Schedule Date" buttons on mass_mailing form view. Check ir.cron.trigger
    model for presence of triggers for cron job "Mail Marketing: Process queue"
    and assert if cron.trigger was created as expected

opw-3137819
original commit b98494d
some trailing whitespace got linted from commit 4cebf5

closes odoo/odoo#115054

X-original-commit: f82dec9e
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

An attribute error 'bool' object has no attribute 'lower' trace back
that occurs in  base_vat/res_partner: _run_vat_test was caught by a sentry.
Because default_country.code is not available in some cases.

Steps to reproduce the issue:
- Install base_vat and contact modules.
- remove any one country's code in contacts/configuration/countries.
- Now create a new contact, give the contact name and
  select that country and fill the tax id(vat)(give the first
  2 characters in tax id such a way that it
  doesn't match with any country's code).
- while saving the data error raises.

So we raised a condition if country code is empty, and also made that field required.

sentry-3923412146

closes odoo/odoo#115041

X-original-commit: c5fad19e
Signed-off-by: William André (wan) <wan@odoo.com>

This commit translate the ics file for an event to
the language chosen by the public user on the website.
For connected users, the ics file is translated to
the user's language.

Task-3199180

closes odoo/odoo#115565

X-original-commit: 2fa5ceaf
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

Steps to reproduce:
Create an expense by sending an email.
Make sure the product has a zero cost.

Issue:
The expense has no total amount even if
a unit price is detected in the subject of the mail.

Solution:
Compute a total amount if we have a unit price.

opw-3128566

closes odoo/odoo#115612

X-original-commit: eb629fa82cbf592184ed60d0bf309a26a4465b70
Signed-off-by: William André (wan) <wan@odoo.com>

Prior to this commit, the generation of token aliases in Ogone relied
on the util function `singularize_reference_prefix`, which is intended
to make transaction references (and not token aliases!) more
distinguishable by suffixing a timestamp accurate to the second. That
util function does not guarantee the uniqueness of generated reference
prefixes, which is okay because the final reference is further suffixed
if the prefix happens to collide with an existing reference.

Using the util to generate Ogone's token aliases, however, poses a
problem because aliases *must* be unique. Otherwise, a customer saving a
payment token at the same second as another customer would end up
linking their payment method to the other customer's payment token.

This commit drops the use of the util method and replaces it with a UUID.

closes odoo/odoo#115463

X-original-commit: 61d833ffcd1562950126d3c87c92569fe35a8b08
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

closes odoo/odoo#115570

X-original-commit: fbcd6fa4
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

closes odoo/odoo#114899

Signed-off-by: Olivier Dony (odo) <odo@odoo.com>

Although Odoo 16.0 was already adapted to work with python 3.11 in
67c7cea4 , the requirements were left untouched. The purpose of this
previous work was to prepare for the next Debian Bookworm release.

With this commit, the requirements are updated to match the python
packages versions from Bookworm. That way, it will allow people who
installs Odoo in Python 3.11 environments by using the requirements
should be able to do so.

Closes #114195

Part-of: odoo/odoo#114899

fix typo in substract

substract -> subtract

closes odoo/odoo#115569

X-original-commit: 1d1ac976
Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>