When the user tries to modify the view with an invalid xpath expression,
an XPathSyntaxError traceback will appear.

Steps to produce:
1. Install the Accounting module.
2. Settings > Technical > UI > Views > Open any view
3. Invalidate expr syntax and try to save, thus an error will be generated.

Error: XPathSyntaxError: Invalid expression

This commit handles XPathSyntaxError by raising ValidationError
instead of a traceback.

sentry-4377014622

closes odoo/odoo#135614

X-original-commit: 58e463e7
Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>

Before this commit, when removing an animation from an element, all the
animation related classes and styles were not removed, leaving the DOM
in an inconsistent state.

This commit fixes that.

task-3497015

closes odoo/odoo#134624

Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>

Before this commit:
When returning a dropshipping, the valuation layers created do not have
the correct accounts on it:
 - Valuation -> Input   for the first SVL
 - Output -> Valuation  for the second SVL

After this commit:
For a dropshipped move, valuation layers have the following chain
of accounts:
 - Input -> Valuation   for the first SVL
 - Valuation -> Output  for the second SVL
Therefore, the return should have it reversed:
 - Output -> Valuation  for the first SVL
 - Valuation -> Input   for the second SVL

Steps to reproduce:
1. Create a dropship product with automated inventory valuation
2. Create a Sales Order, go on the PO and confirm it
3. Set quantities and validate dropshipping
4. Return delivered product (dropship return)

opw-3391174

closes odoo/odoo#136024

X-original-commit: 30de83a5
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

After commit [1], the check that the target url is different from
the current page's url has been removed thus leading to error that anchor
link always scroll down to element that have data-anchor enabled.

Steps to reproduce (the easiest way):
- Install Website Blog
- Turn on customize comment on post
- Go incognito then access any blog post, scroll down and click the
`Sign in to leave a comment` button
- Holy, the page scrolls down to the discussion section but doesn't go
to the login page

[1]: https://github.com/odoo/odoo/commit/fb087dbec96f5e533d1fdd9c2b0c2e00296c83de



closes odoo/odoo#136012

X-original-commit: f5fca171
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>

closes odoo/odoo#33682

Signed-off-by: bve-odoo <bve@odoo.com>

Steps to reproduce:
1. Install hr_attendance
2. Go to attendances
3. Select any line
4. Change the check-out date to next day
5. Change the check-out time to 00:00:00
6. Export that line, file format xlsx
7. Favorites > import records
8. Upload the exported file > Test
9. Column check_out contains incorrect values.
Error in line 2: unconverted data remains: 2023-06-11

Cause of the issue:
options.get('date_format') is empty

opw-3374883

closes odoo/odoo#133424

Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>

1. Backport of [1].
2. Steps to reproduce:
- Install website_crm
- Connect as Admin and remove the sales rights for Demo
- Check the website on a private window (to create an anonymous visit)
- Connect as Demo on the normal window
- Go to Website > Reporting > Visitors
=> It triggers an access error due to lead_ids being restricted to
sales_team.group_sale_salesman.
(Note: the error sometimes isn't triggered at that point. In that case,
click on the visitor: the same error will trigger.)

Considering the computed field doesn't do anything critical as it just
retrieves the email and phone number, the restriction is overridden on
the field.

[1]: https://github.com/odoo/odoo/commit/7de453477d7c23e607a15e0d60613080857e3371



opw-3475301

closes odoo/odoo#136194

X-original-commit: 5ba09c2c
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

In the din5008, there has been problem in the display of the paper format either
in the pdf or the preview.

In the preview we had a part of the page on the right that wasn't used caused by
the negative margin and the width of 180mm. But by removing that the pdf is
broken, the header is hiding some information.

To deal with that, we will add the width and negative margin only for the pdf
by adding a conditional css classes.

Also,it seems the footer with the company details can go out of page, by adding
a text-wrap on it, it solves this issue.

(In this commit, we override part of those commit:
https://github.com/odoo/odoo/commit/481f442f4ef176072edf3261415dbb06f8a3bc6f
https://github.com/odoo/odoo/commit/f7812ae848e0a79adcd11f936f6cd7890da00112

)

closes odoo/odoo#136293

X-original-commit: 96b09395
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>

- Create a move
- Add a line and set a custom tax tag on it
- Add a new line to balance the move
=> The tax tag is gone.

This is because the code is recomputing taxes when adding a new line.

closes odoo/odoo#136047

Opw: 3487465
X-original-commit: 1cad85f7
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Laurent Smet (las) <las@odoo.com>

Steps to reproduce:

- Enable the merge on account.account in data cleaning APP (in debug)
- Create an invoice with a receivable account = A
- Define a lock  date after the invoice date
- Go to chart of accounts
- Select your receivable = A et receivable = B
- Action = Merge accounts where B is the MASTER

Issue:
Upon revisiting the customer invoice: Notice that the journal items have been updated.

Solution:
We simply prevent ~~the use of a nuclear weapon~~ the merge of `account.account` as there other possibilities less dangerous such as multi-edit + archiving

We also prevent the merge of `res.partner` if this one is used in hashed entries

oe:https://github.com/odoo/enterprise/pull/47053



opw-3389157

closes odoo/odoo#134634

Related: odoo/enterprise#47053
Signed-off-by: William André (wan) <wan@odoo.com>

If somehow there is no selection but the `_handleShortcuts` handler still gets
called with `CTRL+A`, `container` would be a JQUERY object instead of an
element leading to a crash in `selectNodeContents` which expects a `Node`.

task-3506666

closes odoo/odoo#136289

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Prior this commit:
The mail scheduler of the event notifies the attendees even when the event is
no longer active.

After this commit:
Inactive events no longer notify attendees.

Task-3381876

closes odoo/odoo#136225

X-original-commit: 10c4091f
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Before this commit:

While saving the body_html a traceback occurred regarding reading HTML
in commit changes as it could not find the editable.

After this commit:

Now while saving the body_html the commit changes could read HTML in editable.

task-3496863

closes odoo/odoo#134614

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Upgrade (aka migration) scripts are a core part of Odoo, allowing
database manipulations for modules during version changes.

Any module, including custom ones can run upgrade scripts, even if the
`--upgrade-path` flag (and with it, the `odoo.upgrade` sub-module) is
not present. Currently only the "standard" modules benefit of easy
upgrade script testing. Any custom modules that want to run tests of
their upgrades have to import the tests in the usual `tests` folder,
which is not ideal.

Therefore, to allow TDD and programmatic testing of upgrade scripts in
custom modules, the test discovery is here modified to also parse the
module's `migrations` and `upgrades` sub-modules for tests.

closes odoo/odoo#136175

X-original-commit: e8683726
Signed-off-by: Vranckx Florian (flvr) <flvr@odoo.com>
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

Steps to reproduce:
1. Have 2 companies, and select the one w/ the highest ID
2. Create a new product tracked by lot + expiration date
3. Receive product
4. Set the received lot's expiration and alert dates in the past
5. Inventory > Operations > Run scheduler

Before this commit:
An activity is created on the lot for OdooBot,
despite the product's responsible set to the current user.
It happens because the default value for `responsible_id` is the current
user, but the value is only set for the current company. When the
scheduler runs, it doesn't set the company; therefore, it takes the
product's responsible user for the company with the lowest ID, which is
not set.

After this commit:
The activity is created for the product's responsible user using
the lot's company.

opw-3489340

closes odoo/odoo#136110

X-original-commit: dacfa844
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Signed-off-by: Walravens Mathieu (wama) <wama@odoo.com>

The method get_resource_path is redundant with file_path but without
all the checks.
The method will be deprecated in master but make it use file_path in
stable.

closes odoo/odoo#135896

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Bug
===
When searching for projects from the Outlook / Gmail addins, the names
were not translated into the user's language.

Task-3486324

closes odoo/odoo#133704

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce
==================

- Use a mobile viewport
- Create a quotation
- Add an order line
- Set a packaging
-> The Packaging Quantity field is missing

The same happens on purchase orders

---

opw-3504829

closes odoo/odoo#135928

Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>

The condition for which the Fiscal Position's Note is shown only in Customer Invoices is removed because unnecessary.
A check has been added on the company's country to be 'IT'.

Task link: https://www.odoo.com/web#id=3420752&model=project.task


task-3420752

closes odoo/odoo#135955

X-original-commit: c32720db
Signed-off-by: John Laterre (jol) <jol@odoo.com>

Steps to reproduce the bug:
- Create a storable “P1”:
   - tracking= serial
   - save
- Change the type of product to service

Problem:
some fields for tracked products are not hidden, because the product
tracking is not updated.

Solution:
Convert _onchange_type into compute methods.
The tracking is updated even if the change type is applied from the
"product.product" form.

opw-3499976

closes odoo/odoo#135912

X-original-commit: d3808a5d
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

purchase_stock, point_of_sale, sale_mrp

What are the steps to reproduce your issue?
When Odoo.sh runs unit tests on a development branch,
it tests the code in the MRP module for rounding errors.

What is the current behavior that you observe?
I had a customization that introduced a rounding error in the standard MRP module.
When the unit tests ran on the development branch, I got a traceback.

What would be your expected behavior in this case?
The rounding error should be reported as a failed test with a message. No traceback.

opw-3454998

closes odoo/odoo#135849

X-original-commit: 74416a2e
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Gaetan Vanden Bergh (gavb) <gavb@odoo.com>

Current behavior:
When refunding an order, the lot_id of the original order was not set
on the refund order.

Steps to reproduce:
- Create a product with tracking by lot
- Open the POS and add the product to the order
- Set a lot on the product
- Pay the order
- Refund the order
- Check the lot on the refund order, there is no lot set

opw-3485740

closes odoo/odoo#135056

Signed-off-by: Robin Heinz (rhe) <rhe@odoo.com>

Steps to reproduce:

- Go to Website > Add menu items to activate the "auto-hide" (to set the
overflowing menu items in a "+" dropdown).
- Go to "edit" mode > While resizing the window width, the "auto-hide"
menu adaptation is disabled, and overflowing menu items are visible.

The goal of this commit is to fix the behaviour described above (and
potentially, issues that can result from the editor's "unbreakable"
rollbacks on top menu) by preventing the unbreakable mechanism from
detecting header changes and cancelling the auto-hide updates.

Related to opw-3484742

closes odoo/odoo#134185

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Steps to reproduce:
-------------------
- add an allocation for an employee;
- add a leave with this allocation;
- validate the leave;
- refuse the leave;
- in action menu, click on "Time off Analysis by Employee and Time Off Type".

Issue:
------
The report does not take into account refused allocations and leaves.

Solution:
---------
Add a condition to take a number of days equal to zero
if the allocation or leave is in a refused state.

Handled the case where no record is found for leave
(with `COALESCE` because `value - NULL = NULL`).

opw-3503617

closes odoo/odoo#135748

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

To reproduce the issue:
1. In Settings, enable "Multi Routes"
2. Edit the warehouse:
   - Manufacture: 2 steps
3. Create three storable products P1, P2, P3
4. Create and confirm a MO for 1 x P1 with 1 x P2
   - It should create the PBM picking
5. Add a component line for P3
6. (Because the MO is locked, the user can not edit the 'to consume'
   quantity, so) Unlock the MO
7. Set the 'to consume' qty to 1
8. Save the MO

Error: P3 is not added to PBM picking. Worst: suppose the user does
the internal transfer and then checks the availability of P3, the
line will still be unreserved

Step 6, when unlocking the MO, it also triggers a save. As a result,
the SM for P3 is created with its demand defined to 0. When adding
such SM, we do several things through this method call:
https://github.com/odoo/odoo/blob/be0b61cbaf3d3b7082aca8f96dcf8a6ee7885fea/addons/mrp/models/mrp_production.py#L776


- We will adapt its procure method (here, because of 2-steps
  manufacturing, it will be MTO)
- We will confirm the new SM -> we will run a procurement for a zero
  quantity -> it will not generate any new SM

Then, when updating the SM quantity (step 7), nothing will run a new
procurement.

Moreover, this also explains why trying to reserve the SM does not
work: it's an MTO one, but it does not have any `move_orig_ids`, so
it is not possible to assign it.

Solutions:
- It should be possible to edit the 'to consume' qty of a new SM,
  even on a locked and confirmed MO
- A procurement should be executed when updating the demand of an SM
  from 0 to >0. From 16.1, a procurement will always be executed
  each time the quantity changed (see [1]). Here, we want to limit
  the impact/risk of the fix

[1] 1f4fb64a

OPW-3253204

closes odoo/odoo#135478

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Before this commit:
-While reading chatter notifications in the chat window, SMS and email icons are
not accessible to click due to action list overlap.
-While reading a reply on any message or attachment in chat widow,
the attachment link is not accessible to click due to action list overlap.

After this commit:
-When SMS and email icons are visible, time and that icon will display to the
following line so user can click on it easily.
-Attachment links will display to the following line of mentioned so user can click
on it easily.

Task-2713371

closes odoo/odoo#131020

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

closes odoo/odoo#135745

X-original-commit: 0d19b9e9
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

adress both use cases in :
https://github.com/odoo/odoo/commit/ed2849a55c1463689cbc201a782b0200207bfd37
and
https://github.com/odoo/odoo/commit/4248aac2d224363a6ac4a59881bdb7c321623e4b



button should be red if there's no qty in stock but still be green if
the qty was reserved for the move

closes odoo/odoo#135049

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

With this commits the data sets about resume of the orderline now are
inheritable, we are introducing new functions that will be the ones that
returns the data structure of the lines resume; That info could be
easily extended.

closes odoo/odoo#134031

Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>

Issue:
Search on website has a big performance issue because the database has
too many product_template.

Analyze :
The website search mechanism has hardcoded sql query. And the generic
query don't have any filtering. Which lead to make a expensive search
(similarity) on the whole product_template even if the products are
not published and then displayed to the user.

Fix :
Filter the is_published field in the generic website method when the
model has a 'is_published' field and the request is not done by a user
(thus for customers or portal users).

Note:
The internal user is still able to search on unpublished product.Thus
have no performance improvement.

Benchmark:
| SQL Query | # Input data | Before PR | After PR |
|:---------:|:------------:|:---------:|:--------:|
|General best_similarity |700000 products (161 published) | 12.65 s | 0.12 s |
|FROM ir_translation|2,796,000 ir_translation | 6.338 s (586k hit) | 0.091 s (185 hit) |

Related task:
task-3473786

closes odoo/odoo#130734

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Versions:
---------
- 14.0
- 15.0

Steps to reproduce:
-------------------
1. create an eCommerce site;
2. add another language;
3. visit site using any language other than English;
4. add product to cart;
5. go to checkout until you can change address.

Issue:
------
In the country and state/province selectors, the default values are not translated.

Cause:
------
Their `msgid` strings in the .pot files don't include the option tags that were introduced in 57d7e75b.

Solution:
---------
Add option tags to the `msgid` strings.

opw-3455492

closes odoo/odoo#135656

X-original-commit: b95770a5
Signed-off-by: Levi Siuzdak (sile) <sile@odoo.com>
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Signed-off-by: Levi Siuzdak <sile@odoo.com>

The following method:
 - https://github.com/odoo/odoo/blob/2091994c/addons/pos_restaurant/models/pos_config.py#L40

Gets the following query:

    SELECT min("pos_order".id) AS id,
    count("pos_order".id) AS "table_id_count",
    "pos_order"."table_id" as "table_id"
    FROM "pos_order"
    LEFT JOIN "restaurant_table" AS "pos_order__table_id" ON (
        "pos_order"."table_id" = "pos_order__table_id"."id")
    WHERE (("pos_order"."state" = 'draft')
        AND ("pos_order"."table_id" in (TOO MANY IDS HERE)))  -- for this case 178 restaurant_table records ids
    GROUP BY  "pos_order"."table_id", "pos_order__table_id"."id"
    ORDER BY "pos_order__table_id"."id"

It spends 24ms without index

After creating index it spends 0.57

It is not the unique side filtering by pos_order.state column

Check the following lines of code:
 - https://github.com/odoo/odoo/blob/f5553c550/addons/point_of_sale/models/pos_order.py#L678
 - https://github.com/odoo/odoo/blob/f5553c550/addons/point_of_sale/models/pos_order.py#L690
 - https://github.com/odoo/odoo/blob/f5553c550/addons/website_sale_coupon/models/sale_order.py#L91



closes odoo/odoo#135434

X-original-commit: a658dfcd
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>

When trying to customize Swiss invoice report with QR-Bill
through Studio an error was thrown because it tries to _compute_name()
on a dummy 'account.move' record with self.id=0.

This is part of a more general task in master around report customization
but it make sense to backport the fix in all stable versions.

task-id:3492033

closes odoo/odoo#135627

X-original-commit: 7b58a288
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Claire Bretton (clbr) <clbr@odoo.com>

Before this commit a singleton error is raised when writing to several
PoS configs at the same time.

After this commit, it is possible to write on multiple records at the
same time.

closes odoo/odoo#135586

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Current behavior:
If you had 2 products with different expense account and using real-time
inventory valuation, there was an error when validating the picking.
This was happening because move_vals we were trying to assign multiple
moves to one pos_order here https://github.com/odoo/odoo/blob/95cec6ea3daebce6491cc2a8a69d9688322989ba/addons/point_of_sale/models/stock_picking.py#L155



The account move is actually reserved for the invoicing of the order.
So we just need to remove that line.

Steps to reproduce:
- Create a product with expense account A
- Create a product with expense account B
- Make sure both products are set to real-time inventory valuation
- Activate ship later in the PoS
- Open the PoS and add both products to the order
- Validate the order with ship later and no invoice
- Close the PoS and try to validate the picking of the order.

opw-3428033

closes odoo/odoo#133301

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

When parsed, if the attachment has a basis quantity of zero,
it creates an error, because it is used in a division.
The condition that checks whether is computed
should be done only if this variable is none.

The code does not handle if `attachement_name.text` is None,
which can be caused by an orphan ID tag (e.i. "<cbc:ID />") ,
in the xml of the pdf.

opw-3470969

closes odoo/odoo#135472

X-original-commit: bfc83df7
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Laurent Smet (las) <las@odoo.com>

The SII module adds some fields on the taxes, so after installing
the module, those fields need to be set on the already installed CoAs.

We forgot to set the l10n_es_bien_inversion field, which is used in
l10n_es_edi_sii to send the right information about the taxes to the gov.

closes odoo/odoo#135456

X-original-commit: 1b37eaaf
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

*website

Steps to reproduce the bug:
- Drop the "Form" snippet on the website.
- Add a new field.
- Replace the field label by "test\".
- Save.
=> Traceback of type "Cannot read properties of null (reading
'dataset')" appears.

In the `start()` function of the `s_website_form` public widget, the
field names of the form are extracted thanks to the `serializeArray()`
function. The field elements are then found by doing a `querySelector()`
on the field names. In our case, the field name of the new field
extracted by `serializeArray()` is `test\\` (there are two backslashes
because the field name is a string so the first backslash has to be
escaped by a second backslash). The problem is that this string has to
be escaped one more time in order to be used in a `querySelector()`. As
it is not the case, the result of the `querySelector()` is `null`
leading to a traceback when the code tries to access its dataset. To
solve the problem, the character `\` is encoded before being stored in
the `name`, `data-name` or `data-visibility-dependency` attribute of the
field element. Thanks to the encoding, the `querySelector()` operation
can perform correctly on those attributes.

opw-3470291

closes odoo/odoo#134021

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>