Tansifex is deprecating it's client and switches to a go-based
solution in its API v3

The new client is still backward compatible with the old format but
the v2 API is going to be phased out.
See https://github.com/transifex/cli

 to install the deplyments using
the tx client

This PR is the result of the "tx migrate" command

closes odoo/odoo#112269

Transifex: adapt to new URL format
X-original-commit: af865ec1
Related: odoo/documentation#3514
Related: odoo/enterprise#36853
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Bug
===
When an error occurs, the error received is wrongly stringified.

closes odoo/odoo#112290

X-original-commit: 1bf9278b
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Stéphane Debauche (std) <std@odoo.com>

Steps to reproduce the bug:
- Enable “Storage location” option
- Create a storable product “P1”
- Create a putaway rule:
    - When in: WH/Stock
    - Store to: WH/Stock/shelf1
    - product: P1
- Go to operation types -> “Receipts orders”
    - Enable “Show Detailed operations” and
    “Pre-fill detailed operations”
- Create a purchase order:
     - Add 2unit of “P1”
     - Confirm the PO
- Go to the receipt:
     - the destination location is correctly set “WH/stock/shelf1”
     - set the qty done to 1
     - validate the delivery and create a back order

Problem:
The destination location is “WH/Stock” instead of “WH/stock/shelf1”
because the ```_apply_putaway_strategy``` function is not called on
the ```stock.move.line``` when there is no package

opw-3162934

closes odoo/odoo#112227

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Issue #1: reading textContent

When reading the textContent property of an element, its does not take into
account line breaks introduced by <br> and block elements, whilst innerHtml
does.

This commit solves the issue of updating a link's href to a non-sense url
upon label change. Before this commit, "www.abc.com <br> www.xyz.com" was
being incorrectely parsed as "www.abc.comwww.xyz.com".

Issue #2: setting textContent

When setting the textContent property of an element, all of its child nodes are
removed and replaced by a single text node. While this is fine when the
element contains a single text node, it might not be the desired result when
the element contains other children.

This commit solves the issue obtained when pasting html such as
"link.com<br>link.be" inside an empty inline element such as STRONG or A,
in which cleanForSave was changing its content (removing the line-break) due
to misuse of textContent, when the intended effected was simply removing
ZeroWidthSpace characters. A safer alternative for removing ZeroWidthSpace is
thus provided.

task-3081254

closes odoo/odoo#108521

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Usecase to reproduce:
- Set product as FIFO and a cost of 10$
- Sell 5 units
- Modify the cost method to average

We expect the value of the stock to remain -50$.
However it went to -150$

It happens because the change of cost method is not supported
with negative quantity of stock. It's not really a huge bug because
it will be reconcile to the real value in the next in and when the
stock will be positive again but at least it gives a proper valuation
of the inventory.

opw-3100717

closes odoo/odoo#111327

X-original-commit: 3ff51daa
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

When chaining multiple moves (like in a multi-step delivery), if
products are reserved on the previous moves of the chain, the products
won't appear as "Reserved" in the forecast report, leading to
inconsistencies between reservation done in stock and the one showed in
the report.

Steps to reproduce :
- Enable multi-step deliveries for this warehouse
- Put enough quantity in stock for a single product
- Create a Sale Order, validate it and the validate the firsts pickings
(i.e. pick/pack transfers)
- Create another Sale Order, validate it. Check that the quantity is
reserved in the first picking (i.e. pick transfer)
- Go to the forecast report, only the first SO will me marked as
"Reserved from Stock", even if both are.

opw-3074572

closes odoo/odoo#107973

X-original-commit: c429c05d
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

Current behavior:
When the opening cash amount is different from the closing cash amount
from the previous session, the difference is not recorded in the
accounting.

Steps to reproduce:
- Open a POS session
- Enter 100 as opening cash amount
- Close the session
- Open a new session
- Enter 50 as opening cash amount
- Close the session
- Go to the accounting entries for this session, there is no entry
  for the difference between the opening cash amount and the closing
  cash amount from the previous session

opw-3100831

closes odoo/odoo#112094

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

This commit adds a test to a fix done in https://github.com/odoo/odoo/commit/afed7db30042e2ea91cdae292dadb7b6f742e33d



bug introduced during: odoo/odoo#109298
opw-3162826

closes odoo/odoo#111440

Signed-off-by: Tiffany Chang <tic@odoo.com>

To reproduce the issue:
(Use demo data)
1. In Settings, enable "Multi Locations"
2. Create a storable and tracked-by-lot product P
3. Create an immediate receipt R
4. Add a line for 1 x P and save
5. Open the wizard 'Detailed Operations' and add a line:
   - 1 x P, lot 123, to WH/Stock/Shelf 1
6. Save
7. Open the wizard again

Error: The destination location of the line is now WH/Stock

When creating the SML, because we write on its done quantity, we
will automatically write the same on the new done quantity of the SM
on the demand of that SM. Doing so, it will trigger the assign
process:
https://github.com/odoo/odoo/blob/57ac92fc4c14bf305ffd9ef98212cc80013345f5/addons/stock/models/stock_move.py#L599-L602
(And it will therefore lead to the putaway rules feature)

Once the above issue is fixed, there will be another one. When
marking the SML as done, if it's needed, we assign it a lot. However,
writing on such a field will trigger the reservation process:
https://github.com/odoo/odoo/blob/c9fdd4f2ac2d8afb18cb0dd126bb0b88c54f374e/addons/stock/models/stock_move_line.py#L330-L333


And it will lead, again, to the putaway rules feature

OPW-3086704

closes odoo/odoo#111993

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

In some cases, components had dark text over dark background (or light
text over light background) by mistake.

Example:
- Enter edit mode.
- In the theme tab, choose "boxed" as page layout.
- A color picker appears below to control the color behind the box.
- Set it to a dark color (if your box main color is light)
- Go to a course page (install website_slides)
- Check the mobile version
=> The bootstrap tab and its section uses the dark color you set up as
   body color instead of the expected boxed layout color (this can also
   be seen with standard "tabs" snippets, although their body is not
   buggy in that case).

This is because of bootstrap which uses `$body-bg` as default value for
other variables, such as `$nav-tabs-link-active-bg` in the case
described above. It also uses the variable in the creation of CSS rules
not controlled by explicit variables.

In 16.0, bootstrap was updated to 5.1.3 with [1] and this actually
increased the problem: input backgrounds now default to `$body-bg`,
amongst other things. Since [2], `$body-bg` is also used as the default
color for range thumbs. Those are for example visible on the shop main
page with the price filter enabled. With a white boxed layout and dark
background, those were broken as well.

This commit focused on fixing the only critical component: nav-tabs, for
which the fix in straightforward. CSS rules that depends on `$body-bg`
in bootstrap are less easy to fix (without duplicating their rule), are
mainly less important ones and would actually not really be possible to
fix in a fully stable way. Those will be fixed only starting from 16.0
with an entirely different fix.

[1]: https://github.com/odoo/odoo/commit/971e5a91aab96d36129a823e03f1f9f1b1293968
[2]: https://github.com/odoo/odoo/commit/46e53879749be7ba3d30338d0f25c0a68a88eb3c



opw-3151962

closes odoo/odoo#112121

X-original-commit: 03f238aa
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

When trying to recover peer to peer connection, the timeout of 500ms or
1000ms might be too short and 15000ms in unnecessary too long.

If the timeout is too short, it could remove the connection before the
peer to peer had the time to reconnect to it. When we call
`_recoverConnection` on `disconnect` in `oniceconnectionstatechange`
or `onconnectionstatechange`, the signal `disconnect` does not
necessarily mean that it will remain disconnected. Doing nothing could
be enough to reconnect.
(see: https://w3c.github.io/webrtc-pc/#dom-rtcicetransportstate-disconnected

)

closes odoo/odoo#112001

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Before this commit, the iceCandidateBuffer was emptied before finishing
the loop. This is wrong as we must add all candidates from the buffer.

Part-of: odoo/odoo#112001

For some reason the `website_id` field was added in the form view of the
`ir.asset` model in a website module overide but it was not done for the
list view where it matters equally (if not most regarding the flow).

Indeed, those views / this model is mainly accessed for debugging
purpose in which case you are most likely looking for a specific asset.
In the website case, it's most of the time to find the custom asset
that was created following a scss customization in the right panel of
the website builder.
In such a case, it will have a website_id and will be easy to find in
the list view.

It's also the case for all the records having a `website_id`, we show
that field in both form and list view, it's always important when
managing / debugging DBs in multi-website environment.

See [1] for introduction of `ir.asset`.

[1]: https://github.com/odoo/odoo/commit/8cc066173dfb61bd95b8e1f0716f71f4e251810a



closes odoo/odoo#111883

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

The user can use arrows up/down to change the value of an input in the
editor (inputs that handle numerical values). Unfortunately if this
input does not trigger a preview (data-no-preview="true"), the
modifications made by the user with arrow up/down are not saved. This
commit solves this problem by notifying that the value has changed at
the input blur (or on ENTER key press) if arrow up/down has been used.

Details:
Since we use text inputs in the editor, (even to manage numerical value)
the management of arrow up/down is done manually, so Javascript does not
consider the value of the input has changed and therefore does not
trigger the change event. Another solution would have been to say that
when we know that the input is going to manage a numeric value, we put
the type="number" on it but in this case, the change event is triggered
at each arrow up/down which breaks the fact that some inputs do not want
to have a preview.

Steps to reproduce the problem:
- Drop the Products block in a page
- Use arrow up/down to change the value of the Slider Speed input
- Save and Edit again
=> The change made with arrow up/down has not been saved.

task-2765868

closes odoo/odoo#88791

Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>

Steps to reproduce the bug:
- Create a repair:
    - Add any product to repair
    - Add any other product as part of the repair
    - Confirm the repair
    - Start the repair
    - End repair

Problem:
The cancel button becomes visible and clicking on it won't cancel the
moves, so it doesn't make sense to cancel a finished repair.

opw-3146606

closes odoo/odoo#111902

X-original-commit: 8d37cf46
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

Steps to reproduce the bug:
- Create a delivery transfer:
- Add any product
- Select any carrier in the additional info tab
- try to validate the transfer

Problem:
An error is triggered: `ValueError: Expected singleton: sale.order()`
The `_compute_amount_total_without_delivery` function is called with an
empty recordset whereas we need to trigger it with a sale_order

opw-3164490
opw-3168878
opw-3166074

closes odoo/odoo#112069

Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

Before this commit, when the user tried to update a checklist, there
was a traceback in `handle_history_divergence` because the `value` is a
byte sequence instead of a string.

opw-3158660
task-3165844

closes odoo/odoo#111616

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

This reverts commit [1] so as to avoid updating the DOM in two separate
places of the code for link edition. Said commit intended to prevent the
removal of custom styles on a button on which styles were applied
(erroneously) without applying a custom button class. This fixes that
issue by adapting the UI to show the button is custom if there are
custom styles applied. This way, if any change is applied, when
modifying the DOM, the custom class will be applied as well. This is the
order in which such corrections are usually applied with the snippets
bar.

[1]: https://github.com/odoo/odoo/commit/eb4edac560227b46efdcfe958e3b93e0b88def64



closes odoo/odoo#108615

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

The background color snippet option contains a superfluous selector. To
make sure the option doesn't actually appear for that selector, without
modifying the XML file in stable, commit [1] hid it in those cases. But
we want the option not to even be instantiated, which this commit
achieves by modifying the selector when computing the snippet templates.

[1]: https://github.com/odoo/odoo/commit/925e73e02c5bc054d06fc2097acc9e4244cabe38

Part-of: odoo/odoo#108615

closes odoo/odoo#111625

Signed-off-by: Stockbauer Matthieu (tsm) <tsm@odoo.com>

In case of a user have no access to all account.move (restrict by ir.rules). An exception can raise during move posting.

Add an index to speed up this function in large database.

OPW #3159258

closes odoo/odoo#112019

X-original-commit: b2e3c58a
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>

In case of an user can edit account.journal and have no access of all account.move of this journal, the user can set to false this field : restrict_mode_hash_table.

closes odoo/odoo#112014

X-original-commit: c1bcf20a
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>

Before this commit, the odooEditor was aware of the initial history id
by reading the data-last-history-steps attribute on the first node of
the editable. When there is a corrupted html in an html field, the
parsing made by wysiwyg can remove some node when it parses the string
value before it is read by the odooEditor. If that process remove the
first node, there is no way for the odooEditor to retrieve it.

This commit makes the wysiwyg responsible to retrieve the initial
history id by reading the string value rather than the generated dom
tree.

At the time of this commit, there is another problem in the editor
that make the above case easy to reproduce. Pasting a table containing
a tbody added a corrupted html. To reproduce:
- open note
- create task
- write a letter in the first paragraph
- hit enter (to create a new paragraph)
- paste into the last paragraph an external html containing a `tbody`
  tag.
=> the pasted html will not contain the table but will contain the
   <tbody> and therefore be considered corrupted.
- save the document
- click edit
- make any change in the document
- click save
=> traceback because the initial history id was not found when the
odooEditor was instanciated.

The reason it was not found is because the first node of the editable
was remove by the parsing of the jquery method `html` that removed the
first node.

This commit improve the retrievement of the id by reading the string
instead of the gerenated dom tree.

opw-3146216

closes odoo/odoo#111596

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Commit [1] fixed the merging of tables on paste but made its checks on
the last child twice instead of checking the first child then the last
child.

[1]: https://github.com/odoo/odoo/commit/a84bca544189e515cf0cb86b7b6dc6f0ea17f132



closes odoo/odoo#111999

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

before this commit, the action name was not translatable into user language and always displayed in english.

after this commit, the action name will be translatable and will be showing the value based on user language preference.

closes odoo/odoo#111959

X-original-commit: 6aa80ca6
Signed-off-by: John Laterre (jol) <jol@odoo.com>

Fields are:

1. button_text
2. default_message
3. input_placeholder

closes odoo/odoo#111837

X-original-commit: 5bf0df88
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

When we paste content in the editor, we merge the first and/or the last
element(s) from the clipboard with the element(s) before/after the
selection (eg, pasting `<p>b</p>` at `<p>a[]c</p>` (where `[]` is the
selection) should result in `<p>ab[]c</p>` rather than
`<p>a</p><p>b</p><p>c</p>`). If the element we try to merge is a table
though, we may end up pasting a `<tbody>` without its parent table,
which leads to unexpected results. In any case we don't ever want to
merge a table with another element, so we prevent that.

Steps to reproduce the issue (in the `note` module):
* Type "a" then hit the ENTER key.
* Add a table (using the /table command) and write in each of its cells.
* Make a selection that starts before "a", and ends after the last
  character of the last cell of the table.
* Copy the selection.
* Paste the selection in the paragraph after the table.
What you see before this commit is the text you copied, without the
table.

Everything above is also true of lists (just replace the table with a
list in the text above) and these cases are fixed here in the same way.

task-3165836

closes odoo/odoo#111957

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Before this commit: it was possible to create two PoS terminals in two
companies with the same `adyen_terminal_identifier`. So it's possible,
after each payment, it would add the response to the wrong payment
method's `adyen_latest_response`.

The solution is to bypass multi-company record rule in
`_check_adyen_terminal_identifier`.

opw-3131814

closes odoo/odoo#111483

X-original-commit: a9e4b1ad
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

before this commit, traceback is raised when trying to create accrued revenue entry without entering the order lines.

open a sale order, enter customer and save it, from the action button, click Accrued Revenue Entry and enter an amount in the amount field, exception will be raised.

after this commit, no exception will be raised.

closes odoo/odoo#110308

Signed-off-by: John Laterre (jol) <jol@odoo.com>

Steps to reproduce:
- In settings, activate "Free sign up" option;
- Go to "Sign in" page;
- Click on "Don't have an account?";
- Create an account.

Issue:
No confirmation email is sent.

Cause:
The `qcontext.get('token')` variable does not exist
in the case of a "Free sign up".
And therefore, we do not respect the condition to send an email.

opw-3103867

closes odoo/odoo#111319

X-original-commit: fe7cb4da
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Strings must be trimmed in the XML output because
the Tax Agency has requisites on the length.

Specs: https://www.fatturapa.gov.it/export/documenti/fatturapa/v1.2.2/RappresentazioneTabellareFattOrdinaria.pdf
Ticket link: https://www.odoo.com/web#id=3044072&model=project.task



opw-3044072

closes odoo/odoo#111909

X-original-commit: b62e3d03
Signed-off-by: Josse Colpaert <jco@odoo.com>

When a odoo user already exists, the installation of the deb package
fails because the `/var/lib/odoo` directory does not exists.

The reason is that the postinst script is trying to change the
permissions of this directory which is only created if a odoo user does
not already exists.

With this commit, the permission changes only occurs when the directory
is created.

closes odoo/odoo#111829

X-original-commit: 8e1ebd8d
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Move QR from header to next to the invoice total,
now it's look like this https://drive.google.com/file/d/1kNge9eWUc0rMD_6VIDni7F4iHDa4QAE7/view?usp=sharing


Fix the QR code size, increase the QR code pixel and give max size so the quality of the QR code is improved.

Merged waybill number and valid until date so it takes less space, same for E-invoice Acknowledgement

task - 3147187

closes odoo/odoo#110665

Signed-off-by: Josse Colpaert <jco@odoo.com>

task - 3147187

Part-of: odoo/odoo#110665

Steps to reproduce:
Realize the process checkout flow on ecommerce.
Taking care to have only one shipping method (example Mondial relay).

Issue:
When confirming the order,
it is not possible to choose another parcel point.

Solution:
Make it possible to click on the shipping method
to change the parcel point.

Remark:
It is only possible to confirm the relay point once.
We must reload the page if we want to modify it.

opw-3149294

closes odoo/odoo#111605

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Steps to reproduce
==================

- Website > Go to website
- Forum > New post
- Fill the form and post your question
- Go to the backend
- Website > Forum > Post
- Click on the one you just created
- Click on the link in the chatter
-> It goes to an ir.ui.view model

Cause of the issue
==================

Since the form is posted from the frontend, the inherit_branding is
automatically added to the context. This causes the
data-oe-{model,view,id} to be added to the button.

https://github.com/odoo/odoo/blob/46ce4345c96a58845bfa13dd1a86be391cf0a923/addons/website/models/ir_ui_view.py#L425-L426



Solution
========

- Set a context key `inherit_branding` to False inside
`message_post_with_view`.

- In `_render`, only set the key to True if it is not set.

- Also do the same for `inherit_branding_auto`

opw-3070490

closes odoo/odoo#108427

Signed-off-by: Hubert Van De Walle <huvw@odoo.com>

opw-3097856

closes odoo/odoo#111819

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

before this commit, in active currency warning is shown in the account move form when the currency_field is empty.

after this commit, the inactive currency warning will be shown only if the currency is set and it is inactive.

closes odoo/odoo#110920

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Before this commit:

On mobile view the toolbar icon gets hidden, which it should not.

After this commit:

Now the toolbar items are flexed and wrapped.

Task-2752096

closes odoo/odoo#108454

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>