Skip to content
Snippets Groups Projects
  1. Jul 13, 2023
    • Louis Wicket (wil)'s avatar
      [I18N] add auth_ldap module to .tx/config · ae48f1cd
      Louis Wicket (wil) authored
      
      The “Authentication via LDAP” module is not available on Transifex for
      Odoo 16+ projects. This commit adds it to the list of translatable
      resources by referencing it in .tx/config.
      
      closes odoo/odoo#128431
      
      Signed-off-by: default avatarLouis Wicket (wil) <wil@odoo.com>
      ae48f1cd
    • tsm-odoo's avatar
      [FIX] im_livechat: fix crash when user changes after starting livechat · 3355d681
      tsm-odoo authored
      Before this commit, a crash occurred when the user changed after
      starting a livechat conversation.
      
      Steps to reproduce (login => logout)
      - Login on admin
      - Go to the website
      - Start a livechat conversation
      - Logout
      - Start typing on the chat window composer
      - Crash due to `NotFound` raised after `notify_typing`
      
      The same error could occur the other way around (logout => login).
      This error is due to the user not being a channel member after it
      changed.
      
      In order to fix this issue, livechat session is cleared when the
      user changes. Indeed, it the "new" user is not linked to the livechat
      conversation so it makes no sense to display it.
      
      fixes https://github.com/odoo/odoo/issues/128206
      
      
      opw-3421386
      
      closes odoo/odoo#128301
      
      Signed-off-by: default avatarMatthieu Stockbauer (tsm) <tsm@odoo.com>
      3355d681
    • priyanshi patel(prpa)'s avatar
      [FIX] mrp: `To Consume` qty not updated while we update in BOM · fe95a337
      priyanshi patel(prpa) authored
      
      Steps to reproduce
      ==================
      - Create and confirm MO with BOM1
      - Consume the theoretical qty of your MO
      - Update the BOM1
      - Click on the `Produce All` button
      - You will receive a message that the consumed quantity does not match the quantity
        of the BOM1 anymore
      - When clicking on the set quantities and validate button, the consume
        quantities are not the ones that are previewed in the flexible consumption message,
        but the initial MO quantities.
      
      So in this commit, we updated the `To Consume` quantities as per the flexible
      consumption wizard.
      
      task - 3323154
      
      closes odoo/odoo#121602
      
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      fe95a337
    • Victor Piryns (pivi)'s avatar
      [FIX] project: disable recurrence for all tasks linked to a recurrence · 4cb2c1d8
      Victor Piryns (pivi) authored
      
      Current behaviour:
      If you disable the recurrence for 1 task in a suite of recurrence,
      if you had other tasks belonging to the same recurrence suite, they
      would still be with recurrence activated.
      
      Expected behaviour:
      It doesn't make sense for some of the tasks in a suite of tasks in a
      recurrence to enabled and others disabled. If we disable the
      recurrence on 1 such tasks, all tasks should linked to that
      recurrence should be set as non-recurrent, regardless if the
      edit-mode is set on "This task".
      
      Steps to reproduce:
      - For 14.0 -> saas-16.1:
        - Install Project, Studio
        - Turn on in Settings the "Recurrent Tasks"
        - Create a new project and a task in it
        - With studio, in debug mode, add a related field to the task form
          that relates to `next_recurrence_date`. Make sure it's not "read
          only"
        - On the task, turn on the recurrence, set the frequency to each
          day, set the `next_recurrence_date` as a day in the past
        - Run the Scheduled Action "Project : Create Recurring Tasks"
        - On one of the task, disable the recurrence
        - Go to the other task, see that their recurrence is still active,
          and the frequency changed to the defaults values of once a week.
      - For saas-16.2 -> master:
        - Install Project
        - Turn on in Settings the "Recurrent Tasks"
        - Create a new project and a task in it
        - Activate the recurrence on the task, set a planned date in the past
        - Set the task as "Done", this should create an new instance of the
          recurrence.
        - Disable the recurrence option in one of the task, observe that
          is doesn't change for the other task, and the recurrence
          frequency is reset to default values.
      
      Reason for the problem:
      When disabling the recurrence on 1 task, with the edit-mode set as
      "This task", the recurrence is being deleted, but we don't disable
      the recurrence of the other tasks linked to that recurrence.
      
      Fix:
      When we are writing `False` on `recurring_task` on a task, we
      explicitely write `False` on `recurring_task` on all tasks that belong
      to the recurrence after the deletion of the recurrence itself.
      
      Affected versions:
      - 14.0
      - 15.0
      - saas-15.2
      - 16.0
      - saas-16.1
      - saas-16.2
      - saas-16.3
      - master
      
      opw-3265212
      
      closes odoo/odoo#128389
      
      X-original-commit: cbca63d7
      Signed-off-by: default avatarXavier Bol (xbo) <xbo@odoo.com>
      Signed-off-by: default avatarPiryns Victor (pivi) <pivi@odoo.com>
      4cb2c1d8
    • lejeune quentin's avatar
      [FIX] point_of_sale: Fix errors of the new version of IoT 23.07 · f84bbfac
      lejeune quentin authored
      
      In the new version of the iot we import a new "crypt" library which is not available for windows
      
      Addition of the class in the input of the password
      
      closes odoo/odoo#128318
      
      Signed-off-by: default avatarQuentin Lejeune (qle) <qle@odoo.com>
      f84bbfac
    • paso-odoo's avatar
      [FIX] web: prevent selection while record in edit mode from editable list view · ef8a9cf0
      paso-odoo authored
      
      If applied, this commit will solve the issue of the list view selection when
      the record is not actually created but it can be selected and can able to
      perform the action.
      
      Steps to produce:
      - Open Accounting > Configurations > Chart of Accounts.
      - Click on the 'New' button.
      - Select the new line which has been added.
      - Perform the 'Duplicate' action for that record.
      
      This commit will fix the generic issue by preventing the record selection while
      the record is in 'Edit' mode.
      
      sentry - 4191036697
      
      closes odoo/odoo#121792
      
      Signed-off-by: default avatarMathieu Duckerts-Antoine (dam) <dam@odoo.com>
      ef8a9cf0
    • Mehdi Bendali Hacine's avatar
      [FIX] l10n_sa_edi: Fix QR code extraction from XML content · c0369d9f
      Mehdi Bendali Hacine authored
      
      QR code extraction fails in some cases when we try to get the Base64 content
      from the Saudi EDI attachment when the datas is too voluminous. To avoid this, we pass
      bin_size=False in the context to always get the attachment datas correctly.
      
      closes odoo/odoo#128315
      
      Signed-off-by: default avatarJosse Colpaert <jco@odoo.com>
      c0369d9f
    • Mehdi Bendali Hacine's avatar
      [FIX] l10n_sa: Fix QR code generation on Invoice report · 4b5b0caa
      Mehdi Bendali Hacine authored
      Sometimes, when the base64 data used to render the QR code is too long,
      some of the special characters included might be wrongly encoded in the
      url passed to the /report/barcode route. To avoid this, we format the QR
      code string through the quote_plus method to make sure it's always
      properly encoded
      
      Part-of: odoo/odoo#128315
      4b5b0caa
    • Bert Stomphorst's avatar
      [FIX] on archiving product notify only about active used_in_boms · 0cc5900c
      Bert Stomphorst authored
      
      closes odoo/odoo#125585
      
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      0cc5900c
    • Renilkumar Kajavadra's avatar
      [FIX] barcodes_gs1_nomenclature: barcode scan for GS1 date rule · fbec8cd5
      Renilkumar Kajavadra authored
      When user adds rule in the 'Default GS1 Nomenclature' that contains
      'Unit product' in Type and 'Date' in GS1 Content Type.
      
      Steps to reproduce the issue:
      - Go to Inventory > Configuration > Settings > Barcode
        > Select 'Default GS1 Nomenclature' in Barcode Nomenclature
      - Go to Inventory > Configuration > Barcode Nomenclatures
        > Open Default GS1 Nomenclature > Add a line > Select 'Unit Product' in Type
        > Select 'Date' in GS1 Content Type > Add Barcode Pattern for Date
          (ex. '(20)(\d{6})' )
      - Go to Barcode > Inventory Adjustment > Click on Add Product
        > In product, add value for that Barcode Pattern (ex. 20230614)
      
      Error: A traceback appears: 'TypeError: expected string or bytes-like object'
      
      When user add barcode of date for product
      https://github.com/odoo/odoo/blob/ae94f14a844352f66490ec326fe2d1a716023891/addons/barcodes_gs1_nomenclature/models/barcode_nomenclature.py#LL156C25-L156C63
      
      
      Here we will receive datetime.date datatype for value.
      Now when it tries to match re with datetime.date, it will lead to the
      above traceback.
      
      sentry-4236166678
      
      closes odoo/odoo#124958
      
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      fbec8cd5
    • dhba-odoo's avatar
      [FIX] web_editor: word tables are broken because of formatting spaces. · ec0ccdcd
      dhba-odoo authored
      
      Before this commit:
      
      When format styles were applied to the word table, it would break table.
      
      After this commit:
      
      Now, when format styles are applied to a word table, the style will be applied to it
      without breaking the table.
      
      task-3165767
      
      closes odoo/odoo#128059
      
      X-original-commit: cdf74e8a56da6a776ff52ef534c3c9c647519d13
      Signed-off-by: default avatarDavid Monjoie (dmo) <dmo@odoo.com>
      ec0ccdcd
    • Ivan Rasputin's avatar
      [FIX] mass_mailing_event_sms: add missing dependency · 8bbb3c0d
      Ivan Rasputin authored
      The module `mass_mailing_event_sms` extends couple methods [1] that are defined
      in  module `mass_mailing_event` [2]. However, because of the missing dependency
      in manifest, user can uninstall `mass_mailing_event`, while keep
      `mass_mailing_event_sms` installed. This leads to error `'super' object has no
      attribute 'action_invite_contacts'` [3].
      
      Fix it by adding the missing dependency explicitly.
      
      [1]: https://github.com/odoo/odoo/blob/fd508fe436c64780a8454ddeb6b7ec8f1f80d7c5/addons/mass_mailing_event_sms/models/event.py
      
      [2]:
      https://github.com/odoo/odoo/blob/fd508fe436c64780a8454ddeb6b7ec8f1f80d7c5/addons/mass_mailing_event/models/event.py#L23
      
      [3]: https://online.sentry.io/issues/4280254156/
      
      
      
      closes odoo/odoo#127995
      
      X-original-commit: add78c90
      Signed-off-by: default avatarIvan Elizaryev (iel) <iel@odoo.com>
      8bbb3c0d
    • Maruan Aguerdouh (magm)'s avatar
      [FIX] account: no traceback thrown in older browsers when formatting · d1475648
      Maruan Aguerdouh (magm) authored
      
      Trying to access quotations using an older version of a browser, that
      doesn't support `structuredClone` like i.e Safari <15.3 will throw a
      traceback that will block the regular usage of the app.
      
      We can use an older alternative to handle the deep cloning, with this
      approach tho, we will lose the support of Dates, RegExps, Maps, Sets,
      Blobs, FileLists, ImageDatas, sparse Arrays, Typed Arrays.
      
      opw-3386434
      
      closes odoo/odoo#127287
      
      Signed-off-by: default avatarSamuel Degueldre (sad) <sad@odoo.com>
      d1475648
  2. Jul 12, 2023
    • Julien Van Roy's avatar
      [FIX] account_edi_ubl_cii: import with missing unit prices · 0d841933
      Julien Van Roy authored
      
      Sometimes, the net price and the gross price are not present in the
      invoice line, but the line subtotal is (for instance, with some xml from
      Billit). In this case, it is still possible to infer the Odoo unit price
      and parse the xml correctly.
      
      opw-3384704
      
      closes odoo/odoo#128303
      
      X-original-commit: a8c82e6e
      Signed-off-by: default avatarLaurent Smet (las) <las@odoo.com>
      Signed-off-by: default avatarJulien Van Roy (juvr) <juvr@odoo.com>
      0d841933
    • Benjamin Vray's avatar
      [FIX] website: fix anchor selector not updating · 62ed601b
      Benjamin Vray authored
      
      Steps to reproduce the bugs:
      
      - Add a banner on the homepage
      - Click on the "create a link to target this section" button.
      - Edit the anchor name to "bannerAnchor".
      - Drop the image-text snippet.
      - Double click on the button inside the snippet.
      - Choose the homepage as the URL ("/")
      - Open the "Page Anchor" select, choose "#bannerAnchor"
      - Validate the changes.
      - Double Click on the snippet button again.
      - First bug: The URL properly shows "/#bannerAnchor" but the page anchor
      select does not show anything.
      - Open the page anchor select again.
      - Second Bug: the "bannerAnchor" option does not appear as a choice.
      
      This commit fixes the two bugs described above.
      
      task-3378864
      
      closes odoo/odoo#128201
      
      X-original-commit: e0f17d9d
      Signed-off-by: default avatarQuentin Smetz (qsm) <qsm@odoo.com>
      62ed601b
    • Aurelien van Delft (avd)'s avatar
      [FIX] mail: avoid serialization errors with multiple tabs · 89883a06
      Aurelien van Delft (avd) authored
      
      A serialization error can happen when chatting with another
      user from the company. To reproduce:
      
      - Log into Odoo as User A
      - Open another Odoo tab in the same window as User A
      - In private mode log into Odoo as User B
      - Send a message via chat from User B to User A.
      
      A concurrent update happens in channel_fetched method when writing
      on mail_channel_partner.fetched_message_id.
      
      To fix that, update the field
      through raw SQL using FOR NO KEY UPDATE SKIP LOCKED in select subquery.
      This skips the row should it be already locked, which is fine
      as we only need to first transaction in the queue to complete.
      
      opw-3164584
      
      closes odoo/odoo#128154
      
      X-original-commit: 757bfb69
      Signed-off-by: default avatarMatthieu Stockbauer (tsm) <tsm@odoo.com>
      Signed-off-by: default avatarAurélien van Delft (avd) <avd@odoo.com>
      89883a06
    • luvi's avatar
      [FIX] web,*: properly format phone href · 74c75c8d
      luvi authored
      
      *: mail
      
      This commit fixes the href used by the PhoneField. Following the
      specs of a phone uri, spaces must be removed from the phone number
      when using the href attribute.
      
      A test has been added to verify that any spaces are removed from
      a given phone number.
      
      In mail, the SMS button href has been edited for the same purpose.
      
      task-3371999
      
      closes odoo/odoo#125613
      
      Signed-off-by: default avatarFlorent Dardenne (dafl) <dafl@odoo.com>
      74c75c8d
    • Adrien Widart (awt)'s avatar
      [FIX] purchase_stock: update RR's qty_to_order on POL's qty change · 17452ad3
      Adrien Widart (awt) authored
      
      When a RR updates the qty of a POL, the qty to order of that RR will
      be incorrect
      
      To reproduce the issue:
      1. Create a product
         - Storable
         - With a vendor
      2. Create a RR:
         - Min 0
         - Max 0
         - Factor 1
      3. Confirm a delivery with 1 x P
         - It should create a PO
      4. Confirm a second delivery with 1 x P
          - The POL of the PO should be updated
      5. Open the Replenishment page
      
      Error: The qty to order of the product is 1 while it should be 0
      
      `qty_to_order` is a computed field and one of the `depends` is the POL
      related to the product. This explains why, after step 3, everything
      is ok: the compute is triggered (because of the new POL) and the qty
      to order becomes 0. However, step 4, the POL qty is updated -> it
      does not concern any `depends` -> the compute is not triggered,
      hence the error
      
      OPW-3292297
      
      closes odoo/odoo#128245
      
      X-original-commit: 80521431601323c1eb7c85cafbf08e8ae0adbdd6
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      Signed-off-by: default avatarAdrien Widart (awt) <awt@odoo.com>
      17452ad3
    • Aurelien van Delft (avd)'s avatar
      [IMP] purchase_stock: add ir_config_parameter to on_time_rate comp. · b0e940e6
      Aurelien van Delft (avd) authored
      
      On-time-rate is a non-stored computed fields that can take
      some time to load because some partners may have lots of
      related purchase_orders. The compute function in itself
      is relatively difficult to optimize further. This commit
      introduces a new system parameter to reduce the timerange of
      orders to consider when computing On-Time Delivery Rate.
      
      That way, if for some customers the on_time_rate computation takes too
      much time (leading to a slow FormView loading), they can reduce
      the accuracy of the estimation to speedup the field's computation.
      
      closes odoo/odoo#128156
      
      X-original-commit: 2e766f11
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      Signed-off-by: default avatarAurélien van Delft (avd) <avd@odoo.com>
      b0e940e6
    • Touati Djamel (otd)'s avatar
      [FIX] purchase: use the current company currency in purchase analysis · 769e83fe
      Touati Djamel (otd) authored
      
      Steps to reproduce the bug:
      - Connect with a company using USD currency.
      - Create a storable product "P1":
          - Cost: $100
      
      - Create a Purchase order:
          - Add 1 unit of "P1"
          - Currency: USD
      
      - Create another Purchase order:
          - Add 1 unit of "P1"
          - Currency: EUR
      
      - Go to the purchase analysis and select the list view.
      
      Problem:
      The purchase order in EUR is converted into the current company
      currency, but the Euro currency symbol is used instead of the dollar
      symbol
      
      opw-3354221
      opw-3348265
      
      closes odoo/odoo#127783
      
      X-original-commit: 6fc5bb27
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      Signed-off-by: default avatarDjamel Touati (otd) <otd@odoo.com>
      769e83fe
    • Julien (jula)'s avatar
      [FIX] base: guess img placeholder size from field name · 30cb308d
      Julien (jula) authored
      __Current behavior before PR:__
      When no width and height is set to resize an image, the dimensions are guessed using the field name. For instance, an image field with `field_name = "XXXX_123"` is resized to 123 pixels when fetched.
      However this guess should be done only to know the size of the placeholder to display if there is no actual image.
      When there is an image stored in the field, there is no need to guess size.
      
      __Description of the fix:__
      Move the call to the method `image_guess_size_from_field_name` in the condition where the `stream` is not set and therefore a placeholder is displayed instead.
      
      closes odoo/odoo#118968
      
      Related: https://github.com/odoo/odoo/pull/117343
      
      
      Signed-off-by: default avatarJulien Castiaux (juc) <juc@odoo.com>
      30cb308d
    • Nasreddin Boulif (bon)'s avatar
      [FIX] mail,test_mail: message_route; filter emails with wrong domain · 29e079f5
      Nasreddin Boulif (bon) authored
      
      Steps to reproduce:
      
        - Install CRM and Helpdesk modules (for test purposes)
        - Set a custom alias domain (e.g. "mydomain.com")
        - Go to CRM > Configuration > Sales Teams
        - Check that a team has en email Alias (e.g. "info@mydomain.com")
        - Go to Helpdesk > Configuration > Helpdesk Teams
        - Check that a team has en email Alias (e.g. "support@mydomain.com")
        - Email your instance with the following `to` value:
          info@mydomain.com, support@test.com
          (notice second email does not match the DB alias domain)
        - Go to CRM : A task has been created
        - Go to Helpdesk : A ticket has been created
      
      Issue:
      
        The ticket in Helpdesk should not have been created.
      
      Cause:
      
        The message_route method does not check the domain of the email
        address before creating the routes.
      
      Solution:
      
        If `mail.catchall.domain.allowed` system parameter is set, filter to
        only keep the emails address that match the allowed domains (including
        domain set in `mail.catchall.domain` system parameter).
      
        The value of `mail.catchall.domain.allowed` system parameter should
        be a comma separated list of domains. e.g. `example.com,example.org`
      
      opw-3150972
      
      closes odoo/odoo#128257
      
      X-original-commit: bb05e441
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      29e079f5
    • Adrien Widart (awt)'s avatar
      [FIX] purchase{,_stock,_mrp}: get unit price of AVCO kit-component · 475dd211
      Adrien Widart (awt) authored
      Receiving a kit's component will fail in AVCO + multi-uom
      
      To reproduce:
      1. Create a product category PC
         - Costing Method: AVCO
      2. Create two products P_compo, P_kit
         - P_kit:
           - In Units
         - P_compo:
           - In L
           - Storable
           - Category PC
      3. Create a BoM
         - Product: P_kit
         - Type: Kit
         - Components: 1 x P_compo
      4. Create and confirm a PO with 1 x P_kit
      5. Process the receipt
      
      Error: When validating the receipt, a user error is displayed: "The
      unit of measure L defined on the order line doesn't belong to the
      same category [...]"
      
      When processing the SM, we create the in-SVL. To do so, at some
      point, we need the unit price of the SM, and here is where the error
      comes from:
      https://github.com/odoo/odoo/blob/708c3d063482e365e49a04f633c83e90e6fa4356/addons/purchase_stock/models/stock_move.py#L39
      
      
      `self.product_id` is P_component, but `line.product_id` is P_kit,
      hence the error with the UoM1
      And there will be some similar errors with the `if` block, L40 (we
      compare some SM quantities and some POL quantities: we are mixing
      components and kit)
      
      For now, in case of a kit, we will always use the `else` block (i.e.,
      the unit price of the POL). This will be improved in master
      
      OPW-3357685
      
      closes odoo/odoo#128041
      
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      475dd211
    • Vincent Larcin's avatar
      [FIX] project: make tests demo data independent · 9193168d
      Vincent Larcin authored
      
      The test `test_duplicate_project_duplicates_milestones_on_tasks` and the test class `TestSoLineMilestones`
      fail when demo data are not installed.
      This commit makes it demo data independent.
      
      Task-3410352
      
      closes odoo/odoo#127326
      
      Signed-off-by: default avatarXavier Bol (xbo) <xbo@odoo.com>
      9193168d
    • Gurupreet Singh's avatar
      [FIX] hr_timesheet: Fix progress bar value in project task view · 00a46c9b
      Gurupreet Singh authored
      
      Description of the issue/feature this PR addresses:
      In the project task view, add initially planned hours 0.05 and assigned a
      complete value to the the task then the progress bar shows the wrong value
      
      Current behavior before PR:
      when adding the  00:05 planned hours and assigning the complete duration the
      The progress bar value is not right
      
      Desired behavior after PR is merged:
      progress bar value should be right
      
      task-3280609
      
      closes odoo/odoo#128170
      
      X-original-commit: 052dfb5f
      Signed-off-by: default avatarXavier Bol (xbo) <xbo@odoo.com>
      00a46c9b
  3. Jul 11, 2023
Loading