- Oct 01, 2019
-
-
Hugo Adan authored
Custom CSS should be in style attribute Closes odoo/odoo#37638 closes odoo/odoo#37666 Signed-off-by:
Martin Trigaux (mat) <mat@odoo.com>
-
Muhammad Awais authored
closes odoo/odoo#37647 Signed-off-by:
Martin Trigaux (mat) <mat@odoo.com>
-
- Sep 30, 2019
-
-
Yenthe666 authored
closes odoo/odoo#37619 X-original-commit: 028def41 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
Eric Channey authored
closes odoo/odoo#37586 X-original-commit: ab265591 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
Nicolas Martinelli authored
Following commit 5d088e6a, we explicitly use the `product` parameter to check the object type. This enlightened the fact that the method `compute_all` might be called with `product` being an integer instead of a recordset. This was not noticed before because `product` is only used in `account_tax_python`. opw-2076993 closes odoo/odoo#37558 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
Nicolas Lempereur authored
opw-2077865 closes #37524 closes odoo/odoo#37636 X-original-commit: 116c525f302c4738cf4f5859a35f2480a2522a5c Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
Jorge Pinna Puissant authored
Since 1d766c06 the attachment icon was missing when it wasn't a pdf or image type file. opw-2064128 closes odoo/odoo#37616 X-original-commit: de13174c Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
Nans Lefebvre authored
Because of f206714a and subsequent commits, adding groups may raise. We ensure that switching between tax included and tax excluded keeps working. Closes 37481 closes odoo/odoo#37517 Signed-off-by:
Nans Lefebvre (len) <len@odoo.com>
-
- Sep 27, 2019
-
-
Nans Lefebvre authored
Because of f206714a and subsequent commits, adding groups may raise. Thus, it is always safer to first remove groups and then add new groups. The converse could raise, making settings save impossible. Closes 37481
-
- Sep 25, 2019
-
-
mreficent authored
closes odoo/odoo#28170 Signed-off-by:
Martin Trigaux (mat) <mat@odoo.com>
-
- Sep 30, 2019
-
-
Florimond Husquinet (fhu) authored
- Go in Discuss - Send an attachment. Before this commit: by hovering the attachment picture, a cross appears, but clicking it has no effect. After this commit: the cross is not visible in Discuss and chat windows anymore, because this feature was designed for the chatter. Deleting the attachment in a message without text will delete the message, which is not the desired behavior in channels. closes odoo/odoo#37491 Opw: 2075622 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
- Sep 25, 2019
-
-
Adrian Torres authored
Before this commit: - Install the `payment` module - Generate a `payment.transaction` - Try to uninstall the `payment` module -> Uninstall process crashes and the DB is rolled back This happens because the field `acquirer_id` of the model `payment.transaction` is a required many2one with ondelete='set null' (the default), this of course makes no sense, and when the ORM tries to set the field of these records to NULL, it crashes. This has been fixed globally in saas-12.2 at ee6dc40a but for stable versions it is best to simply simulate the behavior of an ondelete='cascade' which is what this commit does via an uninstall_hook Fixes #37379 closes odoo/odoo#37422 Signed-off-by:
Raphael Collet (rco) <rco@openerp.com>
-
- Sep 23, 2019
-
-
Adrian Torres authored
As of 12.0, this operation is permitted albeit sub-optimal, as the field triggers of the target field are appended to the field being defined. Fixes #36851 closes odoo/odoo#37242 Signed-off-by:
Raphael Collet (rco) <rco@openerp.com>
-
- Sep 25, 2019
-
-
Humberto Arocha authored
It should be the same way as residual computes the payments. Have an invoice in foreign currency and a payment in yet another one Open the invoice in form view The payment shows with a certain amount in outstanding credits Reconcile by using the button. Before this commit: Outstanding credits are taken using the value computed at date of invoice. After this commit: Outstanding credits are taken using the value computed at date of payment. This is consistent with: https://github.com/odoo/odoo/blob/12.0/addons/account/models/account_invoice.py#L169 `amount_to_show = currency._convert(abs(line.amount_residual), self.currency_id, self.company_id, line.date or fields.Date.today())` closes odoo/odoo#37391 Signed-off-by:
Lucas Perais (lpe) <lpe@odoo.com>
-
- Sep 29, 2019
-
-
Odoo Translation Bot authored
-
- Sep 27, 2019
-
-
Olivier Dony authored
The client IP is a useful piece of information for logs, and it is also used for automatic fraud detection and prevention on the Ingenico side (e.g. with the Ingenico FDM) Without it, many fraud prevention features do not work as expected.
-
Yannick Tivisse authored
-
Nicolas Martinelli authored
- Create a workcenter with a capacity of 500 units - Create a BOM with a routing generating one work order in the WC created - Create 3 MO with the following real durations: MO 1: 1000 units produced in 420.95 seconds MO 2: 1000 units produced in 120.28 seconds MO 3: 1000 units produced in 60 seconds - Create a MO for 1 unit The Duration expected is computed as The Time Cycle is computed as: (420.95 + 120.28 + 60) / (1000 + 1000 + 1000) = 0.20041 The Total Expected is computed as: 0 + 0 + (1.0 * 0.20041) * (100.0 / 100.0) = 0.20041 0.20041 seconds is not realistic based on the previous MO real durations. This is because the Time Cycle doesn't take into account the workcenter capacity. If we can produce 60 units in parallel in 60 seconds, that doesn't mean we can produce 1 unit in 1 second. Therefore, the Time Cycle should be multiplied by the WC capacity, which gives a Time Cycle: 500 * (420.95 + 120.28 + 60) / (3000) = 100.205 Which is much closer to the real duration. opw-2070759 closes odoo/odoo#37539 X-original-commit: 9d3a73f6 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
Florimond Husquinet (fhu) authored
- Go to Sales > Configuration > Settings. - Under Quotations & Orders, check Online Signature & Payment - Select the Payment radio button. - Click Payment Acquirers. - On the Ingenico tile, click Activate. Before this commit: the bottom of the configuration page that appear contains a broken link. After this commit: a new link is provided, and the text of the link as been updated to reflect the title of the new article linked. closes odoo/odoo#37516 Opw: 2075825 X-original-commit: 12676f56 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
- Jul 17, 2019
-
-
Nikunj Ladava authored
purpose of this commit is to show payment token while making payment with sale order before this commit: in SO payment, there is a filter for s2s acquirer, and becuase of that filter, if brings tokens of the acquirer which is set to s2s currently after this commit: payment token will be shown for particular user, now it will not depends on mode of acquirer task- 2028285 closes odoo/odoo#34413 Signed-off-by:
Damien Bouvy (dbo) <dbo@odoo.com>
-
- Sep 25, 2019
-
-
Jorge Pinna Puissant authored
— Have a POS in a multi-companies environment; — the multi-companies environment configuration don't have a 'Common Contact Book'; — user 'A' open a session in the company 'Z'; — user 'A' closes the POS without closing the session; — user 'A' change of company to company 'Y'; — user 'B' opens the POS application in company 'Z'. Before this commit, an error message was shown, because user 'B' didn't have access to the name of user 'A' when user 'A' is not in the same company. Now, the name of user 'A' is shown correctly in the dashboard. opw-2075388 closes odoo/odoo#37430 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
- Sep 23, 2019
-
-
Jairo Llopis authored
`ir.attachment` records do not require to have a filename set. In `AttachmentBox`, a filename is always set, although in case it's missing it was untranslated. I fixed that. In cases where `AttachmentBox` is not used but its underlying templates are rendered using other means, a user could get a client-side error like this one when browsing a record that had an attachment without filename: <details><summary>Error</summary> ``` Error: TypeError: dict.attachment.filename.split is not a function https://www.tecnativa.com/web/static/lib/qweb/qweb2.js line 469 > Function:26 Rastreo de error: anonymous@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js line 469 > Function:26:45 _render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:458:58 call@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:154:35 anonymous/<@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js line 469 > Function:340:33 foreach@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:180:25 anonymous@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js line 469 > Function:338:25 _render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:458:58 call@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:154:35 anonymous/<@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js line 469 > Function:27:31 foreach@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:180:25 anonymous@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js line 469 > Function:11:23 _render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:458:58 render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:450:26 _render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:480:29 call@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:154:35 anonymous@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js line 469 > Function:20:30 _render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:458:58 render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:450:26 _render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:480:29 call@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:154:35 anonymous@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js line 469 > Function:15:31 _render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:458:58 render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:450:26 _render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:480:29 call@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:154:35 anonymous@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js line 469 > Function:11:31 _render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:458:58 render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:450:26 _render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:480:29 render@https://www.tecnativa.com/web/static/lib/qweb/qweb2.js:450:26 render@https://www.tecnativa.com/mail/static/src/js/thread_widget.js:183:28 _fetchAndRenderThread/<@https://www.tecnativa.com/mail/static/src/js/thread_field.js:124:36 then/</</<@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3276:89 fire@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3119:58 fireWith@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3231:49 Deferred/</deferred[tuple[0]]@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3321:62 then/</</<@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3276:89 fire@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3119:58 fireWith@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3231:49 then/</</<@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3283:104 fire@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3119:58 fireWith@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3231:49 Deferred/</deferred[tuple[0]]@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3321:62 fire@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3119:58 fireWith@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3231:49 then/</</<@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3283:104 fire@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3119:58 fireWith@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3231:49 Deferred/</deferred[tuple[0]]@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3321:62 rpc/<@https://www.tecnativa.com/web/static/src/js/services/ajax_service.js:16:29 then/</</<@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3276:89 fire@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3119:58 fireWith@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3231:49 Deferred/</deferred[tuple[0]]@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3321:62 fire@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3119:58 fireWith@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3231:49 Deferred/</deferred[tuple[0]]@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3321:62 genericJsonRpc/<@https://www.tecnativa.com/web/static/src/js/core/ajax.js:65:18 then/</</<@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3276:89 fire@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3119:58 fireWith@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3231:49 then/</</<@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3283:104 fire@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3119:58 fireWith@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:3231:49 done@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:9275:42 callback@https://www.tecnativa.com/web/static/lib/jquery/jquery.js:9685:57 ``` The error is produced when trying to render this line: https://github.com/odoo/odoo/blob/66c5053a3d1f8cb456929453a62869c95eccf86a/addons/mail/static/src/xml/thread.xml#L506 </details> This patch ensures all attachment has a filename, and fixes that problem. closes odoo/odoo#37253 Signed-off-by:
Alexandre Kühn (aku) <aku@odoo.com>
-
- Sep 25, 2019
-
-
Nicolas Lempereur authored
There was a typo that would remove some of the merging in applyFont. Also there is other issue that have been found: - whitespace text nodes were removed: depending on structure this can remove space between two nodes - the looping over walkpoint possibly had parent nodes that made no sense (eg. container instead of second childNode of container) - if a text contains normal line return (`<br>`) they are removed when changing font size or similar operations - other instances that the walpoint does not corresponds In this changeset, the merging is simplified to simply the real previous font node. opw-2071930 closes #37345 closes odoo/odoo#37456 X-original-commit: b6e3725f Signed-off-by:
Nicolas Lempereur (nle) <nle@odoo.com>
-
Nicolas Lempereur authored
It seems to be solved in IE Edge 17*, but it seems in IE Edge 16 that doing: ``` var log = console.log; log('occurs'); ``` would cause an error ("Invalid calling object") if the developer tools are not opened. It seems that binding the variable is enough for it not to happen. NOTE: it should not be necessary after saas-12.4 (since code is refactored without this usage). * https://developer.microsoft.com/microsoft-edge/platform/issues/14495220/ opw-2072818 closes #37449 Signed-off-by:
Nicolas Lempereur (nle) <nle@odoo.com>
-
Nans Lefebvre authored
This fix is similar to 80200333; both are workarounds for the bug (limitation) introduced by 9d87d15d. In this case, the currency_field is a related field, and these fields are only computed after scalar values are written in database. As a result, this value is not rounded at creation. It is a problem since typically accounting reports are written directly in SQL, and thus reuse the values directly. Anyway even in the ORM the convert_to_cache optimised this away using the assumption that 'the value should have been rounded in convert_to_column'. It follows that in the report, errors can be accumulated to the point where the report is not balanced. This needs to be fixed in database by going through every existing line. Of note: the limitation that was readily acknowledged has not been worked around anywhere, in fact almost every single currency_field is a related one. Also of note, commit afef71d6 should "Always round monetary values in database" while it explicitly checked for the presence of the currency_field in the values and while not introducing a mechanism to make sure it would always be in the values. opw 2066849 closes odoo/odoo#37398 Signed-off-by:
Nans Lefebvre (len) <len@odoo.com>
-
- Sep 24, 2019
-
-
Nicolas Lempereur authored
The notification for quotation/sale order would always say "See Sale Order" and things (in the notification view, not inside) and not "Quotation" if it is a quotation. Do something similar to what was done for purchase in 3f72a8fa. opw-207060 closes #37395 Signed-off-by:
Nicolas Lempereur (nle) <nle@odoo.com>
-
Nicolas Lempereur authored
The notification for invoice would always say "See Invoice" and things like that (in the notification view, not inside). Do something similar to what was done for purchase in 3f72a8fa. opw-2070608 closes #37394 Signed-off-by:
Nicolas Lempereur (nle) <nle@odoo.com>
-
- Sep 25, 2019
-
-
Xavier Morel authored
Because the sub-record values would not necessarily get fetched ever (whether default or stored), the computation of modifiers might blow up if it relied on one of the un-fetched un-specified fields. One such situation is trying to create a partner with child partners if base_address_city is installed: the module adds a readonly attr predicated upon the parent_id, without explicitly providing such the field would be missing from the O2M record's values. Closes #37176 closes odoo/odoo#37408 Signed-off-by:
Christophe Simonis <chs@odoo.com>
-
Richard Mathot authored
opw-2071886 closes odoo/odoo#37401 Signed-off-by:
Christophe Simonis <chs@odoo.com>
-
Andrea Grazioso (agr-odoo) authored
Enable "purchase agreements". Create a product with procurement "Propose a call for tenders" and Routes "Buy" + "Make to Order". Create a SO with the product, confirm, and cancel. A stacktrace will popup blocking the action, because the created purchase_requisition is retrieved to log the cancel action but it does not inherit from the activity mixin so it lacks the correct method. We don't know the properties of the retrieved documents at that point, so we need to check if the retrieved document has the correct method before actually calling it. opw-2076368 closes odoo/odoo#37416 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
- Jun 17, 2019
-
-
Humberto Arocha authored
As `_compute_journal_domain_and_types` method is defined in an abstract model and `has_invoices` method is defined in account.payment model, there is a case where strangely `_compute_journal_domain_and_types` is called in the abstract.register.payment itself and, since the model does not have that method, an AttributeError is raised. closes odoo/odoo#32847 Signed-off-by:
Quentin De Paoli (qdp) <qdp@openerp.com>
-
- Sep 24, 2019
-
-
Nans Lefebvre authored
Test import of a file with xml ids. At the first dry run, the xml id X is associated with id R for each such record. If some records refer to X via a relational field, then in SQL it reduces to a query using R as id; but R does not exist since it was a dry run. As a result, subsequent runs fail. The cache should be cleared after a dry run, since the xml ids are not reliable. opw 2068446 closes odoo/odoo#37370 Signed-off-by:
Nans Lefebvre (len) <len@odoo.com>
-
Andrea authored
l10n_ch_currency_name is a related field to currency Without this patch, when creating an invoice, the inverse of the related field was computed, trying to write the name on the currency (with the same value). If a user did not have the required access rights (e.g. a user in the group Billing can create an invoice but not write on res.currency by default), he was unable to create the invoice. Fixes odoo/odoo#31487 Closes odoo/odoo#31489 closes odoo/odoo#37373 X-original-commit: 5e49fa80 Signed-off-by:
Martin Trigaux (mat) <mat@odoo.com>
-
- Sep 18, 2019
-
-
Samuel Degueldre authored
PURPOSE: Default analytic account should be used wherever possible. This wasn't the case because the module didn't implement a default_get and only filled the fields on product_id change, which isn't set by the OCR task-2067097 opw-2068110 closes odoo/odoo#37015 Signed-off-by:
Florian Daloze (fda) <fda@odoo.com>
-
- Sep 24, 2019
-
-
Raf Ven authored
Pre-filter lines based on known products. Closes #36854 opw-2074824 closes odoo/odoo#37356 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
Nicolas Martinelli authored
opw-2075897 closes odoo/odoo#37342 X-original-commit: 2f22b746 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
Romain Derie authored
Before this commit, if one would introduce a scheme or a port in his website domain, it would make the website selector to crash JS side. Indeed, it would replace the current url hostname by the website domain. If the website domain was introduced with `http://` it would lead to `http://http://mysite.com`. If port was introduced, `http://mysite:8069:8069`. Also, by fixing those 2, it also make `localhost` and `127.0.0.1` to work. (which would not work without `http://` . Related to #36390 Signed-off-by:
Romain Derie (rde) <rde@odoo.com>
-
Romain Derie authored
Before this commit, 'Go to website' in website module dashboard might not redirect to the correct website. It would just redirect to `/` (href) without forcing the website selected in the dashboard. task-2063252 Closes #36390
-
Adrian Torres authored
Before this commit: * Install `survey` module * Create a survey * In the survey options, set "Login required" to True * Try to print the survey or test survey > review survey -> Crash, request object does not have a website attribute With this commit, we move the check for request.website.user_id into the website_survey module by overriding a private helper method that is called in the main method that handles the print survey route, this means that the printing works with both survey and website_survey installed. Fixes #37224 closes odoo/odoo#37333 Signed-off-by:
Martin Trigaux (mat) <mat@odoo.com>
-
Nicolas Martinelli authored
- Go to Inventory > Reporting > Inventory Valuation - Run the report - In the search view, filter on 'Location' or 'Warehouse' The filter doesn't work. Actually, the filter can't work. This is a hack introduced in order to add context keys. Originally, the function `search` was added to avoid the error log 'Non-stored field %s cannot be searched.'. This happens because the web client adds the field in the domain on top of adding the context key. By using `filter_domain`, no domain is added and no error is logged. opw-2075456 closes odoo/odoo#37322 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-