Skip to content
Snippets Groups Projects
  1. Oct 01, 2019
  2. Sep 30, 2019
  3. Sep 27, 2019
  4. Sep 25, 2019
  5. Sep 30, 2019
    • Florimond Husquinet (fhu)'s avatar
      [FIX] mail: cross on attachment present but non functioning · 79e029d3
      Florimond Husquinet (fhu) authored
      
      - Go in Discuss
      - Send an attachment.
      
      Before this commit:
      
      by hovering the attachment picture, a cross appears, but clicking it has no
      effect.
      
      After this commit:
      
      the cross is not visible in Discuss and chat windows anymore, because this
      feature was designed for the chatter. Deleting the attachment in a message
      without text will delete the message, which is not the desired behavior in
      channels.
      
      closes odoo/odoo#37491
      
      Opw: 2075622
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      79e029d3
  6. Sep 25, 2019
    • Adrian Torres's avatar
      [FIX] payment: properly uninstall if transaction exists · 3b6ddb91
      Adrian Torres authored
      
      Before this commit:
          - Install the `payment` module
          - Generate a `payment.transaction`
          - Try to uninstall the `payment` module
          -> Uninstall process crashes and the DB is rolled back
      
      This happens because the field `acquirer_id` of the model
      `payment.transaction` is a required many2one with ondelete='set null'
      (the default), this of course makes no sense, and when the ORM tries to
      set the field of these records to NULL, it crashes.
      
      This has been fixed globally in saas-12.2 at ee6dc40a but for stable
      versions it is best to simply simulate the behavior of an
      ondelete='cascade' which is what this commit does via an uninstall_hook
      
      Fixes #37379
      
      closes odoo/odoo#37422
      
      Signed-off-by: default avatarRaphael Collet (rco) <rco@openerp.com>
      3b6ddb91
  7. Sep 23, 2019
  8. Sep 25, 2019
  9. Sep 29, 2019
  10. Sep 27, 2019
    • Olivier Dony's avatar
      [FIX] payment_ogone: send client IP in S2S tx data · 8935d1c3
      Olivier Dony authored
      The client IP is a useful piece of information for logs, and it is
      also used for automatic fraud detection and prevention on the
      Ingenico side (e.g. with the Ingenico FDM)
      
      Without it, many fraud prevention features do not work as expected.
      8935d1c3
    • Yannick Tivisse's avatar
    • Nicolas Martinelli's avatar
      [FIX] mrp: Time Cycle computation · 5adfbacc
      Nicolas Martinelli authored
      
      - Create a workcenter with a capacity of 500 units
      - Create a BOM with a routing generating one work order in the WC
        created
      - Create 3 MO with the following real durations:
        MO 1: 1000 units produced in 420.95 seconds
        MO 2: 1000 units produced in 120.28 seconds
        MO 3: 1000 units produced in 60 seconds
      - Create a MO for 1 unit
      
      The Duration expected is computed as
      
      The Time Cycle is computed as:
        (420.95 + 120.28 + 60) / (1000 + 1000 + 1000) = 0.20041
      The Total Expected is computed as:
        0 + 0 + (1.0 * 0.20041) * (100.0 / 100.0) = 0.20041
      
      0.20041 seconds is not realistic based on the previous MO real
      durations.
      
      This is because the Time Cycle doesn't take into account the workcenter
      capacity. If we can produce 60 units in parallel in 60 seconds, that
      doesn't mean we can produce 1 unit in 1 second. Therefore, the Time
      Cycle should be multiplied by the WC capacity, which gives a Time Cycle:
      
         500 * (420.95 + 120.28 + 60) / (3000) = 100.205
      
      Which is much closer to the real duration.
      
      opw-2070759
      
      closes odoo/odoo#37539
      
      X-original-commit: 9d3a73f6
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      5adfbacc
    • Florimond Husquinet (fhu)'s avatar
      [FIX] payment_ogone: broken Ingenico configuration link · 6b2c8c07
      Florimond Husquinet (fhu) authored
      
      - Go to Sales > Configuration > Settings.
      - Under Quotations & Orders, check Online Signature & Payment
      - Select the Payment radio button.
      - Click Payment Acquirers.
      - On the Ingenico tile, click Activate.
      
      Before this commit:
      
      the bottom of the configuration page that appear contains a broken link.
      
      After this commit:
      
      a new link is provided, and the text of the link as been updated to reflect
      the title of the new article linked.
      
      closes odoo/odoo#37516
      
      Opw: 2075825
      X-original-commit: 12676f56
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      6b2c8c07
  11. Jul 17, 2019
    • Nikunj Ladava's avatar
      [FIX] sale: show payment token in sale payment · c3387e84
      Nikunj Ladava authored
      
      purpose of this commit is to show payment token while making payment with sale order
      
      before this commit:
      in SO payment, there is a filter for s2s acquirer, and becuase of that filter, if brings
      tokens of the acquirer which is set to s2s currently
      
      after this commit:
      payment token will be shown for particular user, now it will not depends on mode of acquirer
      
      task- 2028285
      
      closes odoo/odoo#34413
      
      Signed-off-by: default avatarDamien Bouvy (dbo) <dbo@odoo.com>
      c3387e84
  12. Sep 25, 2019
    • Jorge Pinna Puissant's avatar
      [FIX] point_of_sale: pos session username in a multi-companies environment · b149522b
      Jorge Pinna Puissant authored
      
      — Have a POS in a multi-companies environment;
      — the multi-companies environment configuration don't have a 'Common
          Contact Book';
      — user 'A' open a session in the company 'Z';
      — user 'A' closes the POS without closing the session;
      — user 'A' change of company to company 'Y';
      — user 'B' opens the POS application in company 'Z'.
      
      Before this commit, an error message was shown, because user 'B' didn't
      have access to the name of user 'A' when user 'A' is not in the same
      company.
      
      Now, the name of user 'A' is shown correctly in the dashboard.
      
      opw-2075388
      
      closes odoo/odoo#37430
      
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      b149522b
  13. Sep 23, 2019
  14. Sep 25, 2019
    • Nicolas Lempereur's avatar
      [FIX] web_editor: applyFont improve 2408a1ef · 732ae95c
      Nicolas Lempereur authored
      
      There was a typo that would remove some of the merging in applyFont.
      
      Also there is other issue that have been found:
      
      - whitespace text nodes were removed: depending on structure this can
        remove space between two nodes
      
      - the looping over walkpoint possibly had parent nodes that made no
        sense (eg. container instead of second childNode of container)
      
      - if a text contains normal line return (`<br>`) they are removed when
        changing font size or similar operations
      
      - other instances that the walpoint does not corresponds
      
      In this changeset, the merging is simplified to simply the real previous
      font node.
      
      opw-2071930
      closes #37345
      
      closes odoo/odoo#37456
      
      X-original-commit: b6e3725f
      Signed-off-by: default avatarNicolas Lempereur (nle) <nle@odoo.com>
      732ae95c
    • Nicolas Lempereur's avatar
      [FIX] web: IE<Edge17 error when error in ajax call · 38ae0632
      Nicolas Lempereur authored
      It seems to be solved in IE Edge 17*, but it seems in IE Edge 16 that
      doing:
      
      ```
      var log = console.log;
      log('occurs');
      ```
      
      would cause an error ("Invalid calling object") if the developer tools
      are not opened.
      
      It seems that binding the variable is enough for it not to happen.
      
      NOTE: it should not be necessary after saas-12.4 (since code is
      refactored without this usage).
      
      * https://developer.microsoft.com/microsoft-edge/platform/issues/14495220/
      
      
      
      opw-2072818
      closes #37449
      
      Signed-off-by: default avatarNicolas Lempereur (nle) <nle@odoo.com>
      38ae0632
    • Nans Lefebvre's avatar
      [FIX] account: round debit and credit of account move lines at creation · 9b0d4301
      Nans Lefebvre authored
      
      This fix is similar to 80200333; both are workarounds for the bug (limitation)
      introduced by 9d87d15d.
      In this case, the currency_field is a related field, and these fields are only
      computed after scalar values are written in database.
      As a result, this value is not rounded at creation.
      
      It is a problem since typically accounting reports are written directly in SQL,
      and thus reuse the values directly.
      Anyway even in the ORM the convert_to_cache optimised this away using the
      assumption that 'the value should have been rounded in convert_to_column'.
      It follows that in the report, errors can be accumulated
      to the point where the report is not balanced.
      This needs to be fixed in database by going through every existing line.
      
      Of note: the limitation that was readily acknowledged has not been worked around
      anywhere, in fact almost every single currency_field is a related one.
      Also of note, commit afef71d6 should "Always round monetary values in database"
      while it explicitly checked for the presence of the currency_field in the values
      and while not introducing a mechanism to make sure it would always be in the
      values.
      
      opw 2066849
      
      closes odoo/odoo#37398
      
      Signed-off-by: default avatarNans Lefebvre (len) <len@odoo.com>
      9b0d4301
  15. Sep 24, 2019
  16. Sep 25, 2019
    • Xavier Morel's avatar
      [FIX] core: o2m modifiers in the SSF · 184d1b69
      Xavier Morel authored
      
      Because the sub-record values would not necessarily get fetched
      ever (whether default or stored), the computation of modifiers might
      blow up if it relied on one of the un-fetched un-specified fields.
      
      One such situation is trying to create a partner with child partners
      if base_address_city is installed: the module adds a readonly attr
      predicated upon the parent_id, without explicitly providing such the
      field would be missing from the O2M record's values.
      
      Closes #37176
      
      closes odoo/odoo#37408
      
      Signed-off-by: default avatarChristophe Simonis <chs@odoo.com>
      184d1b69
    • Richard Mathot's avatar
      [FIX] hr_holidays: don't do accrual allocation of time off for archived employees · ad315ab7
      Richard Mathot authored
      
      opw-2071886
      
      closes odoo/odoo#37401
      
      Signed-off-by: default avatarChristophe Simonis <chs@odoo.com>
      ad315ab7
    • Andrea Grazioso (agr-odoo)'s avatar
      [FIX] stock: purchase_requistion make SO crash on cancel · a3b47b1a
      Andrea Grazioso (agr-odoo) authored
      
      Enable "purchase agreements". Create a product with procurement "Propose
      a call for tenders" and Routes "Buy" + "Make to Order".
      Create a SO with the product, confirm, and cancel.
      
      A stacktrace will popup blocking the action, because the created
      purchase_requisition is retrieved to log the cancel action but it does
      not inherit from the activity mixin so it lacks the correct method.
      
      We don't know the properties of the retrieved documents at that point,
      so we need to check if the retrieved document has the correct method before
      actually calling it.
      
      opw-2076368
      
      closes odoo/odoo#37416
      
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      a3b47b1a
  17. Jun 17, 2019
  18. Sep 24, 2019
    • Nans Lefebvre's avatar
      [FIX] base_import: clear cache after a dry run · 1b35294d
      Nans Lefebvre authored
      
      Test import of a file with xml ids.
      At the first dry run, the xml id X is associated with id R for each such record.
      If some records refer to X via a relational field, then in SQL it reduces
      to a query using R as id; but R does not exist since it was a dry run.
      As a result, subsequent runs fail.
      
      The cache should be cleared after a dry run, since the xml ids are not reliable.
      
      opw 2068446
      
      closes odoo/odoo#37370
      
      Signed-off-by: default avatarNans Lefebvre (len) <len@odoo.com>
      1b35294d
    • Andrea's avatar
      [FIX] l10n_ch: set field l10n_ch_currency_name to readonly · ebaf3579
      Andrea authored
      
      l10n_ch_currency_name is a related field to currency
      Without this patch, when creating an invoice, the inverse of the
      related field was computed, trying to write the name on the currency
      (with the same value).
      If a user did not have the required access rights (e.g. a user in the
      group Billing can create an invoice but not write on res.currency by
      default), he was unable to create the invoice.
      
      Fixes odoo/odoo#31487
      Closes odoo/odoo#31489
      
      closes odoo/odoo#37373
      
      X-original-commit: 5e49fa80
      Signed-off-by: default avatarMartin Trigaux (mat) <mat@odoo.com>
      ebaf3579
  19. Sep 18, 2019
  20. Sep 24, 2019
Loading