Skip to content
Snippets Groups Projects
  1. Nov 25, 2022
    • Jigar Vaghela's avatar
      [IMP] mrp,mrp_*,repair: MRP back to basics 6 · dd60647c
      Jigar Vaghela authored
      
      mrp
      ===
      - no time has been recorded on operations then give warning with apply button
      
      - do not allow to mass edit UOM in any manufacturing state
      
      - set value of lot/serial from MO and set read only on unbuild from MO
      
      - remove "archive operation" icon
      
      repair
      ======
      Currently it is not possible to select a return on a repair order unless save it first. so after this commit user can able to select it without save it.
      only show picking related to selected product
      
      closes odoo/odoo#102596
      
      Task: 2845380
      Related: odoo/enterprise#34381
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      dd60647c
    • Odoo's Mergebot's avatar
      [FIX] web,event,mail,crm: fix form views · 07071e14
      Odoo's Mergebot authored
      
      Purpose
      =======
      Fix the inline input fields which width seems broken
      because of the new always edit mode.
      
      Specifications
      ===========
      Web :
      Introduce new css classes to be added to the
      input fields in order to constraint their width and avoid
      white gaps in forms.
      
      Event :
      Limit the size of the confirmed attendees input
      field in the event form and event type form to
      display the confirmed attendees message in one line.
      When using the debug mode, in the event templates,
      inline the Register Button with its checkbox to avoid
      line breaks.
      
      Mail :
      Limit the size of the delay count input
      field in the activity type form and restore the
      inline display of the schedule message to
      avoid unnecessary white gaps.
      
      CRM :
      Fix the leads generation form inlined inputs
      display by reducing the inputs width to match
      their content display.
      Fix the lead form view to align the expected
      revenue with the probability for better UI.
      Fix the geolocation field and send email button
      of the Assigned Partner form tab by restoring
      their inline property. Because of the form
      grid layout, nested groups had to be used to
      correctly restore the display. Alternative solutions
      modify the DOM too much, which could lead to more
      xpath and inheritance issues.
      
      Task-2996467
      
      closes odoo/odoo#102546
      
      See: odoo/enterprise#32460
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      07071e14
    • amdi-odoo's avatar
      [FIX] crm: fix input display · 8edd4c96
      amdi-odoo authored
      Purpose
      =======
      Fix the inline input fields which
      width seems broken because of the new
      always edit mode.
      
      Specifications
      ==============
      Fix the leads generation form inlined inputs
      display by reducing the inputs width to match
      their content display.
      
      Fix the lead form view to align the expected
      revenue with the probability for better UI.
      
      Fix the geolocation field and send email button
      of the Assigned Partner form tab by restoring
      their inline property. Because of the form
      grid layout, nested groups had to be used to
      correctly restore the display. Alternative solutions
      modify the DOM too much, which could lead to more
      xpath and inheritance issues.
      
      Task-2996467
      
      Part-of: odoo/odoo#102546
      8edd4c96
    • amdi-odoo's avatar
      [FIX] mail: fix input display · 89847a8c
      amdi-odoo authored
      Purpose
      =======
      Fix the inline input fields which
      width seems broken because of the new
      always edit mode.
      
      Specifications
      ==============
      Limit the size of the delay count input
      field in the activity type form and restore
      the inline display of the schedule message
      to avoid unnecessary white gaps.
      
      Task-2996467
      
      Part-of: odoo/odoo#102546
      89847a8c
    • amdi-odoo's avatar
      [FIX] {website_}event: fix input display · 60bb067b
      amdi-odoo authored
      Purpose
      =======
      Fix the inline input fields which
      width seems broken because of the new
      always edit mode and the new form grid layout.
      
      Specifications
      ==============
      Limit the size of the confirmed attendees input
      field in the event form and event type form to
      display the confirmed attendees message in one line.
      
      When using the debug mode, in the event templates,
      inline the Register Button with its checkbox to avoid
      line breaks.
      
      Task-2996467
      
      Part-of: odoo/odoo#102546
      60bb067b
    • amdi-odoo's avatar
      [IMP] web: add custom input resize · 5fe7759f
      amdi-odoo authored
      With the arrival of the new always edit mode,
      some form views display are broken because of
      the very big input width creating white gap
      when having inline fields.
      
      This commit introduces new css classes to be
      added to the input fields in order to constraint
      their width and avoid white gaps in forms.
      
      Task-2996467
      
      Part-of: odoo/odoo#102546
      5fe7759f
    • tsm-odoo's avatar
      [FIX] bus: presence service returning wrong value · 0e9351e7
      tsm-odoo authored
      
      Since #106454 the `isOdooFocused` variable is not updated correctly.
      This commit fixes this issue.
      
      closes odoo/odoo#106514
      
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      0e9351e7
    • Florent de Labarre's avatar
      [FIX] mrp_subcontracting: sql crach · aa104980
      Florent de Labarre authored
      
      In large database, if you try to get all subcontrat quant you can crach postgres with a big query.
      
      closes odoo/odoo#106480
      
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      aa104980
    • Tiffany Chang (tic)'s avatar
      [FIX] mrp: prevent editing of readonly locations for MO moves · 1bb2c44d
      Tiffany Chang (tic) authored
      Issue: In the MO view, the src location for components was editable and
      the dest location for byproducts was editable when neither of these
      should be.
      
      Due to the same field appearing twice in the same x2many field list,
      there were 2 issues:
      
      1. something changed (probably during OWL refactoring) that made it so
         the 2nd invisible field instance of the field was overriding the
         "readonly='1'" property of the 1st instance when it was in the view
         (i.e. when multi-locations is active) [in previous versions this did
         not happen]
      2. because of the change by https://github.com/odoo/odoo/commit/168cbe66bee7824bdf389de5c6c680342e27bc6d
      
      
         we ensure that these two required fields are always correctly set (to
         the MO's values as per the default when multi-loc is active) when the
         MO's moves are created.
      
      Part of general bugfix task: 2985735
      
      closes odoo/odoo#105959
      
      Related: odoo/enterprise#34276
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      1bb2c44d
    • niyasraphy's avatar
      [FIX] im_livechat: history field alignment · 696d1be2
      niyasraphy authored
      
      closes odoo/odoo#104788
      
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      696d1be2
    • Dossogne Bertrand's avatar
      [FIX] hr_*: fix visuals after always-edit mode · 6164cf81
      Dossogne Bertrand authored
      
      hr_*:
      - hr
      - hr_contract
      - hr_work_entry
      - hr_work_entry_contract
      
      Fixes multiple visual issues in various models
      
      task-3002444
      
      closes odoo/odoo#102922
      
      Related: odoo/enterprise#32638
      Signed-off-by: default avatarKevin Baptiste <kba@odoo.com>
      6164cf81
    • Loan (lse)'s avatar
      [FIX] pos_adyen: JS error in loop if deleted Adyen payment line · 05049ea0
      Loan (lse) authored
      
      Before this commit:
       If we remove a payment line using an Adyen payment method,
       `pending_adyen_line()` return `undefined`.
       With the `_poll_for_response` still being executed,
       it will pop some JS traceback each call with:
       ```js
       TypeError: Cannot read properties of undefined (reading 'terminalServiceId')
       ```
      
      After this commit:
       No JS traceback loop
      
      OPW-3032391
      
      closes odoo/odoo#106461
      
      X-original-commit: 52a517ca
      Signed-off-by: default avatarQuentin Lejeune (qle) <qle@odoo.com>
      05049ea0
    • Chong Wang (cwg)'s avatar
      [FIX] core: fix translation dialog · 1ed5ce6f
      Chong Wang (cwg) authored
      
      The fix in #106174 was not good.
      The translation dialog cannot update not translated terms
      
      the initial term value may be empty "" when the source and the translation are
      the same at first. So, the source to for update_field_translations should be
        const source = term.value ? term.value : term.source;
      
      closes odoo/odoo#106360
      
      Signed-off-by: default avatarAaron Bohy (aab) <aab@odoo.com>
      1ed5ce6f
    • Aurélien (avd)'s avatar
      [FIX] res_currency: add order by to _select_companies_rates query · 0d829b41
      Aurélien (avd) authored
      
      PG12 introduced an optimization for CTEs that automatically inlines
      CTEs if they are only refered once in the parent query. Prior to that
      CTEs were always materialzed, meaning that PG created a sort of temp
      table on the fly to store the result of the CTE's evaluation.
      
      Whereas this leads to performance improvements in general, in the
      particular case of _select_companies_rates this inlining becomes a
      performance bottleneck. This is because while the currency_rate CTE
      is only refered once in both purchase_report and product_margin,
      the join condition (cr.date_end is null or cr.date_end > ...)
      requires evaluating the CTE's date_end subquery twice. This, combined
      with the fact that in PG12 the planner goes for a Nested Loop JOIN instead
      of a HASH Join in PG10 makes the performances of the whole query
      much worse in PG12 than in PG10.
      
      Adding MATERIALIZED before the CTE definition forces PG to evaluate the
      subquery first using its own plan. This removes the need to rescan the
      subquery each time the Merge JOIN filter has to be applied, which
      is a good strategy in this specific situation.
      
      Examples of query timings change before and after PR:
      
      Number of POs | Before PR | After PR
            2000    |     7s    |    345ms
            7000    |     23s   |    1.1s
      
      opw-2930578
      
      closes odoo/odoo#106097
      
      X-original-commit: 8b7a3941
      Signed-off-by: default avatarRaphael Collet <rco@odoo.com>
      0d829b41
    • Claire Bretton (clbr)'s avatar
      [IMP] l10n_ke: withholding taxes, default POS and inventory accounts · 8406484e
      Claire Bretton (clbr) authored
      
      Some updates to Kenya localization:
      - Withholing taxes support
      - Inventory Interim accounts are set by default when automatic valuation of stocks is used
      - Default temporary account for POS
      
      closes odoo/odoo#105906
      
      Task: 3067646
      Signed-off-by: default avatarFlorian Gilbert (flg) <flg@odoo.com>
      8406484e
    • Odoo's Mergebot's avatar
      [FIX] calendar: hide 'sync' options from users · 48c56e09
      Odoo's Mergebot authored
      
      ## Issues
      
      - When the google and outlook sync plugins are not installed the admin user should see an option to install them from the calendar but other users should not see anything.
      
      - The 'groups' guard would have prevented regular users from syncing their calendar at all if it had worked
      
      - Users can get an obtuse error message if the administrator has not configured the installed sync modules
      
      ## Fix
      
      - Replaces the 'groups' attribute in the calendar controller template with a t-if and a dynamic check as OWL doesn't process 'groups'.
      
      - Update the structure of the calendar sync template to facilitate overriding the display conditions
      - Update the inherits to override the display conditions and allow anyone to see the sync button once a module is installed
      
      - Update the code that handles clicking 'sync' to throw the same error as it would have for other misconfigurations
      
      task - 3056311
      
      closes odoo/odoo#105461
      
      Related: odoo/enterprise#33838
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      48c56e09
    • Renaud Thiry's avatar
      [FIX] calendar: show dialog when sync unconfigured · 6ec6a376
      Renaud Thiry authored
      ## Issue
      
      Currently if an administrator installs one of the sync modules but does
      not set any credentials. If the user tries to sync their calendar
      they are met with an error.
      
      ## Fix
      
      Make sure they get a clear dialog explaining why they cannot sync.
      
      task - 3056311
      
      Part-of: odoo/odoo#105461
      6ec6a376
    • Renaud Thiry's avatar
      [FIX] calendar: show calendar sync when installed · 29f820cf
      Renaud Thiry authored
      ## Issue
      
      Regular users were not able to see the sync button
      used to sync with external calendar services even after
      these services were configured
      
      ## Fix
      
      Conditionally display the whole sync section until one of the
      services is configured.
      
      Override the display conditions when one of the relevant modules are
      installed.
      
      task - 3056311
      
      Part-of: odoo/odoo#105461
      29f820cf
    • Renaud Thiry's avatar
      [FIX] calendar: hide 'sync' options from users · 4d5b7d4b
      Renaud Thiry authored
      Issue
      When the google and outlook sync plugins are not installed the admin user should see an option to install them from the calendar but other users should not see anything.
      
      Fix
      This replaces the 'groups' attribute in the calendar controller template with a t-if and a dynamic check as OWL doesn't process 'groups'.
      
      task - 3056311
      
      Part-of: odoo/odoo#105461
      4d5b7d4b
    • Pierre Rousseau's avatar
      [FIX] spreadsheet: update o_spreadsheet to latest version · 181b3155
      Pierre Rousseau authored
      ### Contains the following commits:
      
      https://github.com/odoo/o-spreadsheet/commit/b167b3e6
      
       [FIX] selection: Altering selection should scroll the viewport
      
      closes odoo/odoo#106387
      
      Related: odoo/enterprise#34336
      Signed-off-by: default avatarRémi Rahir (rar) <rar@odoo.com>
      181b3155
    • Lucas Perais's avatar
      [FIX] base: ir_ui_view: factorize inlining of default subview of x2many · fcf71e51
      Lucas Perais authored
      
      The new get_views API inlines every subview into the main view in an effort to
      optimize client/server communication.
      
      In the situation:
      ```
      <form>
        <field name="my_one_to_many" />
      </form>
      ```
      
      The server algorithm will fetch kanban or list views to display that x2many and inline them
      in the final arch that is sent to the client.
      
      This commit aims at factorizing the code which does just that in order for studio (or other modules)
      to be able to detect whether the subview it receives is "real" or inlined
      
      closes odoo/odoo#106271
      
      Related: odoo/enterprise#34250
      Signed-off-by: default avatarDenis Ledoux (dle) <dle@odoo.com>
      fcf71e51
    • Maruan Aguerdouh (magm)'s avatar
      [FIX] account: bank journal not showing as payment option when unvailable · 0916d36d
      Maruan Aguerdouh (magm) authored
      
      Steps to reproduce:
      
      -Go to Journals > Bank journal > Remove all Incoming Payments
      -Try to pay for an invoice
      -The Bank journal will still appear
      
      Issue:
      
      Bank journal should not be an option if it doesn't have Incoming
      Payments.
      
      Solution:
      
      We need to add the proper filter for journals in the default_domain in
      order to not get the bank journal when it is not available.
      
      This bug affects all versions from 15.2 until 16.
      
      opw-3027346
      
      closes odoo/odoo#106462
      
      X-original-commit: 119676029b929512179a337f0f3b70837a5c2b37
      Signed-off-by: default avatarWilliam André (wan) <wan@odoo.com>
      0916d36d
    • tsm-odoo's avatar
      [FIX] bus: prevent crash of presence service for cross origin iframes · 7210c50d
      tsm-odoo authored
      
      Before this PR, the presence service would crash on cross-origin
      iframes. This is due to the fact that accessing the parent document
      of a cross origin iframe is forbidden for security concerns.
      
      This error was introduced when trying to synchronize the website iframe
      and the window focus state in #102479.
      
      This PR fixes the issue by catching the error and fallbacking to the old
      behavior given than task-3006023 has been fixed by #53143 anyway.
      
      task-3073242
      
      closes odoo/odoo#106454
      
      Signed-off-by: default avatarStockbauer Matthieu (tsm) <tsm@odoo.com>
      7210c50d
    • Abdelouahab (abla)'s avatar
      [FIX] mail: ignore null ref · 10492203
      Abdelouahab (abla) authored
      
      To Reproduce
      ============
      - on chatter, upload 2 images
      - open the first image click or zoom with the mouse wheel (no problem)
      - switch to the second one and try same thing -> traceback
      
      Problem
      =======
      some actions are too fast that sometimes the function `_updateZoomerStyle` is called
      before setting the refs, so we just do nothing when image is null
      
      Solution
      ========
      do nothing when image is `null`
      
      opw-3029580
      opw-3071054
      
      closes odoo/odoo#106445
      
      X-original-commit: d5b16246425093bbb30d0530d5fc50ce6da7425e
      Signed-off-by: default avatarSébastien Theys (seb) <seb@odoo.com>
      10492203
    • Loan (lse)'s avatar
      [FIX] web: Typo in JS parameter name · 9f59129f
      Loan (lse) authored
      
      Before this commit:
       In the bottom of the settings, it would show:
       `Database expiration: Invalid Datetime` if
       the `database.expiration_date` system parameter
       value is set.
      
      After this commit:
       The date is displayed correctly
      
      OPW-3047586
      OPW-3072884
      
      closes odoo/odoo#106434
      
      Signed-off-by: default avatarJorge Pinna Puissant (jpp) <jpp@odoo.com>
      9f59129f
    • Valentin Vallaeys (vava)'s avatar
      [FIX] payment_*: fix supported currencies for providers · 4ddb8a90
      Valentin Vallaeys (vava) authored
      
      *: asiapay, flutterwave and mercado_pago.
      
      Wrong numerical code for USD in Asiapay.
      
      Remove unsupported currencies for Flutterwave (ARS, BRL, CVE, CDF, GMD, LRD, MXN, MZN, SOL, ZMK).
      
      Add supported currencies for Mercado Pago (BOB, EUR).
      
      Reorder currencies from support page list.
      
      closes odoo/odoo#106427
      
      Signed-off-by: default avatarAntoine Vandevenne (anv) <anv@odoo.com>
      4ddb8a90
    • Bruno Boi's avatar
      [FIX] web: popovers and arrows repositioning · c54cc2f8
      Bruno Boi authored
      
      **Before this commit**
      When a popover is shown and then repositioned to a different placement
      (i.e. due to window scrolling or resize), its arrow is misplaced.
      
      This is due to the fact that classnames added in order to correctly place
      its arrow are just added to the previous ones instead of replacing all
      the needed classnames.
      
      **After this commit**
      The classnames are now properly replaced instead of just being appended.
      
      closes odoo/odoo#106421
      
      Signed-off-by: default avatarLuca Vitali <luvi@odoo.com>
      Signed-off-by: default avatarBruno Boi (boi) <boi@odoo.com>
      c54cc2f8
    • Nicolas Martinelli's avatar
      [FIX] account: do not call `button_install` is not necessary · 97ffc518
      Nicolas Martinelli authored
      
      If the method `_auto_install_l10n` is called programmatically on a DB
      where the localization has already been installed, useless processing is
      performed by `button_install`.
      
      Do not call this method if no module need to be installed.
      
      closes odoo/odoo#106407
      
      X-original-commit: 11e9d3f1
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      97ffc518
    • Bassirou Ndaw's avatar
      [CLA] signature for Ergobit · 455c7e77
      Bassirou Ndaw authored
      
      closes odoo/odoo#106400
      
      Signed-off-by: default avatarMartin Trigaux (mat) <mat@odoo.com>
      455c7e77
    • Yolann Sabaux's avatar
      [FIX] barcodes_gs1_nomenclature: access record with portal · e0fec5af
      Yolann Sabaux authored
      
      Steps to reproduce:
      (Activate Project, Timesheets, Sales, and Inventory)
      - connect with portal
      - open Projects
      - try to open project "AGR - S00021 - Sales Order"
      
      Issue:
      Access Error
      
      Cause:
      We want to access to the field "is_gs1_nomenclature" for which Portal has no access.
      
      Note:
      On the main Runbot (all apps) it does work because the subcontractin_portal adds the Barcode Nomenclature access to Portal user
      
      opw-3073064
      
      closes odoo/odoo#106384
      
      Signed-off-by: default avatarAdrien Widart <awt@odoo.com>
      e0fec5af
    • vishal padhiyar's avatar
      [FIX] web_editor: impossible to add signature at some times · 7d5f61ab
      vishal padhiyar authored
      
      Before this commit:
      
      When we try to add signature from powerbox then sometimes it does not show
      the signature.
      
      After this commit:
      
      Now when we try to add signature from powerbox then it will show the signature.
      
      Task-2939080
      
      closes odoo/odoo#103013
      
      Signed-off-by: default avatarDavid Monjoie (dmo) <dmo@odoo.com>
      7d5f61ab
    • niyasraphy's avatar
      [FIX] gamification: fix form view display · e676d88e
      niyasraphy authored
      
      Display goal description and definition field full width. Purpose is to have
      well aligned fields, using v16 new rendering options.
      
      closes odoo/odoo#103999
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      e676d88e
  2. Nov 24, 2022
Loading