Skip to content
Snippets Groups Projects
  1. Oct 10, 2022
    • Martin Trigaux's avatar
      [I18N] *: export 16.0 source terms · de550a9c
      Martin Trigaux authored
      
      closes odoo/odoo#102902
      
      Related: odoo/enterprise#32633
      Signed-off-by: default avatarMartin Trigaux (mat) <mat@odoo.com>
      de550a9c
    • Victor Feyens's avatar
      [IMP] core: docstring improvements · 8250cd4b
      Victor Feyens authored
      
      * clean and improve docstrings in orm
      * fix typos found with codespell
      * rely on the Environment class docstring instead of doc content (and 
      therefore move part of the doc inside the class docstring)
      
      closes odoo/odoo#102896
      
      Related: odoo/documentation#2798
      Signed-off-by: default avatarVictor Feyens (vfe) <vfe@odoo.com>
      8250cd4b
    • Mathias Mathy (MAMA)'s avatar
      [FIX] stock: rename routes on warehouses' name change · 3ebb8082
      Mathias Mathy (MAMA) authored
      
      When a warehouse is renamed, associated route's name shall be renamed accordingly.
      As previously, the call to 'route.write()' in method '_update_name_and_code' was done after the 'super().write()',
      there was no way to remember the old name of the warehouse, and the 'replace' was so uneffective.
      The effectivenes of the replace is reestablished by doing the 'super().write' after the call to '_update_name_and_code',
      however, it breaks the method '_get_sequence_values' because it expects the name and code to be already written.
      That's why the optional parameters 'name' and 'code' are added to this last method.
      
      Task : 2985735
      
      closes odoo/odoo#102456
      
      Signed-off-by: default avatarArnold Moyaux (arm) <arm@odoo.com>
      3ebb8082
    • luvi's avatar
      [FIX] website: redirect to new page after action create · 7cfe4523
      luvi authored
      This commit fixes the behavior of the website app when creating content.
      Since commit (1), once a new record was created, it was no longer
      redirected to the correct page. Now, this behavior is reintroduced and
      works as expected.
      
      (1): https://github.com/odoo/odoo/commit/916a5bebb3e74047a66503ddc59299540c252831
      
      
      
      closes odoo/odoo#102883
      
      Signed-off-by: default avatarQuentin Smetz (qsm) <qsm@odoo.com>
      7cfe4523
    • clesgow's avatar
      [FIX] mrp: production wizards layouts · 5b999ee4
      clesgow authored
      
      Adapts the layouts of the immediate production and the production's
      backorder to match the new grid css for groups.
      
      Part of task-2985735
      
      closes odoo/odoo#102881
      
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      5b999ee4
    • Pierre Masereel's avatar
      [FIX] point_of_sale: fix electronic payment style · 7e237dd6
      Pierre Masereel authored
      
      When an electronic payment is done in the POS, the payment lines
      contains the status of the electronic payment and the corresponding
      button to perform actions.
      
      We are now correctly display those informations.
      
      closes odoo/odoo#102866
      
      Signed-off-by: default avatarMasereel Pierre <pim@odoo.com>
      7e237dd6
    • mafo-odoo's avatar
      [FIX] payment_stripe: allow payment for client without mail · 238f2f58
      mafo-odoo authored
      
      Problem: If you have a customer assigned to an invoice/quotation
      without an e-mail address and then share a payment link with
      the customer. If the customer clicks on 'Pay', he won't be
      redirected to Stripe's checkout page. He'll get instead 'Invalid
      e-mail address: False' (see the image attached).
      
      Explanation:
      When there is no e-mail address defined, Odoo sends 'False' to
      Stripe but Stripe sees it as the e-mail address which is indeed
      Invalid. To solve the issue we replace False by None for the email
      value of a customer without email address.
      
      opw-3007866
      
      closes odoo/odoo#102859
      
      X-original-commit: 647a5fd7
      Signed-off-by: default avatarAntoine Vandevenne (anv) <anv@odoo.com>
      Signed-off-by: default avatarFockedey Martin (mafo) <mafo@odoo.com>
      238f2f58
    • Anna Janiszewska's avatar
      [IMP] website_sale: create hook for website_sale.product rendering values · 7ccb3380
      Anna Janiszewska authored
      
      closes odoo/odoo#102858
      
      X-original-commit: 7ceea15c
      Signed-off-by: default avatarWilliam Braeckman (wbr) <wbr@odoo.com>
      7ccb3380
    • pedrambiria's avatar
      [FIX] google_calendar: sync events without an attendee's state · ec681570
      pedrambiria authored
      
      Before this commit: if an event's attendee didn't have a state, it couldn't
      get synced with Google.
      
      The solution is first to set a default value for it.
      
      opw-2915661
      
      closes odoo/odoo#102857
      
      X-original-commit: 89b53744c668183913b8a188730bd350fe778807
      Signed-off-by: default avatarArnaud Joset <arj@odoo.com>
      Signed-off-by: default avatarPedram Bi Ria (pebr) <pebr@odoo.com>
      ec681570
    • Romain Derie's avatar
      [FIX] website_sale: fix tag mismatch · 0a129f61
      Romain Derie authored
      Commit [1] introduced a mismatch in tags, `<xpath>` is closed with
      `</t>`.
      
      [1]: https://github.com/odoo/odoo/commit/85905934c2ad2507cfc6f74428db61ac97a3bc41
      
      
      
      closes odoo/odoo#102856
      
      Signed-off-by: default avatarQuentin Smetz (qsm) <qsm@odoo.com>
      0a129f61
    • Bruno Boi's avatar
      [FIX] web: display fewer for m2x autocomplete menu · 1b2686ae
      Bruno Boi authored
      
      In legacy, an m2x autocomplete would not display extra lines
      received from the server inside the dropdown menu.
      
      This commit reintroduce that behavior as it was lost in the
      wowl conversion.
      
      closes odoo/odoo#102847
      
      Signed-off-by: default avatarMathieu Duckerts-Antoine <dam@odoo.com>
      1b2686ae
    • luvi's avatar
      [FIX] web: correct form style in x2ManyDialog · af67305b
      luvi authored
      
      Since o_form_view class was not placed on the right element, as the
      form is displayed in a dialog, some styles were not applied in x2Many
      dialogs using a form view. Now, the selector matches all cases and
      dialogs will be stylized as expected, since the class is placed on the
      dialog container instead of the first div.
      
      Now, we are consistent both for dialogs and standard form views.
      
      Tests have been adapted to work as expected.
      
      closes odoo/odoo#102834
      
      Signed-off-by: default avatarMichaël Mattiello <mcm@odoo.com>
      af67305b
    • Didier (did)'s avatar
      [FIX] im_livechat: use the currentPartnerId from livechat · dcf9aa61
      Didier (did) authored
      
      Current code can't work since session doesn't contain partner_id.
      
      task-3010650
      
      closes odoo/odoo#102617
      
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      dcf9aa61
    • Horacio Tellez's avatar
      [FIX] payment, payment_custom: uninstall crash of payment modules · 56318826
      Horacio Tellez authored
      
      Before this commit a constraint between the `ir_ui_view` and
      `payment_provider` view made impossible for providers to be
      uninstalled. After this commit the constraint is correctly treated.
      
      A similar issue is found on a constraint on the `payment_custom`
      module. To fix this and future possible problems we added the
      possibility to modify the way providers are uninstalled following
      each provider needs.
      
      Task - 3002532
      
      closes odoo/odoo#102265
      
      Related: odoo/documentation#2799
      Signed-off-by: default avatarAntoine Vandevenne (anv) <anv@odoo.com>
      56318826
    • Julien Mougenot's avatar
      [FIX] website: Restore correct xpath in kanban layout · 631d552f
      Julien Mougenot authored
      In PR https://github.com/odoo/odoo/pull/101763
      
       the page_kanban template
      in website has been changed because it was thought that the xpath was
      meant to be inserted in the default slot.
      
      However this wasn't the case (we want it applied to the Layout) so it
      crashed the view.
      
      This commit restores the proper xpath.
      
      closes odoo/odoo#102842
      
      Signed-off-by: default avatarRomain Derie (rde) <rde@odoo.com>
      631d552f
    • Romeo Fragomeli's avatar
      [FIX] mail: the subject field is not correctly aligned · 52c8a8f4
      Romeo Fragomeli authored
      
      The field was not correctly aligned because the invisible rule was not
      the same on the field and the sibling's DIV. So in some case, we can
      have an empty DIV present with no label (e.g. when `is_log = false` and
      `composition_mode = mass_mail`).
      
      Note that now with grid, we need two filled columns otherwise we will
      have a shift for the next following labels/fields, because grid will try
      to fill the empty space.
      
      Steps to reproduce:
      * Open Helpdesk
      * Select a Team
      * Select the list view
      * Check a row (line)
      * Click on "Action" menu
      * Click on "Send Email" => BUG
      
      closes odoo/odoo#102840
      
      Signed-off-by: default avatarAdrien Dieudonné (adr) <adr@odoo.com>
      52c8a8f4
    • Mathieu Duckerts-Antoine's avatar
      [FIX] im_livechat: separation icon/text in channels kanban · c55e5672
      Mathieu Duckerts-Antoine authored
      
      closes odoo/odoo#102839
      
      Signed-off-by: default avatarMichaël Mattiello <mcm@odoo.com>
      c55e5672
    • sofiagvaladze's avatar
      [FIX] hr_holidays: show delete button on wizard in validate and refuse states · d8d4f2d3
      sofiagvaladze authored
      
      One should be able to delete time off from the calendar view in validate
      and refuse states.
      
      task - 2857233
      
      closes odoo/odoo#102836
      
      Signed-off-by: default avatarKevin Baptiste <kba@odoo.com>
      d8d4f2d3
    • Victor Piryns (pivi)'s avatar
      [FIX] l10n_sa_pos: not create invoice on pos settlement · 15ee96e7
      Victor Piryns (pivi) authored
      
      Current behaviour:
      Currently when settling an account in a POS session, in Saudi Arabia,
      there is QR code on the receipt and a title "Simplified Tax Invoice",
      which should not be present on settlement
      
      Expected behaviour:
      Receipts generated from a settlement in Saudi Arabia localisation shouldn't generate a QR code and a tax title.
      
      Steps to reproduce:
      - install the modules: `l10n_sa`, `l10n_sa_pos`, `settle_due`
      - Switch to the Saudi Arabia company
      - Enter POS and create at least 2 payment method:
        - Cash: Identify Customer = false, Journal = Cash
        - Customer Balance: Identify Customer = true, Journal = empty
      - Create a new POS Session, just add "Customer Balance" to payment methods,
      the rest of settings are as default (might need to add "Customer Invoices" to the journal of the session)
      - Start a new session, find a customer with some "Amount Due" and click on the value,
      choose one of the payment methods
      - On the payment screen choose "Customer Balance", now you should have 2 payment lines,
      one is the payment methods for settling, the other is the customer balance with a negative value.
      - When validating, the receipt has a QR code and Invoice title, when it shouldn't.
      
      Reason for the problem:
      There is currently no state that differentiate between a normal order and a settlement.
      
      Fix:
      Implement a settlement state (computed) in the localistation order model.
      Add the state to the data that goes to the templating engine.
      Add conditional rendering for the templates related to the QR code and the "Simplified Tax Invoice" title.
      
      Affected versions:
      - 15.0
      - saas-15.2
      - saas-15.3
      - 16.0
      - master
      
      opw-2976267
      
      closes odoo/odoo#102833
      
      X-original-commit: 0b04230d3c5e7fc1bc83340ec2fca9cf646cbc60
      Signed-off-by: default avatarPiryns Victor (pivi) <pivi@odoo.com>
      Signed-off-by: default avatarMasereel Pierre <pim@odoo.com>
      15ee96e7
    • Ahmed Khalaf (ahkh)'s avatar
      [IMP] mrp{_account}: tooltip changes · 817bf131
      Ahmed Khalaf (ahkh) authored
      
      This commit updates some tooltips in workcenters and operations forms
      
      ENT PR: odoo/enterprise#32519
      
      closes odoo/odoo#102672
      
      Signed-off-by: default avatarArnold Moyaux (arm) <arm@odoo.com>
      817bf131
    • yhu-odoo's avatar
      [FIX] mrp_subcontracting: portal should be readonly · 4c5ba480
      yhu-odoo authored
      
      1. Except for registering components, the portal should be readonly
      2. Don't open sm form when click it.
      
      closes odoo/odoo#102637
      
      Signed-off-by: default avatarArnold Moyaux (arm) <arm@odoo.com>
      4c5ba480
    • Sébastien Theys's avatar
      [FIX] mail: avoid losing chatter record when changing container · a3d151d0
      Sébastien Theys authored
      
      Form view has multiple containers that are exclusive, before this commit
      switching from one container to the other would lose all current chatter state.
      
      closes odoo/odoo#102636
      
      Related: odoo/enterprise#32605
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      a3d151d0
    • Mathias Mathy (MAMA)'s avatar
      [FIX] purchase_stock: Adapt configuration's tooltips · cdeccd85
      Mathias Mathy (MAMA) authored
      
      Simplify the tooltips for 'Security Lead Time for Purchase'
      and 'Days to Purchase'  in the 'Advanced Scheduling' part
      of Inventory configuration.
      Task : 2985735
      
      closes odoo/odoo#102577
      
      Signed-off-by: default avatarArnold Moyaux (arm) <arm@odoo.com>
      cdeccd85
    • Odoo's Mergebot's avatar
      [MERGE] project: refactor the list and form views in project sharing in OWL · a995eefa
      Odoo's Mergebot authored
      
      Purpose
      =======
      
      Convert the remaining legacy views in OWL. Before this PR, the list and form views are still in legacy in Project Sharing feature. The goal of this PR is to convert those views to have all views in OWL in Project Sharing.
      
      Details implementation
      ----------------------
      
      - Convert the list view in OWL
      - Convert the chatter portal in OWL to be able to convert the form view in OWL
      - Convert the form view in OWL and integrate the chatter into it.
      - Review the assets used in Project Sharing to reduce the size of the assets since all components and views existing in the backend are not used (only the list, kanban and form views are used)
      - Review the rows attribute set on `textarea` HTML element in`TextField` to be able to altered it with a props.
      - Change the `FileInput` component to be able to override it to be able to use it when the route is different than the one set by default.
      - Fix the `useInputField` hook to be able to use the `TextField` component without any `record` set on its props (since this prop could be optional).
      
      task-2947516
      
      closes odoo/odoo#102130
      
      Signed-off-by: default avatarLaurent Stukkens (ltu) <ltu@odoo.com>
      a995eefa
    • Horacio Tellez's avatar
      [FIX] payment_custom: avoid empty pending message · 84439f66
      Horacio Tellez authored
      
      If `payment_custom` is installed before `account`, not bank account
      information is set up and the `pending_msg` remains `False`. This
      implies that no pending message is shown on the portal after transaction
      confirmation.
      
      After this commit, if `payment_custom` is installed before the `account`
      module, then the pending message falls back to the default message
      defined in the `payment` module.
      
      Task - 3000442
      
      closes odoo/odoo#101593
      
      Signed-off-by: default avatarAntoine Vandevenne (anv) <anv@odoo.com>
      84439f66
    • Alexandre Kühn's avatar
      [IMP] im_livechat, *: Show Livechat Button with notification · 785356f4
      Alexandre Kühn authored
      
      *: mail, website_livechat
      
      This commit adds new option in Livechat Button visibility
      "Show with notifcation", which allow to see livechat button
      and also display a customizable floating text next to button.
      
      This text appears 1 second after the livechat button become visible.
      
      Task-2937993
      
      closes odoo/odoo#100689
      
      Signed-off-by: default avatarLouis Wicket (wil) <wil@odoo.com>
      785356f4
    • Tiffany Chang (tic)'s avatar
      [IMP] stock{_account}: polish views · 8904c3c4
      Tiffany Chang (tic) authored
      
      Followup to inventory back2basics task 2882539
      
      - order stock.move.line tree (Moves History) view by "id desc" for
        better performance (prev: create_date is not indexed)
      - order stock.valuation.layer tree (Valuation) view by "id desc" for
        better performance (prev: date is not indexed)
      - hide "Moved Quantity" column when in current valuation (not at date)
      - remove the action: "Set" and print: "Count Sheet" from
        stock.quant.view when not in "Inventory Adjustment" related view
      - Fix "Inventory At Date"/"Valuation At Date" button visibility issue
        that came up due to OWL refactoring
      - Don't show consumables in stock.valuation.layer (Valuation) report
        view action (forgot to include domain when creating new action)
      - Add stock.move menuitem back in under "reporting" in debug mode since
        this view isn't accesible anywhere else and it is used a lot for qty
        forecasts by users
      - Add "Created By" (as "Done By") to stock.move.line history view for
        easier tracking of inventory adjustments
      
      closes odoo/odoo#100268
      
      Task: 2965586
      Signed-off-by: default avatarArnold Moyaux (arm) <arm@odoo.com>
      8904c3c4
    • xO-Tx's avatar
      [REM] *: remove new content controllers · d559ce5d
      xO-Tx authored
      *: website_event, website_event_sale, website_forum, website_sale,
         website_sale_slides, website_slides, website_slides_forum
      
      This commit removes the remaining controllers that are no longer used
      since the use of form views on website new content dialogs (following
      the website in backend merge at [1] and the many iterations afterwards).
      
      With the website in backend work, a feature was lost for the creation of
      events: dummy tickets were created. This commit actually removes the
      feature for good. Events default values are managed by templates.
      Moreover there are links in frontend to edit the event when being
      allowed to edit it (event groups), notably when there is no ticket in
      registration page. So it makes no sense to create dummy tickets, without
      price, for 1000 seats. Those values are random so they will have to be
      edited. Better let users create real tickets if necessary, than editing
      and/or removing dummy tickets.
      
      [1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b
      
      
      
      task-2687506
      
      closes odoo/odoo#99042
      
      Signed-off-by: default avatarQuentin Smetz (qsm) <qsm@odoo.com>
      Co-authored-by: default avatarqsm-odoo <qsm@odoo.com>
      d559ce5d
    • Arnold Moyaux's avatar
      [FIX] stock: multi warehouse doesn't setup multi location · 6f965fa7
      Arnold Moyaux authored
      
      Use case to reproduce:
      - Create a new db
      - Go to warehouse and create a new one.
      
      Expected behavior (same than enable location options from settings):
      - Internal location has been enable
      - It's possible to create locations
      
      It happens because during the warehouse create call, the multi warehouse
      and multi locations groups are set. However `res.config.settings`
      contains a hook on `set_values` that enable some views and internal
      location. Write directly on the groups won't go throuhg this code.
      
      closes odoo/odoo#102828
      
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      6f965fa7
    • Romain Estievenart's avatar
      [FIX] web: restore form and chatter width size · 3e71df35
      Romain Estievenart authored
      
      In 15.3, the width was applied on `o_form_sheet_bg`.
      As the form view has been refactored in 16, we have to apply
      it on the new parent `o_form_view_container`.
      
      We also restore the chatter width to the same value as in 15.3:
      ```scss
      .o_FormRenderer_chatterContainer {
          &.o-aside {
              width: $o-chatter-min-width;
          }
      }
      ```
      
      Steps to reproduce:
      - Open Helpdesk on screen at 1534x657
      - Open a vip support
      - Unfold 'Done'
      - Click on 'Ugly Chair', the chatter take a lot of space => bug
      
      Steps to reproduce
      - Open Sales
      - Open a quotation
      - Switch between Order lines, Other info, Customer Signature
        notebook tabs a flicker occurs => bug
      
      closes odoo/odoo#102781
      
      Signed-off-by: default avatarAdrien Dieudonné (adr) <adr@odoo.com>
      3e71df35
    • Jacky (trj)'s avatar
      [FIX] loyalty, pos_loyalty: download, print, mail gift card · 5b269ebb
      Jacky (trj) authored
      
      - Gift cards can now be sent alongside the receipt via mail in the Receipt Screen.
      - The gift card report no longer show n² gift cards
      - Properly download all PDF files for the gift cards when there are multiple gift card programs
      
      closes odoo/odoo#102676
      
      Signed-off-by: default avatarMasereel Pierre <pim@odoo.com>
      5b269ebb
    • Xavier BOL (xbo)'s avatar
      [REF] project,hr_timesheet: review assets for project sharing · 6805f5c9
      Xavier BOL (xbo) authored
      Before this commit, the assets used in project sharing takes almost all
      assets in `web.assets_backend`, this way is not a good idea since only
      the kanban view and list are used and the chatter is not the backend
      one. So the assets could be filtered to minize the size of the bundle
      for project sharing to also reduce the loading when the user goes to
      project sharing feature.
      
      This commit reviews the assets used in the project sharing to reduce
      the size.
      
      task-2947516
      6805f5c9
    • Xavier BOL (xbo)'s avatar
      [REF] project: convert project sharing form view in OWL · 175430f3
      Xavier BOL (xbo) authored
      Before this commit, the form view in project sharing was always in
      legacy. Moreover, in that view, the chatter used is the portal one
      and so it is also a legacy widget.
      
      This commit converts the form view and then convert the chatter in
      OWL to be able to correctly compile and add the chatter in the form
      view.
      Also, some styling has been done to remove the overflow. Only the
      overflow on the y axis in the chatter can be scrolled on the page.
      
      task-2947516
      175430f3
    • Xavier BOL (xbo)'s avatar
      [REF] web: review FileInput to use it with different route · 8fdeea2e
      Xavier BOL (xbo) authored
      Before this commit, the `FileInput` component can be used with another
      route only if the route has the same params than the default one.
      For instance, the portal chatter route does not have the same params
      name and so, the component cannot be used.
      
      This commit refactors the component to easily override the
      component to be able to use it in each case.
      
      task-2947516
      8fdeea2e
    • Xavier BOL (xbo)'s avatar
      [FIX] web: allow to change the row on textarea in TextField with a prop · 110915c8
      Xavier BOL (xbo) authored
      Before this commit, the rows attribute given on the TextField component
      was always 2, it is not possible to alter it without overriding the
      component.
      
      This commit adds a props to be able to update the rows with a prop
      called `rowCount` and this prop can be set via `rows` attribute set on
      the field.
      
      task-2947516
      110915c8
    • Xavier BOL (xbo)'s avatar
      [FIX] web: check if record in component props is defined since it is optional · ebe3d00e
      Xavier BOL (xbo) authored
      Before this commit, when a component using the `useInputField` hook (for
      instance `TextField`) and the `record` is not given in its props, the
      hook will crash since it assume the `record` is always defined. However,
      the props definition the `record` is optional.
      
      This commit checks if `record` is defined in the component before using
      it to be sure to avoid any crash because it is not defined.
      
      task-2947516
      ebe3d00e
    • Xavier BOL (xbo)'s avatar
      [REF] project: convert the project sharing list in OWL · 79159c0c
      Xavier BOL (xbo) authored
      This commit converts the list view used in project sharing in OWL and
      remove the legacy definition.
      
      task-2947516
      79159c0c
    • oco-odoo's avatar
      [IMP] account_reports: better helpers for report fields · 91e1c588
      oco-odoo authored
      
      closes odoo/odoo#102674
      
      Signed-off-by: default avatarJosse Colpaert <jco@odoo.com>
      91e1c588
    • rhe-odoo's avatar
      [FIX] pos_loyalty: prevent gift card settings error. · e81db2e6
      rhe-odoo authored
      
      It was possible to sell gift cards without mail template or report link to the gift card program.
      Thus, it was impossible to get the info related to the card unless you have backend access rights.
      
      We now make sure the gift card program have a template and a report when starting the session.
      
      closes odoo/odoo#102613
      
      Signed-off-by: default avatarMasereel Pierre <pim@odoo.com>
      e81db2e6
    • William Braeckman's avatar
      [FIX] website_sale: fix base_unit_price and pricelists · 7701033a
      William Braeckman authored
      
      Prior to this commit the base_unit_price was computed using the price of
      the template instead of the list price displayed on the eCommerce, so it
      sometimes made no sense when compared to another currency.
      It will now be converted properly and use the list_price instead of
      template price to compute the base_unit_price.
      Some other issues with the base_unit_price display in the form view have
      also been fixed (mainly mobile stuff)
      
      TaskId-3006015
      
      closes odoo/odoo#102543
      
      Signed-off-by: default avatarWilliam Braeckman (wbr) <wbr@odoo.com>
      7701033a
Loading