Skip to content
Snippets Groups Projects
  1. Oct 02, 2018
    • Thibault Delavallée's avatar
      [IMP] product: add activity view on main actions · e3a2bfc8
      Thibault Delavallée authored
      Purpose is to extend the use of the newly-introduced activity view allowing
      to see at a glance activities to perform on a given model. It eases daily
      job of people working with activities.
      
      Updated
      
        * product variant main menu action;
        * product main actions used in various apps;
      
      This commit is linked to task ID 1889413.
      e3a2bfc8
    • Thibault Delavallée's avatar
      [IMP] note: add activity view on main actions · 0c452d51
      Thibault Delavallée authored
      Purpose is to extend the use of the newly-introduced activity view allowing
      to see at a glance activities to perform on a given model. It eases daily
      job of people working with activities.
      
      Updated :
      
        * note main menu action
      
      This commit is linked to task ID 1889413.
      0c452d51
    • Thibault Delavallée's avatar
      [IMP] mail, membership: add activity view on main partner actions · c75fa91a
      Thibault Delavallée authored
      Purpose is to extend the use of the newly-introduced activity view allowing
      to see at a glance activities to perform on a given model. It eases daily
      job of people working with activities.
      
      Updated
      
        * main partner menu action (Customers);
        * membership partner main menu action;
        * customers / vendors main menu action used in various other apps;
      
      This commit is linked to task ID 1889413.
      c75fa91a
    • Laurent Smet's avatar
    • Thibault Delavallée's avatar
      [MERGE][FIX] mail, mass_mailing: fix blacklist behavior and its use in mass mailing · ed4beb03
      Thibault Delavallée authored
      This merge fixes blacklist mechanism, mixin and its use in mass mailing.
      Some fixes are related to https://github.com/odoo/odoo/commit/2ff9b379ef80ba6a8744fb9702a8088284372ddd. Tests are added in a
      new module that will gradually hold more complex tests for mass mailing.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and closes PR #27330.
      ed4beb03
    • David Beguin's avatar
      [FIX] mass_mailing : sanitize email used for counters and comparison · 65ab6f49
      David Beguin authored
      Purpose is to fix the comparison between mass mailing record email field
      and blacklist entries by sanitizing email to ensure comparison is done
      on same basis as what is stored in blacklist table. Also fix the action
      merge where the extraction of email is needed before comparing to the blacklist.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and its PR #27330. Done with collaboration of @dbeguin.
      65ab6f49
    • David Beguin's avatar
      [FIX] mail: correctly find and compare blacklist email when sending mass mailing · 331d413f
      David Beguin authored
      Until now, a recipient with a formatted email like 'John Doe
      <john_doe@example.com>' could be reached by email even if its email address
      was blacklisted. Now when sending a mass mail using the composer, the email
      is sanitized before comparing it to blacklist entries.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and its PR #27330. Done with collaboration of @dbeguin.
      331d413f
    • Thibault Delavallée's avatar
      [IMP] blacklist: sanitize search terms on email · c7ad31f0
      Thibault Delavallée authored
      Purpose of this commit is to make search coherent with sanitize of emails
      done when storing blacklist entries. We parse search terms in order to
      find something related to email field and sanitize it to avoid issues
      linked to case insensitivity or formatted addresses.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and its PR #27330. Done with collaboration of @dbeguin.
      c7ad31f0
    • Thibault Delavallée's avatar
      [FIX] mail: correctly extract email from email field in computed blacklist fields · 2b73bed8
      Thibault Delavallée authored
      Purpose of this commit is to correctly extract email address from the email
      field of models inheriting from the blacklist mixin. Indeed email field
      could contain a formatted address like "Raoul Grosbedon <RAOUL@example.com>".
      Related blacklist entry would be raoul@example.com. We have to extract
      the email from the email field and lowerize it in the SQL query or the
      computation in order to have a fully working blacklist mixin. This fixes
      some bits left at commit 2ff9b379.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and its PR #27330. Done with collaboration of @dbeguin.
      2b73bed8
    • Thibault Delavallée's avatar
      [FIX] mail: assert email field used in blacklist and correctly use it in computed fields · bbe46900
      Thibault Delavallée authored
      This commits fixes the use of email field in blacklist mixin as it was based
      on 'email' field instead of the one coming from the _primary_email class
      attribute since commit 2ff9b379.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and its PR #27330. Done with collaboration of @dbeguin.
      bbe46900
    • Thibault Delavallée's avatar
      [FIX] mail: ensure case insensitive check when (de)activating blacklist records · 5743122f
      Thibault Delavallée authored
      Now that blacklist records are set as lower case be sure all checks in
      blacklist are done accordingly by using the sanitizer before comparing
      email adresses.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and its PR #27330. Done with collaboration of @dbeguin.
      5743122f
    • Thibault Delavallée's avatar
      [FIX] mail: ensure creation of unique emails in blacklist · 7b0c502d
      Thibault Delavallée authored
      Currently blacklist is configured to have unique emails. Notably when creating
      new entries it checks for existing records with same email to avoid crashing
      about duplicate entries.
      
      However it does not check if given values use unique emails. When importing
      a big list of emails you are not sure emails are unique. This commit ensures
      values given to create are correct to avoid crashing when importing a lot
      of data.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and its PR #27330. Done with collaboration of @dbeguin.
      7b0c502d
    • Thibault Delavallée's avatar
      [FIX] mail: insert only sanitized and lower-case emails in blacklist · 2f82b95d
      Thibault Delavallée authored
      Purpose of this commit is to standardize content of blacklist records and
      ensure only real email addresses are stored.
      
      We introduce a sanitize method to extract email address from string (like
      Raoul Grosbedon <raoul@example.com> -> raoul@example.com) and return a
      lower case version of it.
      
      Purpose is to gradually get rid of lower() that appear a lot in the code
      and speedup computation by being sure everything is always lower case.
      Moreover indexing on blacklist model will be more performant is using
      directly email field content instead of having to lowerize it.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and its PR #27330. Done with collaboration of @dbeguin.
      2f82b95d
    • Thibault Delavallée's avatar
      [IMP] test_mass_mailing: add blacklist mixin tests · 0c37eb27
      Thibault Delavallée authored
      Purpose of this commit is to add some tests linked to the blacklist mixin
      itself, notably the computed fields and its search method.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and its PR #27330. Done with collaboration of @dbeguin.
      0c37eb27
    • Thibault Delavallée's avatar
      [IMP] test_mass_mailing: add blacklist tests · 39228329
      Thibault Delavallée authored
      Purpose of this commit is to enforce blacklist use and base mechanisms. This
      commit may break on runbot as fixes will come after having introduced tests.
      It notably add tests for a8ce59ce.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and its PR #27330. Done with collaboration of @dbeguin.
      39228329
    • Thibault Delavallée's avatar
      [ADD] test_mass_mailing: add module to hold feature and performance tests for mass mailing · fca1654d
      Thibault Delavallée authored
      Purpose of this commit is to add the skeleton of a module holding models and
      tests for mass mailing. It is build on top of test_mail in order to use
      data, models and parameters already defined in it. Moreover having a
      separate module allow to define test models that will not bloat production
      databases.
      
      It will soon hold unit tests for blacklist mechanism. Future commits will
      gradually move tests from mass mailing module and improve them.
      
      This commit is related to task ID 33224 (original blacklist implementation
      done for v12) and its PR #25966 as well as task ID 1889703 (tests and fixes)
      and its PR #27330. Done with collaboration of @dbeguin.
      fca1654d
    • Romain Derie's avatar
      [FIX] website: add website in attachment list view if multi-websites · 4b3884b0
      Romain Derie authored
      The list view of ir.attachment was missing the website field if multi-websites
      was enabled.
      4b3884b0
    • Christophe Simonis's avatar
      a566c38d
    • Thibault Delavallée's avatar
      [REF] test_mail: reorganize activity tests · d5131fe9
      Thibault Delavallée authored
      Purpose is to separate tests related to access rights (low level), base
      activity features and mixin itself. It eases understanding of tests and
      prepare future addition of tests.
      
      This commit is linked to task ID 1856417.
      d5131fe9
    • Thibault Delavallée's avatar
      [IMP] mass_mailing_{crm/sale}: always show UTM info if not void · db70862c
      Thibault Delavallée authored
      It is not necessary to limitate UTM-based statistics based on the mailing model.
      Indeed a mailing on contacts could for example generate leads and sales that
      people could want to see the mailing view.
      
      Commit linked to task ID 1889754.
      db70862c
    • qsm-odoo's avatar
      [FIX] web: remove portal/website dependency from reports · f427ddcb
      qsm-odoo authored
      See the comments which are removed by this commit for details. We
      finally chose to remove the whole interaction for now.
      f427ddcb
    • qsm-odoo's avatar
      [FIX] web: restore dashboard text-right design · 43655b3b
      qsm-odoo authored
      We should style review the kanban (dashboard) design / grid system / ...
      43655b3b
    • qsm-odoo's avatar
      [FIX] web: review disabled checkbox design · 3b2ab5a4
      qsm-odoo authored
      Thanks to @kea14
      3b2ab5a4
    • qsm-odoo's avatar
      [FIX] base, website: review... · d9a589ad
      qsm-odoo authored
      [FIX] base, website: review https://github.com/odoo/odoo/commit/89678c60412feea004cd3081200092365e6ef3b4
      
      Share the common code in the ir.attachment model and add a sort order
      and a limit to attachment serving.
      d9a589ad
    • Aaron Bohy's avatar
      [FIX] doc: correct typo · ce1c2cf6
      Aaron Bohy authored
      ce1c2cf6
    • Bohdan Lisnenko's avatar
      [FIX] hw_escpos: Printing Cyrillic symbols · d5e1353e
      Bohdan Lisnenko authored
      Tested on real printer for Cyrillic symbols.
      
      port of https://github.com/odoo/odoo/pull/19757 to saas-11.5 for IoT Box
      d5e1353e
    • XavierDo's avatar
      82da171f
    • Martin Trigaux's avatar
      [I18N] export saas-11.5 source terms · d77000ae
      Martin Trigaux authored
      Reflect module moved to enterprise and remove fields after c9837ac5
      Unverified
      d77000ae
    • Adrien Dieudonne's avatar
      [FIX] web: avoid no content helper for pie chart in comparison mode · b2cadc92
      Adrien Dieudonne authored
      In comparison mode with no data, we render two empty pie charts even
      if it's not an embedded view.
      The non content helper is still used when there is no comparison.
      b2cadc92
    • XavierDo's avatar
      [FIX] mail: make guideline template a qweb view · 775e8a9f
      XavierDo authored
      The mail template mail_template_channel_send_guidelines should only be used
      from send_guidelines action. Anyway, with mail_template on activity
      and all demo done to show this mechanic on contacts,
      trying to render this one will generate a traceback. This fix
      transforms the mail_template to qweb view so that it won't be available in
      mail template.
      775e8a9f
    • Mathieu Duckerts-Antoine's avatar
      [FIX] web: fix update problems in graph view · 64d7da41
      Mathieu Duckerts-Antoine authored
      The graph view was not updated correctly with respect to
      time range menu data. We fix that problem in this commit.
      64d7da41
    • Laurent Smet's avatar
      [IMP] account: sort st lines using search instead of sorted · 16469ec9
      Laurent Smet authored
      browse doesn't sort using the table _order so we need to sort the lines after that.
      This commit improves such sorting by searching insteaf of browsing: it's more elegant.
      16469ec9
    • Nicolas Martinelli's avatar
      [FIX] stock: decrease initial demand quantity · cdf201a1
      Nicolas Martinelli authored
      - Open a picking (example WH/IN/00002)
      - Unlock
      - Edit Initial Demand (from 35 to 4 for example)
      - Click on Save
      
      An error occurs: 'Record does not exist or has been deleted.'
      
      When saving, the following values are sent to the server (example):
      `{'move_ids_without_package': [
           [1, 31, {'product_uom_qty': 4, 'date_expected': '2018-10-02 08:27:14'}]
       ],
       'move_line_ids_without_package': [
           [1, 26, {'package_id': False, 'result_package_id': False, 'owner_id': False, 'lot_id': False}]
       ]}`
      
      The field `move_ids_without_package` contains the new quantity. However,
      decreasing the quantity will remove the reservation and therefore unlink
      the move lines.
      
      https://github.com/odoo/odoo/blob/718b0f8b63261e1312b5626d48de050b21a9dccf/addons/stock/models/stock_move_line.py#L349
      
      This means that the field `move_line_ids_without_package` refers to IDs
      which have been deleted when writing on `move_ids_without_package`.
      
      We can make the field read-only if it is not displayed.
      
      opw-1889802
      cdf201a1
    • Yannick Tivisse's avatar
      [IMP] mail: Make mail.compose.message code more readable · 532d82a7
      Yannick Tivisse authored
      Purpose
      =======
      
      Remove the method 'render_template' in mail.compose.message as the indirection
      is not useful. Call the method on the correct model (mail.template) directly.
      532d82a7
    • Yannick Tivisse's avatar
      [IMP] ir_ui_view: Log warning on incorrect 'groups' attribute · b2b9545c
      Yannick Tivisse authored
      Purpose
      =======
      
      They are a lot of places where we set an attribute 'groups' on a view element and:
      
      - The group doesn't exist anymore
      - The group xmlid is not correct
      - The group xmlid exists but the modularity is not respected (example: group_stock_user
        used in a view in the 'product' module).
      
      Where it happens, nothing warns the user or the developer. The element is just never
      rendered.
      
      Specification
      =============
      
      In the method _check_xml, log a warning if a 'groups' attribute is set and if
      a group doesn't not exist at that moment.
      b2b9545c
    • Yannick Tivisse's avatar
      [FIX] sale,stock,account,...: Use groups in views only if they exist · eaba05b9
      Yannick Tivisse authored
      Purpose
      =======
      
      They are a lot of places where we set an attribute 'groups' on a view element and:
      - The group doesn't exist anymore
      - The group xmlid is not correct
      - The group xmlid exists but the modularity is not respected (example: group_stock_user
        used in a view in the 'product' module).
      
      Where it happends, nothing warns the user of the developer. The element is just never
      rendered.
      
      Specification
      =============
      
      Fix the occurences of bad groups definition
      eaba05b9
    • Aurélien Warnon's avatar
      [FIX] (website_)sale: show missing attributes combination message · 497e1346
      Aurélien Warnon authored
      Targets commit d3530eb0
      
      Purpose
      =======
      - A message showing "This combination does not exist" should appear on both webshop and backend
        when the selected product combination is not available (due to exclusions)
      497e1346
    • Martin Trigaux's avatar
      [FIX] base: compare on original module · c9837ac5
      Martin Trigaux authored
      Introduced at 574f4c3d
      model._module has for value of the last module extending the model.
      This means that, when a module B inherit from a model defined in a module A (e.g
      to add a field on the model), an external id, tagged with module B, will be
      created for each field of the model, including the one defined only in A.
      
      The intention of the patch at 574f4c3d was to include the automatic fields (i.e.
      LOG_ACCESS_COLUMNS) into the condition.
      Without that condition, the fields such as create_date were deleted when
      upgrading a module (not defined in any module)
      Unverified
      c9837ac5
    • Martin Trigaux's avatar
      [FIX] models: display first external id onyl · 718b0f8b
      Martin Trigaux authored
      In case the result matches two records (e.g. a model has one external id per
      module inheriting it), the last was used.
      
      Use the first only.
      
      Fixes #27363
      Unverified
      718b0f8b
    • Christophe Simonis's avatar
      dece365d
Loading