Skip to content
Snippets Groups Projects
  1. Oct 02, 2017
    • Melroy van den Berg's avatar
      [CLA] signature for danger89 · f3592c78
      Melroy van den Berg authored
      Done at #19837
      Unverified
      f3592c78
    • Christophe Simonis's avatar
      28217307
    • Olivier Colson's avatar
    • xmo-odoo's avatar
      [FIX] calendar: validation error when moving some events back · 82ef2f1b
      xmo-odoo authored
      Observed via google sync, for some events being moved around during
      sync the stop_datetime ends up being before the start_datetime failing
      the sync. Not (explicitly) reading the computed fields from the old
      record properly recomputes them during copy.
      
      Underlying issue linked to (stored) computed fields when multiple
      fields are computed by the same method *and* the creation provides a
      subset of these fields explicitly: depending on the order in
      which *recompute* iterates the fields, it's possible that some of the
      fields provided explicitly get extracted (from the cache) before
      fields not-provided trigger a recomputation (and overwrite) of
      computed fields.
      
      In this case `recompute` iterates [start_datetime, start_date,
      stop_date, stop_datetime], if `start_datetime` and `stop_datetime` are
      provided explicitly to create, first recompute will check for
      `start_datetime`, find it in the cache and extract it, then it checks
      for `start_date`, does not find it in the cache, calls
      `_compute_dates` which writes all four fields, then it extracts the
      recomputed `start_datetime`, creating an incoherence: `start_datetime`
      is the one from the old event while `stop_datetime` is the one from
      the update/computation. This may lead to invisible corruption if the
      event is moved forwards (e.g. creates a multi-day event) and triggers
      a validation error if the event is moved backwards (stop_datetime is
      now before start_datetime).
      
      ping @rco-odoo multi-field computes may need some special handling
      with respect to invalidations & sequencing & the like (e.g. check
      their caching as a unit or something).
      
      OPW-771886
      82ef2f1b
    • Olivier Colson's avatar
    • Vailiy Korobatov's avatar
      [FIX] typo in guidelines file · 77d49999
      Vailiy Korobatov authored
      77d49999
  2. Oct 01, 2017
  3. Sep 29, 2017
  4. Sep 27, 2017
  5. Sep 26, 2017
  6. Sep 25, 2017
  7. Sep 24, 2017
  8. Sep 21, 2017
  9. Sep 20, 2017
    • Goffin Simon's avatar
      [FIX] account, point_of_sale, purchase, sale, website_sale: correctly set... · 776e77b6
      Goffin Simon authored
      [FIX] account, point_of_sale, purchase, sale, website_sale: correctly set included tax in multi-company
      
      A product can have multiple included taxes (i.e. one by company).
      When computing the product price with function _fix_tax_included_price,
      only the taxes of the company should be considered. Otherwise it could remove
      all the included taxes of all companies.
      
      ps: When no company is set on the SO, all the taxes visible from the company of the user
      are set for the product of the line. Same behavior as in _compute_tax_id.
      
      Closes #19566
      
      opw:770464
      776e77b6
    • Nicolas Lempereur's avatar
      [FIX] base: prevent bin_size/binary visual defect · a0fddebe
      Nicolas Lempereur authored
      Changing the address type of a contact in the "Contact & Addresses" tab
      could in some instance lead to a dead image (just visually, saving it
      would not change it) because the image is set to something like
      "data:image/png;base64,5.23 Kb" because of a combination of kanba/form
      x2many view, onchange, the differences of field present.
      
      In 9.0 this did not happen because the image was not a field in the form
      view corresponding to a contact of the kanban contacts view.
      
      In saa-15 thanks to bf264450 the image_small is different than image in
      the kanban view and this got us out of the issue.
      
      In saas-16 it is solved even further because new views only load missing
      fields.
      
      This commit just get out of the issue by preventing an update of the
      records field (with bin_size which caused the issue of the image) when
      opening the modal form view of a contact's contact.
      
      Ideally we should solve this more deeply but this is dangerous code to
      change (eg. removing the bin_size would solve it but this was done for a
      reason and could affect performances) and the effect is just visual in a
      very particular set of factors (if we save the form after the image is
      dead, the previous image reappeared).
      
      opw-765952
      closes #19491
      a0fddebe
    • Nicolas Martinelli's avatar
      [FIX] stock: UoM on return lot · dfe96ff3
      Nicolas Martinelli authored
      - Create a product with:
        Product UoM: kg
        Purchase UoM: lb(s)
        Tracking: By lot(s)
      - Purchase 100 lb(s), validate and receive picking (set lot 001)
      - Return the picking
      - Set the lot
      
      The quantity to do is 45.36 instead of 100.
      
      We make sure to convert the quant UoM (=Product UoM) into the
      appropriate UoM.
      
      opw-771930
      dfe96ff3
  10. Sep 19, 2017
    • Nicolas Lempereur's avatar
      [FIX] web: modifiers computed when x2many ready · 6252c210
      Nicolas Lempereur authored
      Modifiers (eg. required, readonly, ... on a field) are computed after a
      record has been changed. When loading a record they could be computed
      based on x2many in a inconsistent state.
      
      eg. on res.partner form, by defaut the email is required depending on:
              [('user_ids','!=', [])]
          but when switching from one record to another this was computed
          wrongly based on the difference between the two records.
      
      This change make the x2many when loading a record ready to be used as
      soon as it is set to solve this issue.
      
      forward-port: not needed after saas-15 thanks to framework views rewrite
      
      fix #18239
      opw-749483
      closes #18815
      6252c210
    • Laurent Mignon's avatar
      [FIX] stock: procurements must be confirmed with the right company · e34f6aaa
      Laurent Mignon authored
      The method _procure_orderpoint_confirm in stock/procurement is calld in sudo() by run_scheduler.
      Even if this method receives the company as parameter, the company is not enforced for all
      the processes trigerred into the method. i.e. If a PO is generated by the run of the procurements
      the sequence used is the one of the admin's company and not the one for the given company.
      To enforce the company to use, we force the company into the context if it's not the same as
      the user's company.
      
      opw:771851
      e34f6aaa
Loading