Skip to content
Snippets Groups Projects
  1. Oct 08, 2018
    • Jérome Maes's avatar
      [FIX] sale_timesheet: include milestone in profitability report · 026064c3
      Jérome Maes authored
      The project overview is based on the profitability report to get the
      amount invoiced and to invoice for service sold on a sale order
      linked to a project. This request is wrong as it does not take the
      milestone sale line into account. This commit fixes it.
      
      opw-1890106
      
      closes odoo/odoo#27538
      026064c3
  2. Oct 09, 2018
  3. Oct 08, 2018
  4. Oct 09, 2018
  5. Oct 08, 2018
    • Martin Trigaux's avatar
      [I18N] l10n_multilang: export source terms · 3e178daa
      Martin Trigaux authored
      closes odoo/odoo#27544
      3e178daa
    • Nicolas Martinelli's avatar
      [FIX] account: remove useless file · 94a4b695
      Nicolas Martinelli authored
      The file is not imported by the manifest following the removal of the
      reports.
      
      opw-1891341
      
      closes odoo/odoo#27542
      94a4b695
    • Laurent Smet's avatar
      [FIX] account: fix $.when(defs) in reconciliation widget · 2d242b1e
      Laurent Smet authored
      Introduced by: https://github.com/odoo/odoo/commit/b0a29c9bad4fb9180ddcdae80529e244c6b61d49
      
      Suppose def1, def2, def3, three deferred.
      $.when(def1, def2, def3) is ok
      $.when([def1, def2, def3]) is not ok
      $.when.apply($, [def1, def2, def3]) is ok
      
      closes odoo/odoo#27513
      2d242b1e
    • Swapnesh Shah's avatar
      [FIX] pos_sale: convert string -> datetime.date · d4d820f0
      Swapnesh Shah authored
      fixes #27467
      
      closes odoo/odoo#27468
      d4d820f0
    • Swapnesh Shah's avatar
      [FIX] mrp: print bomstructure report with float quantity · 87a97802
      Swapnesh Shah authored
      Usecase to reproduce (chrome):
      - Create a BoM with float quantity in component
      - Print the BoM cost and structure report
      
      When using a type="number" on firefox it is not possible to use a
      decimal. However on chrome there is no restriction and a decimal
      could be use. It makes senses to be able to work with decimal
      (e.g. the UoM is in kg)
      
      It also exists an explicit cast to integer since data are received as
      string from the javascript. However since quantity displayed could be
      decimal, the cast should be adapted to float.
      
      Closes #27464
      Fixes #27437
      
      closes odoo/odoo#27522
      87a97802
    • Olivier Dony's avatar
      [FIX] website: use proper env in model methods · f4041de4
      Olivier Dony authored
      Using `request.env` should be reserved for code that lies outside of
      model methods (typically: controllers). Model methods have to use the
      appropriate `self.env`.
      
      This particular case caused frequent Python-PostgreSQL undetected
      deadlocks during installations of website-related modules in 12.0.
      One way to reproduce it was to trigger the installation of both
      `website` and `website_form` in a single transaction, with neither
      pre-installed.
      
      Installing Apps that depend on both would do the job, such as
      `website_sale`, provided that GEOIP is available on the system.
      
      In details:
      During installation of `website`, new attachments creation would call
      get_current_website (see 602807ac and
      4f6ec1cd), using the wrong database
      cursor: the one from the request instead of the one for the
      installation, as provided by `ir.module.module._button_immediate_function`.
      This would acquire database locks on `res.country` and `ir.model` in
      the wrong transaction, later blocking alterations to `ir.model` in
      the installation transaction, e.g. for website_form's
      'website_form_access' column.
      
      This combination of events was possible before 12.0, but more difficult
      to reproduce as module installations used to happen with a super-user
      account, ignoring ACL checks and therefore not locking `ir.model`.
      f4041de4
    • Jairo Llopis's avatar
      [FIX] tests: Make `at_install` and `post_install` backwards compatible · a362d0eb
      Jairo Llopis authored
      Fixes #27471 by just using `tagged()` behind the scenes.
      
      calls to `tagged` were done in the wrong order
      
      closes odoo/odoo#27531
      a362d0eb
    • Gustavo Valverde's avatar
      [FIX] purchase_stock: buy_route xml_id · 1c0e419a
      Gustavo Valverde authored
      When creating a warehouse with purchase app installed, it will
      traceback since the route_warehouse0_buy is referenced in a wrong
      module.
      
      closes odoo/odoo#27523
      1c0e419a
    • Jeremy Kersten's avatar
      [FIX] website: auto enable multi website when creating a second website · c39d559e
      Jeremy Kersten authored
      Before this commit, you need to check manually multi website.
      And demo data create 2 websites by default, but don't check it.
      c39d559e
    • Jeremy Kersten's avatar
      [FIX] website: use email as login for public user · 7549ea03
      Jeremy Kersten authored
      Multiwebsite cannot work on the saas since the login use a constraint to check that it is an email.
      7549ea03
  6. Oct 05, 2018
  7. Oct 08, 2018
  8. Oct 07, 2018
  9. Oct 06, 2018
  10. Oct 05, 2018
  11. Oct 04, 2018
    • Nicolas Lempereur's avatar
      [FIX] auth_password_policy: remove deferred when not needed · 23bec7fb
      Nicolas Lempereur authored
      When auth_password_policy is installed, and a field with
      `password="True"` is in a res.config.settings (eg. google calendar is
      installed) we could have an error caused by deferred not expected in the
      res.config.settings _render.
      
      Since the RPC is only needed when the password_policy has been been
      defined, this commit do this removing the error that currently happened.
      
      A customization of res.config.settings adding password_meter would still
      break settings (but it is currently not done) and will be solved in a
      future fix.
      closes #27426
      23bec7fb
  12. Oct 03, 2018
    • Christophe Simonis's avatar
      [REL] 12.0 · 1868713d
      Christophe Simonis authored
      1868713d
    • Christophe Simonis's avatar
    • ThanhDodeurOdoo's avatar
      [FIX] base: ir_http access mode · 8ea5637c
      ThanhDodeurOdoo authored
      Before the fix, routes using binary_content with access_mode
      and access_token didn't work properly since access_token
      was compared to the object's access token in all cases.
      
      This commit:
      
       -prevents the object's access_token check if
      access_mode is truthy (since access_mode does its own access_token
      check).
      
       -changes check_access_mode so it now returns a boolean instead of
       a record and is now private.
      
      Closes #27401
      8ea5637c
    • Christophe Simonis's avatar
    • Pedro M. Baeza's avatar
      [ADD] *: replace hardcoded data URIs with helper · 1ad4d42f
      Pedro M. Baeza authored
      - Add a method for generating an image data URI, and expose it in QWeb context
      
      - Fix reports, website templates or mail templates with data hardcoded
        data URIs, to use the helper (Python cases), or the existing
        kanban_image helper (for JS cases)
      
      This will gracefully handle SVG support in addition to classical image
      formats.
      
      Closes #26635
      1ad4d42f
    • Pedro M. Baeza's avatar
      [ADD] *: support SVG images · 1be50fde
      Pedro M. Baeza authored
      Introduce official support for SVG files in the framework, including the
      following parts:
      
      1. When client-side SVG images are uploaded, the content is displayed until
      you save using data URI scheme according RFC 2397 [1]. This scheme requires
      to specify content format. Using hardcoded "image/png" works for all images
      types except SVG.
      Type-sniffing is done using "magic byte" detection via the first base64
      encode byte, so that the proper data URI scheme can be used.
      This should not cause SVG-related security problems as the file is
      displayed through `<img>` tag, which does not allow SVG scripting [2].
      
      2. Make /web/image controller compatible with SVG
      
      3. Add support for SVG files for company logo, which uses a dedicated
      controller.
      
      4. Resizing of SVG files is a no-op, as it makes little sense for a
      vector-based format. We also want to avoid micro-alterations to the SVG
      document (in "natural" viewport parameters) as we would store multiple
      copies of the files in the filestore.
      
      5. Because SVG files are inherently dangerous, upload of SVG files is
      restricted to administrators, either by blocking it directly before
      saving it in the database (binary fields with attachment=False), or by
      neutering them to text/plain mimetype (for binary fields with
      attachment=True)
      
      6. Add tests for the SVG upload cases and for the non-admin uploads.
      
      [1] https://tools.ietf.org/html/rfc2397
      [2] https://www.w3.org/wiki/SVG_Security
      
      Closes #26635
      1be50fde
    • Christophe Simonis's avatar
      c43f35ee
    • Xavier Morel's avatar
      [FIX] base_import: show error message in some situation where it was missing · 376361c1
      Xavier Morel authored
      On an AccessError, the relevant message is passed as the first arg. But
      the import error handler would only check for the second arg (if any)
      then fallback on error.message, which is missing entirely when the issue
      is raised as an except_orm subclass.
      376361c1
    • Christophe Simonis's avatar
    • Odoo Translation Bot's avatar
Loading