Were missing the translations of the javascript code that was outside
of the static/src/js folders

closes odoo/odoo#61809

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Only translate the literal strings

Since 14.0, the javascript code of snippets is moved inside a
/static/src/snippets directory.
With owl, the components are defined in static/src/components
Some other modules were using more exotic path and ended up with no
translations.

opw-2381030

PURPOSE

When opening the same form view 2 times in quick succession (e.g. clicking twice
on the name of an employee from a chat window), there is a traceback

SPECIFICATION

It should open public employee form and not raise any error

LINKS

Task-2371687
PR https://github.com/odoo/odoo/pull/61457



closes odoo/odoo#61457

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Task-2388565

closes odoo/odoo#61951

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

In previous versions of Odoo, in the New message box, typing a few
letters of the name of your recipient and pressing Enter would
automatically select the conversation with this contact.

Since 14.0, one has to select the first result with the Down key.
This commit restores the previous behavior by using the
[`autofocus`](https://api.jqueryui.com/autocomplete/#option-autoFocus

)
option.

closes odoo/odoo#61886

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

This change highlighted issues with the async behavior of `useUpdate`, which
was no longer necessary and therefore reverted.

This in turn highlighted issue with animation of chat window unfolding, making
restoring of scroll position not work as intended due to the message list not
having its whole height available during some time after render. This animation
being minor (and even annoying in some cases) it was decided to remove it.

task-2387729

closes odoo/odoo#61881

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

With this commit https://github.com/odoo/odoo/commit/db9da432b7aedcd1bc944e23e59459c9c92801b7


the module fleet_account doesn't exist anymore and so the field module_fleet_account is useless

opw:2382169

closes odoo/odoo#61822

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Steps to reproduce the bug:

- Delete the current website
- Go to homepage

Bug:

An error 500 was displayrd

opw:2381929

closes odoo/odoo#61849

X-original-commit: 0e7faad49ed78f5def56d9af90c383cbbfa42e9f
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

When a session is created and no orders can be created because of
misconfiguration. We should be able to close the session.

When a chart of account is installed, we should not try to create
payment methods on config that have active session as it is forbidden.

Check that there is at least one payment method configured when
launching a session.

closes odoo/odoo#61933

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Problem
-------
When a sale order has more than one task within the same project
clicking on X tasks lead to an access error since regular user
cannot read action anymore

Solution
---------
use _for_xml_id method to fetch action data

closes odoo/odoo#61928

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Configure a reorder rule and a restock route for a product A
Go to Inventory / Operations / Replenishment
Remove all filters, find product A and under column 'To Order' input a
quantity, then hit the button 'Order Once'

The user quantity will be overwritten by the '_compute_qty_to_order'.
This is a fine tuning of f5054446

opw-2375317

closes odoo/odoo#61884

Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>

Before this commit, click on a button stat from the website dashboard, don't always respect the current filter.

Date filter was missing, website_id wrongly filtered, or domain not exactly the same.

Now, we try to align the dashboard data with the actions.

opw-2369420
Fixes #44926, fixes #51125

closes odoo/odoo#61883

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>

Before this commit, the python domain on sale.report would not get today's data
as it would do `date >= 2020-03-03`, but it means `2020-03-03 00:00:00`,
actually excluding today.
Then the JS domains to retrieve those data once you click on the metric (it
loads an act window with his domain + additional domain though js) would have
a different date domain, including today.

Note that there is still some inconsistencies between python and JS such as
last month filter which is in python (in template filter) today - 30 days
while in JS it is moment.subtract 1 month which might be 31 days.

Those were removed with f9874b2b and restored in 14.0 (master at that point) with cc6000ab.

This commit restores the missing filters for the context filters to work on
the view used in stable.

Act window domain are used to load tree view data when clicking on dashboard
metric.
That metric is retrieved through domain in backend.

This domain part wasn't adapted in act window domain (can't use ref).
As searching on website is enough to get ecommerce order, this line can be
safely removed, it is an old code that was needed before website_id was set on
order, as it can be noticed in f6fc7c23.

The metrics displayed on the dashboard are retrieved through a domain used in
`fetch_dashboard_data()` route.
When clicking on one of those metrics, an action is called with a domain.

This commit fixes incoherences between those domains.

task-2369420

Without this commit, when clicking on a metric on the website dashboard, it
would not load the correct data.
Indeed, the dashboard is loaded for a specific website only, but clicking on a
metric opens the data for every website together.

Step to reproduce:
  - Make some orders on 2 differents website ecommerce
  - OPTIONAL: Get through the payment on some orders, then just leave some
    products in the cart afterward to have some unpaid orders
  - Go to the website dashboard, you see some metrics
  - Change the selected website on top right, you see the metrics adapts
    correctly
  - Click on a metric, it doesn't fit the number you clicked on. For instance,
    if you had 1 Unpaid Orders for website 1 and 3 Unpaid Orders for website 2,
    you see 4 orders in the tree view once you have clicked the metric.

This commit ensures the correct website is appended to every dashboard action
domain.

opw-2369420
Fixes #44926, fixes #51125

Some projects may not need the tags, while others use the state heavily.
This makes both fields available and optional.

closes odoo/odoo#61924

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this fix, the prefix was detected as `045-0` and the year as `1`
instead of no year with prefix `045-001`.

opw-2381351

closes odoo/odoo#61882

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Currently, when attachment small icon was displayed on portal it
is broken and repeated on background more than once like: task
attachment icon.

So in this commit do not repeat the icon when icon is small on portal
attachment.

closes odoo/odoo#61906

Taskid: 2337684
X-original-commit: 24304608
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

The ControlPanel has been converted in Owl [1], and the code using
it has been adapted accordingly. However, in the FieldX2Many, we
didn't properly wait for the ControlPanel to be updated (an update
of the ControlPanel was synchronous before owl, and is now async,
like every Owl renderings, as it waits for the nextAnimationFrame).

As a consequence, we might have tricky issues because the mounted
hook of the control panel might be called multiple times for a
single call to willUnmount later on. In mobile, we bind a global
event handler (on scroll) in mounted, and unbind it in willUnmount,
so we had leftover event handlers, that crashed when called after
the ControlPanel was destroyed. Note that even if the issue popped
in mobile, calling mounted on already mounted Components isn't a
good idea, and this should be fixed anyway.

The issue could be reproduced for instance in FieldService (with
collaborative pads activated in Project), in mobile, by opening
a task in Edit mode. Then, you might get a traceback by scrolling
after having discarded the edition

Here is a description of what technically happened:
 - when clicking on Edit, all widgets (including the FieldX2Many
   are destroyed and re-instantiated in 'edit' mode).
 - the pad widget directly triggers a field_changed event which
   causes a reset of the FieldX2Many (i.e. 'render' is called
   again)
 - the FieldX2Many detects that it already has a renderer (and a
   ControlPanel) so it updates them
 - it first updates the renderer, and when it's done, it updates
   the ControlPanel BUT doesn't wait for its promise, so the
   promise returned by that call to 'render' in FieldX2Many is
   resolved before the ControlPanel is actually updated
 - note that at this point, all thoses new widgets are not in the
   DOM yet
 - when all widgets are ready, the renderer patches the view (i.e.
   the former content is removed from the DOM, and the new one is
   attached into the DOM). As soon as this is done, the renderer
   calls 'on_attach_callback' on its children, including the
   FieldX2Many, which leads to a call to 'mounted' on the CP.
 - then, just before the nextAnimationFrame, Owl complete the
   rendering of the CP, and detects that it is now in the DOM (it
   wasn't at the beginning), so 'mounted' is called a second time,
   will cause the issue described above.

This commit fixes the issue by properly waiting for the CP to be
rendered in the FieldX2Many. However, this required on cascade
changes:
 - Form view renderings with a FieldX2Many are now *really* async
   (+- 16ms), meaning that the user can easily trigger concurrent
   renderings by, e.g. clicking quickly several times on 'Edit',
   'Save' or 'Discard'. Concurrent renderings are properly handled
   so to prevent this from happening, we disable the buttons and
   re-enable them when the rendering is done (like already done in
   [2])
 - in the FieldX2Many, '_updateControlPanel' was called at several
   placed, but we never waited for it. As this method was
   originally sync, its calls have probably been naively adapted,
   whereas their should have been deeply rethought (for instance,
   as it is async, and we need to wait for it, we don't want it
   to be called multiple times sequentially when something happens).
   This commit does that work, i.e. we clean the places where this
   function is called such that it is (hopefully) never called
   sequentially twice. To do so, we changed a bit the spec of the
   pager in multi page, and we also fixed a paging-related  bug.
   In a few words, here is what we did/do when adding a new row
   in the bottom of a full page:
     - before: tweak the count in the data to fool the pager and
       make it think that no new record has been added (so
       basically, let it display something wrong)
     - now: temporarily increase the pager limit so that the new
       record is displayed on the current pager, and the pager
       values are correct w.r.t. the displayed records.
    Some tests needed to be adapted accordingly.
 - By waiting for the ControlPanel when updating the FieldX2Many,
   a bunch of QUnit tests failed. Those tests have something in
   common: they spawn an X2Many (list or kanban theoretically,
   but always list in practice) containing a FieldBoolean (only
   field widget of /web converted in owl). When the FieldX2Many
   is updated, we update the renderer (i.e. re-renderer the
   FieldBoolean, so we have to wait for the nextAnimationFrame),
   and when this is done, we update the page (again, we have
   to wait for the nextAnimationFrame). So basically, we have
   to wait for two nextAnimationFrames to see the result in the
   DOM. For this, we added a new test util which basically does
   a nextTick ('owlCompatibilityNextTick'), and called it
   everywhere it was necessary. When everything will be written
   in Owl, we could get rid of this util and its calls.

[1] https://github.com/odoo/odoo/commit/fbf347498f1cc7b74ef373179b7bcae201715c24
[2] https://github.com/odoo/odoo/commit/39f08950d6e20460e3a20a5b9c33e4ddf66dce78



closes odoo/odoo#61593

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

Removed all the settings related to billable projects in the quick
create dialog. There were too many settings which slowed down the quick
creation of a project.

closes odoo/odoo#61568

Taskid: 2376401
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Currently, Traceback occurs when we do timezone filters in every one
report of time off because the timezone is non-stored compute field in
hr leave model.

So in this commit, get the timzone value based on compute field from
resource or timezone of the current company's calendar OR user's tz
and at last 'UTC'.

closes odoo/odoo#57597

Taskid: 2334866
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Currently, when go to calendar > list view > action > send sms
to attendees, it will generate the the traceback because default
composition_mode is comment while when you process through the
list then sms_composition mode should be 'mass'.

So in this commit, pass the sms_composition_mode as 'guess' so
it will automatically check the record and take the correct
composition mode and also pass the active_ids as res_ids.

closes odoo/odoo#60330

Taskid: 2344284
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Currently, in the user setting, hovering on the live chat input will
focus on the signature div due to long height of the empty svg.

So in this commit fixes the issue by adding the css property in the
svg element of signature widget due to that svg element contains the
proper width and height.

closes odoo/odoo#61896

Taskid: 2361880
X-original-commit: 6fe2a0b8b6f8dadb2eb7008019f2d7266dcf6fb1
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Previously, the transparency color for shapes was not taken into account
when handling the preview state transitions of the background shape
snippet option. This caused strange behaviours where the shape
transparency color would always get reset when it was a class color,
either when changing to a different shape (expected, all shape colors
should get reset) or when changing any other shape setting like other
shape colors or flipping the shape (not expected). On the other hand, if
the transparency color was not a class color, it would always remain
untouched, when changing other shapes settings (expected) but also when
changing shape type (eg Origins 01 -> Blocks 02, unwanted).

This commit fixes that by cloning the entire shape container during
preview, and restoring it on preview-reset.

task-2380815

closes odoo/odoo#61710

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

task-2387598

closes odoo/odoo#61835

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

*: im_livechat

Also, fix its unopened position so that it stays at the same horizontal
position when opened.

task-2369225

closes odoo/odoo#61649

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

This commit fixes the issue with dropdown of activity in kanban.
The activity dropdown was cut with document inspectorbar in document
kanban view due to data-boundry window on dropdown.

Note:
Dropdown of list activity was cut on the list view and to fix that
commit[1] was done but it has side effect on document kanban view.
another fix was done in commit[2] so now commit[1] is not useful so
here revert that commit.

[1] - https://github.com/odoo/odoo/commit/cef57b930b27cb487973f251797c93ea3967a5b3
[2] - https://github.com/odoo/odoo/commit/a98f0621169144f53f4ebc9361f3b7c6b60556c8



closes odoo/odoo#60529

Taskid: 2336146
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Problem
-------
For regular allocation that have an empty date_from
(Allocation existing before 14.0),
it's not possible to save any change since an invisible field is required
and cannot be set.

Solution
--------
The field date from should be only required for type accrual

closes odoo/odoo#61885

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

When displaying a QR-code on the account.payment form view, we now pass its communication as both structured and unstructured communication, letting the QR-code generator parse it needed. This allows supporting QR-IBANs and QRR communications for Swiss QR-codes.

closes odoo/odoo#61877

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Prior to this commit:

    A race condition could occur when dropping the dynamic product snippet
    creating a traceback "Cannot read property 'limit' of undefined".

After this commit:

    Potential race condition has been removed from the code.

closes odoo/odoo#61872

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Note that in 14.0 the same fix was already applied with [1]. This commit
only clarifies the line's related comment and use the right zindex
variable (even though the value is the same).

[1]: https://github.com/odoo/odoo/commit/0f2cab4aebcc33ca9e278c9395fed2cc8934ed38



closes odoo/odoo#61866

X-original-commit: 702f2b93
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

STEPS:
* activate Product Configurator
* create 3 attributes with custom values option
* create a quotation with a product having all 3 attributes and custom values
* select the custom values for attributes in different orders for each SO line

BEFORE: Product description get random order for the custom attributes list

AFTER: Order is fine

---

opw-2379778

closes odoo/odoo#61862

X-original-commit: 57eb0507
Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

This commit fixes two bugs with payment_test:

First:
Before, payment test would create token without a name.

When you tried to pay your subscription on the portal with these, the following error would occurs:

```
Error to render compiling AST
AttributeError: 'bool' object has no attribute 'replace'
Template: sale_subscription.subscription
Path: /t/t[2]/div/t/t[2]/ul/li[1]/div[3]/t
Node: <t t-esc="account.payment_token_id.short_name"/>

The error occured while rendering the template sale_subscription.subscription and evaluating the following expression: <t t-esc="account.payment_token_id.short_name"/>
```

This commit add a distinct name for these token to avoid errors and confusion.

Secondly,

Before this commit when user tried to make a payment with the payment_test acquirer, the callback method was never called.
This had an impact on module where the callback method is used (mostly subscription).

closes odoo/odoo#60510

Taskid: 2367508
Related: odoo/enterprise#14329
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

- Create a POS session
- Sell some items
- Close the session, go to the closing page
- Duplicate the browser tab
- Close the session in tab 1
- Close the session in tab 2

The journal entries are created twice.

There should be a server check before closing the session.

opw-2379278

closes odoo/odoo#61857

X-original-commit: 0ba535c5123fecb410fa7546b5bb39a52884ca40
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

In this commit, creating SM from SML if trasfer is immediate. Due
to which following issues are getting resolve -
For immediate trasfer -

1) Unable to cancel the picking in draft state and SML is created
by view directly (No SM).

2) Unable to see button Put in pack.

3) Picking remains in state draft instead of ready.

task-2275833

closes odoo/odoo#57098

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Before this commit, the last rating value returned was not the last
consumed one.

closes odoo/odoo#61861

Taskid: 2260685
X-original-commit: 5fd11c46
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Kevin Baptiste <kba@odoo.com>

Steps to reproduce the bug:

- Let's consider a product P with price=100€, Timesheets on tasks and Create a task in sales order's project
- Create a SO with 1 P and confirm it
- A project PR and a task T have been created
- Assign an employee E to T and record 01:00 hour
- Create an invoice I from the SO and confirm I
- Go to the project overview of the SO

Bug:

100€ was counted twice in Non billable task and in Billed on Timesheets

PS:

When validating I, an analytic line L is created and L is not linked to PR.
That's why 100€ was counted twice because L was counted once in the 'Invoiced' part
and once in the 'Other revenue'

opw:2370418

closes odoo/odoo#61433

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>