Before this commit, the callback which selects the currently used
style in the dropdown menu was binded to the mousedown event on the
div which contains the dropdown-toggle and the dropdown-menu. This
was wrong as the callback is thus called even when clicking in the
dropdown menu.

Instead of logging "Killing tour x" when calling the run method a
second time and then logging "ok" when consuming the old running tour,
the message "Killing tour x" is now logged as an error for phamtomJS.

Also, let "x" be the tour which is killed and not the one which wanted
to be runned.

[FIX] account_tax_cash_basis: add the mechanism to report cash basis taxes at the payment time only.

Previsouly they were directly included in the tax reports, in the period of the invoice, and even if it was still unpaid.

Although this is a bugfix, it involves creation of new fields and thus cannot lands at it on stable versions where our policy disallow database changes.

* display all lines and don't display the scroll bar into ace editor
* lazy read ace lib and add missing lib file
* use not minified version of ace lib
* Move ace lib from website to web
* Added ace widget for webclient
* XML mode for view text box
* Python mode for server action text box
* Removed web_ace_editor.xml, instead added template in base.xml itself
* Added widget=ace_editor in compute field of ir.model.fields

Without this patch Email notification of leaved doesnt have the
action buttons('approve','refuse')

related to rev https://github.com/odoo-dev/odoo/commit/46ccb7036fc478e613667777c3cd59b6406aff17

* bad creation of a dictionnary with the dictionary comprehension syntax.
  correction of the syntax.
* unnecessery use of decimal precision function because the wizard is already
  in the good decimal precision. Remove the decimal precision call and lib.
* traceback when the valuation account was not defined on product category.
  raise exception when no valuation account, to explain the user why he can't
  change the price.

during the conversion of the method "assign_outstanding_credit",
the id parameter was wrongly kept. Now that we are working with
recordsets, the id is now stored in self.id

related to rev d6e1d411

When we use firefox top or bottom arrow the ace container does not scroll automatically if the cursor is not visible.

Without this patch, there's a traceback when creating a segment due
to an onchange trying to set an attribute `ir_filter_id` to a dict.

related to rev 0fa2ac1d

During the conversion of the server action "action_account_print_checks",
the "self.env" variable was wrongly kept. Now in server actions we
are using the variable "env" directly.

* get_pdf function expects a list of ids since the removal of old api in
  this commit: rev 47c67b64
  There were still some wrong calls.
* while get_action can receive ids and recordsets, get_html and get_pdf
  are internal methods and still work with list of ids

* display all lines and don't display the scroll bar into ace editor
* lazy read ace lib and add missing lib file
* use not minified version of ace lib
* Move ace lib from website to web
* Added ace widget for webclient
* XML mode for view text box
* Python mode for server action text box
* Removed web_ace_editor.xml, instead added template in base.xml itself
* Added widget=ace_editor in compute field of ir.model.fields

The onchange produced a traceback because, even if start and stop
are required, they have no default value. Adapted `_get_duration`
function so that it is robust to that usecase.

The product_manager field is existing since v6.0 and never displayed in any views. It is used in sale_timesheet module. A task created from a procurement_order (if it is a service and we track the service) is assigned to the product manager. It doesn't make a lot of sense as the value should be set directly in the database. We will remove the field and assign the current user to the task instead, which is the common behavior in Odoo.

Add a link in the general settings to access easily the default_user form view in order to modify the default access rights

The default_user manager rights declarations in all the applications have been move in a noupdate="1" definition to avoid the manual configuration overwrittings

It's ok to give the 'Manager' rights to new users for small companies or new saas instances so that newly created users can direcly use all the features.

For bigger companies, someone is creating the new users and give the rights specifically according to their access rights in the company departments.

But granting administrator access by default is definitely questionable. The main admin is bound to make mistakes and fail to notice or remember that they have given admin access to new users. Making the system insecure by default is not a good trade-off for "simplifying the system for small businesses". And this will not be expected by anyone.

remove the '(no email address)' when no address email. Because when you send
the message, a popup appears with the email field required.

better patch for rev e9b649b5

* also fixes website_event which present the same issue (depends
  on a function that slugs)
* raise an exception when slug is called with wrong arguments
  instead of returning None (which was unclear)
* before calling slug in a function where we got a depends, check
  that the record is actually created

A typo probably introduced during the migration to the new api may have
caused duplicates to appear in the name search results since it added
the ids of the wrong recordset.

The previous fix, while effective, also removed a previous optimization
for databases with a lot of products. While the code may seem obscure
on first read, the comments should shed some light on the
implementation choice.

This commit therefore reintroduce the previous code with the exception
of the call to the wrong recordset (self instead of products).

Amends b02a85fc
Courtesy of @rco-odoo

The key 'tax_code_id' does not exist anymore, therefore the condition
line.get('tax_code_id') == values.get('tax_code_id')
was equivalent to
None == None
which is of course always True.

To make this code more readable and avoid misunderstandings, a clearer
loop implementation avoids checking for this key.

When you execute the slug method on a virtual record (not yet
saved, virtualid/newid) the slugs obviously fails as it needs
an id and a display_name.

This issue happens when there's a depends on a function field
using the slug method: just after the create and during the
onchanges, they'll raise.

This patch makes the slug method returns None in these case,
anyway the depends are re-triggered after the write and at
this time they have an id and everything is working fine.

Stock account is sufficient for Point of Sale. No need to set sale_stock as
dependency, as it installs Sales Management but is not required for running
the POS.

This commits adds the check W0101 to test_pylint and fixes the errors.

The index in sequence.py was added in rev 1381ac13 and cancelled a day later in 83fdc271
so i guess it is safe to remove it.

A new field `create_variant` has been added on `product.attribute`.
If unchecked, the attribute will not create variant.

These attributes will be added on the sale order description if bought from the shop.
The lines of a product with these attributes will be splitted to keep the description.

Fp request: In the user preferences menu, remove "About Us" and put the version number in the Settings dashboard somewhere, as well as the link to switch to developer mode. Odoo is not a desktop application anymore.

For the need of the next commit, we have to know when making a request from an RPC call in which debug mode we are. Previously, the value was always 'true' if we were in debug mode. Now it will return 'true' if we are in simple debug mode and 'assets' if we are in the other one. (this is the current behavior for the simple WebRequest).

Why do we need to know that? When loading the settings dashboard, an rpc request to /web/dataset/call_kw to load the view is accessing the odoo.debug @property method. This value is used in the template to decide which buttons to display to activate or deactivate the debug mode.

==============
Specifications
==============

Add an option in the settings to use the surveys or not
By default : do not use interview forms.
If the option is false : on the job application, hide the Interview form field

A ticket whose seats_availability is unlimited,  is not shown on saleorder line. Fixed it.
It should show all the ticket whose seats_availability is unlimited or seats_available is greater than 0.

========
Purpose
========

The graphs on the accounting dashboard give the impression that we had $0 in the bank because the graph is at the bottom of the kanban kard.

==========
Specification
==========

The bottom should be zero, the top should be the maximum of the visible period, and the rest of the graph should be proportionate.