-By this commit, 'Buy credits' link should only be visible whenever
 'Lead Enrichment' feature is enable in settings of CRM.

task-2116040

closes odoo/odoo#39578

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#39223

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

PURPOSE

Fix a bug where you get a traceback when trying to join a course on a quiz
preview not in fullscreen mode.

A variable was badly named in JS (id -> channelId), leading to the ID not
being forwarded to the "Join Course" sub-widget.

LINKS

Task ID 2079476
PR #38051

closes odoo/odoo#39876

X-original-commit: b32d30b8cde85ba37f9cef975838874a08ea7c07
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

In f2969923 (12.3) part of the code of the editor `Link Dialog` was
moved to a web_editor/static/src/js/wysiwyg/plugin/link.js file/class.

In 13.0 the 12.3 editor changes were mostly reverted in 35b61822 but
part of the change of `Link Dialog` that was moved to another file/class
was not moved back, thus: it does not work as expected => eg. if we add
a link over an image, the image is removed.

In this commit we get back the missing part as it was in 12.0 version.

opw-2086444
closes #39858

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When a pos order is sent to the server, the field 'to_invoice' is never
sent to the server which lead to always having a value to 'false'.

We are now sending correctly this value to the server, and we can also
base the fact to create an invoice on the value of each order.

Because beeing offline could lead to create an order that should be
invoiced as one that should not be.

closes odoo/odoo#39843

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

closes odoo/odoo#39855

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Fixes #39688

closes odoo/odoo#39854

X-original-commit: 06a9e8aa
Signed-off-by: lul-odoo <LucasLefevre@users.noreply.github.com>

In commit: https://github.com/odoo/odoo/commit/0cc30bf08382128a77455a51d831ef45ccdfdb48#diff-fb13a23a71b7b833233add03eb5f10f7R20


confirmation_date was replaced by the date_order on sale order.

At the same time in compute method confirmation_date was too replace
but on sale.report  no such field exist so replace the date_order by
date which coming from date_order of sale order.

Task-1883428

closes odoo/odoo#39849

Closes: #39849
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The commit 3c4bb080 fixed an issue about reservation from transit location
for versions from 11.0 to 12.0 by soften the record rule on stock.move

From 12.3, we need to additionnaly soften the stock.move.line rule
to have the same result as this model has a record rule too since that version

closes odoo/odoo#39809

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Create a customer without email address, go on the accounting module
create an invoice for this customer.

Go back to the invoices list and select some of them including your
invoice for your customer without email address. Send them by mail.

You will have a traceback and the wizard will be broken.

This bug is caused by a change in the account module, there is no more
reference, they are replaced by the name of the invoice.

OPW-2085837

closes odoo/odoo#39738

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- In the sales or accounting module, create some invoices.
- Select them then click on `action > send & print`
- The wizard opens but not in the mass mail mode.

It creates some inconsistency and if you click on send,
the invoices are sent to the wrong customer.

Sometimes, the invoices are not sent at all.

I think the problem comes from the `_compute_composition_mode` method
who set the value of `composition_mode` on the wizard instead of
on the composer.

OPW-2085837

In 13.0, we use the IoTBox which handle https correctly
12.0 was still a transition version but people should have switched in
13.0

closes odoo/odoo#39832

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

A journal entry must always have the same currency as the account when
a secondary currency is set on this one.

closes odoo/odoo#39744

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

This field has been introduced by https://github.com/odoo/odoo/commit/2d1b8e9f3445ab0e1c1ac4683b7b5a25c867b2de
but is no longer used anywhere and is not a valid field on account.move.line.

Fields (and selection values) were re-labeled in multiple models but
the corresponding import templates were not updated to match, and are
now non-working (can't straight import the templates themselves which
is inconvenient).

Task 2059779

closes odoo/odoo#36119

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

* the employees file apparently never worked as the marital status was
  updated before template files were added (respectively
  0eb58775 and
  b60de0db)
* the purchase template was never updated to reflect the Big Demo Data Changes
  (58fc4e44).

Fixes #39074

Employees file update split off of task 2059779.

closes odoo/odoo#39822

X-original-commit: 80a2f687
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Co-authored-by: Prakash Prajapati <ppr@odoo.com>

Go on the accounting module, you'll find a kanban view with a few
cards including "Bank" and "Cash". Click on the Cash card.

The default import button doesn't appears because it is hidden.
The reason of this hiding is that the bank statements of type "Bank"
have a custom import method and the users where confuse. They
didn't know which is the right button for the special import so
we hid the default import button for the whole model.

But there is also a "Cash" type bank statement who doesn't have that
special import and his default import button is hidden too.

This commit checks the type of the bank statement and hide the default
import button only if the type is not "Cash".

OPW-2090477

closes odoo/odoo#39827

X-original-commit: ee45228a
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Forgotten in 
https://github.com/odoo/odoo/commit/7b3d87b905dff1212f88cc381a125590f5cb0bfe



closes odoo/odoo#39819

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Followup of #38948

When building the MS Windows package, the PYTHON_VERSION variable is not
used and the WinPython path is hard coded in the Makefile and NSI file.
This prevent the usage of a newer version of Python.

With this commit, the PYTHON_VERSION is used to compute the WinPython
Python directory. That way, this directory can be derived from
package.py command line argument --vm-winxp-python-version.

Also the less windows binaries are not packaged anymore.

closes odoo/odoo#39816

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

- Create a project
- Create 3 tasks in the project (top, middle, bottom)
- Set top as the parent of middle
- Set middle as the parent of bottom

We don't want to allow multi level subtasks. The behavior is not the
same if you set middle as the parent of bottom first. The "parent task"
field will not be displayed.

This commit remove the tasks who have a parent from the m2o field.

OPW-2087921

closes odoo/odoo#39805

X-original-commit: c7966b64
Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>

The spaces should not be important in a structured reference.
Also, we should not have to include the second batch as that batch
(previously the first) was intended to match the payment reference.
By including it, we may have too much false positives proposed in the
widget and even worse: auto reconciled.

closes odoo/odoo#39334

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

FIX 2092459
The reconciliation tries to find partner based on the bank number, but
that bank number may not be encoded the same way depending where the
statement lines come from.
A solution is to sanitize the bank number at query time.

In 6b048a8b most issue with trigger causing error when uninstalling a
module were solved.

But there was a particular case if the current uninstallation of modules
there was an update of `ir.model.fields.selection` to be removed. The
unlink of `ir.model.fields.selection` would cause a `setup_models` call
that would add all removed triggers back and possibly down the line
cause an trigger recomputation error.

With this changeset, we do as is already done for ir.model.fields and do
not re-initialize the registry during module uninstallation.

opw-2098915
closes #39796

Signed-off-by: Adrian Torres (adt) <adt@odoo.com>

- Create an event
- Add a mail reminder for it
- Run the mail scheduler manually
- Duplicate the event

The mail reminder is sent on the duplicate too.
This commit remove the field `mail_sent` from duplicating.

OPW-2117343

closes odoo/odoo#39770

X-original-commit: 7fede2c0
Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>

The 'delivered quantity' field sometime needs to trigger a search
on related objects (e.g. analytic lines) to know how much has been
delivered.

For performance reasons, this search is done using a read_group where
the results are grouped by SO line.

Unfortunately, this computation is sometimes launched during
recomputes/onchanges where the line in question has a NewId instead
of a regular id.

This means that the mapping will return something like
{240: 50.0}
indicating that (e.g.) there are 50 timesheet hours for the SO line
with id 240; unfortunately by doing
mapping.get(line.id, 0.0)
the NewId (240) is used - therefore returning a delivered quantity
of 0.0 for a line which has actual timesheets.

This commit ensures that if the line has a NewId and an original
underlying record, the id of the latter is used as the key to fetch
the value from the dict that contains the read_group result.

Note that the problem was quite tricky to reproduce as it depended
on the order of operations launched by triggers - the order of
operations was important since triggering the compute with the 'real'
record put things in order before any other piece of code could have
spotted the issue.

closes odoo/odoo#39778

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Business cases should not prevent the unlink of module-related records
during an uninstall.

This commit allows the reinstallation of sale_stock with demo data and
also allows the proper removal of tables and records if a db has any
non-draft inventory adjustments.

closes odoo/odoo#39764

Signed-off-by: Adrian Torres (adt) <adt@odoo.com>

Commit https://github.com/odoo/odoo/commit/4f27e52cabb77b8b1a9637a11185ddf882adc9af


had to instantiate the snippet editor UI differently but the hack broke
the position of the oe_manipulator which is supposed to be at the top
left of the editable zone.

closes odoo/odoo#39751

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Could be the cause of flickering during multiple recomputation of the
overlay position.

Someone new to Linux can run into problems when some system dependencies
are missing. There is a single sentence warning talking about those hard
dependencies and it does not explain how to install them.

Added two § containing the missing `apt` commands required to install
the dependencies on a fresh debian minimal install.

closes odoo/odoo#38948

Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>

URLs with parameters were not correctly supported by the regular
expression.
For example, URLs with parameters were truncated before the '?'.

This patch adds support for a wider range of URLs, and checks in a test
that the parameters are correctly handled.

closes odoo/odoo#39716

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

In the contacts app, you can select 2 partners and merge them.

Before this commit:

    - If a partner was added by a SQL query and not directly on Odoo,
      the create_date will be empty. This causes a crash because the
      merge wizard try to sort the partners by date

After this commit:

    - If a partner do not have a create_date, it will be considered
      as 01/01/1970. The merge wizard will sort the partners by IDs too.

OPW-2091925

closes odoo/odoo#39518

X-original-commit: deeb769c
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before 13.0 .sudo() before sending a mail would send it as superuser user
(which was the intention in this case), but since 13.0 for the same
intention we need .with_user(SUPERUSER_ID).

Without this change, the confirmation email on a sale order would have
no sender ending up in failure.

opw-2118612
closes #39737

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

The extra informations not on the sale.order models were sent before
13.0 with the superuser user. In 13.0 with the change of `sudo` and
`with_user` behavior, we were now in superuser mode but not with the
superuser so the mail would error (no from address) and the sale order
would error.

With this changeset, we get back to the pre-13 behavior.

opw-2116346
closes #39730

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Before this rev, it crashed when opening the (sale or purchase)
product matrix (e.g. on runbot, go to quotations, create, add a
line, select 'My Company tshirt').

This was due to a recent override of _applyChanges (see 4bf98b47),
which didn't return the value returned by super.

OPW 2116083

closes odoo/odoo#39717

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

odoo/odoo#30688 (6ce2d6ef) added an
indirection in prefork workers: Python-level signal handlers are
delayed until native calls have ended (e.g. accept() or
execute()). Running the actual work in a sub-thread allowed the main
thread to handle signals in all cases.

However there is apparently an issue with SIGXCPU on linux (possibly
other cases as well): SIGXCPU is delivered to the child thread (if
possible?) and Thread.join apparently stops it from redelivered to
the main thread (Thread.join is signal-interruptible since 3.2 but
possibly not Python-interruptible).

Blocking SIGXCPU on the child thread causes the OS to deliver on the
main thread and fixes the issue.

Also split set_limits so it sets the signal handler in the parent
thread but properly updates the soft limit in the child after each
request, as the goal is to put a hard limit on the CPU time per
request, not on the worker. 6ce2d6ef would set the limit once then
never update it, likely cycling workers more than desired.

While at it:

* block other signals with a handler set, they seem to work
  regardless on linux but other OS may have a different way of
  dispatching process-directed signals
* unset signals which are set by the prefork server but whose
  set behavior makes no sense in workers:

  - TERM and CHLD were already unset
  - HUP is used to restart the server, workers can just be killed
  - TTIN and TTOU configure the number of workers

closes odoo/odoo#39723

X-original-commit: 549bd199
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Prior to this commit: b234e97f,
uninvoiced orders' state is set to 'done' when the session is validated.
However, this was not taken into consideration in the said commit such
that even if the session is already validated, the uninvoiced orders'
state remains 'paid'.

Setting the orders state to 'done' is the correct behavior and is
implemented in this commit.

closes odoo/odoo#39720

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

before this commit, when try to make payment with
empty card details, it will raise error dialog.

after this commit, error will be append to acquirer
form

task - 2089999

closes odoo/odoo#39708

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Make an invoice in Foreign
Make a refund in Foreign
reconcile the two, partially

Make a payment in domestic, partial also, but with writeoff

Before this commit,

The invoice was not fully reconciled and -0.02 was yet to pay on it
Notice the negativity of that number, which actually means that it HAS been
fully reconciled !!!! (there is too much payment compared to invoiced)

This was because, the account.payment in domestic currency is doing:
Invoice residual in foreign, converted to domestic

Then that amount minus payment's amount gives write off amount in domestic

Then, at reconciliation, the whole payment's amount, which is
the payment + the writeoff contained the expected and mathematically
correct conversion and currency rounding errors
(which should make out the exchange difference)

The exchange difference IS created, and rightfully too
that is, it records the exchange difference as debit 0.01 in the receivable !

What was tricky though, is that the partial line recorded the debit 0.01 receivable
as its CREDIT move line !

After this commit, the receivable line is recorded as the DEBIT move line of
the partial between the payment and the invoice
so the invoice, is fully paid.

We keenly admit this is hackish, but justified:
- business-wise: the rounding/exchange errors are appearing ex-post
to the choice of the amount of the reconciliation between the payment
and the invoice, because we are reconciling them on the domestic amount

- technically: our hands are tied because some key information is not present
every time, and weirdly, not symmetrically. That is, the computation of
line.amount_residual[currency] may be different if your are on a line with a currency,
or on a line that doesn't.
We should really think of systematically putting the currency on the line
whichever it is ! The same goes for partial reconciliation model !
Touching the current behavior is out of the question.

Moreover, we should take into account that comparing amounts at different
points in time should be done by actualizing those amounts to a common date
See #39117 for details

OPW 2057845

X-original-commit: 40db7a8c

Note that the tests did not change in spirit, but the writing
of the exchange difference may vary from happened in v11.0
Indeed a quite big refactoring has been done in between
The tests reflect this

closes odoo/odoo#39685

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

Usecase to reproduce:
- Set warehouse as 3 steps delivery
- On pack rule set the procure method as 'take from stock if enough or
trigger another rule'
- Do an inventory adjustement of a product and set 10 units in pack zone
- Do a delivery order for this product with only 1 unit.

It will create the delivery order from stock to pack even if the
quantity in pack was sufficient.

It's due to [1] that introduce a new function but if the force company
and location (with an integer) are both set in the domain it will
select the wrong ids. It will take all the location in the company + the
location in the context. However if a location is explicitly given to
the context, it should only consider the stock at this location.

[1] commit 330b99f6

opw-2090384

closes odoo/odoo#39644

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>