Skip to content
Snippets Groups Projects
  1. Jan 29, 2019
    • Christophe Monniez's avatar
      [FIX] packaging: allow install on fedora29 · 7eec6b36
      Christophe Monniez authored
      Fedora 29 switched to python 3.7. It seems that there is no official
      way to build a RPM package that could works with 3.6 and 3.7.
      Building two different packages for each version could open the pandora
      box of packaging.
      
      With this commit an ugly hack is used: if python3.7 is found, the odoo
      directory is symlinked into its site-packages dir.
      
      fixes #30579
      
      closes odoo/odoo#30618
      7eec6b36
  2. Jan 26, 2019
  3. Jan 29, 2019
  4. Jan 28, 2019
  5. Jan 29, 2019
    • Nicolas Martinelli's avatar
      [FIX] stock: unreserve · ae88e509
      Nicolas Martinelli authored
      - Create a SO with 2 stockable products: 1 is available, the other is
        not.
      - Validate, go to the picking
      - Set the 'Shipping Policy' to 'When all products are ready'
      
      The 'Unreserve' button disappears, while some products were reserved.
      
      When changing the shipping policy, the state of the picking is
      recomputed and set as `confirmed` ('Waiting').
      
      We make the button visible in this state also, when 'Shipping Policy'
      is set to 'When all products are ready'.
      
      opw-1932658
      
      closes odoo/odoo#30635
      ae88e509
  6. Jan 28, 2019
    • Lucas Perais (lpe)'s avatar
      [FIX] point_of_sale: offline invoicing => backend printing · 4a5862a4
      Lucas Perais (lpe) authored
      In a pos session:
      OFFLINE
      make an order with invoicing , try to validate
          The order stays there because it needs to be validated by the server
      make another non invoiced order, validate
      
      ONLINE
      make another order
          At validation, all orders will be pushed to the server
      
      Before this commit, when trying to validate the invoiced order
      the report download couldn't find the order id, and crashed
      This was because the order in question was already pushed
      but treated as a non invoiced order
      
      After this commit, an "warning" message is displayed to the customer
      saying he/she has to print the invoice from the backend.
      In most cases it is enough and acceptable, since a customer would actually leave the premises
      and come back later for the invoice
      It is also safer in terms of data consistency to keep pushing all orders once the connection is back
      
      OPW 1918044
      
      closes odoo/odoo#30485
      4a5862a4
    • Géry Debongnie's avatar
      [FIX] web: add exponential backoff strategy for lost connection · dc751f20
      Géry Debongnie authored
      Before this commit, the web client had a naive strategy to handle lost
      connections: it tried to poll the server every 2 seconds until a rpc
      succeeds.
      
      This works quite well from the perspective of the user, but may be a problem
      from the perspective of the server.  If a server is down for a longish period,
      then each users active tabs will then perform a request every 2 seconds. This
      means that the server will be progressively hammered by many requests, which
      will clutter the logs, and make it more difficult to gracefully recover.
      
      With this commit, we simply exponentially increase the delay each time, and add
      a little jitter to give a better distribution.
      
      Cherry-pick of 4a3f04bc
      
      closes odoo/odoo#30136
      
      closes odoo/odoo#30596
      dc751f20
    • Lucas Perais (lpe)'s avatar
      [FIX] account: tax in right refund account · 7ab26999
      Lucas Perais (lpe) authored
      Have a tax that has a different account for refunds
      make an invoice and its refund
      
      Before this commit, the refund's tax is still in the old account
      
      After this commit, the refund's tax is in the account for refund defined on the tax
      
      OPW 1907950
      
      closes odoo/odoo#30325
      7ab26999
    • Nicolas Martinelli's avatar
      [FIX] pos_discount: error if misconfigured product · 93a767a6
      Nicolas Martinelli authored
      In case the discount product is misconfigured and therefore not loaded
      by the POS, a traceback appears when applying a discount.
      
      Add a comprehensive error message instead.
      
      Closes #30574
      opw-817527
      
      closes odoo/odoo#30582
      93a767a6
  7. Jan 23, 2019
  8. Jan 21, 2019
  9. Jan 23, 2019
  10. Jan 24, 2019
  11. Jan 17, 2019
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
      17adccd9
    • wan's avatar
      [FIX] account: journal dashboard graph wrong value · 50bae1c0
      wan authored
      OPW 1918926
      
      Current behavior:
        The sql query groups by date,id in a intermediary table instead of the result. This allows to get data in the wrong order if the statements were not produced sequentially. The fill values are computed in the wrong order and may override correct values.
      
      Desired behavior:
        There is no override of the values correctly computed.
      
      closes odoo/odoo#29936
      50bae1c0
    • Lucas Perais (lpe)'s avatar
      [FIX] base: merge contacts linked to by an o2m field with caps · ba39efdf
      Lucas Perais (lpe) authored
      Define a field on a model as:
      - o2m to res.partner
      - the field's column, hence its name, has capital letters in it
      (studio does that)
      
      create two objects of that class, each one linked to a different partner with the new o2m
      
      merge the partners
      
      Before this commit, the object linked to the second partner, was deleted
      This was because merge partner sql requests did not quote the column name
      
      After this commit, the second object still exists
      
      This commit is tested in v12.0 with PR #30300 only. In v10.0 it is not testable as
      the model concerned is in CRM, and that no new fields in business modules can be added in stable
      
      OPW 1925060
      
      closes odoo/odoo#30301
      ba39efdf
  12. Jan 15, 2019
    • Denis Ledoux's avatar
      [FIX] ir_ui_view: do not change view mode when just changing the inherit · a4096276
      Denis Ledoux authored
      Some views have the primary mode while having an inherit_id view
      In such views, if the user wants to change the inherit_id,
      the mode must remain primary.
      
      The use case behind this is a user who want to change
      the inherit_id view of the view
      product.product.form (product.product_normal_form_view)
      to another view.
      This view is in primary mode while having an inherit_id
      (product.product_template_form_view).
      In such a case, the primary mode must remain,
      otherwise the view will no longer be opened by default
      when opening a product.
      Indeed, when searching the default form view of a model,
      it only searches for primary mode views for this model.
      
      The `all` is there because this is an `api.multi` method.
      We could consider adding a `self.ensure_one`,
      but it breaks the API if someones calls this method with multiple records.
      This is likely to happen, as this method is used
      in `write` which is likely to be called with multiple records.
      
      In my opinion, in master, this should be replaced by an
      onchange so the user can see the change of mode
      when he adds or remove an inherit_id for a view.
      
      opw-1916324
      
      closes odoo/odoo#30241
      a4096276
  13. Jan 22, 2019
  14. Jan 18, 2019
  15. Jan 15, 2019
  16. Jan 16, 2019
    • Nicolas Martinelli's avatar
      [FIX] product: unwanted attribute values in name · 180ace7b
      Nicolas Martinelli authored
      - Create the following attributes with values:
        Size: S, M, L, XL
        Color: Black, White
      - Create a product template with the following attribute values:
        Size: S, M, L, XL
        Color: Black
      
      The `name_get` of `product.product` returns `Name (SIZE, Black)` while
      it should only return `Name (SIZE)`.
      
      When using `attribute_id.value_ids`, the list of values contains all
      possible values of the attribute, not only the values which apply to the
      given product. In this case, it contains 'Black' and 'White', therefore
      the condition `> 1` is verified and the attribute is kept for display.
      
      We go back to the original filtering, and add `attribute_line_ids` in
      the list fields read in order to avoid prefetching.
      
      opw-1922140
      opw-1922447
      
      closes odoo/odoo#30273
      180ace7b
    • Joren Van Onder's avatar
      [FIX] point_of_sale: allow refunds on non-cash journals · 302d8a52
      Joren Van Onder authored
      Cherry pick of 5b769650 in version 11.0
      
      A customer can pay an order with a non-cash journal (e.g. a credit
      card through a stand-alone terminal).
      
      When this order has to be refunded later it should be possible to do
      so on that same journal.
      
      Some code prevented this from happening, notably a check in
      order_is_valid which explicitly prevented this for an unknown
      reason. There is no explanation in the
      commit (4647f896) introducing that.
      
      This commit allows the following:
      
      1. input what you want to refund with a negative qty
      2. click 'Payment'
      3. click the Credit Card (type Bank) journal
      4. (amount is auto-populated)
      5. click 'Validate'
      
      opw-805302
      opw-1913731
      
      closes odoo/odoo#30218
      302d8a52
    • Nicolas Martinelli's avatar
      [FIX] account: bank statement with many AML · 614babd1
      Nicolas Martinelli authored
      - Create a bank statement with more than 80 lines (therefore more than
        80 AML)
      - Reconcile the lines
      - Go back to the bank statement, and try to add a new line
      
      An error arise:
      "You cannot do this modification on a posted journal entry, you can just
      change some non legal fields"
      
      The error arise on the `move_line_ids` field on which the web client
      tries to write.
      
      Actually, this field is hidden since it is only used in the domain of a
      stat button. We can make it read-only.
      
      opw-1921138
      
      closes odoo/odoo#30266
      614babd1
    • Iryna Vyshnevska's avatar
      [CLA] signature for ivyshnevska · 92e4c4c3
      Iryna Vyshnevska authored
      Backport to 10.0 of 3b14a7da
      
      closes odoo/odoo#30090
      92e4c4c3
    • Manuel Vázquez Acosta's avatar
      [FIX] survey: don't disclose the survey via print · 6ac32c65
      Manuel Vázquez Acosta authored
      To avoid bigger changes, only verify if the login is required.
      A proper refactoring has been implemented in master at 9771fdfe
      
      Closes odoo/odoo#30166
      6ac32c65
  17. Jan 14, 2019
    • larisa's avatar
      [FIX] hr_payroll_account: correct account move lines creation · 6edfadbd
      larisa authored
      The super call of action_payslip_done executes the method compute_sheet.
      Without this compute_sheet call, there is no salary lines and no accounting
      move is created.
      
      closes odoo/odoo#29737
      6edfadbd
    • Manuel Vázquez Acosta's avatar
      9c6d9697
    • Filippo Iovine's avatar
      [CLA] add Filippo Iovine to levelprime CCLA · 169843d8
      Filippo Iovine authored
      closes odoo/odoo#29072
      169843d8
    • Jeremy Kersten's avatar
      [FIX] payment_sips: allow to customize key_version · 6e3661d5
      Jeremy Kersten authored
      Some sips provider don't use 2 as key_version.
      E.g. mercanet uses '1' as production key.
      
      Now we allow to override it in Ir Config Parameter for stable version.
      
      Todo:
      Need to make it customizable by end user into the configuration of acquirer.
      
      Courtesy of BEK for reporting
      
      opw-1916316
      
      closes odoo/odoo#30185
      6e3661d5
    • Adrian Torres's avatar
      [FIX] ir_model: add constraint on domain field · f3de712d
      Adrian Torres authored
      Previous to this commit, if one were to create an ir.model.field with a
      poorly constructed domain (read: SyntaxError), the server would properly
      send an error message stating that an Error occurred, however this would
      be too late as the registry with the bad code would have already been
      reloaded, this meant that the registry would be left in an unstable
      state (read: crashed).
      
      With this commit, a constraint on the domain is added so that we confirm
      that the code in the domain field is properly constructed, thus no need
      to reload the registry and therefore no crash.
      
      closes odoo/odoo#30157
      f3de712d
Loading