When the country is not defined on the company, there was an error when using the gcc l10n.
To fix this, we check if the country is set before going further.

closes odoo/odoo#109178

X-original-commit: 9c8dec30
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>
Signed-off-by: Heinz Robin (rhe) <rhe@odoo.com>

This commit allows to debounce the events of the RangeUserValueWidget so
that the user can use this widget with the left and right arrows without
having a lag effect (especially on the image quality option).

task-2601533

closes odoo/odoo#108850

X-original-commit: e64d0456
Signed-off-by: Bojabza Soukéina (sobo) <sobo@odoo.com>

closes odoo/odoo#109186

X-original-commit: 9461ebb1
Signed-off-by: Bruno Boi (boi) <boi@odoo.com>

This will allow to get the latest taxes.

closes odoo/odoo#109169

Task: 3111528.
Related: #84918, #107158
X-original-commit: 521c8047
Signed-off-by: William André (wan) <wan@odoo.com>

Before this commit, if the helpdesk module was installed, the title of
the salesperson data was changed from "Your contact" to "Salesperson"
for portal users. This did not add any value and the title of the tab
also became "Salesperson" which we do not want. This commit allows to
keep the title "Your contact" above the salesperson information and to
not change the tab title.

Steps to reproduce the problem fixed by this commit:
- Run Odoo enterprise with helpdesk and sales installed.
- As the admin, create a helpdesk ticket with Joel Willis (portal user)
as the customer and save.
- Click on Joel Willis, select the "Sales & Purchases" tab and set a
salesperson.

=> Log in as Joel Willis and on /my, you will have "Salesperson" as the
title of the tab. This bad behavior is due to [this commit] that added a
title above the salesperson information. But with this change the title
of the tab was also impacted. Then [this other commit] added a default
title above the salesperson information. We can be satisfied with this
default title which does not alter the title of the tab.

[this commit]: https://github.com/odoo/enterprise/commit/700e9dec4a5c9fca354e063d6a85b0514832c84c
[this other commit]: https://github.com/odoo/odoo/commit/d5c66ca1fa5d0f364241636bd502342c1d4ee9ac



opw-3103718

closes odoo/odoo#109124

X-original-commit: 1ebeec9d
Related: odoo/enterprise#35440
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

closes odoo/odoo#109155

X-original-commit: 7f62a1bc
Signed-off-by: William André (wan) <wan@odoo.com>

Current behavior:
When creating a PoS config, it is possible to have multiple cash payment
method. Wich is not supported by the PoS.

opw-3030125

closes odoo/odoo#108443

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

currently the module is named as LT, where as it has to be Lithuania according to odoo localization module standards

closes odoo/odoo#109144

X-original-commit: 5b3e9a65
Related: odoo/enterprise#35447
Signed-off-by: Laurent Smet <las@odoo.com>

Currently, there is no facility for UPI payment for the invoice.

So in this commit, there will be a QR code for UPI payment in the invoice report.

closes odoo/odoo#109069

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

Send an rich HTML email from Odoo, it lands in spam whereas it would
land in inbox in 13.0.

The problem is due to a missing "MIME-Version: 1.0" header on the email.
This header is correctly set on both the html and text alternatives of
the messages but it should be set on the enveloppe too.

The problem is present in the newer EmailMessage mail API of python that
is used since 14.0. Using the newer API, it doesn't set the header on
the enveloppe itself.

This reverts commit 8663f1e2.

opw-3098621

closes odoo/odoo#109056

X-original-commit: 04e91654
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Signed-off-by: Julien Castiaux <juc@odoo.com>

The placeholder may be too long and not fit the screen. In this
situation it would not been shown at all. Using the `text-trauncate`
bootstrap class, the end of the text is truncated with an ellipsis in
case it doesn't fit on screen.

task-id-3098157

closes odoo/odoo#108983

X-original-commit: d02c462f
Signed-off-by: Julien Castiaux <juc@odoo.com>

This PR https://github.com/odoo/odoo/pull/107553


 introduced the constraint on the change of UoM on a product template.

Restricting on the uom_id is a bit too restrictive. Instead, the restriction will be made on the uom category

opw-3039419

closes odoo/odoo#108367

X-original-commit: 44ccecb9
Signed-off-by: John Laterre (jol) <jol@odoo.com>

'State' field on stock move is indexed. Some domains on stock move state
are expressed like (state, not in, ('a', 'b', 'c')) instead of (state,
in, ('d', 'e', 'f', NULL)). The 'not in' domain won't the index and thus
will be relatively slower

closes odoo/odoo#106740

Signed-off-by: Rémy Voet <ryv@odoo.com>

in sale_mrp module, the method `get_sale_order_count` get all stock move
with created_production_id = the current production order. Without
index, this request is significantly slow.

Part-of: odoo/odoo#106740

when the vat is not configured in the company and on printing the invoice, the traceback is raised.

this is due to the calling of method _format_dotted_vat_cl that excepts the vat value as input, when the method is called without a vat value, the traceback is thrown.

add an if condition to check there is a vat configured in the company and then the  _format_dotted_vat_cl method is called only when there is a value in vat.

closes odoo/odoo#109114

X-original-commit: cadbe9e6
Signed-off-by: Josse Colpaert <jco@odoo.com>

In multi-steps receipt, when running a procurement, using "Buy" as
preferred route does not always work because the route is not
correctly configured

To reproduce the issue:
1. In Settings, enable "Multi-Step Routes"
2. Edit the warehouse:
   - Incoming: 2 steps
3. Create a product P:
    - Type: Storable
    - Vendors: a vendor V
    - Routes:
        - Manufacture
        - Buy
4. Update on hand quantity:
   - -1 at WH/Stock
5. Open the Replenishment page
   - There should be a line with 1 x P
6. Set the Preferred route to "Buy"
7. Order Once

Error: a user error is displayed "There is no Bill of Material of
type manufacture [...] Please define a Bill [...]". This is
incorrect, it should generate a PO

The problem is simple: the Buy route is composed of one rule:
- Action: Buy
- Source Location: /
- Destination Location: WH/Input

But, when running the procurement, we first look for a rule to
fulfill the need at WH/Stock. We prioritize the rules of the
preferred route, but as explained above, the route does not contain
such a rule. Therefore, we use the other routes of the product:
https://github.com/odoo/odoo/blob/ba3bb9b701a382c4052ddb57392baeee32625937/addons/stock/models/stock_rule.py#L461-L466


And, because of step 3, it then finds the manufacture rule. This is
the reason why it tries to create a MO and why an error is raised
because of the missing BoM

OPW-3006960

closes odoo/odoo#109097

X-original-commit: 1bc3d37e
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

Steps to reproduce:
1. Customer invoices
2. Upload button
3. Choose a PDF
4. The created invoice does not display the pdf preview

Related commits: a6447663 and 0ab0a92360ba1abe85d0405957d4ed6c6296f8c1

closes odoo/odoo#109108

X-original-commit: 801a80aa
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Ricardo Gomes Rodrigues (rigr) <rigr@odoo.com>

Before this commit, clicking on the social icon of an article in edit
mode opened a popup.

This popup should not open in edit mode.

task-3096813

closes odoo/odoo#108471

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Before this commit, it was possible to edit void element if they were
branded. It does not make sense to edit a void element.

task-3096813

Part-of: odoo/odoo#108471

Before this commit, the byproduct and putaway feature do not work
together. More specifically, changing the quantity to produce on a
manufacturing order will create automatically a byproduct move line (or
update the existing one with the new quantity) but never look for a
putaway rule to apply.

This commit makes use of `_set_quantity_done()` method on `stock.move`
that *do* call the putaway strategy mechanism

closes odoo/odoo#109077

Signed-off-by: Steve Van Essche <svs@odoo.com>

When editing a website form, a `search_read` request is fired on
`ir.model` model to get the list of possible form actions (create
ticket, create opportunity, etc.).
But since commit [1] in Odoo 15, non-admin users don't have read access
anymore on this model, leading to a traceback when clicking on a form in
edit mode.

Steps to reproduce (as designer):
- Install only website and login as admin
- Make "portal" user an internal user and give him "Editor and Designer"
  rights
- Login as "portal" user
- Enter edit mode on any page and drag & drop the form snippet, or
  simply go to /contactus page which already has one
- Click on the form -> Traceback

Steps to reproduce (as publisher/restricted editor):
- Install website_hr_recruitment
- Make "portal" user an internal user and give him the following rights:
  - Website: Restricted Editor
  - Recruitment: Administrator
- Login as "portal" user
- Go to a job page like /jobs/detail/experienced-developer-4
- Enter edit mode and drag & drop the form snippet
- It will crash

[1]: https://github.com/odoo/odoo/commit/5dc4cff60a557e14b08440c227423291c407899b



opw-3098097
opw-3101884

closes odoo/odoo#108680

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Steps to reproduce:

- Go to Projects app.
- Add some activities to different project (for today, overdue, future).
- Go to the activities button in the navbar.
- Search for the project activities and click in 'Today'.
- We are redirected to the kanban view of the projects without filtering

Issue:

We don't get the project filters by it's activities as it should be.

Solution:

Added the proper filters to this specific project kanban view so we can
access the filters when accesing the view.

opw-3095944

closes odoo/odoo#108067

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Current behavior:
After changing customer on the PaymentScreen, the pricelist could be
modified, but the PaymentScreen was not updated accordingly.

Steps to reproduce:
- Create 2 different products with different taxes.
- Create a pricelist with a discount on the 2 products.
- Create a coupon that apply a 100% discount on the order.
- Start a PoS session
- Add the 2 products to the order and apply the coupon.
- The order total is now 0€.
- Go on the PaymentScreen
- Change the customer
- The order should still be 0€, but it's not.

opw-3049098

closes odoo/odoo#108196

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Steps to reproduce:
- Install Odoo with demo data
- Go to Documents app
- Finance workspace
- Select a demo pdf
- Create invoice
- Error because of 'Mail Compose Message Rule'

The fix removes a non-necessary line when creating an invoice from a pdf

closes odoo/odoo#108989

X-original-commit: 60fbcaff
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
Signed-off-by: Ricardo Gomes Rodrigues (rigr) <rigr@odoo.com>

- Create a Bank journal [BNK2] with foreign currency
- Create a reconciliation model:
  * Type: Rule to suggest counterpart entry
  * Amount Type: Paid/Received
  * Auto-validate: True
  * Journals: [BNK2]
  * Label: Contains [Test]
  * Partner Is Set: False
  * Counterpart Entries:
    - Account: select an expense account
    - Amount Type: Percentage of statement line
    - Amount: 100
    - Taxes: add the 15% purchase tax
    - Tax Included in Price: True
- create a bank statement on [BNK2] with reference [Test]
- post that statement and reconcile it

Look at the resulting journal entries.
The tax amount is incorrect, and we will have an open balance.

This occurs after bc0bfde1
In version 14 counterpart amounts are by default in company currency so
we should force the currency after retrieving writeoff vals

opw-3068801

closes odoo/odoo#108960

X-original-commit: ebb25220
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

Due to hefty data the RAM limit gets exhausted.
The process gets killed due to the computed field weight on
- stock.move
- stock.picking
When installing the delivery costs module.

To solve the problem:

We add the column weight to the DB schema.

Ticket ids:
- 3013955
- 2628251
- 3028081

closes odoo/odoo#108872

X-original-commit: c354cf79
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Tiffany Chang <tic@odoo.com>

Current behavior:
Partial and reversed payment were not taken into account for the
product margin calculation.

Steps to reproduce:
1. Create a product with an common avco setup.
2. Go to purchase 1 unit at 10 dollars.
3. Upon confirming the invoice your cost is updated in the product margin
   report.
4. Create a partial payment on the bill. This creates issues as the
   product margin report is looking for paid or open not partially
   paid so it won't show up in the cost calculation.
5. Once the bill is fully paid then it shows up in the cost section
   of the product margin report again as its payment status moves to
   Paid.
6. Create a sales order for the unit at 100 dollars.
7. Invoice for the full amount then cancel it by creating a full credit
   note to put the original invoice in reversed status. This will have
   only the credit note show up in the turnover calculation as it is in
   paid status while the original invoice doesn't have a paid or open
   status so it isn't taken into account.

opw-2887240

closes odoo/odoo#100022

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

When creating the POS journal entry for a POS session (or one of its
orders when realtime inventory management is enabled), it's possible for
the stock picking to fail if a product requires a serial number or lot
id and none was provided. After the POS session is closed, this stock
picking can be corrected and the accompanying inventory valuation
entries will be created. However, when using anglo-saxon accounting, the
amount on the COGS line in the POS journal entry will be 0. That's
because the current implementation sums up the values from the stock
valuation layers to determine this amount. If the stock picking failed,
there will be no stock valuation layers so the result is 0.

In other workflows in Odoo like creating an invoice from a sales order
before the delivery is validated, the implementation deals with this
case by falling back to the standard price if no stock valuation layers
are available. This fix does the same for the POS journal entries.

opw-2988701

closes odoo/odoo#108939

X-original-commit: 4aeed49d
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Merel Geens <mege@odoo.com>

Reproduction:
1. Install Sale, Inventory
2. Go to Sale->products, search for “Customizable Desk”
3. Hover the cursor on the stat button “Sold”, from its definition, the
analysis should show the sold items in last 365 days
4. Click on the “Sold” button, no filter for “Order Date”

Reason: in V14, the “time_ranges” feature is removed. Thus using it in
the context won’t create any filter for searching

Fix: We use a custom filter to replace the time range "last_365_days".
We also make sure that the domain produced by that filter is the same as
the one used to compute the button count server side (this was not the
case in Odoo 13 when "last_365_days" was used). Similar fix is also done
in mrp and l10n_ar. Mind the utc convert for correct results.

opw-3000595

Related commits:
Removal of time_ranges: https://github.com/odoo-dev/odoo/commit/be5a51a345b8986da0e19627260f64f984e11ae9
Date filter fix: https://github.com/odoo/enterprise/pull/10938



closes odoo/odoo#108914

X-original-commit: 03057029
Signed-off-by: Mathieu Duckerts-Antoine <dam@odoo.com>
Signed-off-by: Liu Jinjiu (jili) <jili@odoo.com>

Steps to reproduce :
- Open a pos_restaurant session with Print Bill before Payment selected
- Add some products
- Print a Bill before Payment

Bug :
The receipt does not show the order date

Fix :
After that commit, the receipt shows the order date

Explanation :
The field date.localestring (that appears in the Order Receipt) is computed in the point_of_sale module for
the receipt after payment (in Payment Screen) but was not computed in the pos_restaurant for the receipt before payment

closes odoo/odoo#108516

X-original-commit: 85429ca3
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

On scanning customer barcode, POS updates pricelist, but not fiscal position.

Fix it by using method `updatePricelist`, which both updates pricelist and
fiscal position.

STEPS:

-On a customer, define a fiscal position, a price list and a barcode
-Go to the POS, in settings, define that several price lists & fiscal positions are possible
-open a session and scan your customer.

opw-3102568

closes odoo/odoo#108907

X-original-commit: 26c50f8b
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>
Signed-off-by: Ivan Elizaryev (iel) <iel@odoo.com>

Before this commit, it was not possible to have two vimeo videos playing
at the same time on the same page.
Steps to reproduce the bug:
- Drop two blocks containing an image
- Replace the two images with vimeo videos
- For each of these videos, enable the autoplay feature

=> Only one of these videos is played automatically. When you play the
other one, the first one is paused and vice versa. It is impossible to
have both videos running at the same time. This commit allows to correct
this by allowing to play several vimeo videos at the same time when they
have the autoplay feature activated. Note that if the option is not
enabled, the behavior remains similar to before, only one video can be
played at a time.

opw-3107447

closes odoo/odoo#108864

X-original-commit: 5ad43068
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Currently, odoo's mimetype guesser does not recognize SVGs with explicit
namespace.

closes odoo/odoo#108815

Signed-off-by: Julien Castiaux <juc@odoo.com>

Occasionally a rounding error can occur that returns trailing zeros and a integer on the end.
Since the values are compared, we could be comparing 2 values with a difference of 0.00000001 and end up with an error.

closes odoo/odoo#108613

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

The URLs in notes created from the systray were not transformed into links.
This solves the problem.

Task-3052952

closes odoo/odoo#108146

X-original-commit: 34b35c56
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce:
- Create default analytic rule with (account, tags; conditions: set a product and the account `400000 Product Sales`)
- create a sale order with product
- create an invoice from the sale order

Issue:
There won't be any tag set for the account_move_line

Cause:
In analytic_default rules we use fields available differently according to the scope:

Fields		sale_order	account_move
product_id	V		V
date_start	V		V
end_start	V		V
company_id	V		V
partner_id	V		V
user_id		V		V
account_id	X		V

So the rule created earlier won't be found from the sale order because we don't provide an account_id in
https://github.com/odoo/odoo/blob/15.0/addons/sale/models/sale_order_line.py#L525-L531



And since the field `analytic_tag_ids` is stored, it won't be computed during the creation of the invoice since it is already set (to `[]`).

Solution:
Set the analytic_tag_ids during the conversion from a so to an invoice  only if there is a rule for the so_line.

Note:
The change made in sale_project is to avoid getting a key that, in certain situation, does not exist anymore.

opw-3069382

closes odoo/odoo#107295

Signed-off-by: Laurent Smet <las@odoo.com>

The fix introduced in #106513 was not working in the calendar found in
the "Approvals" menu as it was trying to call a model that was only
defined in the override of the CalendarModel that this view was not
inheriting.

closes odoo/odoo#108890

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Starting from 1 January 2023, the Goods and Services Tax rate (GST) will
change and go from 7% to 8%

task-3098705

closes odoo/odoo#108727

X-original-commit: 5d696b2c
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Simon Morais Da Cunha (smdc) <smdc@odoo.com>

Drop zones are available outside form when dragging form fields.
This leads to errors whenever the field is dropped outside a form.

This commit removes all drop zones outside the form when a field is
dragged.

Steps to reproduce:
- Edit Contact Us form.
- Drag'n'drop a field to the footer.
=> Error popup (should not be allowed in the first place)

task-2855670

closes odoo/odoo#108828

X-original-commit: b74cfe75
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>