Part of https://github.com/odoo/odoo/pull/37135
task-2070507

The product count was not returned in the product page thus the search
count feature that you can enable in the customize was broken.
Now we reset the search in the product page.

Part of https://github.com/odoo/odoo/pull/37135
task-2070507

It is possible to select "System (English)" as chosen language,
or False in v12 or earlier versions.
However, if the language has not been activated,
then record_lang is an empty recordset, so record_lang.date_format is False,
(respectively time_format), and so the formatting crashes.
In principle there is a default, but it did not assume that lang could be set
but without a date_format. By slightly rewriting it, it also handles this case.

Note that if this happens, the calendar notification mechanism generates a crash
at each page load.

closes odoo/odoo#38286

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

* web_editor

The purpose is to force our dropdown style in our UI so that themes do
not break it anymore (same way all the other elements are forced (cards,
headings, etc)).

task-2059538

closes odoo/odoo#38268

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

e9350993 restored the /apps/<app> controller and introduced  a test.

Despite the test still working, the feature was broken at higher level with
19eacf7d refactoring.
Indeed, loadState was not called anymore even if state.sa existed.

Enterprise counterpart https://github.com/odoo/enterprise/pull/5974



closes odoo/odoo#38206

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Create a Project with tasks, archive it, delete it.

The project is deleted, but this should not happen:
tasks are present, but they are hidden because when the project is
archived all its tasks are archived too (active flag is set to false).
On project unlinking only active tasks are checked, thus allowing the
deletion. Using a context flag to avoid filtering the non active tasks.

opw-2080515

closes odoo/odoo#38251

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Have a lead with a partner on it, convert it to opportunity
in the conversion wizard, tick "don't link to customer"

Before this commit, the opportunity has been linked to the
lead's partner

After this commit, the opportunity is not linked to any partner

OPW 2077692

closes odoo/odoo#38202

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

rollback of 47f5a294
partial back port of 5cddbbf9

closes odoo/odoo#38218

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

.. and first menu is a container with # as url.

There is a particular case where the / url would loop endlessly.

1. Unpublished the homepage /
2. Edit the menu so the first menu is a container. There is a hint telling you
   a container menu should have its URL set to `#` as a good practice.
3. This will lead to endless loop for public user as the code will check if the
   homepage can be accessed. Since it is unpublished, it will then fallback on
   the first menu which is not '/' and redirect to it.
   Sadly, the code was not expecting `#` to be handled as `/`.

opw-2081969

closes odoo/odoo#38219

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Allows the quick create on m2o in list views

Before this commit, when entering a new value in a many2one in a list and
exiting the cell through a click, the quick-create modal appeared for the
duration of the mousedown.

Now, the modal remains and allow to edit the new many2one value

Task 2076380

closes odoo/odoo#38176

Signed-off-by: Julien Mougenot (JUM) <Arcasias@users.noreply.github.com>

before this commit: mrp work center kanban card has UI glitch in
kanban card, work center stage was overlapping kanban card right
div

after this commit: overlapping issue of work center stage will
not occur, issue was occuring due to absolute position given on
work center stage div, added margin bottom of 16px on kanban
card right div

task-2060181

closes odoo/odoo#37228

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

One2many fields can use it actually

closes odoo/odoo#25449

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#38055

X-original-commit: 1b50c056
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

backport of e2f20ffa

Ability to notify the channel but do not add the channel as a follower.
Faster than mentioning every member of the channel.

Also, clean the rendering of the mention suggestions name to avoid
having escaped char in the UI.

closes odoo/odoo#37602

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

original PR: https://github.com/odoo/odoo/pull/25801



closes odoo/odoo#38123

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

[FIX] base: fine-tuning of https://github.com/odoo/odoo/commit/a8dbbc029d1e86c84f9f2e3789e9224725143d91



Avoid error of 'user_type_readonly' referenced before assignment. This situation happen during database migration or if the module category
is deleted.

closes odoo/odoo#38110

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

Following 9878f319

closes odoo/odoo#38099

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Usecase:
- Create a route without company
- Create a push rule for company B from intercompany to stock
- Apply the push rule on product and set in on a product.
- Connect with a user in company A
- Create a move from stock(company A) to intercompany.
- Confirm the move

-> The receipt for company B is not created.

Multiple issues:
- The rule is not found because it belong to the other company and is
filtered by the record rules. -> Aplly the seach as sudo if the move
is going to a location without company.

- Record rule error because a move from intercompany to company B is
created with a user from company A that has no access to company A.
-> Search and read company values and create the move as super user.

Based on work from Simon Lejeune <sle@odoo.com>

closes odoo/odoo#38043

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

The user for the kiosk mode must have access to personal information of
the employees. To avoid easily leaking information, prevent grouping.

Fixes #34231
opw-2079330

closes odoo/odoo#38056

X-original-commit: 2b231303d23437c4dc2ec75b99248bd3667f8b4b
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Follows https://github.com/odoo/odoo/pull/35852

. More useless crawls saved.

closes odoo/odoo#37990

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Currently when inviting someone on a document all recipients are considered
as standard customers. It means access buttons are not displayed and
addon specific behavior not really triggered.

This commit makes use of ``_get_recipient_data`` tool method allowing
to categorize recipients in groups and display buttons and action links
like other post on documents.

Task ID 1967234

closes odoo/odoo#36199

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

- Go to Inventory > Configuration > Warehouse Management > Routes >
   Make To Order
- Edit
- Swap two rules with the handles
- Save

An access error is raised.

This is due to the recomputation of `route_sequence` which is performed
on all companies.

Setting it as `compute_sudo` solves the problem.

opw-2072159

closes odoo/odoo#38063

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

In some cases you may have a void attachment (datas being False) that you
try to send through the mail.mail send flow and this make crash the send
process. This commit fixes that behavior by filtering void attachments.

closes odoo/odoo#37939

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#37918

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The `image` structured data is set on the `<div>` element, therefore it
is not recognized by web crawlers. We add it to improve the SEO.

Reference: https://search.google.com/structured-data/testing-tool/



opw-2076934

closes odoo/odoo#37870

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Take the following QWeb snippet:

```
<div t-field="product.image" itemprop="image" t-options="{'widget': 'image'}"/>
```

When the image is rendered, the `itemprop="image"` remains on the
`<div>` tag, it is not set on the `<img>` tag.

We add the support of the `itemprop` option, so it can be added to the
`<img>` tag:

```
<div t-field="product.image" t-options="{'widget': 'image', 'itemprop': 'image'}"/>
```

opw-2076934

As the vat result is cleared at the end of the perior to the account 4751, there's
no sense to have these intermediate accounts with the reconcile flag, as they are
not going to be reconcile at all.

This has been also reported to be unperformant on enterprise reports where this
flag is used for obtaining the records to show.

4751 account already has the reconcile flag, and it's the one which is reconciled
on the bank reconciliation process when the fiscal authority (AEAT) charges you
the result.

closes odoo/odoo#37819

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Currently when creating an attachment in backend, history section holds
a "Creation: on" void line that is populated after create with "creation:
administator on 2019..." . This is quite ugly and not usability oriented.

Let us hide the history line while create information are not set, aka
before first save of record.

closes odoo/odoo#37907

X-original-commit: 9ef4cb3a
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

-Create a sales order.
-Add product E-COM11 (invoicing policy "Delivered quantities").
-Add Delivery method "Normal Delivery Charges".
-Confirm Sale.
-Sale Order Invoice Status = "Nothing to Invoice" (OK).
-Now Open Sales Order again in Edit mode.
-Add Choose "Add a note" in the order line section and add a random note and
don't save yet.
-Check the "Invoice Status" in the "Other Information" tab.

Before this commit:

-The status of the invoice changed to "Fully Invoiced".
-If you save the invoice with the new note, the status changes to "To Invoice".

After this commit:

The status stays "Nothing to Invoice" in both cases.

closes odoo/odoo#37757

Opw: 2078581
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Set Joel Willis (the portal user) as a vendor.
- Create a purchase order and add a line with a variant product, such as the
conference chair (aluminium).
- Confirm the order.
- Then switch user to the portal user.
- In the portal view, go to the purchase orders and select the purchase order.

Before this commit:

the product line does not show the variant, only the base name of the product.

After this commit:

the product line now shows the vendor specific product name and product code.
To set this name and code, go to the Purchase tab of the product, and add a
line for the vendor in the Vendors table, or modify the existing line for
the vendor.

closes odoo/odoo#37702

Opw: 2076962
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Install stock and purchase. Make a RFQ for just one product, coonfirm
and receive in one transfer. Click on the delivery (should be only 1).
The picking will display. Open studio, select view, activate list view.

Javascript traceback will popup. Moreover the view of the stock
module will be altered in a faulty way (can be recovered from "Window
Actions", looking for the stock.picking action with external id
"stock.action_picking_tree_all" and removing the last added tree from
"View Mode").

This is caused by studio not detecting all the active views, thus giving
the possibility to add an already active view, because when there is just
one picking all other views are filtered out.
Changing the way the form view is retrieved in case of a single picking
fix the issue.

opw-2076241

closes odoo/odoo#37582

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Small improvement in order to not trigger twice the write
function on state

close #34884

closes odoo/odoo#38032

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Have a partner with an invoice address

Create an vendor bill for the partner of type invoice
(which is a child of the main partner)

Go onto the list view, select the invoice and click
on action > register payments

Before this commit, the payment had the commercial partner id as its partner

After this commit, the partner of type invoice is choosen
This is consistent with what is done when clicking on the "Register payment"
button on a single invoice

OPW 2079691

closes odoo/odoo#37974

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

Backport of 64f6e50d, with a test!

Closes #27109

Purpose
=======

If the model on a reference fields is not modified from the interface
by the user but by the server, the selection is not correctly
recomputed on the interface.

Specification
=============

By calling super first on the '_reset' method, the new model
is taken into account when resetting the selection.

closes odoo/odoo#37900

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Open a search view modal ("search more" on a m2o)
Select a filter that will make records fall to zero
The modal will shrink
Trigger the opening of a dropdown (Filters), and make sure
that there are many many menu items there (many filters)

Before this commit, the dropdown was bigger than the modal
which had a scroll bar,
however, the dropdown itself was not scrollable properly
So, clicking in it to select a menu item will fail when scrolled
all the way down, because elements did not actually followed the scroll

After this commit, the dropdown follows the scroll, and it is possible
to use it even way down

We use a behavior of bootstrap 4 itself:
FIX: https://github.com/twbs/bootstrap/pull/24976
ISSUE: https://github.com/twbs/bootstrap/issues/24251



OPW 2076337

closes odoo/odoo#37594

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

Before this commit, when creating an event without setting the company,
an error 500 is raised, this arises because the pricelist is not found,
it depends on the company.

Now, the company field is mandatory and the pricelist is reachable.

opw-2079246

closes odoo/odoo#37975

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

The feature that allows res.lang's first day of week parameter
to be the reference point of web calendar
has been introduced at 27b30dae
A few other came on top of it to fix a few things

Before this current commit though, only Fullcalendar was
rendered using that initial value, nothing was done
to actually fetch the right data

After this current commit, we fetch data from the server
according to the range displayed by the calendar

OPW 2072872

closes odoo/odoo#37202

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

Some barcodes nomenclatures and rules are added in the modules that use
the barcode module. We should set them in no update to avoid loosing
modifications when the module is updated.

closes odoo/odoo#37971

X-original-commit: c4251c1c
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

When is created a refund from a invoice, the payment term its cleans,
but not the date due.

In the next case:
1. Create an invoice with date 05/26/2019, with payment term "30 days".
2. Create an invoice refund for invoice in 1, with the same date.

In this case, the payment term in the refund is empty, but the date_due
is the same that in the invoice.

With this change, the date due in the refund is the same that invoice
date.

closes odoo/odoo#37932

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>