* LDAP import: python-ldap is not python3-compatible, pyldap is

  Warning: only supported from debian Stretch (current testing)?
  https://packages.debian.org/search?searchon=names&keywords=pyldap

* implicitly relative imports
* imports of moved or removed stdlib modules

issue #8530

When switching between records, the active tab of the previous
record is made active on the new record.

However, before this rev., this was done without checking that
this tab is still visible on the new record (there may be an
invisible attrs that makes it invisible), so it happened that
the active tab was actually invisible.

This was for instance the case when switching between stock
pickings, as the first tab ('Operations') is sometimes hidden.

This commit actually fixes a few problems:

1. the _visitChildren method in the basic model was not following the
changes, only the data, so it was not correct (for example, the isDirty
method was wrong for relational data, when no other change was done)

2. new records could not be discarded, because they had no data in their
data key. What we do here is to add a savePoint, so it is safe to
restore them (it caused a crash)

3. the save method was not properly following children when it was
called with the option savePoint=true

4. when the user tried to discard a form view, in an action with only a
form view, it was redirected to the previous url (via the history_back
action), instead of simply discarding the current form view

We changed the field on which 'My requests' filter is applied from
'owner_user_id' to 'technician_user_id' because a normal employee who
has requests only see the ones he owns, and the responsible of
requests should be able to easily see the ones he's assigned to.

As the reporting on maintenances by team is already available through a
filter on requests and just show the pivot view, we added the the menu
item 'Reporting' and a link in kaban record of maintenance team to
redirect to the pivot view.

This commit modify the kanban card for maintenance requests/team:
For maintenance request:
Kanban view:
- Move the star priority from right to left
- Add the text 'request by' before the field owner_user_id
- Add the field for the technician with the text 'responsible'
- The image is the responsible and not the owner anymore
Forw view:
- Change the label for name from 'Subject' to 'Name'
- Change the placeholder for name from 'Maintenance Subject' to 'Maintenance Request'
- Request date field is read only and set to the date where the request is created
- Close date is read only and set when the request is in a done state
- Category is invisible if the related equipment has no category.
- Disable creation and opening maintenance team from the form view.
For maintenance team (dashboard):
- To Do button filter requests on their state
- Team name link to maintenance requests belonging to the corresponding team

Technically, there are just basic changes in the view.

This commit changes the maintenance team:
-In the form view -> replace Category name by Team name
-Replace the partner by a many2many with users
-Display the from view instead of editable list view of teams

In the model, the partner field is replaced by member_ids.
However this field is never used except in the form view.

The feature added is a count of todo request that has no schedule date.
It will also add a link in the team dashboard that redirect to all
mainenance requests without a scheduled date.

The count is computed in the existing function '_compute_todo_requests'.
It will count requests that are not done and have no scheduled date.

This commit also modify the view and add the default filter 'unscheduled'
(created by a previous commit) for the action
'hr_equipment_todo_request_action_from_dashboard' which opens the maintenance
request for the active team.

This commit add the following feature :
Add the responsible and the owner of the maintenance request as
follower.

This commit creates a new method that adds as follower the responsible and/or
the owner. This method is triggered in the create and in the write if they
are modified.

It will not remove old responsible or owner from the chatter.

This widget behaviour hadn't correctly implemented with the new views.
This commit also introduces some tests.

This field widget has been adapted to the new views.
This commit also introduces some tests.

This field widget has been adapted to the new views.
This commit also introduces some tests.

When fetching record, `bin_size` needs to be passed in the context
to notify the server to send the `bin_size` and not the whole base64
of binary fields.

This widget behaviour hadn't been correctly implemented with the new views.
This commit also introduces some tests.

`session` is not an field widget attribute anymore.
One should use `getSession` instead.

This commit also introduces tests for the `binary` field.

This key has been renamed `supportedFieldTypes` since the new views
but has been wrongly forward-ported in 2e540eb3.

The callback function of `execute_action` is called `on_closed` (and not
`on_close` as previously written).

... function to ease extensions and overrides (especially, an
override in web_enterprise).

Before this rev., if concurrent calls to 'read_follower' were
performed, it might happen that the read followers appearead twice
in the follower dropdown.

This was for example the case when validating an invoice: the
customer was listed twice as follower.

Note: in this particular case, the record shouldn't be reloaded
twice: this is another bug to adress.

Moves back the mobile rendering part of the FieldStatus to
enterprise, alongside all other tweaks to improve the UX in mobile.

This part had been moved to community inadvertendly in the new
views branch.

Oversight of python3 compat changes made at 2e6a589f

Like product categories.

This commit proposes to store the complete name of a product category.
It is formatted like parent.name / name, recursively. Storing it and
using it as a rec_name allows to search products belonging to a category
or its child categories without having to rely on a strange hack of
name_get and name_search.

Searching on products having a category containing "all" will get results
from "all" category as well as "all / saleable", and so on.

The sequence set by function next_by_code for a company must be
either defined for this company or witn company specified on it.
In the other cases, the sequence "NEW" is used.
With courtesy of @odony

opw:728554

Yes, it makes sense

* Reverse wrapper courtesy of @rco-odoo's original P3 branch
* thin compat module stripped down from werkzeug (to augment as needed)

issue 8530

Critical improvement, 
`:)` was making a laughing guy that could be considered as mockery.
This smiley is way more friendly and should improve support feedback by at
least an order of magnitude better, maybe two.

Closes #16672

Oversight of previous forward-port.

This commit merges various usability and business flow improvements
in time tracking application. Please refer to under-commits for more
details. Main changes are

 * simplify user experience when logging timesheets through UX, filters
   and menus improvements
 * log timesheets on employees instead of users

All tribute goes to @jem-odoo .

Sale module now installs sale_timesheet module and not its auto-install
enterprise bridge. It seems more intuitive to installe real applications
and let bridges automatically install themselves.

Some wording is also improved to ease user experience through the various
timesheet related blocks of settings.

This commits mainly switches the semantic of timesheeting from users
to employees. Main points of this commit are :

 * add an employee_id field on timesheet;
 * replace user_id field by employee_id on timesheet views;
 * provide a stat button on employee form view to access its timesheets;
 * use timesheet cost as a real monetary field and handle currency
   conversion;

The purpose is to allow timesheet manager to record timesheet for
employees that are not users. All employees do not necessarily have an
user account in the system. Now you can record timesheet for your employee.
Hooray !

In sale_timesheet timesheet_cost is now a monetary field. Currency convertion
is also better taken into account when computing UPDATE ME

Timesheet details

 * add an invisible timesheet group on employee form view allowing to
   hook on it. Indeed sale_timesheet and timesheet_grid modules override
   this view to add information but have no other common module that
   hr_timesheet. Using an invisible group set as visible in those modules
   eases inheritance.

Sale timesheet details

 * timesheet_cost is now a monetary field
 * better display of timesheet_cost on employee form view, notably telling
   it is per hour
 * remove account_id field on employee as its only use was buggy and was
   mixing account.account and analytic.account records.

Purpose of timesheet module is to track user time. This commit applies
various improvements and tweaking to better reflect this purpose.

This commit provides some UI improvements

 * improve views : user_id field is not displayed on 'My Timesheet'
   action, since it will always be the same user;
 * simplify menus : 'My timesheet' only for current user's timesheets
   and 'All timesheet' for everyone's. The latter one allows creating
   timesheets for someone else, if you have the required access rights;
 * add calendar views for timesheets
 * some filters are added to ease time-based filtering of timesheets

This commit also reorganizes user groups. Groups are now

 * new 'timesheet user' group (different from base.group_employee). Users
   can record their own timesheet. New access rights were added to perform
   the same operations as before.
 * 'timesheet manager' (hr_timesheet.group_manager). Users can record
   timesheets for other users, access to settings and reporting tools.

This commit removes document count on project kanban view. Indeed it
does not add much valuable information and bloats the kanban cards.

In order to keep the kanban card order, it was required to adapt all
inherited views. The order is 'task', 'issue', 'rating', 'timesheet'
and 'forecast'.

It also uses a read_group to better compute task count, by the way.