Steps to reproduce:
-------------------
- create a stage without selecting a project.

Issue:
------
The new stage is inaccessible.

Cause:
------
When the project is not defined, the following ORM command is used:
`[6, False, []]` for the `project_ids` field.

Solution:
---------
When we create a project stage (project task type),
it is essential that we link it to a project.
Add the possibility to override `_get_default_project_ids`.
Set default project as first fsm project if not project in
the context.

opw-3322992

closes odoo/odoo#125318

Related: odoo/enterprise#42529
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

We have introduced a new tag `website_nightly` which is linked to a
custom build on the nightly.
It has been introduced with this commit [1].

The goal is to extract the `external` tagged tests linked to the website
app to another special build linked to the website team.
Otherwise, we would not see when the test fail, as the `external` build
of the nightly is always red and we don't check why all the time.

Encapsulating this in a new build and linking to our team means that
whenever the test fail in a nightly, we will be visually warned on the
runbot homepage by a red warning, see screenshot on the PR of this
commit.

Sadly, before 16.4, as there is not yet `website_nightly` tours, the
build is considered failed, showing the error.
Another solution would have been to somehow disable this tour on Odoo
versions < 16.4 but it we opted for this solution as:
- It's simpler, no need to add yet another custom stuff in runbot
- It will work out of the box should be introduce such a test in those
  versions: we won't need to ask runbot to activate the test in another
  version, should we even think about it..

[1]: https://github.com/odoo/odoo/commit/a0d0afb20594aa103eb1d0476d53012b9821e861



closes odoo/odoo#125676

X-original-commit: 231a7d63
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Before this commit:
When importing `stock.quant` with two lines with the same product and
different counted quantities, only the last line is taken.

After this commit:
Each line creates a `stock.quant`, even if a similar Quant exists.
The records will be merged at a later time by `_merge_quants`.

Steps to reproduce:
1. Create a storable product
2. Go to Inventory > Operations > Inventory Adjustments
3. Create a file with two lines with the same product,
    and different counted quantities
5. Favourites > Import Records & upload the file

OPW-3340017

closes odoo/odoo#124185

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Prior to this commit, when using the "Slide Hover" reveal effect on the
footer, Safari would glitch it scrolls and could result in unreadable
content.

This commit fixes this by a weird hack that seems to work. Adding an
element with a background-image and a background-attachment set to
fixed seems to resolve the issue.

task-3302302

closes odoo/odoo#125229

X-original-commit: a6307448
Signed-off-by: Dieleman Guillaume (gdi) <gdi@odoo.com>

In width and height attributes, the "px" unit is implicit. In some cases
we introduced it explicitly, which is unexpected.

closes odoo/odoo#125146

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Since Bootstrap responsive behavior can't be guaranteed, we have to make
sure that images that didn't keep their original dimensions preserve
their aspect ratio. This can be achieved with the `object-fit: cover`
CSS property. We apply this on images that are not responsive and that
are alone in a div because these are the ones at risk.

opw-3244705
task-3334591

Part-of: odoo/odoo#125146

This addresses a series of issues regarding images, their responsive
behavior and their alignment.

This is a partial backport of commit [1] from 16.0.

[1]: https://github.com/odoo/odoo/commit/25f63ecdc89cfabe07f0348c1dc5c830aeed7cca

Part-of: odoo/odoo#125146

Since flexbox is not well supported in e-mails, the Bootstrap grids
don't stack. This means that the .img-fluid images have to adapt to
columns that are smaller than what they were designed for. We remove the
dimensions on the images to let .img-fluid images resize percentually.

Part-of: odoo/odoo#125146

Outlook needs explicit dimensions for images, which .img-fluid - by
design - doesn't provide. This puts them in mso conditionals with said
dimensions for Outlook.

This is a backport of commit [1] from 16.0.

[1]: https://github.com/odoo/odoo/commit/dba3259adedb12a81591bd2aff19ce676a1c698c

Part-of: odoo/odoo#125146

The `_wrap` util function of `convert_inline` was not checking if
`className` and `style` were defined before adding them to the wrapper
element, leading to things like `<div class="undefined">element</div>`.

This is a backport of commit [1] from 16.0.

[1]: https://github.com/odoo/odoo/commit/ac8aa12125063aae6ef7357827f3763732440ae0

Part-of: odoo/odoo#125146

Firefox doesn't seem to do well with sibling tables, so we need to
wrap them each in separate rows.

This is a backport of commit [1] from 16.0.

[1]: https://github.com/odoo/odoo/commit/3759a83773ac7a3d7ff004cbe54823ab90c56b64

Part-of: odoo/odoo#125146

Bootstrap rows have negative left and right margins, which are not
supported by GMail and Outlook. Sometimes we use padding on columns to
undo the negative margins of their child rows. This corrects these.

This is a backport of commit [1] from 16.0.

[1]: https://github.com/odoo/odoo/commit/b730483f6fd0895241516f032befa8db606b6ba1

Part-of: odoo/odoo#125146

This addresses a series of alignment issues in the conversion of html.
This is a backport of commit [1] from 16.0.

[1]: https://github.com/odoo/odoo/commit/54fa22007094e13f2d229c42195191d224517617

Part-of: odoo/odoo#125146

Bootstrap grid media queries were only inlined from the xl breakpoint
and up, but the snippets typically use the lg breakpoint.

Part-of: odoo/odoo#125146

A call to `setProperty` failed silently, making it so the height was
never set on certain rows.

Part-of: odoo/odoo#125146

To reproduce:
1. Create a Sales Order for a product whose product category is set to
   FIFO and automated. Use route "dropship".
2. Confirm the PO created.
3. Deliver the products (DS transfer)
4. Create the customer invoice
5. Return, for example, 1 unit of product
6. Add a credit note to the invoice for that 1 unit returned (reset to
   draft then change qty and post)
Issues:
The value on the valuation layers of the returned picking is 0, posted
entries for COGS and stock interim (delivered) account for credit note
is also 0.

Since #85751, When create valuation layer for return, we take all svls
of origin_returned_move_id into account to calculate the price unit.
However, then dropshiping, 2 svls are created for the original move, and
the sum of them is 0 since there is no impact of the stock when
dropshiping. So when return, the price unit will be calculated as 0.

To fix, when calculate price unit for return of dropshiping, we only
take non-negative svls into account. Note that we use non-negative ones
instead of positive ones because when subcontract dropshiping,
additional negative svls will be added for the cost of the components.

opw-3283436

closes odoo/odoo#124655

X-original-commit: 3b88958f
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

After preventing "async" code on link tools update in [1], the
`'link_tools'` test is still failing because of another race condition
issue:

The click on "save" after setting the link style to secondary triggers
an event handler that destroys the link tools widget (see `Wysiwyg` >
`destroyLinkTools()`), leading to calling the `_removeHintClasses()`
method first (both `_addHintClasses()` and `_removeHintClasses()` will
disable the editor observer while adding / removing the link hint
class to prevent their mutations to be recorded...).

Since the observer is inactive, the changes made to the link using the
link tools will not be processed, and the block will not be set as
`.o_dirty`.

As mentioned previously, (and starting from [2]) the editor observer is
inactive (while handling the `.oe_edited_link` class) in order to
prevent recording the mutations... But since [3], the editor had the
ability to prevent some classes (including `.oe_edited_link`) from being
taken into consideration in the `filterMutationRecords()` method...

The goal of this commit is to fix this race condition issue by simply
keeping the observer activated while handling the link hint class...

Remarks:

- These changes are supposed to fix the `link_tools` test that fails on
16.0+, but 15.0 was targeted here since the `.oe_edited_link` class is
ignored by the editor starting from 15.0 and also to prevent any future
issue linked to disabling the observer...

- Adding and removing the `active` class should not affect the history,
since it targets the `linktTools` toolbar button...

[1]: https://github.com/odoo/odoo/pull/109250/commits/f42715fdc89a6a88446c5f88ecec29e6a9c96fe1
[2]: https://github.com/odoo/odoo/pull/90064/commits/26377710a6e3ad61a8c266e9f7c0b8ade98f657d
[3]: https://github.com/odoo/odoo/commit/1c25ddb42393b136cac2a0ee0b9b7280fd803e7d



runbot-18747

closes odoo/odoo#121622

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Use case:
It happens that a product is consumed in different operations.
So it needs two distinct BoM lines. Since commit [1] the stock.move
in pbm are not merged. However [1] was design for kit.
In our case we would like to have only one stock.move for all the
quantities.

The fix is not perfect because it won't work if we confirm at the
same time a move with a kit and without it. But at least it will let
people using MO without kit has the correct behavior

+ remove a duplicate of the function

[1] commit 741d2fe9

closes odoo/odoo#122682

X-original-commit: 07b192b8
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

'replace() argument 1 must be str, not bool' is generated if the user edit a
float or monetary section in the website view.

Steps to Reproduce

- Make debugger mode ON.
- Go to Settings > Translations > Languages.
- Remove the value of the 'Thousands Separator' field from the current user
language.
- Install the 'eCommerce' module.
- Go to the website.
- Go to the shop menu, and click any product from the product list.
- Click on the Edit button and try to edit any float or
monetary section like a product price (eg. change a product price from 750 to
70) and click on the Save button.

And traceback will be generated.

Applying this commit will resolve this issue.

sentry-4148693017

closes odoo/odoo#125634

X-original-commit: b895175c
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

The values for the key "async" found in some services is used to declare
async methods that should be "protected". The hook "useService" makes sure
that no code used to process results of those protected methods is
executed by a destroyed component. The orm method "webSearchRead" was
not protected due to a "typo".

closes odoo/odoo#125621

Signed-off-by: Géry Debongnie <ged@odoo.com>

When you add items in the cart it always show the number of available left in stock of the previous state for example :
1- cart is empty it shows 20 items
2- add one into cart - it shows 20 items left in stock (should be 19)
3- add another one into cart - it show 19 items left in stock (should be 18)

Steps to reproduce the error :
1 - Go to one of the product and make sure that it has some available quantity
2 - Go to sale configuration on the product and remove "out-of-stock : continue selling" and add show available qty only if below 5000 for example
3 - Go the web page of the product and try to add some items into the cart you will see that the stock message is wrong

The origin of the problem is that when we have optional products activated , it will launch a product configurator modal. After posting the update in the database there is no call to the function that updates the stock message.

opw-3341377

closes odoo/odoo#124164

Signed-off-by: Mahdi Cheikh Rouhou (macr) <macr@odoo.com>

With the introduction of our l10n_sa_edi module we are able to send invoices to ZATCA,
in this commit we are forcing the invoicing of every PoS order in order to send a simplified
invoice for each PoS order.
add a fallback for l10n_sa_edi for invoice_payment_means
This commit is to add a fallback ('unknown') incase _l10n_sa_get_payment_means_code
returns value not considered

closes odoo/odoo#124300

Signed-off-by: Josse Colpaert <jco@odoo.com>

Let us consider the search arch

    <search>
        <field name="foo"/>
        <searchpanel>
            <field name="bar"/>
        </searchpanel>
    </search>

The two tags "field" are supposed to generate different objects:
 - the first one should generate an entry in the search bar autocompletion
 - the second one should generate a search panel section.

It turns out that the second field did also generate an entry in the
search bar. This is of course wrong. We fix that problem and add a test.

closes odoo/odoo#125541

Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>

By RPC an other user in other company can access to an other fec.

closes odoo/odoo#125367

X-original-commit: 857f2e02
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

This reverts commit 7b433492.

There is a legal requirement in Switzerland that justifies ignoring
the generic `display_qr_code` field.

Confirmed with an accounting PO.

closes odoo/odoo#125441

X-original-commit: 3dbbdd7b
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

closes odoo/odoo#125323

X-original-commit: 813142a4
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Yolann Sabaux (yosa) <yosa@odoo.com>

Adding base translation files for l10n_sa_edi as well as arabic translation

closes odoo/odoo#125201

Signed-off-by: Josse Colpaert <jco@odoo.com>

On the Blanket Order PDF (as well as other purchase agreements), the
vendor isn't specified on the report while it is a required and
significative field on the purchase agreement.
Added it like in the purchase order PDF.

Also added in the Custom Description field into the PDF as it may
contain useful information as well.

Task-3358385

closes odoo/odoo#125014

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

This commit improves the performance of `_is_applicable_for`, by:

1) Leveraging the `product.category.parent_path` field.
2) Use `applied_on` for the `if` conditions, which is ~100% faster than using
   the many2one fields due to the related record initialization.

These micro-optimizations are important because of the way `_is_applicable_for`
is used.

See: https://github.com/odoo/odoo/blob/0a5d84289/addons/product/models/product_pricelist.py#L169-L193



Which, for demostration purposes, could be simplified to:

```
for product, qty, partner in products_qty_partner:
    for rule in items:
        if not rule._is_applicable_for(product, qty_in_product_uom):
            continue
```

On a database with 470 products, and about the same number of pricelist items,
these optimization result in a ~30% speedup when computing prices for all
products at once. It may be even better depending on how many nested product
categories are used in the database and in the pricelist rules.

closes odoo/odoo#124376

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Ever since iOS 16.4, going back and forth through a website with the
cache enabled, creates an error in the console which Odoo tries to
handle but fails to do so. Therefor a generic CORS error message
appears.

There is unfortunately no proper way to fix this bug on our end so
instead, this commit tries to mitigate the error by returning early and
not showing the traceback dialog.

I (ARD) have submitted a feedback through Apple's Feedback Assistant app
and will subsequently remove this commit when Apple releases an update
that fixes this.

opw-3281727

closes odoo/odoo#125265

X-original-commit: 19e484b6
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

create a vendor Bill
attach the PDF
go back to list view, select the bill > print Original Bills

Issue: a traceback is raised
Similar to f814c607
In some malformed PDF files zlib is unable to extract the data properly.

opw-3368907

closes odoo/odoo#125377

Signed-off-by: John Laterre (jol) <jol@odoo.com>

When updating taxes, all taxes are correctly created but the link
between children taxes and their parent was not correctly set.

opw-3347425 (1st issue)

closes odoo/odoo#124778

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Since [1] an error is raised when switching the Mode of an Images Wall
from Float to Grid or Masonry while an image is selected.
The display of the size of the image is being updated while its option
panel is not there anymore.

This commit prevents this error from happening by checking if the
`.data('$optionsSection')` hack (as stated when it was introduced in
[2]) is available before trying to use it.

Steps to reproduce:
- Drop an Images Wall snippet.
- Switch Mode to Float.
- Select an image.
- Switch Mode to Grid.

=> Traceback.

[1]: https://github.com/odoo/odoo/commit/2cbb691a84ce186ddd34a2a4c76d95671ed6e834
[2]: https://github.com/odoo/odoo/commit/5ac6a7a5dbd2af1190d0d027d0239dd1cfc257b0



task-2990053

closes odoo/odoo#119156

Signed-off-by: Vray Benjamin (bvr) <bvr@odoo.com>

It turns out `instanceof` is wonky in Firefox when multiple
documents are involved (e.g. iframe) since [1] has been fixed
and [2] has not yet been addressed accordingly.
Because of that, the check at [3] will return false and
therefore `getReference` will be a Node rather than a Function,
thus triggering the traceback.

**Solution**
Check if `reference` is typeof 'function' instead, which will not fall into the Firefox trap.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1360715
[2]: https://bugzilla.mozilla.org/show_bug.cgi?id=1821790
[3]: https://github.com/odoo/odoo/pull/73130/commits/a9614e0babd6dc517287d547708a8be758c14e12#diff-86a5774240db76cdc93cb570596564cc6816ef4144a7c960f10cd347b7564e44R220



opw-3348172

closes odoo/odoo#125249

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Current behavior:
When you refund a downpayment in the PoS, the downpayment is not added
to the original order.

Steps to reproduce:
- Create an order in the sales app
- Open the PoS and make a downpayment for the order
- Refund the downpayment you just made
- Go back to the original order in the sales app, the downpayment is
  correctly added, but the refund of the downpayment is not added.
- The order should contain : The original product, the downpayment and
  the refund of the downpayment.

opw-3275708

closes odoo/odoo#121160

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Issue: the xml declaration "<?xml version='1.0' encoding='UTF-8'?>" is
lost when opening the send & print wizard with existing xml attachments.

Explanation: When opening the send and print wizard, the PDF are
generated and postprocessed by `_postprocess_pdf_report`. In the
`_postprocess_pdf_report` override in `account_edi_ubl_cii`, the xml
attachments are parsed through `tree = etree.fromstring(xml)`, then the
base64 PDF is inserted, and the etree is converted to a bytes through
`etree.tostring(cleanup_xml_node(tree))` and the resulting bytes is
written back on the attachment, but the xml declaration disappeared.

Solution: include the arguments `xml_declaration=True, encoding='UTF-8'`
in the `tostring` function when converting the etree to a bytes.

opw-3144519

closes odoo/odoo#125266

X-original-commit: d89f5cb2
Signed-off-by: Laurent Smet <las@odoo.com>

When creating an invoice with a positive line and a negative line, with
different taxes, the DatiRiepilogo node for the tax of the negative
line contained positive amounts when they should be negative.

This is because we were applying `abs()` too naively in the XML template
and in the code of _l10n_it_edi_prepare_fatturapa_tax_details.

This bugfix commit changes the logic to no longer use abs().

We also include a test to check that the XML is correctly generated for
credit notes.

Back-port of #121933

opw-3316300

closes odoo/odoo#125198

X-original-commit: 17f336e4
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Antoine Dupuis (andu) <andu@odoo.com>

The cause of the issue is that `datetimepicker('viewDate')` will return
the datetime of today by default event if the user selects nothing, to
remedy this, we now check if the user has chosen something before
storing the content of the field in `form_values`.

Step to reproduce:
- Install website_crm_partner_assign to have the "Partnership Date"
  field on res.partner.
- Install website_sale to have the "Create customer" capability on the
  website forms.
- Drag & drop a form snippet on any page
- Select "Create customer" as form action
- Add a custom field "Partnership Date"
- Submit the form without filling the Partnership Date field
- The field will be set to today's date while it should have been left
  void.

opw-3333364

closes odoo/odoo#124548

X-original-commit: a2a49579
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

This commit will have nested components making use of
the usePosition hook to synchronize their repositioning.

**Before this commit**
Each component handles its own repositioning logic.
If it is mounted somehow inside another component using that
same logic, conflicts occur in some circumstances.

**After this commit**
It is now ensured that, in case of nested positioned components,
the whole chain of repositioning computations is called in the
proper order: from the parent to the children.

**Example**
- Before
  ![before]
- After
  ![after]

[before]: https://github.com/odoo/odoo/assets/1159815/3c9cfae7-db68-4707-a73c-ad7e2e71d4bf
[after]: https://github.com/odoo/odoo/assets/1159815/a21f56e0-d8e3-48c1-9509-8e6ee5040d4b



closes odoo/odoo#125048

Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>