Skip to content
Snippets Groups Projects
  1. Dec 16, 2015
  2. Dec 15, 2015
    • Denis Ledoux's avatar
      [FIX] payment, website_sale: condition to recreate a payment transaction · cb9d7982
      Denis Ledoux authored
      Before this revision, in the ecommerce,
      a new payment transaction was created only
      when the transaction reference was different than
      the order number, meaning that the transaction id
      in the user session no longer refers to the current order,
      that the user created a new order which has nothing
      to do with the transaction he has in his session
      variable `sale_transaction_id`
      
      This made sense when the transaction reference
      strictly matched the order number, but,
      since f89e8f9d,
      this is possible that a payment transaction reference
      number no longer strictly matches its order number,
      as the transaction reference can contain `-1`, `-2`
      at the end of its reference, meaning there was
      already another transaction existing with the sale
      order number as reference. But the transaction
      is still about this order.
      
      Therefore, from this revision, the condition on
      which a new transaction has to be created
      should no longer be based on the transaction
      reference, but to which `sale_order_id` the transaction belongs.
      
      In addition, we add two more conditions for which a new transaction
      should be created:
       - The transaction has been cancelled or in error
       - The acquirer has changed.
      
      For the second case, this is to handle a corner case:
       - The user selects one payment acquirer (Ogone), then click
         on "Pay now", and is therefore redirected to the payment provider website (Ogone)
       - Then, the user opens a new browser tab on the ecommerce, on his cart,
         choose another payment provider (Paypal), then click "Pay now" and is
         redirected to this second payment provider website  (Paypal),
       - Then, the user comes back on the first tab, on which he is on the first
         provider website (ogone), and pays/validate the payment
       - Then, we receive the payment feedback (either from the user/DPN, either from
         the server to server call/IPN)
      
      Before this revision, this use case would have lead to the feedback from the first
      provider (`/payment/ogone/accept`) while the transaction is set with the second
      payment provider (`Paypal`), therefore breaking the payment validation.
      
      Creating a new transaction when the user changes of payment provider solves this issue.
      He will nevertheless be able to pay twice, on each provider, but it was
      already the case before.
      
      opw-659294
      cb9d7982
    • Olivier Dony's avatar
      Revert "[FIX] web: Can't save a x2m in list editable if contains a m2m_tags with a color field" · b4949f75
      Olivier Dony authored
      Reverted because it causes issue #10083 when serializing
      nexted x2many values, and produces invalid x2many commands,
      such as:
      
          `[[6, false, [[5, false, false], [6, false, [8]]]]]`
      
      Pending a proper fix for the oririginal issue.
      
      This reverts commit 7e2628ae.
      
      Closes #10083
      b4949f75
    • David Monjoie's avatar
      [FIX] mass_mailing: added missing models in form view · fda5021e
      David Monjoie authored
      In 9.0, we created a simplified form view for mail templates, in
      which the model_id field is retricted to show only the models for
      which mass mailing makes sense. However, two of those models were
      forgotten. There should have been some sort of override in their
      respective modules, but considering the nature of the domain
      attributes, there is no easy way to write such overrides, which is
      probably why there wasn't any override to begin with. We decided
      with tde and al to just add these models in mass_mailing, thus
      breaking module abstraction, but avoiding a very complex override
      mechanism for a rather simple case like this.
      fda5021e
    • Goffin Simon's avatar
      [FIX] purchase: _default_picking_type · cd5638ef
      Goffin Simon authored
      The function "_default_picking_type" must return a browse record.
      cd5638ef
    • Christophe Matthieu's avatar
    • Christophe Matthieu's avatar
      [FIX] web_editor: help the user to edit the link · f3f7bd9f
      Christophe Matthieu authored
      User can't edit the first and last chars of a link (same issue for a lot of editors), and users don't want to click on edit link button in the editor bar.
      When the user click (not if the user use arrow) on a link the link is activate with a content editable true and can edit the first and last chars.
      
      opw: 654280
      f3f7bd9f
    • Yenthe's avatar
      [FIX] Scaffold according to new module structure · 8e81abfe
      Yenthe authored
      fixes #10074
      8e81abfe
    • Aaron Bohy's avatar
      [FIX] mail: various ui improvements/fixes · 17896a92
      Aaron Bohy authored
      * chat windows:
        - input was kicked out of the window on chrome 43
        - don't animate if folded by default (e.g. after a refresh)
        - width and height 100% like in the frontend
        - z-index to make sure that they are over bootstrap active btn,
          but below notifications, and modals
      
      * chatter:
        - internal note: send button renammed to 'Log'
        - send button is the first button again
        - remove annoying form view widget's tooltip
      
      * client action: focus on composer on channel change
      17896a92
    • Aaron Bohy's avatar
      [FIX] im_livechat: various fixes · 1029571c
      Aaron Bohy authored
      - Don't display livechat button if no operator available
      - Livechat windows persistence through website pages
      - Auto popup feature re-introduced (inadvertently removed at rev. f23f57cc)
      - Operators that are 'away' are available, as 'away' means that the focus isn't
        on the Odoo tab for at least 10 minutes, but the user is still connected.
      - Avoid duplicated messages when the visitor is a connected user
      - Unfold livechat window on first 'close' click as the event is intercepted to
        ask the user feedback before actually closing the window
      1029571c
  3. Dec 14, 2015
    • Denis Ledoux's avatar
      [FIX] portal: portal access management for partners having users · 11911fe0
      Denis Ledoux authored
      When the partner already had a user,
      checking `in_portal` of this partner and applying
      the wizard raised the fact there was already a duplicated
      user for this email, even if there wasn't.
      
      This is because the system relied on the fact
      the field `user_id` of the `portal.wizard.user`
      was automatically filled with the partner user if
      there was one, but it was not the case:
      This `user_id` field is a simple many2one field,
      not computed, and the assignation was done nowhere
      when the partner already had a user.
      
      The assignation should be done in the `onchange_portal_id` method
      of the `portal.wizard` model, like the other fields
      `partner_id`, `email` and `in_portal`,
      but if we do it know, as the `user_id` field is not
      in the view (not even in `invisible`), the
      web client will ignore it even if returned by
      this `onchange_portal_id` method. It was therefore pointless
      to solve this issue by adding the correct `user_id`
      in the `user_ids` returned by this onchange method.
      
      We could add `user_id` in invisible in the view,
      but existing databases with the current view
      will not benefit of the bug fix without updating the according view.
      
      This revision therefore replaces `wizard.user_id` by
      `wizard.partner_ids.user_ids[0]` everywhere where it's needed to
      know if the partner already has a user or not.
      
      Besides, it takes care about the fact his user could
      be disabled (`active` False).
      
      opw-659339
      11911fe0
    • Thibault Delavallée's avatar
      [FIX] rating: reuse ratings from the same customer · 7a3ad6ba
      Thibault Delavallée authored
      Otherwise Micheline ratings will be overridden by Raoul ones.
      7a3ad6ba
    • Thibault Delavallée's avatar
      [FIX] crm: default sales team computation · 14008d05
      Thibault Delavallée authored
      Delegate the whole default sales team computation to the _get_default_team_id
      of sales team to ease the overriding and understanding. Otherwise part of the
      behavior is implemented in crm, part in sales team, leading to a difficult
      overriding.
      
      Order
      
       - team the user is member of
       - team in context
       - Direct Sales
      14008d05
    • David Monjoie's avatar
      [FIX] mail: fixed redirect to messaging url · f6dd8994
      David Monjoie authored
      I checked with aab, and action definition comes after # and not ?.
      f6dd8994
    • David Monjoie's avatar
      [FIX] web_planner: modal body height in IE11 · 9c43f796
      David Monjoie authored
      Credits go to qsm for the fix.
      9c43f796
    • Raphael Collet's avatar
    • Olivier Dony's avatar
      [FIX] res.lang: do not leak `load_language` global · dde3432f
      Olivier Dony authored
      During database creation via the database manager,
      or when using the startup option `--load-language`,
      the selected language(s) will be installed as soon
      as either:
       - the base module is installed/updated (because
      base_data.xml includes a call to res.lang.install_lang()
       - the registry is loaded (after loading `base`,
      the system installs the requested languages, even
      if the server is not in update/install mode)
      
      This is implemented by passing a global config
      option `load_lang
      
      This behavior was modified as of saas-7 by PR
      for the command-line and for the database manager.
      
      In both cases, we don't want the installation
      to be repeated the next time either of these
      event occur. Essentially the `load_language`
      dde3432f
    • Olivier Dony's avatar
      [FIX] registry: explicitly log registry loading errors · e62b9e7c
      Olivier Dony authored
      In case the caller happens to silently catch
      the exception, leading to hard-to-diagnose
      registry/routing problems.
      e62b9e7c
  4. Dec 13, 2015
  5. Dec 11, 2015
Loading