Use case:
It happens that a product is consumed in different operations.
So it needs two distinct BoM lines. Since commit [1] the stock.move
in pbm are not merged. However [1] was design for kit.
In our case we would like to have only one stock.move for all the
quantities.

The fix is not perfect because it won't work if we confirm at the
same time a move with a kit and without it. But at least it will let
people using MO without kit has the correct behavior

+ remove a duplicate of the function

[1] commit 741d2fe9

closes odoo/odoo#122682

X-original-commit: 07b192b8
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

'replace() argument 1 must be str, not bool' is generated if the user edit a
float or monetary section in the website view.

Steps to Reproduce

- Make debugger mode ON.
- Go to Settings > Translations > Languages.
- Remove the value of the 'Thousands Separator' field from the current user
language.
- Install the 'eCommerce' module.
- Go to the website.
- Go to the shop menu, and click any product from the product list.
- Click on the Edit button and try to edit any float or
monetary section like a product price (eg. change a product price from 750 to
70) and click on the Save button.

And traceback will be generated.

Applying this commit will resolve this issue.

sentry-4148693017

closes odoo/odoo#125634

X-original-commit: b895175c
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

The values for the key "async" found in some services is used to declare
async methods that should be "protected". The hook "useService" makes sure
that no code used to process results of those protected methods is
executed by a destroyed component. The orm method "webSearchRead" was
not protected due to a "typo".

closes odoo/odoo#125621

Signed-off-by: Géry Debongnie <ged@odoo.com>

When you add items in the cart it always show the number of available left in stock of the previous state for example :
1- cart is empty it shows 20 items
2- add one into cart - it shows 20 items left in stock (should be 19)
3- add another one into cart - it show 19 items left in stock (should be 18)

Steps to reproduce the error :
1 - Go to one of the product and make sure that it has some available quantity
2 - Go to sale configuration on the product and remove "out-of-stock : continue selling" and add show available qty only if below 5000 for example
3 - Go the web page of the product and try to add some items into the cart you will see that the stock message is wrong

The origin of the problem is that when we have optional products activated , it will launch a product configurator modal. After posting the update in the database there is no call to the function that updates the stock message.

opw-3341377

closes odoo/odoo#124164

Signed-off-by: Mahdi Cheikh Rouhou (macr) <macr@odoo.com>

With the introduction of our l10n_sa_edi module we are able to send invoices to ZATCA,
in this commit we are forcing the invoicing of every PoS order in order to send a simplified
invoice for each PoS order.
add a fallback for l10n_sa_edi for invoice_payment_means
This commit is to add a fallback ('unknown') incase _l10n_sa_get_payment_means_code
returns value not considered

closes odoo/odoo#124300

Signed-off-by: Josse Colpaert <jco@odoo.com>

Let us consider the search arch

    <search>
        <field name="foo"/>
        <searchpanel>
            <field name="bar"/>
        </searchpanel>
    </search>

The two tags "field" are supposed to generate different objects:
 - the first one should generate an entry in the search bar autocompletion
 - the second one should generate a search panel section.

It turns out that the second field did also generate an entry in the
search bar. This is of course wrong. We fix that problem and add a test.

closes odoo/odoo#125541

Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>

By RPC an other user in other company can access to an other fec.

closes odoo/odoo#125367

X-original-commit: 857f2e02
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

This reverts commit 7b433492.

There is a legal requirement in Switzerland that justifies ignoring
the generic `display_qr_code` field.

Confirmed with an accounting PO.

closes odoo/odoo#125441

X-original-commit: 3dbbdd7b
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

closes odoo/odoo#125323

X-original-commit: 813142a4
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Yolann Sabaux (yosa) <yosa@odoo.com>

Adding base translation files for l10n_sa_edi as well as arabic translation

closes odoo/odoo#125201

Signed-off-by: Josse Colpaert <jco@odoo.com>

On the Blanket Order PDF (as well as other purchase agreements), the
vendor isn't specified on the report while it is a required and
significative field on the purchase agreement.
Added it like in the purchase order PDF.

Also added in the Custom Description field into the PDF as it may
contain useful information as well.

Task-3358385

closes odoo/odoo#125014

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

This commit improves the performance of `_is_applicable_for`, by:

1) Leveraging the `product.category.parent_path` field.
2) Use `applied_on` for the `if` conditions, which is ~100% faster than using
   the many2one fields due to the related record initialization.

These micro-optimizations are important because of the way `_is_applicable_for`
is used.

See: https://github.com/odoo/odoo/blob/0a5d84289/addons/product/models/product_pricelist.py#L169-L193



Which, for demostration purposes, could be simplified to:

```
for product, qty, partner in products_qty_partner:
    for rule in items:
        if not rule._is_applicable_for(product, qty_in_product_uom):
            continue
```

On a database with 470 products, and about the same number of pricelist items,
these optimization result in a ~30% speedup when computing prices for all
products at once. It may be even better depending on how many nested product
categories are used in the database and in the pricelist rules.

closes odoo/odoo#124376

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Ever since iOS 16.4, going back and forth through a website with the
cache enabled, creates an error in the console which Odoo tries to
handle but fails to do so. Therefor a generic CORS error message
appears.

There is unfortunately no proper way to fix this bug on our end so
instead, this commit tries to mitigate the error by returning early and
not showing the traceback dialog.

I (ARD) have submitted a feedback through Apple's Feedback Assistant app
and will subsequently remove this commit when Apple releases an update
that fixes this.

opw-3281727

closes odoo/odoo#125265

X-original-commit: 19e484b6
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

create a vendor Bill
attach the PDF
go back to list view, select the bill > print Original Bills

Issue: a traceback is raised
Similar to f814c607
In some malformed PDF files zlib is unable to extract the data properly.

opw-3368907

closes odoo/odoo#125377

Signed-off-by: John Laterre (jol) <jol@odoo.com>

When updating taxes, all taxes are correctly created but the link
between children taxes and their parent was not correctly set.

opw-3347425 (1st issue)

closes odoo/odoo#124778

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Since [1] an error is raised when switching the Mode of an Images Wall
from Float to Grid or Masonry while an image is selected.
The display of the size of the image is being updated while its option
panel is not there anymore.

This commit prevents this error from happening by checking if the
`.data('$optionsSection')` hack (as stated when it was introduced in
[2]) is available before trying to use it.

Steps to reproduce:
- Drop an Images Wall snippet.
- Switch Mode to Float.
- Select an image.
- Switch Mode to Grid.

=> Traceback.

[1]: https://github.com/odoo/odoo/commit/2cbb691a84ce186ddd34a2a4c76d95671ed6e834
[2]: https://github.com/odoo/odoo/commit/5ac6a7a5dbd2af1190d0d027d0239dd1cfc257b0



task-2990053

closes odoo/odoo#119156

Signed-off-by: Vray Benjamin (bvr) <bvr@odoo.com>

It turns out `instanceof` is wonky in Firefox when multiple
documents are involved (e.g. iframe) since [1] has been fixed
and [2] has not yet been addressed accordingly.
Because of that, the check at [3] will return false and
therefore `getReference` will be a Node rather than a Function,
thus triggering the traceback.

**Solution**
Check if `reference` is typeof 'function' instead, which will not fall into the Firefox trap.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1360715
[2]: https://bugzilla.mozilla.org/show_bug.cgi?id=1821790
[3]: https://github.com/odoo/odoo/pull/73130/commits/a9614e0babd6dc517287d547708a8be758c14e12#diff-86a5774240db76cdc93cb570596564cc6816ef4144a7c960f10cd347b7564e44R220



opw-3348172

closes odoo/odoo#125249

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Current behavior:
When you refund a downpayment in the PoS, the downpayment is not added
to the original order.

Steps to reproduce:
- Create an order in the sales app
- Open the PoS and make a downpayment for the order
- Refund the downpayment you just made
- Go back to the original order in the sales app, the downpayment is
  correctly added, but the refund of the downpayment is not added.
- The order should contain : The original product, the downpayment and
  the refund of the downpayment.

opw-3275708

closes odoo/odoo#121160

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Issue: the xml declaration "<?xml version='1.0' encoding='UTF-8'?>" is
lost when opening the send & print wizard with existing xml attachments.

Explanation: When opening the send and print wizard, the PDF are
generated and postprocessed by `_postprocess_pdf_report`. In the
`_postprocess_pdf_report` override in `account_edi_ubl_cii`, the xml
attachments are parsed through `tree = etree.fromstring(xml)`, then the
base64 PDF is inserted, and the etree is converted to a bytes through
`etree.tostring(cleanup_xml_node(tree))` and the resulting bytes is
written back on the attachment, but the xml declaration disappeared.

Solution: include the arguments `xml_declaration=True, encoding='UTF-8'`
in the `tostring` function when converting the etree to a bytes.

opw-3144519

closes odoo/odoo#125266

X-original-commit: d89f5cb2
Signed-off-by: Laurent Smet <las@odoo.com>

When creating an invoice with a positive line and a negative line, with
different taxes, the DatiRiepilogo node for the tax of the negative
line contained positive amounts when they should be negative.

This is because we were applying `abs()` too naively in the XML template
and in the code of _l10n_it_edi_prepare_fatturapa_tax_details.

This bugfix commit changes the logic to no longer use abs().

We also include a test to check that the XML is correctly generated for
credit notes.

Back-port of #121933

opw-3316300

closes odoo/odoo#125198

X-original-commit: 17f336e4
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Antoine Dupuis (andu) <andu@odoo.com>

The cause of the issue is that `datetimepicker('viewDate')` will return
the datetime of today by default event if the user selects nothing, to
remedy this, we now check if the user has chosen something before
storing the content of the field in `form_values`.

Step to reproduce:
- Install website_crm_partner_assign to have the "Partnership Date"
  field on res.partner.
- Install website_sale to have the "Create customer" capability on the
  website forms.
- Drag & drop a form snippet on any page
- Select "Create customer" as form action
- Add a custom field "Partnership Date"
- Submit the form without filling the Partnership Date field
- The field will be set to today's date while it should have been left
  void.

opw-3333364

closes odoo/odoo#124548

X-original-commit: a2a49579
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

This commit will have nested components making use of
the usePosition hook to synchronize their repositioning.

**Before this commit**
Each component handles its own repositioning logic.
If it is mounted somehow inside another component using that
same logic, conflicts occur in some circumstances.

**After this commit**
It is now ensured that, in case of nested positioned components,
the whole chain of repositioning computations is called in the
proper order: from the parent to the children.

**Example**
- Before
  ![before]
- After
  ![after]

[before]: https://github.com/odoo/odoo/assets/1159815/3c9cfae7-db68-4707-a73c-ad7e2e71d4bf
[after]: https://github.com/odoo/odoo/assets/1159815/a21f56e0-d8e3-48c1-9509-8e6ee5040d4b



closes odoo/odoo#125048

Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>

This reverts commit a9273ced.

The IntersectionObserver strategy it implements do not
fullfil properly its purpose.
It was a mistake trying to use this kind of observer as
it is specifically meant for a different use case than
the one we tried to solve in the first place.

Another fix should follow directly this revert commit.

Part-of: odoo/odoo#125048

Since d88409e8, taxes from different companies
are forbidden on sale.order.line records (which is the expected behavior).

Nonetheless, this highlighted some flows where the taxes were not properly
set/recomputed, especially re-invoicing, which is fixed by the current commit.

Fixes #123675

closes odoo/odoo#124483

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Before this commit:

Duplicating the contact that is linked to an attendee of a course also
creates a copy of an attendee as well.

After this commit:

It does not create duplicate attendee in course.

Task-3253983

closes odoo/odoo#125148

X-original-commit: 13f03853
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The triangle pointing towards an option in the editor is pointing
right. In a RTL setting, this does not make sense and should be
mirrored.

task-3284274

closes odoo/odoo#125076

X-original-commit: f65a9bff
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

 This takes into account the option that allows to disable/enable the QR file generation

 Closes #85283

closes odoo/odoo#125038

X-original-commit: 7b433492
Signed-off-by: John Laterre (jol) <jol@odoo.com>

Those tests happened to fail nondeterministically for no apparent
reason and with multiple different wrong tests results.

Some of those wrong results were particularly striking like having
completely empty contents, while others looked more like some kind
of race condition.

Aiming to kill two birds with one stone, I moved the html contents
of the tests into their very own test file so that no asynchronous
file loading on the server is done during testing at runtime anymore.

closes odoo/odoo#125020

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Steps to reproduce the issue:

Add a project and create a task with a timesheet in it
set the allocated hours to 00:03
add a line in the timesheet with hours spent 00:03
Current Behaviour:
The percentage calculated would be 96%, even though the time allocated and time spent are equal.

Desired Behaviour:
The percentage should be 100 as both values i.e. time spent and time allocated are equal.

This is happening because effective_hours value is being rounded off to 2 decimal places, and is not accurate enough to compute the progress_hours.

Here, I have used the same line, that is used to compute effective_hours, to compute the task_total_hours but without rounding off. This will make the calculate more precise and accurate.

OPW-3270858

closes odoo/odoo#124892

X-original-commit: 3b1316e7
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Have a product with internal reference
Open POS session
Create an order with the product
Invoice

Issue: Internal reference is shown twice on the invoice line

opw-3343170

closes odoo/odoo#124620

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

*: account, event_booth, gamification, hr, project,
   website_event_track, website_slides

HTML fields that appear in the front-end can be modified using the
website editor. Some of them are sanitized in a way that breaks the
behavior of snippets that can be dropped within them.

This commit adapts the sanitization of those HTML fields so that the
snippets behave as expected.

opw-3267589

closes odoo/odoo#119543

Related: odoo/enterprise#40211
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

closes odoo/odoo#125132

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

In a Sale Order, it is possible to select an invoice address without a
name. The partner of the transaction does not have a name, which leads
to a traceback when trying to split the name.

The idea is to force the name to be filled, with a fallback on the
partner' parent name.

OPW-3338406

closes odoo/odoo#124825

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

When notification type is set as sms we need to check whether the template
which is referenced is coming from a correct model or not.

Applying this commit will fix this issue.

sentry-4195133685

closes odoo/odoo#122026

Related: odoo/enterprise#41322
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

For a `pos.payment.method`, it is possible to define an outstanding
account, but if this account is not defined as an outstanding account in
the company settings nor in the journal, the payment will not be
considered in the bank reconciliation, nor in the bank reconciliation
report.

Steps to reproduce (demo-data with POS and Accounting installed):
-go to 'Point of Sale/Configuration/Payment Methods'.
-click on the "Bank" payment method.
-add an 'Outstanding Account' which is not the default outstanding
 account of the company, nor an outstanding account of an
 `account.payment.method.line`.  So for example "Liquidity Transfer".
-then open a POS session, sell smth, pay with the Bank method, validate,
 then close the session.
-If you go to 'Accounting/Customers/Payments', you can see that an
 `account.payment` has been created, with the outstanding account being
 "Liquidity Transfer".
->It is not possible to reconcile that payment with a
 `account.bank.statement.line`. If you go to the accounting dashboard,
 then click the reconcile button of the journal "Bank", then on a
 statement line with no partner, you will not see the outstanding line
 of that payment.
->If you open the 'Reconciliation Report' of the journal "Bank"
 (accessible from the journal dashboard, by clicking the options of the
 journal), the line will not show in the 'Outstanding Receipts'
 category.

FIX:
Override the `_get_journal_inbound_outstanding_payment_accounts`
method of `account.journal`, to add the accounts from each
`pos.payment.method` linked to the journal.  Using the field
`pos_payment_method_ids` from `account.journal`.

opw-3271090

closes odoo/odoo#121158

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Steps to reproduce the bug:

- Install the Website Slides module.
- Got to the /slides page.
- Click on a course.
- Click on the "Add Content" button.
- Choose "Web Page" in the modal.
- Once in edit mode, drag and drop a "Table of Content" snippet onto the
page.
- Save the page.
- Scroll the page and observe that the navbar items are updated as you
scroll.
- Click on the "Fullscreen" button.
- Bug: When scrolling the page, the navbar items are no longer updated
as you scroll.

This commit fixes the issue by detecting the scrolling element by
traversing up the ancestors from the 'table of content' snippet, instead
of using the 'getScrollingElement' function, which always returned the
'#wrapwrap' when a Website Slides page is in fullscreen.

opw-3302118

closes odoo/odoo#124893

X-original-commit: 1ac274c3
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Vray Benjamin (bvr) <bvr@odoo.com>

When the browser is zoomed, the value of the `border-width` CSS
properties obtained through `getComputedStyle` are impacted by the
zoom. Because of this, entering a "10px" border in a Chrome zoomed at
125% turns it into "9.6px" when leaving the input field.

This commit neutralizes the zoom effect by rounding the value up.
The rounding operation was empirically determined by observing values,
see table below.

When zoomed out this does not always work: e.g. at 50% zoom, a value
of 11px becomes 10px. But zooming out is an unxpected use case, that
situation is therefore not handled by this fix.

Observed values of the border-width property:
Set value => `getComputedStyle`
```
Value  Chrome 125%  Firefox 120%
  1px        0.8px     0.83333px
  2px        1.6px     1.66667px
  3px        2.4px     2.50000px
  4px        4.0px     3.33333px
  5px        4.8px     5.00000px
  6px        5.6px     5.83333px
  7px        6.4px     6.66667px
  8px        8.0px     7.50000px
  9px        8.8px     8.33333px
 10px        9.6px    10.00000px
 11px       10.4px    10.83333px
 12px       12.0px    11.66667px
```

Steps to reproduce:
- Drop a "Text - Image" block.
- Select the text column.
- Zoom with ctrl+mouse wheel or ctrl-plus.
- Set a 10px border.
- Leave input field.

=> Border option field displayed a different size.

task-3172235

closes odoo/odoo#125068

X-original-commit: 6398b0c7
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>

Issue:
------
When we have the link to the form to apply for a job,
even if the job is not published, we can still apply.

Solution:
---------
Check that the job is published before the creation of the record
in the `website_form_input_filter`.

opw-3331717

closes odoo/odoo#124987

X-original-commit: 508f373f
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Signed-off-by: Lefebvre Thomas (thle) <thle@odoo.com>

Steps to reproduce the bug:
- Install mrp_plm
- Create a BoM with an analytic account
- Create an ECO
- Start the revision

Problem:
The new BoM version doesn't have the analytic account from the original
one.

opw-3329901

closes odoo/odoo#124841

Signed-off-by: William Henrotin (whe) <whe@odoo.com>